public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/2] lib/igt_kms: Remove stale restrictions for HSW/BDW HDMI connector forcing
@ 2019-08-23 18:33 Ville Syrjala
  2019-08-23 18:33 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_force_connector_basic: Execute with HDMI connectors Ville Syrjala
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Ville Syrjala @ 2019-08-23 18:33 UTC (permalink / raw)
  To: igt-dev

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We have no problems forcing HDMI connector status on HSW/BDW these days.
Remove the bogus restriction.

Also DP forcing doesn't really work on any platform because the kernel
can't get the DPCD if there's nothing actually connected. So keep
refusing DP forcing, and in fact extend it to all platforms.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 lib/igt_kms.c | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 17a7d2b67f82..d8cdae76c913 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -980,23 +980,15 @@ bool kmstest_force_connector(int drm_fd, drmModeConnector *connector,
 	char *path, **tmp;
 	const char *value;
 	drmModeConnector *temp;
-	uint32_t devid;
 	int len, dir, idx;
 
-	if (is_i915_device(drm_fd)) {
-		devid = intel_get_drm_devid(drm_fd);
-
-		/*
-		 * forcing hdmi or dp connectors on HSW and BDW doesn't
-		 * currently work, so fail early to allow the test to skip if
-		 * required
-		 */
-		if ((connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
-		     connector->connector_type == DRM_MODE_CONNECTOR_HDMIB ||
-		     connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
-		    && (IS_HASWELL(devid) || IS_BROADWELL(devid)))
-			return false;
-	}
+	/*
+	 * Forcing DP connectors doesn't currently work, so
+	 * fail early to allow the test to skip if required.
+	 */
+	if (is_i915_device(drm_fd) &&
+	    connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
+		return false;
 
 	switch (state) {
 	case FORCE_CONNECTOR_ON:
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-08-26 13:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-23 18:33 [igt-dev] [PATCH i-g-t 1/2] lib/igt_kms: Remove stale restrictions for HSW/BDW HDMI connector forcing Ville Syrjala
2019-08-23 18:33 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_force_connector_basic: Execute with HDMI connectors Ville Syrjala
2019-08-26 13:36   ` Ser, Simon
2019-08-23 20:07 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/igt_kms: Remove stale restrictions for HSW/BDW HDMI connector forcing Patchwork
2019-08-24 23:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-08-26 13:05 ` [igt-dev] [PATCH i-g-t 1/2] " Ser, Simon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox