[igt-dev] [PATCH i-g-t v1] igt/lib: Don't refresh output in igt_output_set_pipe

[igt-dev] [PATCH i-g-t v1] igt/lib: Don't refresh output in igt_output_set_pipe

[Stanislav Lisovskiy]

There are some bugs where DP seems to dissappear in the
middle of test case, which causes garbage modes being returned
for output causing some test cases to fail in unexpected places.
igt_output_refresh should only be called during igt_display_require.

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=109495

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
 lib/igt_kms.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 17a7d2b6..6d990221 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -3754,8 +3754,6 @@ void igt_output_set_pipe(igt_output_t *output, enum pipe pipe)
 
 	igt_output_set_prop_value(output, IGT_CONNECTOR_CRTC_ID, pipe == PIPE_NONE ? 0 : display->pipes[pipe].crtc_id);
 
-	igt_output_refresh(output);
-
 	if (pipe_obj) {
 		if (display->is_atomic)
 			igt_pipe_obj_replace_prop_blob(pipe_obj, IGT_CRTC_MODE_ID, igt_output_get_mode(output), sizeof(drmModeModeInfo));
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for igt/lib: Don't refresh output in igt_output_set_pipe

[Patchwork]

== Series Details ==

Series: igt/lib: Don't refresh output in igt_output_set_pipe
URL   : https://patchwork.freedesktop.org/series/66431/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6853 -> IGTPW_3434
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3434 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3434, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/66431/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3434:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_psr@cursor_plane_move:
    - fi-kbl-r:           [PASS][1] -> [FAIL][2] +3 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6853/fi-kbl-r/igt@kms_psr@cursor_plane_move.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-kbl-r/igt@kms_psr@cursor_plane_move.html
    - fi-icl-u2:          [PASS][3] -> [FAIL][4] +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6853/fi-icl-u2/igt@kms_psr@cursor_plane_move.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-icl-u2/igt@kms_psr@cursor_plane_move.html
    - fi-icl-u3:          [PASS][5] -> [FAIL][6] +3 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6853/fi-icl-u3/igt@kms_psr@cursor_plane_move.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-icl-u3/igt@kms_psr@cursor_plane_move.html

  * igt@kms_psr@primary_mmap_gtt:
    - fi-cml-u2:          [PASS][7] -> [FAIL][8] +3 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6853/fi-cml-u2/igt@kms_psr@primary_mmap_gtt.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-cml-u2/igt@kms_psr@primary_mmap_gtt.html

  * igt@kms_psr@primary_page_flip:
    - fi-skl-6600u:       [PASS][9] -> [FAIL][10] +3 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6853/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-skl-6600u/igt@kms_psr@primary_page_flip.html

  
#### Warnings ####

  * igt@kms_psr@cursor_plane_move:
    - fi-whl-u:           [FAIL][11] ([fdo#107383]) -> [FAIL][12] +3 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6853/fi-whl-u/igt@kms_psr@cursor_plane_move.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-whl-u/igt@kms_psr@cursor_plane_move.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@gem_sync@basic-all:
    - {fi-tgl-u}:         [PASS][13] -> [INCOMPLETE][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6853/fi-tgl-u/igt@gem_sync@basic-all.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-tgl-u/igt@gem_sync@basic-all.html

  * igt@kms_psr@cursor_plane_move:
    - {fi-kbl-soraka}:    NOTRUN -> [FAIL][15] +3 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-kbl-soraka/igt@kms_psr@cursor_plane_move.html

  * igt@kms_psr@sprite_plane_onoff:
    - {fi-icl-u4}:        [PASS][16] -> [FAIL][17] +3 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6853/fi-icl-u4/igt@kms_psr@sprite_plane_onoff.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-icl-u4/igt@kms_psr@sprite_plane_onoff.html

  
Known issues
------------

  Here are the changes found in IGTPW_3434 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_gem_contexts:
    - fi-cfl-8700k:       [PASS][18] -> [INCOMPLETE][19] ([fdo#111514])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6853/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-cml-u2:          [PASS][20] -> [FAIL][21] ([fdo#110627])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6853/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html

  
#### Possible fixes ####

  * igt@gem_mmap_gtt@basic-write-read:
    - fi-icl-u3:          [DMESG-WARN][22] ([fdo#107724]) -> [PASS][23] +2 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6853/fi-icl-u3/igt@gem_mmap_gtt@basic-write-read.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-icl-u3/igt@gem_mmap_gtt@basic-write-read.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][24] ([fdo#111096]) -> [PASS][25]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6853/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#110627]: https://bugs.freedesktop.org/show_bug.cgi?id=110627
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
  [fdo#111514]: https://bugs.freedesktop.org/show_bug.cgi?id=111514


Participating hosts (53 -> 47)
------------------------------

  Additional (1): fi-kbl-soraka 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5176 -> IGTPW_3434

  CI-20190529: 20190529
  CI_DRM_6853: ad1a8a60aba111d2c186d19391d5a17bd09ab48b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3434: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/
  IGT_5176: 0102dcf4e2e8b357b59173fe1ff78069148080c6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3434/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev