* [igt-dev] [PATCH i-g-t] tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding
@ 2019-09-11 14:11 Wang, Chao-kai (Stylon)
2019-09-11 14:29 ` Kazlauskas, Nicholas
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wang, Chao-kai (Stylon) @ 2019-09-11 14:11 UTC (permalink / raw)
To: igt-dev@lists.freedesktop.org
From: Stylon Wang <stylon.wang@amd.com>
HDMI 2.0 compliance tests needs 4K modes with YUV encoding.
This test selects 4K modes based on specified VIC.
Signed-off-by: Stylon Wang <stylon.wang@amd.com>
---
tools/Makefile.am | 3 +
tools/Makefile.sources | 4 +
tools/amd_hdmi_compliance_yuv420.c | 193 +++++++++++++++++++++++++++++
tools/meson.build | 5 +
4 files changed, 205 insertions(+)
create mode 100644 tools/amd_hdmi_compliance_yuv420.c
diff --git a/tools/Makefile.am b/tools/Makefile.am
index 4f54720f..1a23e078 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -11,6 +11,9 @@ bin_PROGRAMS += intel_dp_compliance
intel_dp_compliance_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS)
intel_dp_compliance_LDADD = $(top_builddir)/lib/libintel_tools.la
+bin_PROGRAMS += amd_hdmi_compliance_yuv420
+amd_hdmi_compliance_yuv420_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS)
+
SUBDIRS = null_state_gen registers
AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/include/drm-uapi -I$(top_srcdir)/lib \
diff --git a/tools/Makefile.sources b/tools/Makefile.sources
index 50706f41..8196cb59 100644
--- a/tools/Makefile.sources
+++ b/tools/Makefile.sources
@@ -66,3 +66,7 @@ intel_dp_compliance_SOURCES = \
intel_dp_compliance_hotplug.c \
$(NULL)
+amd_hdmi_compliance_yuv420_SOURCES = \
+ amd_hdmi_compliance_yuv420.c \
+ $(NULL)
+
diff --git a/tools/amd_hdmi_compliance_yuv420.c b/tools/amd_hdmi_compliance_yuv420.c
new file mode 100644
index 00000000..5f5eae2c
--- /dev/null
+++ b/tools/amd_hdmi_compliance_yuv420.c
@@ -0,0 +1,193 @@
+/*
+ * Copyright 2019 Advanced Micro Devices, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "igt.h"
+
+/* Common test data */
+typedef struct data {
+ struct igt_fb pattern_fb_info;
+ int fd;
+ igt_display_t display;
+ igt_plane_t *primary;
+ igt_output_t *output;
+ igt_pipe_t *pipe;
+ enum pipe pipe_id;
+ bool use_virtual_connector;
+} data_t;
+
+// Video modes indexed by VIC
+static drmModeModeInfo test_modes[] = {
+ [1] = { 25175,
+ 640, 656, 752, 800, 0,
+ 480, 489, 492, 525, 0,
+ 60, 0xa, 0x40,
+ "640x480", /* VIC 1 */
+ },
+ [96] = { 594000,
+ 3840, 4896, 4984, 5280, 0,
+ 2160, 2168, 2178, 2250, 0,
+ 50, 0x5|DRM_MODE_FLAG_PIC_AR_16_9, 0x40,
+ "3840x2160", /* VIC 96 */
+ },
+ [97] = { 594000,
+ 3840, 4016, 4104, 4400, 0,
+ 2160, 2168, 2178, 2250, 0,
+ 60, 0x5|DRM_MODE_FLAG_PIC_AR_16_9, 0x40,
+ "3840x2160", /* VIC 97 */
+ },
+ [101] = { 594000,
+ 4096, 5064, 5152, 5280, 0,
+ 2160, 2168, 2178, 2250, 0,
+ 50, 0x5|DRM_MODE_FLAG_PIC_AR_256_135, 0x40,
+ "4096x2160", /* VIC 101 */
+ },
+ [102] = { 594000,
+ 4096, 4184, 4272, 4400, 0,
+ 2160, 2168, 2178, 2250, 0,
+ 60, 0x5|DRM_MODE_FLAG_PIC_AR_256_135, 0x40,
+ "4096x2160", /* VIC 102 */
+ },
+ [106] = { 594000,
+ 3840, 4896, 4984, 5280, 0,
+ 2160, 2168, 2178, 2250, 0,
+ 50, 0x5|DRM_MODE_FLAG_PIC_AR_64_27, 0x40,
+ "3840x2160", /* VIC 106 */
+ },
+ [107] = { 594000,
+ 3840, 4016, 4104, 4400, 0,
+ 2160, 2168, 2178, 2250, 0,
+ 60, 0x5|DRM_MODE_FLAG_PIC_AR_64_27, 0x40,
+ "3840x2160", /* VIC 107 */
+ },
+};
+
+/* Common test setup. */
+static void test_init(data_t *data)
+{
+ igt_display_t *display = &data->display;
+
+ data->pipe_id = PIPE_A;
+ data->pipe = &data->display.pipes[data->pipe_id];
+
+ igt_display_reset(display);
+
+ /* find a connected HDMI output */
+ data->output = NULL;
+ for (int i=0; i < data->display.n_outputs; ++i) {
+ drmModeConnector *connector = data->display.outputs[i].config.connector;
+ if (connector->connection == DRM_MODE_CONNECTED &&
+ (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
+ (data->use_virtual_connector &&
+ connector->connector_type == DRM_MODE_CONNECTOR_VIRTUAL))) {
+ data->output = &data->display.outputs[i];
+ }
+ }
+
+ igt_require(data->output);
+
+ data->primary =
+ igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_PRIMARY);
+
+ igt_output_set_pipe(data->output, data->pipe_id);
+
+}
+
+/* Common test cleanup. */
+static void test_fini(data_t *data)
+{
+ igt_display_reset(&data->display);
+}
+
+static void test_vic_mode(data_t *data, int vic)
+{
+ igt_display_t *display = &data->display;
+ drmModeModeInfo *mode;
+ igt_fb_t afb;
+
+ test_init(data);
+
+ mode = &test_modes[vic];
+
+ igt_output_override_mode(data->output, mode);
+
+ igt_create_pattern_fb(data->fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, 0, &afb);
+
+ igt_plane_set_fb(data->primary, &afb);
+
+ igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+
+ fprintf(stderr, "Press [Enter] to finish\n");
+ getchar();
+
+ test_fini(data);
+}
+
+const char *optstr = "hvt:";
+static void usage(const char *name)
+{
+ fprintf(stderr, "Usage: %s [-ht]\n", name);
+ fprintf(stderr, "-h: show help\n");
+ fprintf(stderr, "-t vic: select video mode based on VIC\n");
+ fprintf(stderr, "-v: test on 'Virtual' connector as well, for debugging.\n");
+}
+
+int main(int argc, char **argv)
+{
+ data_t data;
+ int c;
+ int vic = 1; /* default to VIC 1 (640x480) */
+
+ memset(&data, 0, sizeof(data));
+
+ while((c = getopt(argc, argv, optstr)) != -1) {
+ switch(c) {
+ case 't':
+ vic = atoi(optarg);
+ break;
+ case 'v':
+ data.use_virtual_connector = true;
+ break;
+ default:
+ case 'h':
+ usage(argv[0]);
+ exit(1);
+ }
+ }
+
+ if (vic < 1 ||
+ vic > ARRAY_SIZE(test_modes) ||
+ !test_modes[vic].name[0]) {
+ fprintf(stderr, "VIC %d is not supported\n", vic);
+ exit(1);
+ }
+
+ data.fd = drm_open_driver_master(DRIVER_ANY);
+ kmstest_set_vt_graphics_mode();
+
+ igt_display_require(&data.display, data.fd);
+ igt_require(data.display.is_atomic);
+ igt_display_require_output(&data.display);
+
+ test_vic_mode(&data, vic);
+
+ igt_display_fini(&data.display);
+}
diff --git a/tools/meson.build b/tools/meson.build
index 6e72b263..fa366ab2 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -100,6 +100,11 @@ executable('intel_gpu_top', 'intel_gpu_top.c',
install_rpath : bindir_rpathdir,
dependencies : lib_igt_perf)
+executable('amd_hdmi_compliance_yuv420', 'amd_hdmi_compliance_yuv420.c',
+ dependencies : [tool_deps],
+ install_rpath : bindir_rpathdir,
+ install : true)
+
conf_data = configuration_data()
conf_data.set('prefix', prefix)
conf_data.set('exec_prefix', '${prefix}')
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding 2019-09-11 14:11 [igt-dev] [PATCH i-g-t] tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding Wang, Chao-kai (Stylon) @ 2019-09-11 14:29 ` Kazlauskas, Nicholas 2019-09-13 9:57 ` Petri Latvala 2019-09-11 15:07 ` [igt-dev] ✓ Fi.CI.BAT: success for tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding (rev2) Patchwork 2019-09-12 1:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2 siblings, 1 reply; 6+ messages in thread From: Kazlauskas, Nicholas @ 2019-09-11 14:29 UTC (permalink / raw) To: Wang, Chao-kai (Stylon), igt-dev@lists.freedesktop.org On 2019-09-11 10:11 a.m., Wang, Chao-kai (Stylon) wrote: > From: Stylon Wang <stylon.wang@amd.com> > > HDMI 2.0 compliance tests needs 4K modes with YUV encoding. > This test selects 4K modes based on specified VIC. It helps to note what changed in a patch series in both the patch title and in the commit message here. You can add a v2 to the patch header by appending a -v2 to your command, eg: "git send-email -v2 ..." And in the commit description you should do something like: v2: - example change 1 - example change 2 Other than that, I do have some general comments and nitpicks: I think this tool might be better off named as just amd_hdmi_compliance so we can expand on this later. Nicholas Kazlauskas > > Signed-off-by: Stylon Wang <stylon.wang@amd.com> > --- > tools/Makefile.am | 3 + > tools/Makefile.sources | 4 + > tools/amd_hdmi_compliance_yuv420.c | 193 +++++++++++++++++++++++++++++ > tools/meson.build | 5 + > 4 files changed, 205 insertions(+) > create mode 100644 tools/amd_hdmi_compliance_yuv420.c > > diff --git a/tools/Makefile.am b/tools/Makefile.am > index 4f54720f..1a23e078 100644 > --- a/tools/Makefile.am > +++ b/tools/Makefile.am > @@ -11,6 +11,9 @@ bin_PROGRAMS += intel_dp_compliance > intel_dp_compliance_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS) > intel_dp_compliance_LDADD = $(top_builddir)/lib/libintel_tools.la > > +bin_PROGRAMS += amd_hdmi_compliance_yuv420 > +amd_hdmi_compliance_yuv420_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS) > + > SUBDIRS = null_state_gen registers > > AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/include/drm-uapi -I$(top_srcdir)/lib \ > diff --git a/tools/Makefile.sources b/tools/Makefile.sources > index 50706f41..8196cb59 100644 > --- a/tools/Makefile.sources > +++ b/tools/Makefile.sources > @@ -66,3 +66,7 @@ intel_dp_compliance_SOURCES = \ > intel_dp_compliance_hotplug.c \ > $(NULL) > > +amd_hdmi_compliance_yuv420_SOURCES = \ > + amd_hdmi_compliance_yuv420.c \ > + $(NULL) > + > diff --git a/tools/amd_hdmi_compliance_yuv420.c b/tools/amd_hdmi_compliance_yuv420.c > new file mode 100644 > index 00000000..5f5eae2c > --- /dev/null > +++ b/tools/amd_hdmi_compliance_yuv420.c > @@ -0,0 +1,193 @@ > +/* > + * Copyright 2019 Advanced Micro Devices, Inc. > + * > + * Permission is hereby granted, free of charge, to any person obtaining a > + * copy of this software and associated documentation files (the "Software"), > + * to deal in the Software without restriction, including without limitation > + * the rights to use, copy, modify, merge, publish, distribute, sublicense, > + * and/or sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR > + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +#include "igt.h" > + > +/* Common test data */ > +typedef struct data { > + struct igt_fb pattern_fb_info; > + int fd; > + igt_display_t display; > + igt_plane_t *primary; > + igt_output_t *output; > + igt_pipe_t *pipe; > + enum pipe pipe_id; > + bool use_virtual_connector; > +} data_t; > + > +// Video modes indexed by VIC IGT uses kernel style formatting so this comment should be: /* Video modes indexed by VIC */ > +static drmModeModeInfo test_modes[] = { > + [1] = { 25175, > + 640, 656, 752, 800, 0, > + 480, 489, 492, 525, 0, > + 60, 0xa, 0x40, > + "640x480", /* VIC 1 */ > + }, > + [96] = { 594000, > + 3840, 4896, 4984, 5280, 0, > + 2160, 2168, 2178, 2250, 0, > + 50, 0x5|DRM_MODE_FLAG_PIC_AR_16_9, 0x40, > + "3840x2160", /* VIC 96 */ > + }, > + [97] = { 594000, > + 3840, 4016, 4104, 4400, 0, > + 2160, 2168, 2178, 2250, 0, > + 60, 0x5|DRM_MODE_FLAG_PIC_AR_16_9, 0x40, > + "3840x2160", /* VIC 97 */ > + }, > + [101] = { 594000, > + 4096, 5064, 5152, 5280, 0, > + 2160, 2168, 2178, 2250, 0, > + 50, 0x5|DRM_MODE_FLAG_PIC_AR_256_135, 0x40, > + "4096x2160", /* VIC 101 */ > + }, > + [102] = { 594000, > + 4096, 4184, 4272, 4400, 0, > + 2160, 2168, 2178, 2250, 0, > + 60, 0x5|DRM_MODE_FLAG_PIC_AR_256_135, 0x40, > + "4096x2160", /* VIC 102 */ > + }, > + [106] = { 594000, > + 3840, 4896, 4984, 5280, 0, > + 2160, 2168, 2178, 2250, 0, > + 50, 0x5|DRM_MODE_FLAG_PIC_AR_64_27, 0x40, > + "3840x2160", /* VIC 106 */ > + }, > + [107] = { 594000, > + 3840, 4016, 4104, 4400, 0, > + 2160, 2168, 2178, 2250, 0, > + 60, 0x5|DRM_MODE_FLAG_PIC_AR_64_27, 0x40, > + "3840x2160", /* VIC 107 */ > + }, > +}; > + > +/* Common test setup. */ > +static void test_init(data_t *data) > +{ > + igt_display_t *display = &data->display; > + > + data->pipe_id = PIPE_A; > + data->pipe = &data->display.pipes[data->pipe_id]; > + > + igt_display_reset(display); > + > + /* find a connected HDMI output */ > + data->output = NULL; > + for (int i=0; i < data->display.n_outputs; ++i) { > + drmModeConnector *connector = data->display.outputs[i].config.connector; > + if (connector->connection == DRM_MODE_CONNECTED && > + (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA || > + (data->use_virtual_connector && > + connector->connector_type == DRM_MODE_CONNECTOR_VIRTUAL))) { > + data->output = &data->display.outputs[i]; > + } > + } > + > + igt_require(data->output); > + > + data->primary = > + igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_PRIMARY); > + > + igt_output_set_pipe(data->output, data->pipe_id); > + > +} > + > +/* Common test cleanup. */ > +static void test_fini(data_t *data) > +{ > + igt_display_reset(&data->display); > +} > + > +static void test_vic_mode(data_t *data, int vic) > +{ > + igt_display_t *display = &data->display; > + drmModeModeInfo *mode; > + igt_fb_t afb; > + > + test_init(data); > + > + mode = &test_modes[vic]; > + > + igt_output_override_mode(data->output, mode); > + > + igt_create_pattern_fb(data->fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, 0, &afb); > + > + igt_plane_set_fb(data->primary, &afb); > + > + igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL); > + > + fprintf(stderr, "Press [Enter] to finish\n"); I think igt_info(...) is preferred here over fprintf directly. > + getchar(); I understand that you aren't using igt_debug_wait_for_keypress here, but I think an improvement that could be made is to extract this out into a sub function that waits explicitly for the newline: static void wait_for_keypress(void) { while (getchar() != '\n') ; } > + > + test_fini(data); > +} > + > +const char *optstr = "hvt:"; > +static void usage(const char *name) > +{ > + fprintf(stderr, "Usage: %s [-ht]\n", name); > + fprintf(stderr, "-h: show help\n"); > + fprintf(stderr, "-t vic: select video mode based on VIC\n"); > + fprintf(stderr, "-v: test on 'Virtual' connector as well, for debugging.\n"); igt_info(...) if possible here > +} > + > +int main(int argc, char **argv) > +{ > + data_t data; > + int c; > + int vic = 1; /* default to VIC 1 (640x480) */ > + > + memset(&data, 0, sizeof(data)); > + > + while((c = getopt(argc, argv, optstr)) != -1) { > + switch(c) { > + case 't': > + vic = atoi(optarg); > + break; > + case 'v': > + data.use_virtual_connector = true; > + break; > + default: > + case 'h': > + usage(argv[0]); > + exit(1); > + } > + } > + > + if (vic < 1 || > + vic > ARRAY_SIZE(test_modes) || > + !test_modes[vic].name[0]) { > + fprintf(stderr, "VIC %d is not supported\n", vic); igt_info(...) if possible here > + exit(1); > + } > + > + data.fd = drm_open_driver_master(DRIVER_ANY); > + kmstest_set_vt_graphics_mode(); > + > + igt_display_require(&data.display, data.fd); > + igt_require(data.display.is_atomic); > + igt_display_require_output(&data.display); > + > + test_vic_mode(&data, vic); > + > + igt_display_fini(&data.display); > +} > diff --git a/tools/meson.build b/tools/meson.build > index 6e72b263..fa366ab2 100644 > --- a/tools/meson.build > +++ b/tools/meson.build > @@ -100,6 +100,11 @@ executable('intel_gpu_top', 'intel_gpu_top.c', > install_rpath : bindir_rpathdir, > dependencies : lib_igt_perf) > > +executable('amd_hdmi_compliance_yuv420', 'amd_hdmi_compliance_yuv420.c', > + dependencies : [tool_deps], > + install_rpath : bindir_rpathdir, > + install : true) > + > conf_data = configuration_data() > conf_data.set('prefix', prefix) > conf_data.set('exec_prefix', '${prefix}') > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding 2019-09-11 14:29 ` Kazlauskas, Nicholas @ 2019-09-13 9:57 ` Petri Latvala 2019-09-16 12:35 ` Kazlauskas, Nicholas 0 siblings, 1 reply; 6+ messages in thread From: Petri Latvala @ 2019-09-13 9:57 UTC (permalink / raw) To: Kazlauskas, Nicholas; +Cc: igt-dev@lists.freedesktop.org On Wed, Sep 11, 2019 at 02:29:51PM +0000, Kazlauskas, Nicholas wrote: > On 2019-09-11 10:11 a.m., Wang, Chao-kai (Stylon) wrote: > > From: Stylon Wang <stylon.wang@amd.com> > > > > HDMI 2.0 compliance tests needs 4K modes with YUV encoding. > > This test selects 4K modes based on specified VIC. > > It helps to note what changed in a patch series in both the patch title > and in the commit message here. > > You can add a v2 to the patch header by appending a -v2 to your command, eg: > > "git send-email -v2 ..." > > And in the commit description you should do something like: > > v2: > - example change 1 > - example change 2 > > Other than that, I do have some general comments and nitpicks: > > I think this tool might be better off named as just amd_hdmi_compliance > so we can expand on this later. Is there anything specific that makes this tool AMD-specific? It even uses DRIVER_ANY. I guess the same question can be asked about intel_dp_compliance.c... -- Petri Latvala > > Nicholas Kazlauskas > > > > > Signed-off-by: Stylon Wang <stylon.wang@amd.com> > > --- > > tools/Makefile.am | 3 + > > tools/Makefile.sources | 4 + > > tools/amd_hdmi_compliance_yuv420.c | 193 +++++++++++++++++++++++++++++ > > tools/meson.build | 5 + > > 4 files changed, 205 insertions(+) > > create mode 100644 tools/amd_hdmi_compliance_yuv420.c > > > > diff --git a/tools/Makefile.am b/tools/Makefile.am > > index 4f54720f..1a23e078 100644 > > --- a/tools/Makefile.am > > +++ b/tools/Makefile.am > > @@ -11,6 +11,9 @@ bin_PROGRAMS += intel_dp_compliance > > intel_dp_compliance_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS) > > intel_dp_compliance_LDADD = $(top_builddir)/lib/libintel_tools.la > > > > +bin_PROGRAMS += amd_hdmi_compliance_yuv420 > > +amd_hdmi_compliance_yuv420_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS) > > + > > SUBDIRS = null_state_gen registers > > > > AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/include/drm-uapi -I$(top_srcdir)/lib \ > > diff --git a/tools/Makefile.sources b/tools/Makefile.sources > > index 50706f41..8196cb59 100644 > > --- a/tools/Makefile.sources > > +++ b/tools/Makefile.sources > > @@ -66,3 +66,7 @@ intel_dp_compliance_SOURCES = \ > > intel_dp_compliance_hotplug.c \ > > $(NULL) > > > > +amd_hdmi_compliance_yuv420_SOURCES = \ > > + amd_hdmi_compliance_yuv420.c \ > > + $(NULL) > > + > > diff --git a/tools/amd_hdmi_compliance_yuv420.c b/tools/amd_hdmi_compliance_yuv420.c > > new file mode 100644 > > index 00000000..5f5eae2c > > --- /dev/null > > +++ b/tools/amd_hdmi_compliance_yuv420.c > > @@ -0,0 +1,193 @@ > > +/* > > + * Copyright 2019 Advanced Micro Devices, Inc. > > + * > > + * Permission is hereby granted, free of charge, to any person obtaining a > > + * copy of this software and associated documentation files (the "Software"), > > + * to deal in the Software without restriction, including without limitation > > + * the rights to use, copy, modify, merge, publish, distribute, sublicense, > > + * and/or sell copies of the Software, and to permit persons to whom the > > + * Software is furnished to do so, subject to the following conditions: > > + * > > + * The above copyright notice and this permission notice shall be included in > > + * all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > > + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR > > + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > > + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > > + * OTHER DEALINGS IN THE SOFTWARE. > > + */ > > + > > +#include "igt.h" > > + > > +/* Common test data */ > > +typedef struct data { > > + struct igt_fb pattern_fb_info; > > + int fd; > > + igt_display_t display; > > + igt_plane_t *primary; > > + igt_output_t *output; > > + igt_pipe_t *pipe; > > + enum pipe pipe_id; > > + bool use_virtual_connector; > > +} data_t; > > + > > +// Video modes indexed by VIC > > IGT uses kernel style formatting so this comment should be: > > /* Video modes indexed by VIC */ > > > +static drmModeModeInfo test_modes[] = { > > + [1] = { 25175, > > + 640, 656, 752, 800, 0, > > + 480, 489, 492, 525, 0, > > + 60, 0xa, 0x40, > > + "640x480", /* VIC 1 */ > > + }, > > + [96] = { 594000, > > + 3840, 4896, 4984, 5280, 0, > > + 2160, 2168, 2178, 2250, 0, > > + 50, 0x5|DRM_MODE_FLAG_PIC_AR_16_9, 0x40, > > + "3840x2160", /* VIC 96 */ > > + }, > > + [97] = { 594000, > > + 3840, 4016, 4104, 4400, 0, > > + 2160, 2168, 2178, 2250, 0, > > + 60, 0x5|DRM_MODE_FLAG_PIC_AR_16_9, 0x40, > > + "3840x2160", /* VIC 97 */ > > + }, > > + [101] = { 594000, > > + 4096, 5064, 5152, 5280, 0, > > + 2160, 2168, 2178, 2250, 0, > > + 50, 0x5|DRM_MODE_FLAG_PIC_AR_256_135, 0x40, > > + "4096x2160", /* VIC 101 */ > > + }, > > + [102] = { 594000, > > + 4096, 4184, 4272, 4400, 0, > > + 2160, 2168, 2178, 2250, 0, > > + 60, 0x5|DRM_MODE_FLAG_PIC_AR_256_135, 0x40, > > + "4096x2160", /* VIC 102 */ > > + }, > > + [106] = { 594000, > > + 3840, 4896, 4984, 5280, 0, > > + 2160, 2168, 2178, 2250, 0, > > + 50, 0x5|DRM_MODE_FLAG_PIC_AR_64_27, 0x40, > > + "3840x2160", /* VIC 106 */ > > + }, > > + [107] = { 594000, > > + 3840, 4016, 4104, 4400, 0, > > + 2160, 2168, 2178, 2250, 0, > > + 60, 0x5|DRM_MODE_FLAG_PIC_AR_64_27, 0x40, > > + "3840x2160", /* VIC 107 */ > > + }, > > +}; > > + > > +/* Common test setup. */ > > +static void test_init(data_t *data) > > +{ > > + igt_display_t *display = &data->display; > > + > > + data->pipe_id = PIPE_A; > > + data->pipe = &data->display.pipes[data->pipe_id]; > > + > > + igt_display_reset(display); > > + > > + /* find a connected HDMI output */ > > + data->output = NULL; > > + for (int i=0; i < data->display.n_outputs; ++i) { > > + drmModeConnector *connector = data->display.outputs[i].config.connector; > > + if (connector->connection == DRM_MODE_CONNECTED && > > + (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA || > > + (data->use_virtual_connector && > > + connector->connector_type == DRM_MODE_CONNECTOR_VIRTUAL))) { > > + data->output = &data->display.outputs[i]; > > + } > > + } > > + > > + igt_require(data->output); > > + > > + data->primary = > > + igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_PRIMARY); > > + > > + igt_output_set_pipe(data->output, data->pipe_id); > > + > > +} > > + > > +/* Common test cleanup. */ > > +static void test_fini(data_t *data) > > +{ > > + igt_display_reset(&data->display); > > +} > > + > > +static void test_vic_mode(data_t *data, int vic) > > +{ > > + igt_display_t *display = &data->display; > > + drmModeModeInfo *mode; > > + igt_fb_t afb; > > + > > + test_init(data); > > + > > + mode = &test_modes[vic]; > > + > > + igt_output_override_mode(data->output, mode); > > + > > + igt_create_pattern_fb(data->fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, 0, &afb); > > + > > + igt_plane_set_fb(data->primary, &afb); > > + > > + igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL); > > + > > + fprintf(stderr, "Press [Enter] to finish\n"); > > I think igt_info(...) is preferred here over fprintf directly. > > > + getchar(); > I understand that you aren't using igt_debug_wait_for_keypress here, but > I think an improvement that could be made is to extract this out into a > sub function that waits explicitly for the newline: > > static void wait_for_keypress(void) > { > while (getchar() != '\n') > ; > } > > > + > > + test_fini(data); > > +} > > + > > +const char *optstr = "hvt:"; > > +static void usage(const char *name) > > +{ > > + fprintf(stderr, "Usage: %s [-ht]\n", name); > > + fprintf(stderr, "-h: show help\n"); > > + fprintf(stderr, "-t vic: select video mode based on VIC\n"); > > + fprintf(stderr, "-v: test on 'Virtual' connector as well, for debugging.\n"); > > igt_info(...) if possible here > > > +} > > + > > +int main(int argc, char **argv) > > +{ > > + data_t data; > > + int c; > > + int vic = 1; /* default to VIC 1 (640x480) */ > > + > > + memset(&data, 0, sizeof(data)); > > + > > + while((c = getopt(argc, argv, optstr)) != -1) { > > + switch(c) { > > + case 't': > > + vic = atoi(optarg); > > + break; > > + case 'v': > > + data.use_virtual_connector = true; > > + break; > > + default: > > + case 'h': > > + usage(argv[0]); > > + exit(1); > > + } > > + } > > + > > + if (vic < 1 || > > + vic > ARRAY_SIZE(test_modes) || > > + !test_modes[vic].name[0]) { > > + fprintf(stderr, "VIC %d is not supported\n", vic); > > igt_info(...) if possible here > > > + exit(1); > > + } > > + > > + data.fd = drm_open_driver_master(DRIVER_ANY); > > + kmstest_set_vt_graphics_mode(); > > + > > + igt_display_require(&data.display, data.fd); > > + igt_require(data.display.is_atomic); > > + igt_display_require_output(&data.display); > > + > > + test_vic_mode(&data, vic); > > + > > + igt_display_fini(&data.display); > > +} > > diff --git a/tools/meson.build b/tools/meson.build > > index 6e72b263..fa366ab2 100644 > > --- a/tools/meson.build > > +++ b/tools/meson.build > > @@ -100,6 +100,11 @@ executable('intel_gpu_top', 'intel_gpu_top.c', > > install_rpath : bindir_rpathdir, > > dependencies : lib_igt_perf) > > > > +executable('amd_hdmi_compliance_yuv420', 'amd_hdmi_compliance_yuv420.c', > > + dependencies : [tool_deps], > > + install_rpath : bindir_rpathdir, > > + install : true) > > + > > conf_data = configuration_data() > > conf_data.set('prefix', prefix) > > conf_data.set('exec_prefix', '${prefix}') > > > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding 2019-09-13 9:57 ` Petri Latvala @ 2019-09-16 12:35 ` Kazlauskas, Nicholas 0 siblings, 0 replies; 6+ messages in thread From: Kazlauskas, Nicholas @ 2019-09-16 12:35 UTC (permalink / raw) To: Wang, Chao-kai (Stylon), igt-dev@lists.freedesktop.org, Petri Latvala On 2019-09-13 5:57 a.m., Petri Latvala wrote: > On Wed, Sep 11, 2019 at 02:29:51PM +0000, Kazlauskas, Nicholas wrote: >> On 2019-09-11 10:11 a.m., Wang, Chao-kai (Stylon) wrote: >>> From: Stylon Wang <stylon.wang@amd.com> >>> >>> HDMI 2.0 compliance tests needs 4K modes with YUV encoding. >>> This test selects 4K modes based on specified VIC. >> >> It helps to note what changed in a patch series in both the patch title >> and in the commit message here. >> >> You can add a v2 to the patch header by appending a -v2 to your command, eg: >> >> "git send-email -v2 ..." >> >> And in the commit description you should do something like: >> >> v2: >> - example change 1 >> - example change 2 >> >> Other than that, I do have some general comments and nitpicks: >> >> I think this tool might be better off named as just amd_hdmi_compliance >> so we can expand on this later. > > Is there anything specific that makes this tool AMD-specific? It even > uses DRIVER_ANY. > > I guess the same question can be asked about intel_dp_compliance.c... > > > Nothing yet that I can see in the patch itself. I know that debugfs entries to help with automating this compliance were added to amdgpu (like the one that controls 420 vs 444 output), so I would imagine that they would be added after though. Nicholas Kazlauskas _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding (rev2) 2019-09-11 14:11 [igt-dev] [PATCH i-g-t] tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding Wang, Chao-kai (Stylon) 2019-09-11 14:29 ` Kazlauskas, Nicholas @ 2019-09-11 15:07 ` Patchwork 2019-09-12 1:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2019-09-11 15:07 UTC (permalink / raw) To: Wang, Chao-kai (Stylon); +Cc: igt-dev == Series Details == Series: tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding (rev2) URL : https://patchwork.freedesktop.org/series/66451/ State : success == Summary == CI Bug Log - changes from CI_DRM_6871 -> IGTPW_3443 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/66451/revisions/2/mbox/ Known issues ------------ Here are the changes found in IGTPW_3443 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html * igt@kms_frontbuffer_tracking@basic: - fi-icl-u3: [PASS][3] -> [FAIL][4] ([fdo#103167]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html * igt@kms_prop_blob@basic: - fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/fi-icl-u3/igt@kms_prop_blob@basic.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/fi-icl-u3/igt@kms_prop_blob@basic.html #### Possible fixes #### * igt@gem_ctx_create@basic-files: - {fi-icl-guc}: [INCOMPLETE][7] ([fdo#107713] / [fdo#109100]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/fi-icl-guc/igt@gem_ctx_create@basic-files.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/fi-icl-guc/igt@gem_ctx_create@basic-files.html * igt@gem_flink_basic@flink-lifetime: - fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10] +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/fi-icl-u3/igt@gem_flink_basic@flink-lifetime.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/fi-icl-u3/igt@gem_flink_basic@flink-lifetime.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [FAIL][11] ([fdo#111407]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html * igt@kms_frontbuffer_tracking@basic: - {fi-icl-u4}: [FAIL][13] ([fdo#103167]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/fi-icl-u4/igt@kms_frontbuffer_tracking@basic.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/fi-icl-u4/igt@kms_frontbuffer_tracking@basic.html - fi-icl-u2: [FAIL][15] ([fdo#103167]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html #### Warnings #### * igt@kms_chamelium@common-hpd-after-suspend: - fi-icl-u2: [DMESG-WARN][17] ([fdo#102505] / [fdo#110390]) -> [FAIL][18] ([fdo#109483]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107 [fdo#106350]: https://bugs.freedesktop.org/show_bug.cgi?id=106350 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100 [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483 [fdo#110390]: https://bugs.freedesktop.org/show_bug.cgi?id=110390 [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407 Participating hosts (53 -> 47) ------------------------------ Additional (1): fi-kbl-soraka Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5178 -> IGTPW_3443 CI-20190529: 20190529 CI_DRM_6871: f58f61f8f8a1137f3b4e2bf4af02d5f7694a0b2e @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3443: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/ IGT_5178: efb4539494d94f03374874d3b61bd04ef3802aaa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding (rev2) 2019-09-11 14:11 [igt-dev] [PATCH i-g-t] tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding Wang, Chao-kai (Stylon) 2019-09-11 14:29 ` Kazlauskas, Nicholas 2019-09-11 15:07 ` [igt-dev] ✓ Fi.CI.BAT: success for tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding (rev2) Patchwork @ 2019-09-12 1:42 ` Patchwork 2 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2019-09-12 1:42 UTC (permalink / raw) To: Wang, Chao-kai (Stylon); +Cc: igt-dev == Series Details == Series: tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding (rev2) URL : https://patchwork.freedesktop.org/series/66451/ State : success == Summary == CI Bug Log - changes from CI_DRM_6871_full -> IGTPW_3443_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/66451/revisions/2/mbox/ Known issues ------------ Here are the changes found in IGTPW_3443_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110841]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-iclb8/igt@gem_ctx_shared@exec-single-timeline-bsd.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_exec_schedule@independent-bsd: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#111325]) +2 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-iclb8/igt@gem_exec_schedule@independent-bsd.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-iclb4/igt@gem_exec_schedule@independent-bsd.html * igt@i915_pm_rc6_residency@rc6-accuracy: - shard-kbl: [PASS][5] -> [SKIP][6] ([fdo#109271]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-kbl1/igt@i915_pm_rc6_residency@rc6-accuracy.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-kbl7/igt@i915_pm_rc6_residency@rc6-accuracy.html * igt@i915_suspend@debugfs-reader: - shard-apl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +4 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-apl2/igt@i915_suspend@debugfs-reader.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-apl8/igt@i915_suspend@debugfs-reader.html * igt@kms_big_fb@x-tiled-8bpp-rotate-180: - shard-snb: [PASS][9] -> [SKIP][10] ([fdo#109271]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-snb4/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-snb2/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html * igt@kms_cursor_crc@pipe-a-cursor-64x64-random: - shard-apl: [PASS][11] -> [FAIL][12] ([fdo#103232]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw: - shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) +2 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103166]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-y.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_vblank@pipe-c-wait-busy-hang: - shard-iclb: [PASS][17] -> [INCOMPLETE][18] ([fdo#107713]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-iclb5/igt@kms_vblank@pipe-c-wait-busy-hang.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-iclb1/igt@kms_vblank@pipe-c-wait-busy-hang.html * igt@prime_vgem@fence-wait-bsd2: - shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109276]) +6 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-iclb3/igt@prime_vgem@fence-wait-bsd2.html #### Possible fixes #### * igt@gem_bad_reloc@negative-reloc-bsd2: - shard-iclb: [SKIP][21] ([fdo#109276]) -> [PASS][22] +14 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-iclb8/igt@gem_bad_reloc@negative-reloc-bsd2.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-iclb2/igt@gem_bad_reloc@negative-reloc-bsd2.html * igt@gem_exec_schedule@preempt-other-bsd: - shard-iclb: [SKIP][23] ([fdo#111325]) -> [PASS][24] +6 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-iclb1/igt@gem_exec_schedule@preempt-other-bsd.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-iclb8/igt@gem_exec_schedule@preempt-other-bsd.html * igt@gem_tiled_swapping@non-threaded: - shard-apl: [DMESG-WARN][25] ([fdo#108686]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-apl2/igt@gem_tiled_swapping@non-threaded.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-apl1/igt@gem_tiled_swapping@non-threaded.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-apl: [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28] +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-apl5/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy: - shard-glk: [FAIL][29] ([fdo#104873]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite: - shard-iclb: [FAIL][31] ([fdo#103167]) -> [PASS][32] +3 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-iclb: [FAIL][33] ([fdo#103166]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-x.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [SKIP][35] ([fdo#109441]) -> [PASS][36] +2 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-iclb1/igt@kms_psr@psr2_cursor_blt.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html * igt@tools_test@tools_test: - shard-apl: [SKIP][37] ([fdo#109271]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-apl8/igt@tools_test@tools_test.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-apl5/igt@tools_test@tools_test.html #### Warnings #### * igt@gem_mocs_settings@mocs-settings-bsd2: - shard-iclb: [FAIL][39] ([fdo#111330]) -> [SKIP][40] ([fdo#109276]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-iclb2/igt@gem_mocs_settings@mocs-settings-bsd2.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-iclb7/igt@gem_mocs_settings@mocs-settings-bsd2.html * igt@kms_vblank@pipe-c-accuracy-idle: - shard-snb: [SKIP][41] ([fdo#109271] / [fdo#109278]) -> [SKIP][42] ([fdo#109271]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6871/shard-snb6/igt@kms_vblank@pipe-c-accuracy-idle.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/shard-snb2/igt@kms_vblank@pipe-c-accuracy-idle.html [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325 [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330 Participating hosts (10 -> 6) ------------------------------ Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5178 -> IGTPW_3443 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_6871: f58f61f8f8a1137f3b4e2bf4af02d5f7694a0b2e @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3443: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/ IGT_5178: efb4539494d94f03374874d3b61bd04ef3802aaa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3443/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-16 12:35 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-09-11 14:11 [igt-dev] [PATCH i-g-t] tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding Wang, Chao-kai (Stylon) 2019-09-11 14:29 ` Kazlauskas, Nicholas 2019-09-13 9:57 ` Petri Latvala 2019-09-16 12:35 ` Kazlauskas, Nicholas 2019-09-11 15:07 ` [igt-dev] ✓ Fi.CI.BAT: success for tools/amd_hdmi_compliance_yuv420: Test 4K video modes with YUV encoding (rev2) Patchwork 2019-09-12 1:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox