Re: [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c: Skip test if chamelium

[Kunal Joshi <kunal1.joshi@intel.com>]

On 2019-12-12 at 17:37:45 +0530, Martin Peres wrote:
> On 12/12/2019 13:26, Kunal Joshi wrote:
> > If chamelium is not present at the specified IP in the igtrc file,
> > tests should be skipped instead of failing.
> > Adding a change to skip tests on any network related issue and
> > assert on any other issue.
> > 
> > Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> > ---
> >  lib/igt_chamelium.c | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
> > index 9971f51..79eddde 100644
> > --- a/lib/igt_chamelium.c
> > +++ b/lib/igt_chamelium.c
> > @@ -344,9 +344,12 @@ static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium,
> >  				 format_str, va_args);
> >  	va_end(va_args);
> >  
> > -	igt_assert_f(!chamelium->env.fault_occurred,
> > -		     "Chamelium RPC call failed: %s\n",
> > -		     chamelium->env.fault_string);
> > +	if (chamelium->env.fault_code == XMLRPC_NETWORK_ERROR)
> > +		igt_skip("Chamelium not found at specified IP");
> 
> This message is misleading when the network just did not come back.
> 
> I prefer the fact that the test fails as it draws attention to either a
> mis-configured igtrc, a network problem, or a chamelium problem.
> 
Would it be fine if I modify the log to state the cause more explicitly?
Would you also suggest waiting for the xml-rpc timeout, to assure that
the problem isn't with network not coming back?
Is there a better way I can handle this?
> What is your rationale for this change? Skips are considered as failure
> anyway from our bug tracking point of view.
> 
If we happen to use igt_chamelium library with some other tests, then
skipping could be more appropriate than failing?
For Ex: In PSR tests we skip the test if edp panel is not present rather
than failing.
The same way I think the test should be skipped if chamelium is not
present.
> Martin
> 
> > +	else
> > +		igt_assert_f(!chamelium->env.fault_occurred,
> > +				"Chamelium RPC call failed: %s\n",
> > +				chamelium->env.fault_string);
> >  
> >  	return res;
> >  }
> > 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev