* [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c: Skip test if chamelium
@ 2019-12-12 11:26 Kunal Joshi
2019-12-12 12:07 ` Martin Peres
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Kunal Joshi @ 2019-12-12 11:26 UTC (permalink / raw)
To: igt-dev; +Cc: Kunal Joshi
If chamelium is not present at the specified IP in the igtrc file,
tests should be skipped instead of failing.
Adding a change to skip tests on any network related issue and
assert on any other issue.
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
lib/igt_chamelium.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index 9971f51..79eddde 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -344,9 +344,12 @@ static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium,
format_str, va_args);
va_end(va_args);
- igt_assert_f(!chamelium->env.fault_occurred,
- "Chamelium RPC call failed: %s\n",
- chamelium->env.fault_string);
+ if (chamelium->env.fault_code == XMLRPC_NETWORK_ERROR)
+ igt_skip("Chamelium not found at specified IP");
+ else
+ igt_assert_f(!chamelium->env.fault_occurred,
+ "Chamelium RPC call failed: %s\n",
+ chamelium->env.fault_string);
return res;
}
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c: Skip test if chamelium
2019-12-12 11:26 [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c: Skip test if chamelium Kunal Joshi
@ 2019-12-12 12:07 ` Martin Peres
2019-12-13 9:57 ` Kunal Joshi
2019-12-12 12:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-12-13 0:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Martin Peres @ 2019-12-12 12:07 UTC (permalink / raw)
To: Kunal Joshi, igt-dev
On 12/12/2019 13:26, Kunal Joshi wrote:
> If chamelium is not present at the specified IP in the igtrc file,
> tests should be skipped instead of failing.
> Adding a change to skip tests on any network related issue and
> assert on any other issue.
>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> lib/igt_chamelium.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
> index 9971f51..79eddde 100644
> --- a/lib/igt_chamelium.c
> +++ b/lib/igt_chamelium.c
> @@ -344,9 +344,12 @@ static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium,
> format_str, va_args);
> va_end(va_args);
>
> - igt_assert_f(!chamelium->env.fault_occurred,
> - "Chamelium RPC call failed: %s\n",
> - chamelium->env.fault_string);
> + if (chamelium->env.fault_code == XMLRPC_NETWORK_ERROR)
> + igt_skip("Chamelium not found at specified IP");
This message is misleading when the network just did not come back.
I prefer the fact that the test fails as it draws attention to either a
mis-configured igtrc, a network problem, or a chamelium problem.
What is your rationale for this change? Skips are considered as failure
anyway from our bug tracking point of view.
Martin
> + else
> + igt_assert_f(!chamelium->env.fault_occurred,
> + "Chamelium RPC call failed: %s\n",
> + chamelium->env.fault_string);
>
> return res;
> }
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_chamelium.c: Skip test if chamelium
2019-12-12 11:26 [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c: Skip test if chamelium Kunal Joshi
2019-12-12 12:07 ` Martin Peres
@ 2019-12-12 12:18 ` Patchwork
2019-12-13 0:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-12-12 12:18 UTC (permalink / raw)
To: Kunal Joshi; +Cc: igt-dev
== Series Details ==
Series: lib/igt_chamelium.c: Skip test if chamelium
URL : https://patchwork.freedesktop.org/series/70823/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7549 -> IGTPW_3854
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_3854 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_3854, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3854:
### IGT changes ###
#### Warnings ####
* igt@kms_chamelium@dp-hpd-fast:
- fi-cml-u2: [FAIL][1] ([i915#410]) -> [SKIP][2] +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/fi-cml-u2/igt@kms_chamelium@dp-hpd-fast.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/fi-cml-u2/igt@kms_chamelium@dp-hpd-fast.html
Known issues
------------
Here are the changes found in IGTPW_3854 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][3] -> [FAIL][4] ([i915#178])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_blt:
- fi-byt-j1900: [PASS][5] -> [DMESG-FAIL][6] ([i915#725])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/fi-byt-j1900/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/fi-byt-j1900/igt@i915_selftest@live_blt.html
#### Possible fixes ####
* igt@gem_exec_gttfill@basic:
- {fi-tgl-u}: [INCOMPLETE][7] ([fdo#111593]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/fi-tgl-u/igt@gem_exec_gttfill@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/fi-tgl-u/igt@gem_exec_gttfill@basic.html
* igt@i915_selftest@live_blt:
- fi-ivb-3770: [DMESG-FAIL][9] ([i915#563]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/fi-ivb-3770/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/fi-ivb-3770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_hangcheck:
- fi-icl-u3: [INCOMPLETE][11] ([fdo#108569] / [i915#140]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
#### Warnings ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92]) -> [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][15] ([fdo#111096] / [i915#323]) -> [FAIL][16] ([fdo#111407])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#62] / [i915#92]) +6 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#410]: https://gitlab.freedesktop.org/drm/intel/issues/410
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (48 -> 44)
------------------------------
Additional (3): fi-hsw-4770r fi-tgl-y fi-cfl-guc
Missing (7): fi-ilk-m540 fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5346 -> IGTPW_3854
CI-20190529: 20190529
CI_DRM_7549: 9573e1b7d1cb54cc984cf5c4f93a743641d868da @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3854: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/index.html
IGT_5346: 466b0e6cbcbaccff012b484d1fd7676364b37b93 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_chamelium.c: Skip test if chamelium
2019-12-12 11:26 [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c: Skip test if chamelium Kunal Joshi
2019-12-12 12:07 ` Martin Peres
2019-12-12 12:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-12-13 0:49 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-12-13 0:49 UTC (permalink / raw)
To: Kunal Joshi; +Cc: igt-dev
== Series Details ==
Series: lib/igt_chamelium.c: Skip test if chamelium
URL : https://patchwork.freedesktop.org/series/70823/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7549_full -> IGTPW_3854_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3854_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_3854_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3854_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_persistence@processes:
- shard-iclb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb3/igt@gem_ctx_persistence@processes.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb1/igt@gem_ctx_persistence@processes.html
Known issues
------------
Here are the changes found in IGTPW_3854_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-apl8/igt@gem_ctx_isolation@bcs0-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-apl1/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276] / [fdo#112080])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed-process.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed-process.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#110841])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_balancer@nop:
- shard-tglb: [PASS][9] -> [INCOMPLETE][10] ([fdo#111736])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-tglb6/igt@gem_exec_balancer@nop.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-tglb5/igt@gem_exec_balancer@nop.html
* igt@gem_exec_schedule@deep-bsd2:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276]) +6 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb1/igt@gem_exec_schedule@deep-bsd2.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb3/igt@gem_exec_schedule@deep-bsd2.html
* igt@gem_exec_schedule@preempt-queue-bsd:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#112146]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive:
- shard-tglb: [PASS][15] -> [TIMEOUT][16] ([i915#530])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-tglb8/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-tglb2/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#644])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [PASS][19] -> [DMESG-WARN][20] ([fdo#111870]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-snb4/igt@gem_userptr_blits@dmabuf-sync.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-snb5/igt@gem_userptr_blits@dmabuf-sync.html
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- shard-glk: [PASS][21] -> [DMESG-WARN][22] ([i915#118] / [i915#95])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-glk5/igt@i915_pm_rpm@modeset-stress-extra-wait.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
* igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen:
- shard-hsw: [PASS][23] -> [DMESG-WARN][24] ([IGT#6])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-hsw8/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-hsw6/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][25] -> [DMESG-WARN][26] ([i915#180]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [PASS][27] -> [INCOMPLETE][28] ([i915#61])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-hsw5/igt@kms_flip@flip-vs-suspend-interruptible.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- shard-tglb: [PASS][29] -> [INCOMPLETE][30] ([i915#435] / [i915#474] / [i915#667])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-glk: [PASS][31] -> [FAIL][32] ([i915#49]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-glk9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-glk9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html
- shard-apl: [PASS][33] -> [FAIL][34] ([i915#49])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-apl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-apl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html
- shard-kbl: [PASS][35] -> [FAIL][36] ([i915#49])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109642] / [fdo#111068])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb2/igt@kms_psr2_su@page_flip.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb4/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@perf_pmu@idle-vcs1:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#112080]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb4/igt@perf_pmu@idle-vcs1.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb5/igt@perf_pmu@idle-vcs1.html
#### Possible fixes ####
* igt@gem_ctx_isolation@vcs1-s3:
- shard-tglb: [INCOMPLETE][43] ([i915#456]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-tglb3/igt@gem_ctx_isolation@vcs1-s3.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-tglb1/igt@gem_ctx_isolation@vcs1-s3.html
* igt@gem_ctx_persistence@vcs1-persistence:
- shard-iclb: [SKIP][45] ([fdo#109276] / [fdo#112080]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb5/igt@gem_ctx_persistence@vcs1-persistence.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb2/igt@gem_ctx_persistence@vcs1-persistence.html
* igt@gem_eio@reset-stress:
- shard-snb: [FAIL][47] ([i915#232]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-snb2/igt@gem_eio@reset-stress.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-snb7/igt@gem_eio@reset-stress.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][49] ([fdo#110854]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb8/igt@gem_exec_balancer@smoke.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb4/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][51] ([fdo#112146]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb5/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][53] ([fdo#109276]) -> [PASS][54] +17 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive:
- shard-snb: [TIMEOUT][55] ([i915#530]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-snb1/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-snb7/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-hsw: [FAIL][57] ([i915#520]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-hsw4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-hsw2/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_persistent_relocs@forked-thrashing:
- shard-iclb: [TIMEOUT][59] ([i915#530]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb6/igt@gem_persistent_relocs@forked-thrashing.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb8/igt@gem_persistent_relocs@forked-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][61] ([fdo#111870]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@i915_selftest@mock_sanitycheck:
- shard-snb: [DMESG-WARN][63] ([i915#747]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-snb1/igt@i915_selftest@mock_sanitycheck.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-snb4/igt@i915_selftest@mock_sanitycheck.html
* igt@kms_color@pipe-a-gamma:
- shard-tglb: [FAIL][65] ([i915#71]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-tglb1/igt@kms_color@pipe-a-gamma.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-tglb8/igt@kms_color@pipe-a-gamma.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][67] ([i915#180]) -> [PASS][68] +6 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [DMESG-WARN][69] ([i915#180]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible.html
- shard-snb: [DMESG-WARN][71] ([i915#42]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-snb2/igt@kms_flip@flip-vs-suspend-interruptible.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-snb4/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@plain-flip-interruptible:
- shard-kbl: [INCOMPLETE][73] ([fdo#103665]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-kbl7/igt@kms_flip@plain-flip-interruptible.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-kbl4/igt@kms_flip@plain-flip-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-tglb: [INCOMPLETE][75] ([i915#474] / [i915#667]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][77] ([fdo#109642] / [fdo#111068]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb4/igt@kms_psr2_su@frontbuffer.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][79] ([fdo#109441]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][81] ([i915#460]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-tglb1/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-tglb7/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
* igt@perf_pmu@busy-check-all-vcs1:
- shard-iclb: [SKIP][83] ([fdo#112080]) -> [PASS][84] +12 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb5/igt@perf_pmu@busy-check-all-vcs1.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb4/igt@perf_pmu@busy-check-all-vcs1.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][85] ([fdo#109276] / [fdo#112080]) -> [FAIL][86] ([IGT#28])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][87] ([fdo#109349]) -> [DMESG-WARN][88] ([fdo#107724])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7549/shard-iclb5/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232
[i915#42]: https://gitlab.freedesktop.org/drm/intel/issues/42
[i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
[i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
[i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#667]: https://gitlab.freedesktop.org/drm/intel/issues/667
[i915#71]: https://gitlab.freedesktop.org/drm/intel/issues/71
[i915#747]: https://gitlab.freedesktop.org/drm/intel/issues/747
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-hsw-4770r
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5346 -> IGTPW_3854
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_7549: 9573e1b7d1cb54cc984cf5c4f93a743641d868da @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3854: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/index.html
IGT_5346: 466b0e6cbcbaccff012b484d1fd7676364b37b93 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3854/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c: Skip test if chamelium
2019-12-12 12:07 ` Martin Peres
@ 2019-12-13 9:57 ` Kunal Joshi
2019-12-16 11:17 ` Martin Peres
0 siblings, 1 reply; 6+ messages in thread
From: Kunal Joshi @ 2019-12-13 9:57 UTC (permalink / raw)
To: Martin Peres, igt-dev@lists.freedesktop.org; +Cc: igt-dev@lists.freedesktop.org
On 2019-12-12 at 17:37:45 +0530, Martin Peres wrote:
> On 12/12/2019 13:26, Kunal Joshi wrote:
> > If chamelium is not present at the specified IP in the igtrc file,
> > tests should be skipped instead of failing.
> > Adding a change to skip tests on any network related issue and
> > assert on any other issue.
> >
> > Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> > ---
> > lib/igt_chamelium.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
> > index 9971f51..79eddde 100644
> > --- a/lib/igt_chamelium.c
> > +++ b/lib/igt_chamelium.c
> > @@ -344,9 +344,12 @@ static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium,
> > format_str, va_args);
> > va_end(va_args);
> >
> > - igt_assert_f(!chamelium->env.fault_occurred,
> > - "Chamelium RPC call failed: %s\n",
> > - chamelium->env.fault_string);
> > + if (chamelium->env.fault_code == XMLRPC_NETWORK_ERROR)
> > + igt_skip("Chamelium not found at specified IP");
>
> This message is misleading when the network just did not come back.
>
> I prefer the fact that the test fails as it draws attention to either a
> mis-configured igtrc, a network problem, or a chamelium problem.
>
Would it be fine if I modify the log to state the cause more explicitly?
Would you also suggest waiting for the xml-rpc timeout, to assure that
the problem isn't with network not coming back?
Is there a better way I can handle this?
> What is your rationale for this change? Skips are considered as failure
> anyway from our bug tracking point of view.
>
If we happen to use igt_chamelium library with some other tests, then
skipping could be more appropriate than failing?
For Ex: In PSR tests we skip the test if edp panel is not present rather
than failing.
The same way I think the test should be skipped if chamelium is not
present.
> Martin
>
> > + else
> > + igt_assert_f(!chamelium->env.fault_occurred,
> > + "Chamelium RPC call failed: %s\n",
> > + chamelium->env.fault_string);
> >
> > return res;
> > }
> >
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c: Skip test if chamelium
2019-12-13 9:57 ` Kunal Joshi
@ 2019-12-16 11:17 ` Martin Peres
0 siblings, 0 replies; 6+ messages in thread
From: Martin Peres @ 2019-12-16 11:17 UTC (permalink / raw)
To: Kunal Joshi, igt-dev@lists.freedesktop.org
On 13/12/2019 11:57, Kunal Joshi wrote:
> On 2019-12-12 at 17:37:45 +0530, Martin Peres wrote:
>> On 12/12/2019 13:26, Kunal Joshi wrote:
>>> If chamelium is not present at the specified IP in the igtrc file,
>>> tests should be skipped instead of failing.
>>> Adding a change to skip tests on any network related issue and
>>> assert on any other issue.
>>>
>>> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
>>> ---
>>> lib/igt_chamelium.c | 9 ++++++---
>>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
>>> index 9971f51..79eddde 100644
>>> --- a/lib/igt_chamelium.c
>>> +++ b/lib/igt_chamelium.c
>>> @@ -344,9 +344,12 @@ static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium,
>>> format_str, va_args);
>>> va_end(va_args);
>>>
>>> - igt_assert_f(!chamelium->env.fault_occurred,
>>> - "Chamelium RPC call failed: %s\n",
>>> - chamelium->env.fault_string);
>>> + if (chamelium->env.fault_code == XMLRPC_NETWORK_ERROR)
>>> + igt_skip("Chamelium not found at specified IP");
>>
>> This message is misleading when the network just did not come back.
>>
>> I prefer the fact that the test fails as it draws attention to either a
>> mis-configured igtrc, a network problem, or a chamelium problem.
>>
> Would it be fine if I modify the log to state the cause more explicitly?
> Would you also suggest waiting for the xml-rpc timeout, to assure that
> the problem isn't with network not coming back?
> Is there a better way I can handle this?
Yes, you could provide possible explanations there (A. the device is not
present or B. the network is down.
>> What is your rationale for this change? Skips are considered as failure
>> anyway from our bug tracking point of view.
>>
> If we happen to use igt_chamelium library with some other tests, then
> skipping could be more appropriate than failing?
> For Ex: In PSR tests we skip the test if edp panel is not present rather
> than failing.
> The same way I think the test should be skipped if chamelium is not
> present.
I agree with the logic that if chamelium is not present, the tests
should skip. However, if the user has said "Chamelium is at this IP
address" but the test can't connect to it, then I would at least
consider this a failure in deploying chamelium.
Martin
>> Martin
>>
>>> + else
>>> + igt_assert_f(!chamelium->env.fault_occurred,
>>> + "Chamelium RPC call failed: %s\n",
>>> + chamelium->env.fault_string);
>>>
>>> return res;
>>> }
>>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-16 11:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-12 11:26 [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c: Skip test if chamelium Kunal Joshi
2019-12-12 12:07 ` Martin Peres
2019-12-13 9:57 ` Kunal Joshi
2019-12-16 11:17 ` Martin Peres
2019-12-12 12:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-12-13 0:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox