Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c: Skip test if chamelium
@ 2019-12-12 11:26 Kunal Joshi
  2019-12-12 12:07 ` Martin Peres
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Kunal Joshi @ 2019-12-12 11:26 UTC (permalink / raw)
  To: igt-dev; +Cc: Kunal Joshi

If chamelium is not present at the specified IP in the igtrc file,
tests should be skipped instead of failing.
Adding a change to skip tests on any network related issue and
assert on any other issue.

Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
 lib/igt_chamelium.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index 9971f51..79eddde 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -344,9 +344,12 @@ static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium,
 				 format_str, va_args);
 	va_end(va_args);
 
-	igt_assert_f(!chamelium->env.fault_occurred,
-		     "Chamelium RPC call failed: %s\n",
-		     chamelium->env.fault_string);
+	if (chamelium->env.fault_code == XMLRPC_NETWORK_ERROR)
+		igt_skip("Chamelium not found at specified IP");
+	else
+		igt_assert_f(!chamelium->env.fault_occurred,
+				"Chamelium RPC call failed: %s\n",
+				chamelium->env.fault_string);
 
 	return res;
 }
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-12-16 11:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-12 11:26 [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c: Skip test if chamelium Kunal Joshi
2019-12-12 12:07 ` Martin Peres
2019-12-13  9:57   ` Kunal Joshi
2019-12-16 11:17     ` Martin Peres
2019-12-12 12:18 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-12-13  0:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox