[igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait

[igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait

[Juha-Pekka Heikkila]

When run on more than one monitor there may be modeset in queue
which will block flip. Kernel will timeout with modeset at
ten seconds so lets wait in test also that same ten seconds at
maximum.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_cursor_legacy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index f41f68d..f2f1c09 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -251,7 +251,7 @@ static void flip_nonblocking(igt_display_t *display, enum pipe pipe_id, bool ato
 	igt_plane_t *primary = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
 	int ret;
 
-	igt_set_timeout(1, "Scheduling page flip\n");
+	igt_set_timeout(10, "Scheduling page flip\n");
 	if (!atomic) {
 		/* Schedule a nonblocking flip for the next vblank */
 		do {
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait

[Chris Wilson]

Quoting Juha-Pekka Heikkila (2020-02-21 12:08:07)
> When run on more than one monitor there may be modeset in queue
> which will block flip. Kernel will timeout with modeset at
> ten seconds so lets wait in test also that same ten seconds at
> maximum.

10s! You are joking, right? For a modeset that should not be there?
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait

[Juha-Pekka Heikkila]

On 21.2.2020 14.23, Chris Wilson wrote:
> Quoting Juha-Pekka Heikkila (2020-02-21 12:08:07)
>> When run on more than one monitor there may be modeset in queue
>> which will block flip. Kernel will timeout with modeset at
>> ten seconds so lets wait in test also that same ten seconds at
>> maximum.
> 
> 10s! You are joking, right? For a modeset that should not be there?

10s sounded quite big number to me too but that is from Ville. This test 
is now failing because modeset + flip take more than one second, on my 
ICL box with eDP + HDMI connected it becomes 1.19s. Arek is talking 
about test box where it is more than two seconds. Anyway if 10s is what 
kernel is waiting in the worst case I don't think test should be more 
strict.

/Juha-Pekka
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait

[Chris Wilson]

Quoting Juha-Pekka Heikkila (2020-02-21 13:12:46)
> On 21.2.2020 14.23, Chris Wilson wrote:
> > Quoting Juha-Pekka Heikkila (2020-02-21 12:08:07)
> >> When run on more than one monitor there may be modeset in queue
> >> which will block flip. Kernel will timeout with modeset at
> >> ten seconds so lets wait in test also that same ten seconds at
> >> maximum.
> > 
> > 10s! You are joking, right? For a modeset that should not be there?
> 
> 10s sounded quite big number to me too but that is from Ville. This test 
> is now failing because modeset + flip take more than one second, on my 
> ICL box with eDP + HDMI connected it becomes 1.19s. Arek is talking 
> about test box where it is more than two seconds. Anyway if 10s is what 
> kernel is waiting in the worst case I don't think test should be more 
> strict.

I think the kernel is broken. From a UX perspective that needs fixing.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait

[Juha-Pekka Heikkila]

On 21.2.2020 15.16, Chris Wilson wrote:
> Quoting Juha-Pekka Heikkila (2020-02-21 13:12:46)
>> On 21.2.2020 14.23, Chris Wilson wrote:
>>> Quoting Juha-Pekka Heikkila (2020-02-21 12:08:07)
>>>> When run on more than one monitor there may be modeset in queue
>>>> which will block flip. Kernel will timeout with modeset at
>>>> ten seconds so lets wait in test also that same ten seconds at
>>>> maximum.
>>>
>>> 10s! You are joking, right? For a modeset that should not be there?
>>
>> 10s sounded quite big number to me too but that is from Ville. This test
>> is now failing because modeset + flip take more than one second, on my
>> ICL box with eDP + HDMI connected it becomes 1.19s. Arek is talking
>> about test box where it is more than two seconds. Anyway if 10s is what
>> kernel is waiting in the worst case I don't think test should be more
>> strict.
> 
> I think the kernel is broken. From a UX perspective that needs fixing.

Possibly yes. In this test when modeset happen that monitor which is 
causing delay is coming from power saving. There's really big wait on 
kernel to see power cycle has gone through on monitor with modeset. 
Probably depend on much quality of monitor hw.

/Juha-Pekka
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait

[Ville Syrjälä]

On Fri, Feb 21, 2020 at 01:16:25PM +0000, Chris Wilson wrote:
> Quoting Juha-Pekka Heikkila (2020-02-21 13:12:46)
> > On 21.2.2020 14.23, Chris Wilson wrote:
> > > Quoting Juha-Pekka Heikkila (2020-02-21 12:08:07)
> > >> When run on more than one monitor there may be modeset in queue
> > >> which will block flip. Kernel will timeout with modeset at
> > >> ten seconds so lets wait in test also that same ten seconds at
> > >> maximum.
> > > 
> > > 10s! You are joking, right? For a modeset that should not be there?
> > 
> > 10s sounded quite big number to me too but that is from Ville. This test 
> > is now failing because modeset + flip take more than one second, on my 
> > ICL box with eDP + HDMI connected it becomes 1.19s. Arek is talking 
> > about test box where it is more than two seconds. Anyway if 10s is what 
> > kernel is waiting in the worst case I don't think test should be more 
> > strict.
> 
> I think the kernel is broken. From a UX perspective that needs fixing.

10s is the flip_done timeout. We shouldn't need quite that long.
IIRC the max panel power cycle delay we can program is something
like 5s.

I had a quick look at the test case but couldn't quite figure out
what specifically it was trying to say with the different timeouts.

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_cursor_legacy: increase timeout for nonblocking flip wait

[Patchwork]

== Series Details ==

Series: tests/kms_cursor_legacy: increase timeout for nonblocking flip wait
URL   : https://patchwork.freedesktop.org/series/73767/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7982 -> IGTPW_4209
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_4209 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_4209, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4209/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_4209:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live_gt_pm:
    - fi-bwr-2160:        [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-bwr-2160/igt@i915_selftest@live_gt_pm.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4209/fi-bwr-2160/igt@i915_selftest@live_gt_pm.html

  
New tests
---------

  New tests have been introduced between CI_DRM_7982 and IGTPW_4209:

### New IGT tests (1) ###

  * igt@i915_pm_rpm@module-reload:
    - Statuses : 2 dmesg-warn(s) 30 pass(s) 8 skip(s)
    - Exec time: [0.0, 48.80] s

  

Known issues
------------

  Here are the changes found in IGTPW_4209 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_flink_basic@flink-lifetime:
    - fi-tgl-y:           [PASS][3] -> [DMESG-WARN][4] ([CI#94] / [i915#402]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-tgl-y/igt@gem_flink_basic@flink-lifetime.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4209/fi-tgl-y/igt@gem_flink_basic@flink-lifetime.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-cml-s:           [PASS][5] -> [DMESG-FAIL][6] ([i915#877])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-cml-s/igt@i915_selftest@live_gem_contexts.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4209/fi-cml-s/igt@i915_selftest@live_gem_contexts.html

  * igt@i915_selftest@live_gtt:
    - fi-bdw-5557u:       [PASS][7] -> [TIMEOUT][8] ([fdo#112271])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-bdw-5557u/igt@i915_selftest@live_gtt.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4209/fi-bdw-5557u/igt@i915_selftest@live_gtt.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-skl-6600u:       [INCOMPLETE][9] ([i915#146] / [i915#69]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-skl-6600u/igt@gem_exec_suspend@basic-s3.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4209/fi-skl-6600u/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-tgl-y:           [FAIL][11] ([CI#94]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4209/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_selftest@live_sanitycheck:
    - fi-icl-u3:          [DMESG-WARN][13] ([i915#585]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4209/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html

  * igt@kms_addfb_basic@addfb25-modifier-no-flag:
    - fi-tgl-y:           [DMESG-WARN][15] ([CI#94] / [i915#402]) -> [PASS][16] +1 similar issue
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-tgl-y/igt@kms_addfb_basic@addfb25-modifier-no-flag.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4209/fi-tgl-y/igt@kms_addfb_basic@addfb25-modifier-no-flag.html

  
#### Warnings ####

  * igt@amdgpu/amd_prime@amd-to-i915:
    - fi-icl-u3:          [SKIP][17] ([fdo#109315]) -> [SKIP][18] ([fdo#109315] / [i915#585])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7982/fi-icl-u3/igt@amdgpu/amd_prime@amd-to-i915.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4209/fi-icl-u3/igt@amdgpu/amd_prime@amd-to-i915.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
  [i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233
  [i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#585]: https://gitlab.freedesktop.org/drm/intel/issues/585
  [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
  [i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877


Participating hosts (51 -> 46)
------------------------------

  Additional (2): fi-hsw-peppy fi-snb-2520m 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5457 -> IGTPW_4209

  CI-20190529: 20190529
  CI_DRM_7982: f02659605b48dcabb562bbb96db2996b334e57fd @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4209: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4209/index.html
  IGT_5457: 3e686098d928aa928f668e00fa01e92234e173ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4209/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait

[Juha-Pekka Heikkila]

When run on more than one monitor there may be modeset in queue
which will block flip. Kernel will timeout with modeset at
ten seconds so lets wait in test also that same ten seconds at
maximum.

V2 Ville Syrjälä: lets just wait for five seconds

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_cursor_legacy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index f41f68d..d5f95b8 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -251,7 +251,7 @@ static void flip_nonblocking(igt_display_t *display, enum pipe pipe_id, bool ato
 	igt_plane_t *primary = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
 	int ret;
 
-	igt_set_timeout(1, "Scheduling page flip\n");
+	igt_set_timeout(5, "Scheduling page flip\n");
 	if (!atomic) {
 		/* Schedule a nonblocking flip for the next vblank */
 		do {
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait

[Kahola, Mika]

On Wed, 2020-03-04 at 16:50 +0200, Juha-Pekka Heikkila wrote:
> When run on more than one monitor there may be modeset in queue
> which will block flip. Kernel will timeout with modeset at
> ten seconds so lets wait in test also that same ten seconds at
> maximum.
> 
> V2 Ville Syrjälä: lets just wait for five seconds
Let's just do this.

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>


> ---
>  tests/kms_cursor_legacy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index f41f68d..d5f95b8 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -251,7 +251,7 @@ static void flip_nonblocking(igt_display_t
> *display, enum pipe pipe_id, bool ato
>  	igt_plane_t *primary = igt_pipe_get_plane_type(pipe,
> DRM_PLANE_TYPE_PRIMARY);
>  	int ret;
>  
> -	igt_set_timeout(1, "Scheduling page flip\n");
> +	igt_set_timeout(5, "Scheduling page flip\n");
>  	if (!atomic) {
>  		/* Schedule a nonblocking flip for the next vblank */
>  		do {
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev