* [igt-dev] [RFC i-g-t] LPSP igt test on TGL
@ 2020-02-27 8:41 Anshuman Gupta
2020-02-27 12:44 ` Jani Nikula
2020-02-27 12:55 ` Ville Syrjälä
0 siblings, 2 replies; 8+ messages in thread
From: Anshuman Gupta @ 2020-02-27 8:41 UTC (permalink / raw)
To: igt-dev; +Cc: martin.peres
+-------------------------------------------------------------------------------+
| |
| |
| |
| +--------------------+ +-------------+ +------------+ |
| | | | | | | |
| | PIPE A | | DP/HDMI | | PORT_A | |
| | +--------+ TRANSCODER +---------+ | |
| | | | | | | |
| +--------------------+ +-------------> +------------> |
| | | | | |
| | | | PORT_B | |
| | | | | |
| | | | | |
| +-------------> +------------> |
| | | | | |
| | DSI | | PORT_C | |
| | TRANSCODER | | | |
| +-------------> +------------+ |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| +-------------+ |
| |
| LPSP on Tigerlake |
| |
+-------------------------------------------------------------------------------+
Above block diagram depicts lpsp on TGL, while earlier development of lpsp igt test
it has been assumed that every non-edp panel is not a lpsp panel but it is not true
on TGL, any HDMI/DP panel connected on pipe A and connected to PORT_{A,B,C} is lpsp
panel, and DSI panel is also lpsp panel.
Currently i915_pm_lpsp igt has been categorized in edp-native and non-edp subtest.
non-edp subtest require the fix to validate the lpsp panels.
My solution approach to check the port on which DP/HDMI connector is currently
connected.
if (port <= PORT_C)
lpsp_should_be_enabled.
else
lpsp_should_be_disabled.
Currently there are two igt i915_pm_lpsp, i915_pm_rpm require to know the port
of DP/HDMI connector, so we need a igt library function for that.
I am looking to parse the i915_display_info to get the port information, but at
same time it seems a fragile solution to me as any change in i915_display_info
will break the test, but i don't have any other idea to get the port information.
Please provide your opinion and feedback for the above solution approach.
Thanks,
Anshuman Gupta.
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [igt-dev] [RFC i-g-t] LPSP igt test on TGL 2020-02-27 8:41 [igt-dev] [RFC i-g-t] LPSP igt test on TGL Anshuman Gupta @ 2020-02-27 12:44 ` Jani Nikula 2020-03-03 4:27 ` Anshuman Gupta 2020-02-27 12:55 ` Ville Syrjälä 1 sibling, 1 reply; 8+ messages in thread From: Jani Nikula @ 2020-02-27 12:44 UTC (permalink / raw) To: Anshuman Gupta, igt-dev; +Cc: martin.peres On Thu, 27 Feb 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > Above block diagram depicts lpsp on TGL, while earlier development of > lpsp igt test it has been assumed that every non-edp panel is not a > lpsp panel but it is not true on TGL, any HDMI/DP panel connected on > pipe A and connected to PORT_{A,B,C} is lpsp panel, and DSI panel is > also lpsp panel. > > Currently i915_pm_lpsp igt has been categorized in edp-native and non-edp subtest. > non-edp subtest require the fix to validate the lpsp panels. > My solution approach to check the port on which DP/HDMI connector is currently > connected. > if (port <= PORT_C) > lpsp_should_be_enabled. > else > lpsp_should_be_disabled. > > Currently there are two igt i915_pm_lpsp, i915_pm_rpm require to know > the port of DP/HDMI connector, so we need a igt library function for > that. > > I am looking to parse the i915_display_info to get the port > information, but at same time it seems a fragile solution to me as any > change in i915_display_info will break the test, but i don't have any > other idea to get the port information. > > Please provide your opinion and feedback for the above solution approach. I'd add a connector specific debugfs file that tells you whether LPSS (Low Power Single Pipe, for those who want to know what the acronym means) is possible and whether it's enabled. Alternatively add the info about LPSS to i915_display_info. But AFAICT there's no need for userspace to know about the port. This also avoids reading the HSW_PWR_WELL_CTL2 register directly. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [RFC i-g-t] LPSP igt test on TGL 2020-02-27 12:44 ` Jani Nikula @ 2020-03-03 4:27 ` Anshuman Gupta 2020-03-03 8:34 ` Jani Nikula 0 siblings, 1 reply; 8+ messages in thread From: Anshuman Gupta @ 2020-03-03 4:27 UTC (permalink / raw) To: Jani Nikula, ville.syrjala; +Cc: igt-dev, martin.peres On 2020-02-27 at 14:44:18 +0200, Jani Nikula wrote: > On Thu, 27 Feb 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > > Above block diagram depicts lpsp on TGL, while earlier development of > > lpsp igt test it has been assumed that every non-edp panel is not a > > lpsp panel but it is not true on TGL, any HDMI/DP panel connected on > > pipe A and connected to PORT_{A,B,C} is lpsp panel, and DSI panel is > > also lpsp panel. > > > > Currently i915_pm_lpsp igt has been categorized in edp-native and non-edp subtest. > > non-edp subtest require the fix to validate the lpsp panels. > > My solution approach to check the port on which DP/HDMI connector is currently > > connected. > > if (port <= PORT_C) > > lpsp_should_be_enabled. > > else > > lpsp_should_be_disabled. > > > > Currently there are two igt i915_pm_lpsp, i915_pm_rpm require to know > > the port of DP/HDMI connector, so we need a igt library function for > > that. > > > > I am looking to parse the i915_display_info to get the port > > information, but at same time it seems a fragile solution to me as any > > change in i915_display_info will break the test, but i don't have any > > other idea to get the port information. > > > > Please provide your opinion and feedback for the above solution approach. > > I'd add a connector specific debugfs file that tells you whether LPSS > (Low Power Single Pipe, for those who want to know what the acronym > means) is possible and whether it's enabled. Alternatively add the info > about LPSS to i915_display_info. But AFAICT there's no need for > userspace to know about the port. This also avoids reading the > HSW_PWR_WELL_CTL2 register directly. Thanks Jani and Ville for your feedback and suggestion, based upon your feedback i have following solution approach. Add a connector specific debugfs attributes i915_lpsp_cpable. for ecah connector if it is lpsp capable, do modeset with pipe A crtc on that connector and validate if power wells above pg2 are turned off by using i915_power_domain_info. Thanks , Anshuman > > BR, > Jani. > > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [RFC i-g-t] LPSP igt test on TGL 2020-03-03 4:27 ` Anshuman Gupta @ 2020-03-03 8:34 ` Jani Nikula 2020-03-03 8:45 ` Anshuman Gupta 0 siblings, 1 reply; 8+ messages in thread From: Jani Nikula @ 2020-03-03 8:34 UTC (permalink / raw) To: Anshuman Gupta, ville.syrjala; +Cc: igt-dev, martin.peres On Tue, 03 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > On 2020-02-27 at 14:44:18 +0200, Jani Nikula wrote: >> On Thu, 27 Feb 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: >> > Above block diagram depicts lpsp on TGL, while earlier development of >> > lpsp igt test it has been assumed that every non-edp panel is not a >> > lpsp panel but it is not true on TGL, any HDMI/DP panel connected on >> > pipe A and connected to PORT_{A,B,C} is lpsp panel, and DSI panel is >> > also lpsp panel. >> > >> > Currently i915_pm_lpsp igt has been categorized in edp-native and non-edp subtest. >> > non-edp subtest require the fix to validate the lpsp panels. >> > My solution approach to check the port on which DP/HDMI connector is currently >> > connected. >> > if (port <= PORT_C) >> > lpsp_should_be_enabled. >> > else >> > lpsp_should_be_disabled. >> > >> > Currently there are two igt i915_pm_lpsp, i915_pm_rpm require to know >> > the port of DP/HDMI connector, so we need a igt library function for >> > that. >> > >> > I am looking to parse the i915_display_info to get the port >> > information, but at same time it seems a fragile solution to me as any >> > change in i915_display_info will break the test, but i don't have any >> > other idea to get the port information. >> > >> > Please provide your opinion and feedback for the above solution approach. >> >> I'd add a connector specific debugfs file that tells you whether LPSS >> (Low Power Single Pipe, for those who want to know what the acronym >> means) is possible and whether it's enabled. Alternatively add the info >> about LPSS to i915_display_info. But AFAICT there's no need for >> userspace to know about the port. This also avoids reading the >> HSW_PWR_WELL_CTL2 register directly. > Thanks Jani and Ville for your feedback and suggestion, based upon your feedback > i have following solution approach. > Add a connector specific debugfs attributes i915_lpsp_cpable. > for ecah connector if it is lpsp capable, do modeset with pipe A crtc > on that connector and validate if power wells above pg2 are turned off > by using i915_power_domain_info. Why not add a debugfs file that will tell you both, instead of forcing the userspace to know about the connection between lpsp and pg2? BR, Jani. > > Thanks , > Anshuman >> >> BR, >> Jani. >> >> >> -- >> Jani Nikula, Intel Open Source Graphics Center -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [RFC i-g-t] LPSP igt test on TGL 2020-03-03 8:34 ` Jani Nikula @ 2020-03-03 8:45 ` Anshuman Gupta 2020-03-03 10:44 ` Jani Nikula 0 siblings, 1 reply; 8+ messages in thread From: Anshuman Gupta @ 2020-03-03 8:45 UTC (permalink / raw) To: Jani Nikula; +Cc: igt-dev, martin.peres On 2020-03-03 at 10:34:06 +0200, Jani Nikula wrote: > On Tue, 03 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > > On 2020-02-27 at 14:44:18 +0200, Jani Nikula wrote: > >> On Thu, 27 Feb 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > >> > Above block diagram depicts lpsp on TGL, while earlier development of > >> > lpsp igt test it has been assumed that every non-edp panel is not a > >> > lpsp panel but it is not true on TGL, any HDMI/DP panel connected on > >> > pipe A and connected to PORT_{A,B,C} is lpsp panel, and DSI panel is > >> > also lpsp panel. > >> > > >> > Currently i915_pm_lpsp igt has been categorized in edp-native and non-edp subtest. > >> > non-edp subtest require the fix to validate the lpsp panels. > >> > My solution approach to check the port on which DP/HDMI connector is currently > >> > connected. > >> > if (port <= PORT_C) > >> > lpsp_should_be_enabled. > >> > else > >> > lpsp_should_be_disabled. > >> > > >> > Currently there are two igt i915_pm_lpsp, i915_pm_rpm require to know > >> > the port of DP/HDMI connector, so we need a igt library function for > >> > that. > >> > > >> > I am looking to parse the i915_display_info to get the port > >> > information, but at same time it seems a fragile solution to me as any > >> > change in i915_display_info will break the test, but i don't have any > >> > other idea to get the port information. > >> > > >> > Please provide your opinion and feedback for the above solution approach. > >> > >> I'd add a connector specific debugfs file that tells you whether LPSS > >> (Low Power Single Pipe, for those who want to know what the acronym > >> means) is possible and whether it's enabled. Alternatively add the info > >> about LPSS to i915_display_info. But AFAICT there's no need for > >> userspace to know about the port. This also avoids reading the > >> HSW_PWR_WELL_CTL2 register directly. > > Thanks Jani and Ville for your feedback and suggestion, based upon your feedback > > i have following solution approach. > > Add a connector specific debugfs attributes i915_lpsp_cpable. > > for ecah connector if it is lpsp capable, do modeset with pipe A crtc > > on that connector and validate if power wells above pg2 are turned off > > by using i915_power_domain_info. > > Why not add a debugfs file that will tell you both, instead of forcing > the userspace to know about the connection between lpsp and pg2? IMHO a DP/HDMI connector may not be connected to pipe A crtc in default mode. So via igt we can have modeset on Pipe A with DP/HDMI connector and can validate lpsp for DP/HDMI connector. Please correct me if am wrong. Thanks, Anshuman Gupta. > > BR, > Jani. > > > > > > > Thanks , > > Anshuman > >> > >> BR, > >> Jani. > >> > >> > >> -- > >> Jani Nikula, Intel Open Source Graphics Center > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [RFC i-g-t] LPSP igt test on TGL 2020-03-03 8:45 ` Anshuman Gupta @ 2020-03-03 10:44 ` Jani Nikula 2020-03-03 12:20 ` Anshuman Gupta 0 siblings, 1 reply; 8+ messages in thread From: Jani Nikula @ 2020-03-03 10:44 UTC (permalink / raw) To: Anshuman Gupta; +Cc: igt-dev, martin.peres On Tue, 03 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > On 2020-03-03 at 10:34:06 +0200, Jani Nikula wrote: >> On Tue, 03 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: >> > On 2020-02-27 at 14:44:18 +0200, Jani Nikula wrote: >> >> On Thu, 27 Feb 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: >> > Add a connector specific debugfs attributes i915_lpsp_cpable. >> > for ecah connector if it is lpsp capable, do modeset with pipe A crtc >> > on that connector and validate if power wells above pg2 are turned off >> > by using i915_power_domain_info. >> >> Why not add a debugfs file that will tell you both, instead of forcing >> the userspace to know about the connection between lpsp and pg2? > IMHO a DP/HDMI connector may not be connected to pipe A crtc in default mode. What is default mode? > So via igt we can have modeset on Pipe A with DP/HDMI connector and can > validate lpsp for DP/HDMI connector. > Please correct me if am wrong. Sorry, I am not sure what you're asking. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [RFC i-g-t] LPSP igt test on TGL 2020-03-03 10:44 ` Jani Nikula @ 2020-03-03 12:20 ` Anshuman Gupta 0 siblings, 0 replies; 8+ messages in thread From: Anshuman Gupta @ 2020-03-03 12:20 UTC (permalink / raw) To: Jani Nikula; +Cc: igt-dev, martin.peres On 2020-03-03 at 12:44:30 +0200, Jani Nikula wrote: > On Tue, 03 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > > On 2020-03-03 at 10:34:06 +0200, Jani Nikula wrote: > >> On Tue, 03 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > >> > On 2020-02-27 at 14:44:18 +0200, Jani Nikula wrote: > >> >> On Thu, 27 Feb 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > >> > Add a connector specific debugfs attributes i915_lpsp_cpable. > >> > for ecah connector if it is lpsp capable, do modeset with pipe A crtc > >> > on that connector and validate if power wells above pg2 are turned off > >> > by using i915_power_domain_info. > >> > >> Why not add a debugfs file that will tell you both, instead of forcing > >> the userspace to know about the connection between lpsp and pg2? > > IMHO a DP/HDMI connector may not be connected to pipe A crtc in default mode. > > What is default mode? > > > So via igt we can have modeset on Pipe A with DP/HDMI connector and can > > validate lpsp for DP/HDMI connector. > > Please correct me if am wrong. > > Sorry, I am not sure what you're asking. Sorry for noise, yes it would make sense to expose both lpsp capabilty and lpsp status in debugfs. Thanks, Anshuman Gupta. > > BR, > Jani. > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [RFC i-g-t] LPSP igt test on TGL 2020-02-27 8:41 [igt-dev] [RFC i-g-t] LPSP igt test on TGL Anshuman Gupta 2020-02-27 12:44 ` Jani Nikula @ 2020-02-27 12:55 ` Ville Syrjälä 1 sibling, 0 replies; 8+ messages in thread From: Ville Syrjälä @ 2020-02-27 12:55 UTC (permalink / raw) To: Anshuman Gupta; +Cc: igt-dev, martin.peres On Thu, Feb 27, 2020 at 02:11:49PM +0530, Anshuman Gupta wrote: > +-------------------------------------------------------------------------------+ > | | > | | > | | > | +--------------------+ +-------------+ +------------+ | > | | | | | | | | > | | PIPE A | | DP/HDMI | | PORT_A | | > | | +--------+ TRANSCODER +---------+ | | > | | | | | | | | > | +--------------------+ +-------------> +------------> | > | | | | | | > | | | | PORT_B | | > | | | | | | > | | | | | | > | +-------------> +------------> | > | | | | | | > | | DSI | | PORT_C | | > | | TRANSCODER | | | | > | +-------------> +------------+ | > | | | | > | | | | > | | | | > | | | | > | | | | > | | | | > | | | | > | +-------------+ | > | | > | LPSP on Tigerlake | > | | > +-------------------------------------------------------------------------------+ > > Above block diagram depicts lpsp on TGL, while earlier development of lpsp igt test > it has been assumed that every non-edp panel is not a lpsp panel but it is not true > on TGL, It wasn't necessarily true on earlier platforms either. I don't know if this makes any sense whatsoever. Probably a better way to validate would be to check that the resulting power domains make sense for various single pipe configurations. -- Ville Syrjälä Intel _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-03-03 12:28 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-02-27 8:41 [igt-dev] [RFC i-g-t] LPSP igt test on TGL Anshuman Gupta 2020-02-27 12:44 ` Jani Nikula 2020-03-03 4:27 ` Anshuman Gupta 2020-03-03 8:34 ` Jani Nikula 2020-03-03 8:45 ` Anshuman Gupta 2020-03-03 10:44 ` Jani Nikula 2020-03-03 12:20 ` Anshuman Gupta 2020-02-27 12:55 ` Ville Syrjälä
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox