public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] runner: Only show the kmsg underflow/overflow message once
@ 2020-03-25 12:33 Chris Wilson
  2020-03-25 12:41 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Chris Wilson @ 2020-03-25 12:33 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala

Instead of repeating every single time we underflow the read from kmsg,
just once per test is enough warning.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
---
 runner/executor.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/runner/executor.c b/runner/executor.c
index a56cb5d66..b26cb7bc7 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -549,6 +549,8 @@ static int dump_dmesg(int kmsgfd, int outfd)
 	int comparefd;
 	unsigned flags;
 	unsigned long long seq, cmpseq, usec;
+	bool underflow_once = false;
+	bool overflow_once = false;
 	char cont;
 	char buf[2048];
 	ssize_t r;
@@ -586,10 +588,16 @@ static int dump_dmesg(int kmsgfd, int outfd)
 		r = read(kmsgfd, buf, sizeof(buf));
 		if (r < 0) {
 			if (errno == EPIPE) {
-				errf("Warning: kernel log ringbuffer underflow, some records lost.\n");
+				if (!overflow_once) {
+					errf("Warning: kernel log ringbuffer underflow, some records lost.\n");
+					overflow_once = true;
+				}
 				continue;
 			} else if (errno == EINVAL) {
-				errf("Warning: Buffer too small for kernel log record, record lost.\n");
+				if (!underflow_once) {
+					errf("Warning: Buffer too small for kernel log record, record lost.\n");
+					underflow_once = true;
+				}
 				continue;
 			} else if (errno != EAGAIN) {
 				errf("Error reading from kmsg: %m\n");
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-03-25 15:38 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-25 12:33 [igt-dev] [PATCH i-g-t] runner: Only show the kmsg underflow/overflow message once Chris Wilson
2020-03-25 12:41 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2020-03-25 12:52 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2020-03-25 12:58 ` [igt-dev] [PATCH i-g-t v2] runner: Only show the kmsg overflow " Chris Wilson
2020-03-25 13:14   ` Petri Latvala
2020-03-25 13:06 ` [igt-dev] ✓ Fi.CI.BAT: success for runner: Only show the kmsg underflow/overflow " Patchwork
2020-03-25 13:30 ` [igt-dev] ✓ Fi.CI.BAT: success for runner: Only show the kmsg underflow/overflow message once (rev2) Patchwork
2020-03-25 14:56 ` [igt-dev] ✓ Fi.CI.IGT: success for runner: Only show the kmsg underflow/overflow message once Patchwork
2020-03-25 15:38 ` [igt-dev] ✗ Fi.CI.IGT: failure for runner: Only show the kmsg underflow/overflow message once (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox