public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_chamelium: Capture on type-c
@ 2020-04-15 22:26 Kunal Joshi
  2020-04-16  6:35 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2020-04-17  2:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  0 siblings, 2 replies; 6+ messages in thread
From: Kunal Joshi @ 2020-04-15 22:26 UTC (permalink / raw)
  To: arkadiusz.hiler, igt-dev, imre.deak; +Cc: Kunal Joshi

When we try to capture from chamelium it sends hpd pulse 
when it needs fsm handling but on type-c connector we
dodn't get it when the modeset is enabled, disabling
modeset so  we get hpd pulse.

Cc: Hiler Arkadiusz <arkadiusz.hiler@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Issue: https://gitlab.freedesktop.org/drm/intel/issues/262
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
 tests/kms_chamelium.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index 8b20bbb..3639f5a 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -672,7 +672,6 @@ test_suspend_resume_edid_change(data_t *data, struct chamelium_port *port,
 	get_connectors_link_status_failed(data, link_status_failed[0]);
 
 	igt_flush_hotplugs(mon);
-
 	igt_system_suspend_autoresume(state, test);
 	igt_assert(igt_hotplug_detected(mon, HOTPLUG_TIMEOUT));
 	chamelium_assert_reachable(data->chamelium, ONLINE_TIMEOUT);
@@ -841,6 +840,11 @@ static void test_display_all_modes(data_t *data, struct chamelium_port *port,
 		bridge = check_analog_bridge(data, port);
 
 	for (i = 0; i < connector->count_modes; i++) {
+	        output = prepare_output(data, port, TEST_EDID_BASE);
+	        connector = chamelium_port_get_connector(data->chamelium, port, false);
+	        primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+	        igt_assert(primary);
+	        igt_require(igt_plane_has_format_mod(primary, fourcc, LOCAL_DRM_FORMAT_MOD_NONE));
 		drmModeModeInfo *mode = &connector->modes[i];
 
 		if (check == CHAMELIUM_CHECK_ANALOG && bridge &&
@@ -848,6 +852,7 @@ static void test_display_all_modes(data_t *data, struct chamelium_port *port,
 			continue;
 
 		do_test_display(data, port, output, mode, fourcc, check, count);
+		reset_state(data, port);
 	}
 
 	drmModeFreeConnector(connector);
@@ -876,6 +881,10 @@ test_display_frame_dump(data_t *data, struct chamelium_port *port)
 	igt_assert(primary);
 
 	for (i = 0; i < connector->count_modes; i++) {
+		output = prepare_output(data, port, TEST_EDID_BASE);
+		connector = chamelium_port_get_connector(data->chamelium, port, false);
+		primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+		igt_assert(primary);
 		mode = &connector->modes[i];
 		fb_id = igt_create_color_pattern_fb(data->drm_fd,
 						    mode->hdisplay, mode->vdisplay,
@@ -896,6 +905,7 @@ test_display_frame_dump(data_t *data, struct chamelium_port *port)
 		}
 
 		igt_remove_fb(data->drm_fd, &fb);
+		reset_state(data, port);
 	}
 
 	drmModeFreeConnector(connector);
@@ -2506,7 +2516,6 @@ test_hpd_storm_detect(data_t *data, struct chamelium_port *port, int width)
 {
 	struct udev_monitor *mon;
 	int count = 0;
-
 	igt_require_hpd_storm_ctl(data->drm_fd);
 	reset_state(data, port);
 
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_chamelium Capture on type-c
@ 2020-04-16  3:21 Kunal Joshi
  2020-04-16 10:41 ` Arkadiusz Hiler
  0 siblings, 1 reply; 6+ messages in thread
From: Kunal Joshi @ 2020-04-16  3:21 UTC (permalink / raw)
  To: arkadiusz.hiler, igt-dev, imre.deak; +Cc: Kunal Joshi

When we try to capture from chamelium it sends hpd pulse
when it needs fsm handling but on type-c connector we
dodn't get it when the modeset is enabled, disabling
modeset so  we get hpd pulse.

Cc: Hiler Arkadiusz <arkadiusz.hiler@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Issue: https://gitlab.freedesktop.org/drm/intel/issues/262
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
 tests/kms_chamelium.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index 8b20bbb..2f53063 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -672,7 +672,6 @@ test_suspend_resume_edid_change(data_t *data, struct chamelium_port *port,
 	get_connectors_link_status_failed(data, link_status_failed[0]);
 
 	igt_flush_hotplugs(mon);
-
 	igt_system_suspend_autoresume(state, test);
 	igt_assert(igt_hotplug_detected(mon, HOTPLUG_TIMEOUT));
 	chamelium_assert_reachable(data->chamelium, ONLINE_TIMEOUT);
@@ -833,14 +832,16 @@ static void test_display_all_modes(data_t *data, struct chamelium_port *port,
 
 	output = prepare_output(data, port, TEST_EDID_BASE);
 	connector = chamelium_port_get_connector(data->chamelium, port, false);
-	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
-	igt_assert(primary);
-	igt_require(igt_plane_has_format_mod(primary, fourcc, LOCAL_DRM_FORMAT_MOD_NONE));
 
 	if (check == CHAMELIUM_CHECK_ANALOG)
 		bridge = check_analog_bridge(data, port);
 
 	for (i = 0; i < connector->count_modes; i++) {
+	        output = prepare_output(data, port, TEST_EDID_BASE);
+	        connector = chamelium_port_get_connector(data->chamelium, port, false);
+	        primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+	        igt_assert(primary);
+	        igt_require(igt_plane_has_format_mod(primary, fourcc, LOCAL_DRM_FORMAT_MOD_NONE));
 		drmModeModeInfo *mode = &connector->modes[i];
 
 		if (check == CHAMELIUM_CHECK_ANALOG && bridge &&
@@ -848,6 +849,7 @@ static void test_display_all_modes(data_t *data, struct chamelium_port *port,
 			continue;
 
 		do_test_display(data, port, output, mode, fourcc, check, count);
+		reset_state(data, port);
 	}
 
 	drmModeFreeConnector(connector);
@@ -872,10 +874,12 @@ test_display_frame_dump(data_t *data, struct chamelium_port *port)
 
 	output = prepare_output(data, port, TEST_EDID_BASE);
 	connector = chamelium_port_get_connector(data->chamelium, port, false);
-	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
-	igt_assert(primary);
 
 	for (i = 0; i < connector->count_modes; i++) {
+		output = prepare_output(data, port, TEST_EDID_BASE);
+		connector = chamelium_port_get_connector(data->chamelium, port, false);
+		primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+		igt_assert(primary);
 		mode = &connector->modes[i];
 		fb_id = igt_create_color_pattern_fb(data->drm_fd,
 						    mode->hdisplay, mode->vdisplay,
@@ -896,6 +900,7 @@ test_display_frame_dump(data_t *data, struct chamelium_port *port)
 		}
 
 		igt_remove_fb(data->drm_fd, &fb);
+		reset_state(data, port);
 	}
 
 	drmModeFreeConnector(connector);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-17  2:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-15 22:26 [igt-dev] [PATCH i-g-t] tests/kms_chamelium: Capture on type-c Kunal Joshi
2020-04-16  6:35 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-04-17  2:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2020-04-16  3:21 [igt-dev] [PATCH i-g-t] tests/kms_chamelium " Kunal Joshi
2020-04-16 10:41 ` Arkadiusz Hiler
2020-04-16  4:26   ` Kunal Joshi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox