* [igt-dev] [[RFC] PATCH i-g-t 1/2] lib/drmtest: Don't write ffffffff to a numeric param
2020-06-10 19:11 [igt-dev] [[RFC] PATCH i-g-t 0/2] lib/igt_kms: Add support for display with Mohammed Khajapasha
@ 2020-06-10 19:11 ` Mohammed Khajapasha
2020-06-10 19:11 ` [igt-dev] [[RFC] PATCH i-g-t 2/2] lib/igt_kms: Add support for display with non-contiguous pipes Mohammed Khajapasha
2020-06-10 19:22 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Mohammed Khajapasha @ 2020-06-10 19:11 UTC (permalink / raw)
To: kishore.kunche, petri.latvala, mohammed.khajapasha,
arkadiusz.hiler, igt-dev
From: Petri Latvala <petri.latvala@intel.com>
__cancel_work_at_exit writes -1 to param "reset", with the intention
that it's "any available method". Hex values to numeric params should
be prefixed with 0x to be parsed as a number. Use the convention of %u
with -1 as is used elsewhere with the "reset" param.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/drmtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index e4e710d4..c732d1dd 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -478,7 +478,7 @@ static void __cancel_work_at_exit(int fd)
{
igt_terminate_spins(); /* for older kernels */
- igt_params_set(fd, "reset", "%x", -1u /* any method */);
+ igt_params_set(fd, "reset", "%u", -1u /* any method */);
igt_drop_caches_set(fd,
/* cancel everything */
DROP_RESET_ACTIVE | DROP_RESET_SEQNO |
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread* [igt-dev] [[RFC] PATCH i-g-t 2/2] lib/igt_kms: Add support for display with non-contiguous pipes
2020-06-10 19:11 [igt-dev] [[RFC] PATCH i-g-t 0/2] lib/igt_kms: Add support for display with Mohammed Khajapasha
2020-06-10 19:11 ` [igt-dev] [[RFC] PATCH i-g-t 1/2] lib/drmtest: Don't write ffffffff to a numeric param Mohammed Khajapasha
@ 2020-06-10 19:11 ` Mohammed Khajapasha
2020-06-10 19:22 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Mohammed Khajapasha @ 2020-06-10 19:11 UTC (permalink / raw)
To: kishore.kunche, petri.latvala, mohammed.khajapasha,
arkadiusz.hiler, igt-dev
Add support for non-contiguous pipe display by allocating
upper bound pipes array for display. Set the pipe enum name
to igt pipe for enabled pipes in drm.
Signed-off-by: Mohammed Khajapasha <mohammed.khajapasha@intel.com>
---
lib/igt_kms.c | 30 +++++++++++++++++++++++++-----
lib/igt_kms.h | 15 +++++++++------
2 files changed, 34 insertions(+), 11 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index afef5939..2b1cf878 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1921,10 +1921,26 @@ void igt_display_require(igt_display_t *display, int drm_fd)
* We cache the number of pipes, that number is a physical limit of the
* hardware and cannot change of time (for now, at least).
*/
- display->n_pipes = resources->count_crtcs;
- display->pipes = calloc(sizeof(igt_pipe_t), display->n_pipes);
+ display->n_pipes = IGT_MAX_PIPES;
+ display->pipes = calloc(sizeof(igt_pipe_t), IGT_MAX_PIPES);
igt_assert_f(display->pipes, "Failed to allocate memory for %d pipes\n", display->n_pipes);
+ for(i = 0; i < resources->count_crtcs; i++) {
+ igt_pipe_t *pipe;
+ struct drm_i915_get_pipe_from_crtc_id get_pipe;
+
+ /* Get right pipe enum from kernel for a pipe */
+ get_pipe.pipe = 0;
+ get_pipe.crtc_id = resources->crtcs[i];
+ do_ioctl(display->drm_fd,
+ DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID, &get_pipe);
+
+ pipe = &display->pipes[get_pipe.pipe];
+ pipe->pipe = get_pipe.pipe;
+ pipe->enabled = true;
+ pipe->crtc_id = resources->crtcs[i];
+ }
+
drmSetClientCap(drm_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
if (drmSetClientCap(drm_fd, DRM_CLIENT_CAP_ATOMIC, 1) == 0)
display->is_atomic = 1;
@@ -1959,9 +1975,7 @@ void igt_display_require(igt_display_t *display, int drm_fd)
int j, type;
uint8_t last_plane = 0, n_planes = 0;
- pipe->crtc_id = resources->crtcs[i];
pipe->display = display;
- pipe->pipe = i;
pipe->plane_cursor = -1;
pipe->plane_primary = -1;
pipe->planes = NULL;
@@ -2409,12 +2423,18 @@ static bool output_is_internal_panel(igt_output_t *output)
igt_output_t **__igt_pipe_populate_outputs(igt_display_t *display, igt_output_t **chosen_outputs)
{
- unsigned full_pipe_mask = (1 << (display->n_pipes)) - 1, assigned_pipes = 0;
+ unsigned full_pipe_mask, assigned_pipes = 0;
igt_output_t *output;
int i, j;
memset(chosen_outputs, 0, sizeof(*chosen_outputs) * display->n_pipes);
+ for( i = 0; i < display->n_pipes; i++) {
+ igt_pipe_t *pipe = &display->pipes[i];
+ if (pipe->enabled)
+ full_pipe_mask |= (1 << pipe->pipe);
+ }
+
/*
* Try to assign all outputs to the first available CRTC for
* it, start with the outputs restricted to 1 pipe, then increase
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 32a0e4cc..624fc9da 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -341,6 +341,7 @@ typedef struct igt_plane {
struct igt_pipe {
igt_display_t *display;
enum pipe pipe;
+ bool enabled;
int n_planes;
int plane_cursor;
@@ -497,7 +498,8 @@ static inline bool igt_output_is_connected(igt_output_t *output)
* depencies.
*/
#define for_each_pipe_static(pipe) \
- for (pipe = 0; pipe < IGT_MAX_PIPES; pipe++)
+ for (pipe = 0; pipe < IGT_MAX_PIPES; pipe++) \
+ for_each_if((display)->pipes[(pipe)].enabled)
/**
* for_each_pipe:
@@ -510,8 +512,8 @@ static inline bool igt_output_is_connected(igt_output_t *output)
* depends upon runtime probing of the actual kms driver that is being tested.
* Use #for_each_pipe_static instead.
*/
-#define for_each_pipe(display, pipe) \
- for (pipe = 0; assert(igt_can_fail()), pipe < igt_display_get_n_pipes(display); pipe++)
+#define for_each_pipe(display, pipe) \
+ for_each_pipe_static(pipe)
/**
* for_each_pipe_with_valid_output:
@@ -530,8 +532,9 @@ static inline bool igt_output_is_connected(igt_output_t *output)
for (int con__ = (pipe) = 0; \
assert(igt_can_fail()), (pipe) < igt_display_get_n_pipes((display)) && con__ < (display)->n_outputs; \
con__ = (con__ + 1 < (display)->n_outputs) ? con__ + 1 : (pipe = pipe + 1, 0)) \
- for_each_if ((((output) = &(display)->outputs[con__]), \
- igt_pipe_connector_valid((pipe), (output))))
+ for_each_if((display)->pipes[pipe].enabled) \
+ for_each_if ((((output) = &(display)->outputs[con__]), \
+ igt_pipe_connector_valid((pipe), (output))))
igt_output_t **__igt_pipe_populate_outputs(igt_display_t *display,
igt_output_t **chosen_outputs);
@@ -549,7 +552,7 @@ igt_output_t **__igt_pipe_populate_outputs(igt_display_t *display,
#define for_each_pipe_with_single_output(display, pipe, output) \
for (igt_output_t *__outputs[(display)->n_pipes], \
**__output = __igt_pipe_populate_outputs((display), __outputs); \
- __output < &__outputs[(display)->n_pipes]; __output++) \
+ __output < &__outputs[(display)->n_pipes]; __output++) \
for_each_if (*__output && \
((pipe) = (__output - __outputs), (output) = *__output, 1))
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread