* [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches
@ 2020-07-29 22:29 Bhanuprakash Modem
2020-07-29 15:03 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
` (7 more replies)
0 siblings, 8 replies; 20+ messages in thread
From: Bhanuprakash Modem @ 2020-07-29 22:29 UTC (permalink / raw)
To: bhanuprakash.modem, igt-dev; +Cc: Petri Latvala
We’ve seen multiple CRC related issues on older platforms and
pre-silicon environment, most of the time we end up with debugging.
This patch works as a crc-sanity test, which can verify that the
CRC mechanism is clean from the platform side before debugging the
actual CRC mismatches or other CRC related issues.
Cc: Swati Sharma <swati2.sharma@intel.com>
Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Jeevan B <jeevan.b@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_pipe_crc_basic.c | 77 ++++++++++++++++++++++++++++++++++++++
1 file changed, 77 insertions(+)
diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index cb93c1ad..a59c6bf1 100644
--- a/tests/kms_pipe_crc_basic.c
+++ b/tests/kms_pipe_crc_basic.c
@@ -154,6 +154,80 @@ static void test_read_crc(data_t *data, enum pipe pipe, unsigned flags)
}
}
+/*
+ * CRC-sanity test, to make sure there would be no CRC mismatches
+ *
+ * - Create two framebuffers (FB0 & FB1) with same color info
+ * - Flip FB0 with the Primary plane & collect the CRC as ref CRC.
+ * - Flip FB1, collect CRC & compare with the ref CRC.
+ *
+ * No CRC mismatch should happen
+ */
+static void test_check_crc(data_t *data)
+{
+ igt_display_t *display = &data->display;
+ igt_output_t *output;
+ enum pipe pipe;
+ drmModeModeInfo *mode;
+ struct igt_fb fb0, fb1;
+ igt_crc_t ref_crc, crc;
+ igt_pipe_crc_t *pipe_crc;
+ igt_plane_t *primary;
+
+ for_each_pipe_with_valid_output(display, pipe, output) {
+ igt_output_set_pipe(output, pipe);
+ mode = igt_output_get_mode(output);
+
+ /* Create two framebuffers with the same color info. */
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ LOCAL_DRM_FORMAT_MOD_NONE,
+ 1.0, 1.0, 1.0,
+ &fb0);
+ igt_create_color_fb(data->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ LOCAL_DRM_FORMAT_MOD_NONE,
+ 1.0, 1.0, 1.0,
+ &fb1);
+
+ /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_plane_set_fb(primary, &fb0);
+ igt_display_commit(display);
+
+ if (pipe_crc)
+ igt_pipe_crc_free(pipe_crc);
+
+ pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe,
+ INTEL_PIPE_CRC_SOURCE_AUTO);
+ igt_pipe_crc_collect_crc(pipe_crc, &ref_crc);
+
+ /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. */
+ igt_plane_set_fb(primary, &fb1);
+ igt_display_commit(display);
+
+ igt_pipe_crc_collect_crc(pipe_crc, &crc);
+ igt_assert_crc_equal(&crc, &ref_crc);
+
+ /* Clean-up */
+ igt_pipe_crc_free(pipe_crc);
+ pipe_crc = NULL;
+ igt_plane_set_fb(primary, NULL);
+ igt_output_set_pipe(output, PIPE_NONE);
+ igt_display_commit(display);
+
+ igt_remove_fb(data->drm_fd, &fb0);
+ igt_remove_fb(data->drm_fd, &fb1);
+
+ /* once is enough */
+ return;
+ }
+
+ igt_skip("no valid crtc/connector combinations found\n");
+}
+
data_t data = {0, };
igt_main
@@ -211,6 +285,9 @@ igt_main
}
}
+ igt_subtest("compare-crc-basic")
+ test_check_crc(&data);
+
igt_fixture {
igt_display_fini(&data.display);
}
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 20+ messages in thread* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-07-29 22:29 [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem @ 2020-07-29 15:03 ` Patchwork 2020-07-30 11:27 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev2) Patchwork ` (6 subsequent siblings) 7 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2020-07-29 15:03 UTC (permalink / raw) To: Bhanuprakash Modem; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 6782 bytes --] == Series Details == Series: tests/kms_pipe_crc_basic: Sanity check for CRC mismatches URL : https://patchwork.freedesktop.org/series/80040/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8814 -> IGTPW_4819 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_4819 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_4819, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_4819: ### IGT changes ### #### Possible regressions #### * igt@i915_selftest@live@gt_engines: - fi-tgl-y: NOTRUN -> [INCOMPLETE][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/fi-tgl-y/igt@i915_selftest@live@gt_engines.html Known issues ------------ Here are the changes found in IGTPW_4819 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_module_load@reload: - fi-byt-j1900: [PASS][2] -> [DMESG-WARN][3] ([i915#1982]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8814/fi-byt-j1900/igt@i915_module_load@reload.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/fi-byt-j1900/igt@i915_module_load@reload.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-bsw-kefka: [PASS][4] -> [DMESG-WARN][5] ([i915#1982]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8814/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2: - fi-skl-guc: [PASS][6] -> [DMESG-WARN][7] ([i915#2203]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8814/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html #### Possible fixes #### * igt@debugfs_test@read_all_entries: - {fi-kbl-7560u}: [INCOMPLETE][8] ([i915#2175]) -> [PASS][9] [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8814/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-bsw-kefka: [DMESG-WARN][10] ([i915#1982]) -> [PASS][11] [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8814/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-byt-j1900: [DMESG-WARN][12] ([i915#1982]) -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8814/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_cursor_legacy@basic-flip-after-cursor-atomic: - fi-icl-u2: [DMESG-WARN][14] ([i915#1982]) -> [PASS][15] +1 similar issue [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8814/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html #### Warnings #### * igt@debugfs_test@read_all_entries: - fi-kbl-x1275: [DMESG-WARN][16] ([i915#62] / [i915#92]) -> [DMESG-WARN][17] ([i915#62] / [i915#92] / [i915#95]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8814/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html * igt@gem_exec_suspend@basic-s0: - fi-kbl-x1275: [DMESG-WARN][18] ([i915#1982] / [i915#62] / [i915#92]) -> [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8814/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html * igt@i915_pm_rpm@module-reload: - fi-kbl-x1275: [SKIP][20] ([fdo#109271]) -> [DMESG-FAIL][21] ([i915#62]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8814/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html * igt@kms_force_connector_basic@force-edid: - fi-kbl-x1275: [DMESG-WARN][22] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][23] ([i915#62] / [i915#92]) +6 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8814/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2175]: https://gitlab.freedesktop.org/drm/intel/issues/2175 [i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (39 -> 37) ------------------------------ Additional (2): fi-tgl-y fi-tgl-u2 Missing (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5750 -> IGTPW_4819 CI-20190529: 20190529 CI_DRM_8814: c3d46022808ab0325db29918a829ac7fa02a4314 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4819: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/index.html IGT_5750: 95d906bf458634850626f7e5d6a707191022279f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Testlist changes == +igt@kms_pipe_crc_basic@compare-crc-basic == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4819/index.html [-- Attachment #1.2: Type: text/html, Size: 8876 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev2) 2020-07-29 22:29 [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem 2020-07-29 15:03 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork @ 2020-07-30 11:27 ` Patchwork 2020-07-30 13:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork ` (5 subsequent siblings) 7 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2020-07-30 11:27 UTC (permalink / raw) To: Bhanuprakash Modem; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 5041 bytes --] == Series Details == Series: tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev2) URL : https://patchwork.freedesktop.org/series/80040/ State : success == Summary == CI Bug Log - changes from IGT_5752 -> IGTPW_4828 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/index.html Known issues ------------ Here are the changes found in IGTPW_4828 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_busy@basic@flip: - fi-kbl-x1275: [PASS][1] -> [DMESG-WARN][2] ([i915#62] / [i915#92] / [i915#95]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/fi-kbl-x1275/igt@kms_busy@basic@flip.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/fi-kbl-x1275/igt@kms_busy@basic@flip.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s3: - fi-tgl-u2: [FAIL][3] ([i915#1888]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html * igt@i915_module_load@reload: - fi-apl-guc: [DMESG-WARN][5] ([i915#1635] / [i915#1982]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/fi-apl-guc/igt@i915_module_load@reload.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/fi-apl-guc/igt@i915_module_load@reload.html - fi-bsw-n3050: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/fi-bsw-n3050/igt@i915_module_load@reload.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/fi-bsw-n3050/igt@i915_module_load@reload.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-byt-j1900: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/fi-byt-j1900/igt@i915_pm_rpm@basic-pci-d3-state.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/fi-byt-j1900/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_pm_rpm@module-reload: - {fi-kbl-7560u}: [WARN][11] -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/fi-kbl-7560u/igt@i915_pm_rpm@module-reload.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/fi-kbl-7560u/igt@i915_pm_rpm@module-reload.html * igt@kms_setmode@basic-clone-single-crtc: - {fi-kbl-7560u}: [WARN][13] ([i915#2100]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/fi-kbl-7560u/igt@kms_setmode@basic-clone-single-crtc.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/fi-kbl-7560u/igt@kms_setmode@basic-clone-single-crtc.html #### Warnings #### * igt@gem_exec_suspend@basic-s0: - fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][16] ([i915#62] / [i915#92]) +5 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html * igt@kms_cursor_legacy@basic-flip-before-cursor-legacy: - fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92]) -> [DMESG-WARN][18] ([i915#62] / [i915#92] / [i915#95]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2100]: https://gitlab.freedesktop.org/drm/intel/issues/2100 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (43 -> 36) ------------------------------ Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5752 -> IGTPW_4828 CI-20190529: 20190529 CI_DRM_8815: 521846d50ed323d4dcb0ffafa63e34528b0a4996 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4828: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/index.html IGT_5752: 3ecf9d88803a686354394ea60164551646235273 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Testlist changes == +igt@kms_pipe_crc_basic@compare-crc-basic == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/index.html [-- Attachment #1.2: Type: text/html, Size: 6637 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev2) 2020-07-29 22:29 [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem 2020-07-29 15:03 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork 2020-07-30 11:27 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev2) Patchwork @ 2020-07-30 13:26 ` Patchwork 2020-08-05 11:43 ` [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Karthik B S ` (4 subsequent siblings) 7 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2020-07-30 13:26 UTC (permalink / raw) To: Bhanuprakash Modem; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 24773 bytes --] == Series Details == Series: tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev2) URL : https://patchwork.freedesktop.org/series/80040/ State : failure == Summary == CI Bug Log - changes from IGT_5752_full -> IGTPW_4828_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_4828_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_4828_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_4828_full: ### IGT changes ### #### Possible regressions #### * igt@kms_prime@basic-crc@second-to-first: - shard-iclb: [PASS][1] -> [SKIP][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-iclb7/igt@kms_prime@basic-crc@second-to-first.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-iclb4/igt@kms_prime@basic-crc@second-to-first.html - shard-tglb: [PASS][3] -> [SKIP][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-tglb1/igt@kms_prime@basic-crc@second-to-first.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-tglb2/igt@kms_prime@basic-crc@second-to-first.html * igt@runner@aborted: - shard-tglb: NOTRUN -> [FAIL][5] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-tglb2/igt@runner@aborted.html New tests --------- New tests have been introduced between IGT_5752_full and IGTPW_4828_full: ### New IGT tests (1) ### * igt@kms_pipe_crc_basic@compare-crc-basic: - Statuses : 7 pass(s) - Exec time: [0.27, 0.70] s Known issues ------------ Here are the changes found in IGTPW_4828_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@device_reset@unbind-reset-rebind: - shard-tglb: [PASS][6] -> [INCOMPLETE][7] ([i915#1602]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-tglb1/igt@device_reset@unbind-reset-rebind.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-tglb2/igt@device_reset@unbind-reset-rebind.html * igt@gem_exec_reloc@basic-concurrent0: - shard-glk: [PASS][8] -> [FAIL][9] ([i915#1930]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-glk6/igt@gem_exec_reloc@basic-concurrent0.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-glk2/igt@gem_exec_reloc@basic-concurrent0.html * igt@gem_exec_whisper@basic-forked: - shard-glk: [PASS][10] -> [DMESG-WARN][11] ([i915#118] / [i915#95]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-glk7/igt@gem_exec_whisper@basic-forked.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-glk3/igt@gem_exec_whisper@basic-forked.html * igt@i915_pm_dc@dc6-dpms: - shard-iclb: [PASS][12] -> [FAIL][13] ([i915#454]) +1 similar issue [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-iclb2/igt@i915_pm_dc@dc6-dpms.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html * igt@kms_big_fb@linear-64bpp-rotate-180: - shard-glk: [PASS][14] -> [DMESG-FAIL][15] ([i915#118] / [i915#95]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-glk3/igt@kms_big_fb@linear-64bpp-rotate-180.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-180.html * igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen: - shard-glk: [PASS][16] -> [FAIL][17] ([i915#54]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-glk6/igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-glk4/igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen.html - shard-apl: [PASS][18] -> [FAIL][19] ([i915#1635] / [i915#54]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen.html - shard-kbl: [PASS][20] -> [FAIL][21] ([i915#54]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen.html * igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding: - shard-hsw: [PASS][22] -> [TIMEOUT][23] ([i915#1958] / [i915#2119]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-hsw2/igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-hsw1/igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding.html - shard-snb: [PASS][24] -> [TIMEOUT][25] ([i915#1958] / [i915#2119]) +1 similar issue [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-snb1/igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-snb2/igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding.html * igt@kms_cursor_edge_walk@pipe-c-64x64-bottom-edge: - shard-glk: [PASS][26] -> [DMESG-WARN][27] ([i915#1982]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-glk9/igt@kms_cursor_edge_walk@pipe-c-64x64-bottom-edge.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-glk5/igt@kms_cursor_edge_walk@pipe-c-64x64-bottom-edge.html * igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible@ab-hdmi-a1-hdmi-a2: - shard-glk: [PASS][28] -> [FAIL][29] ([i915#2122]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-glk9/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible@ab-hdmi-a1-hdmi-a2.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-glk6/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible@ab-hdmi-a1-hdmi-a2.html * igt@kms_flip@flip-vs-expired-vblank@a-dp1: - shard-apl: [PASS][30] -> [FAIL][31] ([i915#1635] / [i915#2122]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-apl7/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-apl7/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html * igt@kms_hdr@bpc-switch-suspend: - shard-kbl: [PASS][32] -> [DMESG-WARN][33] ([i915#180]) +5 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-kbl4/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_prime@basic-crc@second-to-first: - shard-apl: [PASS][34] -> [SKIP][35] ([fdo#109271] / [i915#1635]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-apl8/igt@kms_prime@basic-crc@second-to-first.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-apl8/igt@kms_prime@basic-crc@second-to-first.html - shard-kbl: [PASS][36] -> [SKIP][37] ([fdo#109271]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-kbl1/igt@kms_prime@basic-crc@second-to-first.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-kbl6/igt@kms_prime@basic-crc@second-to-first.html - shard-hsw: [PASS][38] -> [SKIP][39] ([fdo#109271]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-hsw4/igt@kms_prime@basic-crc@second-to-first.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-hsw4/igt@kms_prime@basic-crc@second-to-first.html - shard-snb: [PASS][40] -> [SKIP][41] ([fdo#109271]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-snb6/igt@kms_prime@basic-crc@second-to-first.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-snb6/igt@kms_prime@basic-crc@second-to-first.html - shard-glk: [PASS][42] -> [SKIP][43] ([fdo#109271]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-glk6/igt@kms_prime@basic-crc@second-to-first.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-glk2/igt@kms_prime@basic-crc@second-to-first.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][44] -> [FAIL][45] ([i915#173]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-iclb2/igt@kms_psr@no_drrs.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_cursor_plane_onoff: - shard-iclb: [PASS][46] -> [SKIP][47] ([fdo#109441]) +2 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-iclb7/igt@kms_psr@psr2_cursor_plane_onoff.html * igt@kms_vblank@pipe-c-wait-forked-busy: - shard-tglb: [PASS][48] -> [DMESG-WARN][49] ([i915#1982]) +1 similar issue [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-tglb6/igt@kms_vblank@pipe-c-wait-forked-busy.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-tglb1/igt@kms_vblank@pipe-c-wait-forked-busy.html - shard-kbl: [PASS][50] -> [DMESG-WARN][51] ([i915#1982]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-kbl2/igt@kms_vblank@pipe-c-wait-forked-busy.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-kbl4/igt@kms_vblank@pipe-c-wait-forked-busy.html #### Possible fixes #### * igt@core_setmaster@master-drop-set-user: - shard-iclb: [FAIL][52] -> [PASS][53] [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-iclb5/igt@core_setmaster@master-drop-set-user.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-iclb3/igt@core_setmaster@master-drop-set-user.html - shard-kbl: [FAIL][54] -> [PASS][55] [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-kbl2/igt@core_setmaster@master-drop-set-user.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-kbl6/igt@core_setmaster@master-drop-set-user.html - shard-snb: [FAIL][56] -> [PASS][57] [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-snb6/igt@core_setmaster@master-drop-set-user.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-snb4/igt@core_setmaster@master-drop-set-user.html - shard-tglb: [FAIL][58] -> [PASS][59] [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-tglb5/igt@core_setmaster@master-drop-set-user.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-tglb7/igt@core_setmaster@master-drop-set-user.html - shard-apl: [FAIL][60] ([i915#1635]) -> [PASS][61] [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-apl4/igt@core_setmaster@master-drop-set-user.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-apl4/igt@core_setmaster@master-drop-set-user.html - shard-glk: [FAIL][62] -> [PASS][63] [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-glk5/igt@core_setmaster@master-drop-set-user.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-glk7/igt@core_setmaster@master-drop-set-user.html - shard-hsw: [FAIL][64] -> [PASS][65] [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-hsw6/igt@core_setmaster@master-drop-set-user.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-hsw6/igt@core_setmaster@master-drop-set-user.html * igt@gem_exec_whisper@basic-queues-priority-all: - shard-glk: [DMESG-WARN][66] ([i915#118] / [i915#95]) -> [PASS][67] [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-glk4/igt@gem_exec_whisper@basic-queues-priority-all.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-glk6/igt@gem_exec_whisper@basic-queues-priority-all.html * igt@kms_addfb_basic@bo-too-small: - shard-hsw: [TIMEOUT][68] ([i915#1958] / [i915#2119]) -> [PASS][69] +2 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-hsw1/igt@kms_addfb_basic@bo-too-small.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-hsw4/igt@kms_addfb_basic@bo-too-small.html * igt@kms_cursor_edge_walk@pipe-b-128x128-left-edge: - shard-glk: [DMESG-WARN][70] ([i915#1982]) -> [PASS][71] [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-glk6/igt@kms_cursor_edge_walk@pipe-b-128x128-left-edge.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-glk4/igt@kms_cursor_edge_walk@pipe-b-128x128-left-edge.html * igt@kms_cursor_edge_walk@pipe-b-256x256-top-edge: - shard-snb: [TIMEOUT][72] ([i915#1958] / [i915#2119]) -> [PASS][73] +3 similar issues [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-snb5/igt@kms_cursor_edge_walk@pipe-b-256x256-top-edge.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-snb6/igt@kms_cursor_edge_walk@pipe-b-256x256-top-edge.html * igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible@ab-vga1-hdmi-a1: - shard-hsw: [DMESG-WARN][74] ([i915#1982]) -> [PASS][75] [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-hsw6/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible@ab-vga1-hdmi-a1.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-hsw6/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible@ab-vga1-hdmi-a1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [DMESG-WARN][76] ([i915#180]) -> [PASS][77] +8 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1: - shard-hsw: [INCOMPLETE][78] ([i915#2055]) -> [PASS][79] [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-hsw4/igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1.html * igt@kms_frontbuffer_tracking@fbc-modesetfrombusy: - shard-kbl: [DMESG-WARN][80] ([i915#1982]) -> [PASS][81] [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-modesetfrombusy.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-modesetfrombusy.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render: - shard-tglb: [DMESG-WARN][82] ([i915#1982]) -> [PASS][83] +3 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-tglb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-tglb2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html - shard-iclb: [DMESG-WARN][84] ([i915#1982]) -> [PASS][85] [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-iclb8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-iclb8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-kbl: [INCOMPLETE][86] ([i915#155]) -> [PASS][87] [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_prime@basic-crc@first-to-second: - shard-iclb: [SKIP][88] ([i915#1836]) -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-iclb7/igt@kms_prime@basic-crc@first-to-second.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-iclb4/igt@kms_prime@basic-crc@first-to-second.html - shard-snb: [SKIP][90] ([fdo#109271]) -> [PASS][91] [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-snb6/igt@kms_prime@basic-crc@first-to-second.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-snb6/igt@kms_prime@basic-crc@first-to-second.html - shard-hsw: [SKIP][92] ([fdo#109271]) -> [PASS][93] [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-hsw4/igt@kms_prime@basic-crc@first-to-second.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-hsw4/igt@kms_prime@basic-crc@first-to-second.html - shard-kbl: [SKIP][94] ([fdo#109271]) -> [PASS][95] [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-kbl1/igt@kms_prime@basic-crc@first-to-second.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-kbl6/igt@kms_prime@basic-crc@first-to-second.html - shard-apl: [SKIP][96] ([fdo#109271] / [i915#1635]) -> [PASS][97] [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-apl8/igt@kms_prime@basic-crc@first-to-second.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-apl8/igt@kms_prime@basic-crc@first-to-second.html - shard-tglb: [SKIP][98] ([i915#1836]) -> [PASS][99] [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-tglb1/igt@kms_prime@basic-crc@first-to-second.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-tglb2/igt@kms_prime@basic-crc@first-to-second.html - shard-glk: [SKIP][100] ([fdo#109271]) -> [PASS][101] [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-glk6/igt@kms_prime@basic-crc@first-to-second.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-glk2/igt@kms_prime@basic-crc@first-to-second.html * igt@kms_psr@psr2_cursor_mmap_cpu: - shard-iclb: [SKIP][102] ([fdo#109441]) -> [PASS][103] +4 similar issues [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html * igt@kms_setmode@basic: - shard-kbl: [FAIL][104] ([i915#31]) -> [PASS][105] [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-kbl7/igt@kms_setmode@basic.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-kbl6/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-c-query-forked-busy: - shard-apl: [DMESG-WARN][106] ([i915#1635] / [i915#1982]) -> [PASS][107] +1 similar issue [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-apl3/igt@kms_vblank@pipe-c-query-forked-busy.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-apl3/igt@kms_vblank@pipe-c-query-forked-busy.html * igt@perf@blocking-parameterized: - shard-iclb: [FAIL][108] ([i915#1542]) -> [PASS][109] [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-iclb2/igt@perf@blocking-parameterized.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-iclb5/igt@perf@blocking-parameterized.html #### Warnings #### * igt@i915_suspend@debugfs-reader: - shard-kbl: [INCOMPLETE][110] ([i915#155]) -> [DMESG-WARN][111] ([i915#180]) [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-kbl6/igt@i915_suspend@debugfs-reader.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-kbl7/igt@i915_suspend@debugfs-reader.html * igt@kms_content_protection@atomic: - shard-kbl: [TIMEOUT][112] ([i915#1319] / [i915#2119]) -> [TIMEOUT][113] ([i915#1319] / [i915#1958] / [i915#2119]) [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-kbl1/igt@kms_content_protection@atomic.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-kbl2/igt@kms_content_protection@atomic.html * igt@kms_cursor_crc@pipe-c-cursor-512x512-random: - shard-snb: [TIMEOUT][114] ([i915#1958] / [i915#2119]) -> [SKIP][115] ([fdo#109271]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-snb5/igt@kms_cursor_crc@pipe-c-cursor-512x512-random.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-snb4/igt@kms_cursor_crc@pipe-c-cursor-512x512-random.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [SKIP][116] ([fdo#109349]) -> [DMESG-WARN][117] ([i915#1226]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt: - shard-hsw: [TIMEOUT][118] ([i915#1958] / [i915#2119]) -> [SKIP][119] ([fdo#109271]) +1 similar issue [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-hsw2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-tiling-y: - shard-snb: [SKIP][120] ([fdo#109271]) -> [TIMEOUT][121] ([i915#1958] / [i915#2119]) +2 similar issues [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-snb4/igt@kms_frontbuffer_tracking@fbcpsr-tiling-y.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-snb2/igt@kms_frontbuffer_tracking@fbcpsr-tiling-y.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-cpu: - shard-hsw: [SKIP][122] ([fdo#109271]) -> [TIMEOUT][123] ([i915#1958] / [i915#2119]) +2 similar issues [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5752/shard-hsw4/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-cpu.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/shard-hsw1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-cpu.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155 [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836 [i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930 [i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055 [i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (8 -> 8) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5752 -> IGTPW_4828 CI-20190529: 20190529 CI_DRM_8815: 521846d50ed323d4dcb0ffafa63e34528b0a4996 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4828: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/index.html IGT_5752: 3ecf9d88803a686354394ea60164551646235273 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4828/index.html [-- Attachment #1.2: Type: text/html, Size: 30398 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-07-29 22:29 [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem ` (2 preceding siblings ...) 2020-07-30 13:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork @ 2020-08-05 11:43 ` Karthik B S 2020-08-05 12:32 ` Sharma, Swati2 2020-08-06 5:16 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev3) Patchwork ` (3 subsequent siblings) 7 siblings, 1 reply; 20+ messages in thread From: Karthik B S @ 2020-08-05 11:43 UTC (permalink / raw) To: Bhanuprakash Modem, igt-dev; +Cc: Petri Latvala On 7/30/2020 3:59 AM, Bhanuprakash Modem wrote: > We’ve seen multiple CRC related issues on older platforms and > pre-silicon environment, most of the time we end up with debugging. > > This patch works as a crc-sanity test, which can verify that the > CRC mechanism is clean from the platform side before debugging the > actual CRC mismatches or other CRC related issues. > Please add the test details as well in the commit message. > Cc: Swati Sharma <swati2.sharma@intel.com> > Cc: Karthik B S <karthik.b.s@intel.com> > Cc: Jeevan B <jeevan.b@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> > --- > tests/kms_pipe_crc_basic.c | 77 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > > diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c > index cb93c1ad..a59c6bf1 100644 > --- a/tests/kms_pipe_crc_basic.c > +++ b/tests/kms_pipe_crc_basic.c > @@ -154,6 +154,80 @@ static void test_read_crc(data_t *data, enum pipe pipe, unsigned flags) > } > } > > +/* > + * CRC-sanity test, to make sure there would be no CRC mismatches > + * > + * - Create two framebuffers (FB0 & FB1) with same color info > + * - Flip FB0 with the Primary plane & collect the CRC as ref CRC. > + * - Flip FB1, collect CRC & compare with the ref CRC Nitpick, but its better if both sentences are consistent. In the first, primary plane is mentioned, but in the second nothing is mentioned. Little ambiguous for me. > + * > + * No CRC mismatch should happen > + */ > +static void test_check_crc(data_t *data) > +{ > + igt_display_t *display = &data->display; > + igt_output_t *output; > + enum pipe pipe; > + drmModeModeInfo *mode; > + struct igt_fb fb0, fb1; > + igt_crc_t ref_crc, crc; > + igt_pipe_crc_t *pipe_crc; > + igt_plane_t *primary; > + > + for_each_pipe_with_valid_output(display, pipe, output) { Can we use 'igt_get_single_output_for_pipe' for the intended pipe instead of using loop when we're only using it for one iteration always. > + igt_output_set_pipe(output, pipe); > + mode = igt_output_get_mode(output); > + > + /* Create two framebuffers with the same color info. */ > + igt_create_color_fb(data->drm_fd, > + mode->hdisplay, mode->vdisplay, > + DRM_FORMAT_XRGB8888, > + LOCAL_DRM_FORMAT_MOD_NONE, > + 1.0, 1.0, 1.0, > + &fb0); > + igt_create_color_fb(data->drm_fd, > + mode->hdisplay, mode->vdisplay, > + DRM_FORMAT_XRGB8888, > + LOCAL_DRM_FORMAT_MOD_NONE, > + 1.0, 1.0, 1.0, > + &fb1); > + > + /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */ > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > + igt_plane_set_fb(primary, &fb0); > + igt_display_commit(display); > + > + if (pipe_crc) > + igt_pipe_crc_free(pipe_crc); Is this check required? > + > + pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, > + INTEL_PIPE_CRC_SOURCE_AUTO); > + igt_pipe_crc_collect_crc(pipe_crc, &ref_crc); > + > + /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. */ > + igt_plane_set_fb(primary, &fb1); > + igt_display_commit(display); > + > + igt_pipe_crc_collect_crc(pipe_crc, &crc); > + igt_assert_crc_equal(&crc, &ref_crc); > + > + /* Clean-up */ > + igt_pipe_crc_free(pipe_crc); > + pipe_crc = NULL; > + igt_plane_set_fb(primary, NULL); > + igt_output_set_pipe(output, PIPE_NONE); > + igt_display_commit(display); > + > + igt_remove_fb(data->drm_fd, &fb0); > + igt_remove_fb(data->drm_fd, &fb1); > + > + /* once is enough */ > + return; > + } > + > + igt_skip("no valid crtc/connector combinations found\n"); Based on the comments above, we can remove the return and igt_skip(); > +} > +' > data_t data = {0, }; > > igt_main > @@ -211,6 +285,9 @@ igt_main > } > } > > + igt_subtest("compare-crc-basic") > + test_check_crc(&data); Should we have this at a per pipe level like the other subtests? May be dynamic-subtests, but not sure because other tests in this IGT are not dynamic. Thanks, Karthik.B.S > + > igt_fixture { > igt_display_fini(&data.display); > } > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-08-05 11:43 ` [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Karthik B S @ 2020-08-05 12:32 ` Sharma, Swati2 0 siblings, 0 replies; 20+ messages in thread From: Sharma, Swati2 @ 2020-08-05 12:32 UTC (permalink / raw) To: Karthik B S, Bhanuprakash Modem, igt-dev; +Cc: Petri Latvala Hi, PFI my review comments. Agree with Karthik's comments except IMO dynamic subtest is not required if we are testing one o/p per pipe its more than sufficient to test CRC. CI is not green for this patch. Please make sure there are no regressions. If these are false positive; report to Lakshmi. On 05-Aug-20 5:13 PM, Karthik B S wrote: > > > On 7/30/2020 3:59 AM, Bhanuprakash Modem wrote: >> We’ve seen multiple CRC related issues on older platforms and >> pre-silicon environment, most of the time we end up with debugging. >> >> This patch works as a crc-sanity test, which can verify that the >> CRC mechanism is clean from the platform side before debugging the >> actual CRC mismatches or other CRC related issues. >> > > Please add the test details as well in the commit message. >> Cc: Swati Sharma <swati2.sharma@intel.com> >> Cc: Karthik B S <karthik.b.s@intel.com> >> Cc: Jeevan B <jeevan.b@intel.com> >> Cc: Petri Latvala <petri.latvala@intel.com> >> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com> >> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> >> --- >> tests/kms_pipe_crc_basic.c | 77 ++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 77 insertions(+) >> >> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c >> index cb93c1ad..a59c6bf1 100644 >> --- a/tests/kms_pipe_crc_basic.c >> +++ b/tests/kms_pipe_crc_basic.c >> @@ -154,6 +154,80 @@ static void test_read_crc(data_t *data, enum pipe >> pipe, unsigned flags) >> } >> } >> +/* >> + * CRC-sanity test, to make sure there would be no CRC mismatches >> + * >> + * - Create two framebuffers (FB0 & FB1) with same color info >> + * - Flip FB0 with the Primary plane & collect the CRC as ref CRC. >> + * - Flip FB1, collect CRC & compare with the ref CRC > Nitpick, but its better if both sentences are consistent. > In the first, primary plane is mentioned, but in the second > nothing is mentioned. Little ambiguous for me. >> + * >> + * No CRC mismatch should happen >> + */ >> +static void test_check_crc(data_t *data) >> +{ >> + igt_display_t *display = &data->display; >> + igt_output_t *output; >> + enum pipe pipe; >> + drmModeModeInfo *mode; >> + struct igt_fb fb0, fb1; >> + igt_crc_t ref_crc, crc; >> + igt_pipe_crc_t *pipe_crc; >> + igt_plane_t *primary; >> + >> + for_each_pipe_with_valid_output(display, pipe, output) { > > Can we use 'igt_get_single_output_for_pipe' for the intended pipe > instead of using loop when we're only using it for one iteration always. >> + igt_output_set_pipe(output, pipe); >> + mode = igt_output_get_mode(output); >> + >> + /* Create two framebuffers with the same color info. */ >> + igt_create_color_fb(data->drm_fd, >> + mode->hdisplay, mode->vdisplay, >> + DRM_FORMAT_XRGB8888, >> + LOCAL_DRM_FORMAT_MOD_NONE, >> + 1.0, 1.0, 1.0, >> + &fb0); >> + igt_create_color_fb(data->drm_fd, >> + mode->hdisplay, mode->vdisplay, >> + DRM_FORMAT_XRGB8888, >> + LOCAL_DRM_FORMAT_MOD_NONE, >> + 1.0, 1.0, 1.0, >> + &fb1); Alignment is off. >> + >> + /* Flip FB0 with the Primary plane & collect the CRC as ref >> CRC. */ >> + primary = igt_output_get_plane_type(output, >> DRM_PLANE_TYPE_PRIMARY); >> + igt_plane_set_fb(primary, &fb0); >> + igt_display_commit(display); >> + >> + if (pipe_crc) >> + igt_pipe_crc_free(pipe_crc); > > Is this check required? >> + >> + pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, >> + INTEL_PIPE_CRC_SOURCE_AUTO); >> + igt_pipe_crc_collect_crc(pipe_crc, &ref_crc); >> + >> + /* Flip FB1 with the Primary plane & compare the CRC with ref >> CRC. */ >> + igt_plane_set_fb(primary, &fb1); >> + igt_display_commit(display); >> + >> + igt_pipe_crc_collect_crc(pipe_crc, &crc); >> + igt_assert_crc_equal(&crc, &ref_crc); >> + >> + /* Clean-up */ >> + igt_pipe_crc_free(pipe_crc); >> + pipe_crc = NULL; >> + igt_plane_set_fb(primary, NULL); >> + igt_output_set_pipe(output, PIPE_NONE); >> + igt_display_commit(display); >> + >> + igt_remove_fb(data->drm_fd, &fb0); >> + igt_remove_fb(data->drm_fd, &fb1); >> + >> + /* once is enough */ >> + return; >> + } >> + >> + igt_skip("no valid crtc/connector combinations found\n"); > > Based on the comments above, we can remove the return and igt_skip(); >> +} >> +' >> data_t data = {0, }; >> igt_main >> @@ -211,6 +285,9 @@ igt_main >> } >> } >> + igt_subtest("compare-crc-basic") >> + test_check_crc(&data); Can this be renamed to something more meaningful maybe test_compare_crc or test_crc_sanity? Also igt_describe() is missing. > > Should we have this at a per pipe level like the other subtests? > May be dynamic-subtests, but not sure because other tests in this IGT > are not dynamic. > > Thanks, > Karthik.B.S >> + >> igt_fixture { >> igt_display_fini(&data.display); >> } >> -- ~Swati Sharma _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev3) 2020-07-29 22:29 [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem ` (3 preceding siblings ...) 2020-08-05 11:43 ` [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Karthik B S @ 2020-08-06 5:16 ` Patchwork 2020-08-06 6:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork ` (2 subsequent siblings) 7 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2020-08-06 5:16 UTC (permalink / raw) To: Bhanuprakash Modem; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 5250 bytes --] == Series Details == Series: tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev3) URL : https://patchwork.freedesktop.org/series/80040/ State : success == Summary == CI Bug Log - changes from CI_DRM_8847 -> IGTPW_4855 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/index.html Known issues ------------ Here are the changes found in IGTPW_4855 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_pm_rpm@module-reload: - fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html * igt@kms_flip@basic-flip-vs-wf_vblank@b-lvds1: - fi-snb-2520m: [PASS][3] -> [FAIL][4] ([i915#2122]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/fi-snb-2520m/igt@kms_flip@basic-flip-vs-wf_vblank@b-lvds1.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/fi-snb-2520m/igt@kms_flip@basic-flip-vs-wf_vblank@b-lvds1.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0: - fi-tgl-u2: [FAIL][5] ([i915#1888]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-bsw-kefka: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@kms_busy@basic@flip: - fi-kbl-x1275: [DMESG-WARN][9] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/fi-kbl-x1275/igt@kms_busy@basic@flip.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/fi-kbl-x1275/igt@kms_busy@basic@flip.html * igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1: - fi-icl-u2: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html #### Warnings #### * igt@debugfs_test@read_all_entries: - fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92]) -> [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html * igt@gem_exec_suspend@basic-s3: - fi-kbl-x1275: [DMESG-WARN][15] ([i915#1982] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/fi-kbl-x1275/igt@gem_exec_suspend@basic-s3.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/fi-kbl-x1275/igt@gem_exec_suspend@basic-s3.html * igt@kms_flip@basic-flip-vs-modeset@a-dp1: - fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#62] / [i915#92]) +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (44 -> 37) ------------------------------ Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5760 -> IGTPW_4855 CI-20190529: 20190529 CI_DRM_8847: 5ee1362eb4d8790a6c4b12d4b9f7ff9b833d5901 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4855: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/index.html IGT_5760: 53d2ddd2f5f7beb98a996d7f2c3976c87d4da01f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Testlist changes == +igt@kms_pipe_crc_basic@compare-crc-basic-a +igt@kms_pipe_crc_basic@compare-crc-basic-b +igt@kms_pipe_crc_basic@compare-crc-basic-c +igt@kms_pipe_crc_basic@compare-crc-basic-d +igt@kms_pipe_crc_basic@compare-crc-basic-e +igt@kms_pipe_crc_basic@compare-crc-basic-f == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/index.html [-- Attachment #1.2: Type: text/html, Size: 7327 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev3) 2020-07-29 22:29 [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem ` (4 preceding siblings ...) 2020-08-06 5:16 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev3) Patchwork @ 2020-08-06 6:19 ` Patchwork 2020-08-06 12:44 ` [igt-dev] [PATCH v2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem 2020-08-06 18:04 ` [igt-dev] [PATCH v3 0/2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem 7 siblings, 0 replies; 20+ messages in thread From: Patchwork @ 2020-08-06 6:19 UTC (permalink / raw) To: Bhanuprakash Modem; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 17480 bytes --] == Series Details == Series: tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev3) URL : https://patchwork.freedesktop.org/series/80040/ State : success == Summary == CI Bug Log - changes from CI_DRM_8847_full -> IGTPW_4855_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_4855_full: ### IGT changes ### #### Possible regressions #### * {igt@kms_pipe_crc_basic@compare-crc-basic-f} (NEW): - shard-tglb: NOTRUN -> [SKIP][1] +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-tglb6/igt@kms_pipe_crc_basic@compare-crc-basic-f.html New tests --------- New tests have been introduced between CI_DRM_8847_full and IGTPW_4855_full: ### New IGT tests (6) ### * igt@kms_pipe_crc_basic@compare-crc-basic-a: - Statuses : 7 pass(s) - Exec time: [0.27, 0.71] s * igt@kms_pipe_crc_basic@compare-crc-basic-b: - Statuses : 7 pass(s) - Exec time: [0.34, 1.73] s * igt@kms_pipe_crc_basic@compare-crc-basic-c: - Statuses : 6 pass(s) 1 skip(s) - Exec time: [0.0, 1.75] s * igt@kms_pipe_crc_basic@compare-crc-basic-d: - Statuses : 1 pass(s) 6 skip(s) - Exec time: [0.0, 1.63] s * igt@kms_pipe_crc_basic@compare-crc-basic-e: - Statuses : 7 skip(s) - Exec time: [0.0] s * igt@kms_pipe_crc_basic@compare-crc-basic-f: - Statuses : 7 skip(s) - Exec time: [0.0] s Known issues ------------ Here are the changes found in IGTPW_4855_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_pm_rps@waitboost: - shard-apl: [PASS][2] -> [FAIL][3] ([i915#1635] / [i915#39]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-apl4/igt@i915_pm_rps@waitboost.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-apl2/igt@i915_pm_rps@waitboost.html * igt@kms_big_fb@linear-64bpp-rotate-180: - shard-apl: [PASS][4] -> [DMESG-WARN][5] ([i915#1635] / [i915#1982]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-apl8/igt@kms_big_fb@linear-64bpp-rotate-180.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-apl6/igt@kms_big_fb@linear-64bpp-rotate-180.html * igt@kms_big_fb@x-tiled-64bpp-rotate-0: - shard-glk: [PASS][6] -> [DMESG-FAIL][7] ([i915#118] / [i915#95]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-glk6/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-glk8/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html * igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge: - shard-glk: [PASS][8] -> [DMESG-FAIL][9] ([i915#118] / [i915#70] / [i915#95]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-glk7/igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-glk8/igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge.html - shard-iclb: [PASS][10] -> [DMESG-FAIL][11] ([i915#1226]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-iclb5/igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-iclb8/igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge.html * igt@kms_cursor_legacy@basic-flip-before-cursor-atomic: - shard-kbl: [PASS][12] -> [DMESG-WARN][13] ([i915#1982]) +1 similar issue [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-kbl1/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-kbl1/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html * igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled: - shard-snb: [PASS][14] -> [TIMEOUT][15] ([i915#1958]) +1 similar issue [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-snb6/igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-snb1/igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [PASS][16] -> [DMESG-WARN][17] ([i915#180]) +2 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt: - shard-tglb: [PASS][18] -> [DMESG-WARN][19] ([i915#1982]) +2 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt.html * igt@kms_properties@get_properties-sanity-atomic: - shard-hsw: [PASS][20] -> [TIMEOUT][21] ([i915#1958]) +1 similar issue [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-hsw4/igt@kms_properties@get_properties-sanity-atomic.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-hsw8/igt@kms_properties@get_properties-sanity-atomic.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [PASS][22] -> [SKIP][23] ([fdo#109441]) +1 similar issue [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-iclb8/igt@kms_psr@psr2_primary_page_flip.html * igt@prime_busy@before-wait@vecs0: - shard-hsw: [PASS][24] -> [FAIL][25] ([i915#2258]) +1 similar issue [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-hsw7/igt@prime_busy@before-wait@vecs0.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-hsw4/igt@prime_busy@before-wait@vecs0.html #### Possible fixes #### * igt@gem_ctx_engines@execute-allforone: - shard-snb: [TIMEOUT][26] ([i915#1958]) -> [PASS][27] +2 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-snb2/igt@gem_ctx_engines@execute-allforone.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-snb2/igt@gem_ctx_engines@execute-allforone.html * igt@gem_exec_whisper@basic-fds-priority: - shard-glk: [DMESG-WARN][28] ([i915#118] / [i915#95]) -> [PASS][29] +1 similar issue [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-glk1/igt@gem_exec_whisper@basic-fds-priority.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-glk9/igt@gem_exec_whisper@basic-fds-priority.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [SKIP][30] ([i915#2190]) -> [PASS][31] [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-tglb6/igt@gem_huc_copy@huc-copy.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-tglb1/igt@gem_huc_copy@huc-copy.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [DMESG-WARN][32] ([i915#180]) -> [PASS][33] +3 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-kbl1/igt@gem_workarounds@suspend-resume-fd.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-kbl7/igt@gem_workarounds@suspend-resume-fd.html * igt@gen9_exec_parse@allowed-all: - shard-glk: [DMESG-WARN][34] ([i915#1436] / [i915#716]) -> [PASS][35] [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-glk6/igt@gen9_exec_parse@allowed-all.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-glk1/igt@gen9_exec_parse@allowed-all.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [FAIL][36] ([i915#1899]) -> [PASS][37] [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-iclb7/igt@i915_pm_dc@dc6-psr.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-iclb3/igt@i915_pm_dc@dc6-psr.html * igt@i915_selftest@mock@contexts: - shard-apl: [INCOMPLETE][38] ([i915#1635]) -> [PASS][39] [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-apl3/igt@i915_selftest@mock@contexts.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-apl7/igt@i915_selftest@mock@contexts.html * igt@kms_big_fb@y-tiled-64bpp-rotate-0: - shard-glk: [DMESG-FAIL][40] ([i915#118] / [i915#95]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-glk8/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-glk6/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html * igt@kms_cursor_crc@pipe-a-cursor-64x21-random: - shard-hsw: [TIMEOUT][42] ([i915#1958]) -> [PASS][43] +2 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-hsw4/igt@kms_cursor_crc@pipe-a-cursor-64x21-random.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-hsw8/igt@kms_cursor_crc@pipe-a-cursor-64x21-random.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1: - shard-apl: [FAIL][44] ([i915#1635] / [i915#79]) -> [PASS][45] [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-apl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1.html * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack: - shard-tglb: [DMESG-WARN][46] ([i915#1982]) -> [PASS][47] +2 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite: - shard-glk: [FAIL][48] ([i915#49]) -> [PASS][49] [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-glk9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-glk4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping: - shard-iclb: [DMESG-WARN][50] ([i915#1982]) -> [PASS][51] [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-iclb3/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-iclb6/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [SKIP][52] ([fdo#109441]) -> [PASS][53] +2 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-iclb7/igt@kms_psr@psr2_no_drrs.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-iclb2/igt@kms_psr@psr2_no_drrs.html * igt@kms_vblank@pipe-b-ts-continuation-idle-hang: - shard-apl: [DMESG-WARN][54] ([i915#1635] / [i915#1982]) -> [PASS][55] [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-apl2/igt@kms_vblank@pipe-b-ts-continuation-idle-hang.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-apl8/igt@kms_vblank@pipe-b-ts-continuation-idle-hang.html * igt@kms_vblank@pipe-c-ts-continuation-suspend: - shard-iclb: [INCOMPLETE][56] ([fdo#111764] / [i915#1078] / [i915#1185]) -> [PASS][57] [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-iclb3/igt@kms_vblank@pipe-c-ts-continuation-suspend.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-iclb8/igt@kms_vblank@pipe-c-ts-continuation-suspend.html * igt@perf@blocking-parameterized: - shard-iclb: [FAIL][58] ([i915#1542]) -> [PASS][59] [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-iclb8/igt@perf@blocking-parameterized.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-iclb5/igt@perf@blocking-parameterized.html #### Warnings #### * igt@gem_render_copy@y-tiled-ccs-to-x-tiled: - shard-hsw: [TIMEOUT][60] ([i915#1958]) -> [SKIP][61] ([fdo#109271]) +1 similar issue [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-hsw4/igt@gem_render_copy@y-tiled-ccs-to-x-tiled.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-hsw8/igt@gem_render_copy@y-tiled-ccs-to-x-tiled.html * igt@gen9_exec_parse@allowed-all: - shard-apl: [INCOMPLETE][62] ([i915#1436] / [i915#1635]) -> [DMESG-WARN][63] ([i915#1436] / [i915#1635] / [i915#716]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-apl7/igt@gen9_exec_parse@allowed-all.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-apl6/igt@gen9_exec_parse@allowed-all.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-render: - shard-hsw: [SKIP][64] ([fdo#109271]) -> [TIMEOUT][65] ([i915#1958]) +2 similar issues [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-hsw8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-render.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-hsw8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-render.html * igt@kms_plane_lowres@pipe-a-tiling-yf: - shard-snb: [TIMEOUT][66] ([i915#1958]) -> [SKIP][67] ([fdo#109271]) +2 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-snb2/igt@kms_plane_lowres@pipe-a-tiling-yf.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-snb5/igt@kms_plane_lowres@pipe-a-tiling-yf.html * igt@kms_vblank@pipe-d-ts-continuation-modeset-hang: - shard-snb: [SKIP][68] ([fdo#109271]) -> [TIMEOUT][69] ([i915#1958]) +2 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-snb6/igt@kms_vblank@pipe-d-ts-continuation-modeset-hang.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-snb1/igt@kms_vblank@pipe-d-ts-continuation-modeset-hang.html * igt@runner@aborted: - shard-apl: ([FAIL][70], [FAIL][71]) ([fdo#109271] / [i915#1635] / [i915#2110] / [i915#716]) -> [FAIL][72] ([fdo#109271] / [i915#1635] / [i915#716]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-apl3/igt@runner@aborted.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8847/shard-apl7/igt@runner@aborted.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/shard-apl6/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764 [i915#1078]: https://gitlab.freedesktop.org/drm/intel/issues/1078 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185 [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1899]: https://gitlab.freedesktop.org/drm/intel/issues/1899 [i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2258]: https://gitlab.freedesktop.org/drm/intel/issues/2258 [i915#39]: https://gitlab.freedesktop.org/drm/intel/issues/39 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#70]: https://gitlab.freedesktop.org/drm/intel/issues/70 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (11 -> 8) ------------------------------ Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5760 -> IGTPW_4855 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_8847: 5ee1362eb4d8790a6c4b12d4b9f7ff9b833d5901 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4855: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/index.html IGT_5760: 53d2ddd2f5f7beb98a996d7f2c3976c87d4da01f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4855/index.html [-- Attachment #1.2: Type: text/html, Size: 21670 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* [igt-dev] [PATCH v2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-07-29 22:29 [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem ` (5 preceding siblings ...) 2020-08-06 6:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2020-08-06 12:44 ` Bhanuprakash Modem 2020-08-06 8:16 ` Petri Latvala ` (2 more replies) 2020-08-06 18:04 ` [igt-dev] [PATCH v3 0/2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem 7 siblings, 3 replies; 20+ messages in thread From: Bhanuprakash Modem @ 2020-08-06 12:44 UTC (permalink / raw) To: bhanuprakash.modem, igt-dev; +Cc: Petri Latvala We’ve seen multiple CRC related issues on older platforms and pre-silicon environment, most of the time we end up with debugging. This patch works as a crc-sanity test, which can verify that the CRC mechanism is clean from the platform side before debugging the actual CRC mismatches or other CRC related issues. This patch will create two framebuffers (fb0 & fb1) with the same color info, flip fb0 with primary plane & collect CRC as reference. Then flip fb1 with primary plane, collect the CRC and compare with the reference CRC. There should be no CRC mismatch. v2: * Run subtest to all pipes (Karthik & Swati) * Fix commit message & few comments (Karthik) * Use meaningful name for functions (Swati) * Remove unwanted checks (Karthik) Cc: Swati Sharma <swati2.sharma@intel.com> Cc: Karthik B S <karthik.b.s@intel.com> Cc: Jeevan B <jeevan.b@intel.com> Cc: Petri Latvala <petri.latvala@intel.com> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> --- tests/kms_pipe_crc_basic.c | 73 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index cb93c1ad..599047cb 100644 --- a/tests/kms_pipe_crc_basic.c +++ b/tests/kms_pipe_crc_basic.c @@ -154,6 +154,75 @@ static void test_read_crc(data_t *data, enum pipe pipe, unsigned flags) } } +/* + * CRC-sanity test, to make sure there would be no CRC mismatches + * + * - Create two framebuffers (FB0 & FB1) with same color info + * - Flip FB0 with the Primary plane & collect the CRC as ref CRC. + * - Flip FB1 with the Primary plane, collect the CRC & compare with + * the ref CRC. + * + * No CRC mismatch should happen + */ +static void test_compare_crc(data_t *data, enum pipe pipe) +{ + igt_display_t *display = &data->display; + igt_plane_t *primary; + drmModeModeInfo *mode; + igt_crc_t ref_crc, crc; + igt_pipe_crc_t *pipe_crc = NULL; + struct igt_fb fb0, fb1; + igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); + + igt_require_f(output, "No connector found for pipe %s\n", + kmstest_pipe_name(pipe)); + + igt_require_pipe(display, pipe); + igt_display_reset(display); + igt_output_set_pipe(output, pipe); + + mode = igt_output_get_mode(output); + + /* Create two framebuffers with the same color info. */ + igt_create_color_fb(data->drm_fd, + mode->hdisplay, mode->vdisplay, + DRM_FORMAT_XRGB8888, + LOCAL_DRM_FORMAT_MOD_NONE, + 1.0, 1.0, 1.0, + &fb0); + igt_create_color_fb(data->drm_fd, + mode->hdisplay, mode->vdisplay, + DRM_FORMAT_XRGB8888, + LOCAL_DRM_FORMAT_MOD_NONE, + 1.0, 1.0, 1.0, + &fb1); + + /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */ + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + igt_plane_set_fb(primary, &fb0); + igt_display_commit(display); + + pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, + INTEL_PIPE_CRC_SOURCE_AUTO); + igt_pipe_crc_collect_crc(pipe_crc, &ref_crc); + + /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. */ + igt_plane_set_fb(primary, &fb1); + igt_display_commit(display); + + igt_pipe_crc_collect_crc(pipe_crc, &crc); + igt_assert_crc_equal(&crc, &ref_crc); + + /* Clean-up */ + igt_pipe_crc_free(pipe_crc); + igt_plane_set_fb(primary, NULL); + igt_output_set_pipe(output, PIPE_NONE); + igt_display_commit(display); + + igt_remove_fb(data->drm_fd, &fb0); + igt_remove_fb(data->drm_fd, &fb1); +} + data_t data = {0, }; igt_main @@ -209,6 +278,10 @@ igt_main igt_disallow_hang(data.drm_fd, hang); } + + igt_describe("Basic sanity check for CRC mismatches"); + igt_subtest_f("compare-crc-basic-%s", kmstest_pipe_name(pipe)) + test_compare_crc(&data, pipe); } igt_fixture { -- 2.20.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [igt-dev] [PATCH v2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-08-06 12:44 ` [igt-dev] [PATCH v2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem @ 2020-08-06 8:16 ` Petri Latvala 2020-08-06 8:30 ` Modem, Bhanuprakash 2020-08-06 18:04 ` [igt-dev] [PATCH v3 1/2] " Bhanuprakash Modem 2020-08-06 18:04 ` [igt-dev] [PATCH v1 2/2] intel-ci: Add compare CRC sanity test to BAT Bhanuprakash Modem 2 siblings, 1 reply; 20+ messages in thread From: Petri Latvala @ 2020-08-06 8:16 UTC (permalink / raw) To: Bhanuprakash Modem; +Cc: igt-dev On Thu, Aug 06, 2020 at 06:14:50PM +0530, Bhanuprakash Modem wrote: > We’ve seen multiple CRC related issues on older platforms and > pre-silicon environment, most of the time we end up with debugging. > > This patch works as a crc-sanity test, which can verify that the > CRC mechanism is clean from the platform side before debugging the > actual CRC mismatches or other CRC related issues. > > This patch will create two framebuffers (fb0 & fb1) with the same > color info, flip fb0 with primary plane & collect CRC as reference. > Then flip fb1 with primary plane, collect the CRC and compare with > the reference CRC. There should be no CRC mismatch. > > v2: > * Run subtest to all pipes (Karthik & Swati) > * Fix commit message & few comments (Karthik) > * Use meaningful name for functions (Swati) > * Remove unwanted checks (Karthik) > > Cc: Swati Sharma <swati2.sharma@intel.com> > Cc: Karthik B S <karthik.b.s@intel.com> > Cc: Jeevan B <jeevan.b@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> > --- > tests/kms_pipe_crc_basic.c | 73 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > > diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c > index cb93c1ad..599047cb 100644 > --- a/tests/kms_pipe_crc_basic.c > +++ b/tests/kms_pipe_crc_basic.c > @@ -154,6 +154,75 @@ static void test_read_crc(data_t *data, enum pipe pipe, unsigned flags) > } > } > > +/* > + * CRC-sanity test, to make sure there would be no CRC mismatches > + * > + * - Create two framebuffers (FB0 & FB1) with same color info > + * - Flip FB0 with the Primary plane & collect the CRC as ref CRC. > + * - Flip FB1 with the Primary plane, collect the CRC & compare with > + * the ref CRC. > + * > + * No CRC mismatch should happen > + */ > +static void test_compare_crc(data_t *data, enum pipe pipe) > +{ > + igt_display_t *display = &data->display; > + igt_plane_t *primary; > + drmModeModeInfo *mode; > + igt_crc_t ref_crc, crc; > + igt_pipe_crc_t *pipe_crc = NULL; > + struct igt_fb fb0, fb1; > + igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); > + > + igt_require_f(output, "No connector found for pipe %s\n", > + kmstest_pipe_name(pipe)); > + > + igt_require_pipe(display, pipe); > + igt_display_reset(display); > + igt_output_set_pipe(output, pipe); > + > + mode = igt_output_get_mode(output); > + > + /* Create two framebuffers with the same color info. */ > + igt_create_color_fb(data->drm_fd, > + mode->hdisplay, mode->vdisplay, > + DRM_FORMAT_XRGB8888, > + LOCAL_DRM_FORMAT_MOD_NONE, > + 1.0, 1.0, 1.0, > + &fb0); > + igt_create_color_fb(data->drm_fd, > + mode->hdisplay, mode->vdisplay, > + DRM_FORMAT_XRGB8888, > + LOCAL_DRM_FORMAT_MOD_NONE, > + 1.0, 1.0, 1.0, > + &fb1); > + > + /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */ > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > + igt_plane_set_fb(primary, &fb0); > + igt_display_commit(display); > + > + pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, > + INTEL_PIPE_CRC_SOURCE_AUTO); > + igt_pipe_crc_collect_crc(pipe_crc, &ref_crc); > + > + /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. */ > + igt_plane_set_fb(primary, &fb1); > + igt_display_commit(display); > + > + igt_pipe_crc_collect_crc(pipe_crc, &crc); > + igt_assert_crc_equal(&crc, &ref_crc); > + > + /* Clean-up */ > + igt_pipe_crc_free(pipe_crc); > + igt_plane_set_fb(primary, NULL); > + igt_output_set_pipe(output, PIPE_NONE); > + igt_display_commit(display); > + > + igt_remove_fb(data->drm_fd, &fb0); > + igt_remove_fb(data->drm_fd, &fb1); > +} > + > data_t data = {0, }; > > igt_main > @@ -209,6 +278,10 @@ igt_main > > igt_disallow_hang(data.drm_fd, hang); > } > + > + igt_describe("Basic sanity check for CRC mismatches"); > + igt_subtest_f("compare-crc-basic-%s", kmstest_pipe_name(pipe)) Please change the name to "compare-crc-sanitycheck-pipe-%s". For one, calling it "basic" is redundant, this test binary already says "basic". Another change is the per-pipe naming convention used elsewhere, "pipe-%s". This test should go to BAT. Do you want to add a fast-feedback.testlist change separately or can it go to this patch? -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [igt-dev] [PATCH v2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-08-06 8:16 ` Petri Latvala @ 2020-08-06 8:30 ` Modem, Bhanuprakash 0 siblings, 0 replies; 20+ messages in thread From: Modem, Bhanuprakash @ 2020-08-06 8:30 UTC (permalink / raw) To: Latvala, Petri; +Cc: igt-dev@lists.freedesktop.org > -----Original Message----- > From: Latvala, Petri <petri.latvala@intel.com> > Sent: Thursday, August 6, 2020 1:47 PM > To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com> > Cc: igt-dev@lists.freedesktop.org; Sharma, Swati2 > <swati2.sharma@intel.com>; B S, Karthik <karthik.b.s@intel.com>; B, Jeevan > <jeevan.b@intel.com>; Arkadiusz Hiler <arek@hiler.eu> > Subject: Re: [PATCH v2] tests/kms_pipe_crc_basic: Sanity check for CRC > mismatches > > On Thu, Aug 06, 2020 at 06:14:50PM +0530, Bhanuprakash Modem wrote: > > We’ve seen multiple CRC related issues on older platforms and > > pre-silicon environment, most of the time we end up with debugging. > > > > This patch works as a crc-sanity test, which can verify that the > > CRC mechanism is clean from the platform side before debugging the > > actual CRC mismatches or other CRC related issues. > > > > This patch will create two framebuffers (fb0 & fb1) with the same > > color info, flip fb0 with primary plane & collect CRC as reference. > > Then flip fb1 with primary plane, collect the CRC and compare with > > the reference CRC. There should be no CRC mismatch. > > > > v2: > > * Run subtest to all pipes (Karthik & Swati) > > * Fix commit message & few comments (Karthik) > > * Use meaningful name for functions (Swati) > > * Remove unwanted checks (Karthik) > > > > Cc: Swati Sharma <swati2.sharma@intel.com> > > Cc: Karthik B S <karthik.b.s@intel.com> > > Cc: Jeevan B <jeevan.b@intel.com> > > Cc: Petri Latvala <petri.latvala@intel.com> > > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com> > > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> > > --- > > tests/kms_pipe_crc_basic.c | 73 ++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 73 insertions(+) > > > > diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c > > index cb93c1ad..599047cb 100644 > > --- a/tests/kms_pipe_crc_basic.c > > +++ b/tests/kms_pipe_crc_basic.c > > @@ -154,6 +154,75 @@ static void test_read_crc(data_t *data, enum pipe > pipe, unsigned flags) > > } > > } > > > > +/* > > + * CRC-sanity test, to make sure there would be no CRC mismatches > > + * > > + * - Create two framebuffers (FB0 & FB1) with same color info > > + * - Flip FB0 with the Primary plane & collect the CRC as ref CRC. > > + * - Flip FB1 with the Primary plane, collect the CRC & compare with > > + * the ref CRC. > > + * > > + * No CRC mismatch should happen > > + */ > > +static void test_compare_crc(data_t *data, enum pipe pipe) > > +{ > > + igt_display_t *display = &data->display; > > + igt_plane_t *primary; > > + drmModeModeInfo *mode; > > + igt_crc_t ref_crc, crc; > > + igt_pipe_crc_t *pipe_crc = NULL; > > + struct igt_fb fb0, fb1; > > + igt_output_t *output = igt_get_single_output_for_pipe(display, > pipe); > > + > > + igt_require_f(output, "No connector found for pipe %s\n", > > + kmstest_pipe_name(pipe)); > > + > > + igt_require_pipe(display, pipe); > > + igt_display_reset(display); > > + igt_output_set_pipe(output, pipe); > > + > > + mode = igt_output_get_mode(output); > > + > > + /* Create two framebuffers with the same color info. */ > > + igt_create_color_fb(data->drm_fd, > > + mode->hdisplay, mode->vdisplay, > > + DRM_FORMAT_XRGB8888, > > + LOCAL_DRM_FORMAT_MOD_NONE, > > + 1.0, 1.0, 1.0, > > + &fb0); > > + igt_create_color_fb(data->drm_fd, > > + mode->hdisplay, mode->vdisplay, > > + DRM_FORMAT_XRGB8888, > > + LOCAL_DRM_FORMAT_MOD_NONE, > > + 1.0, 1.0, 1.0, > > + &fb1); > > + > > + /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */ > > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > > + igt_plane_set_fb(primary, &fb0); > > + igt_display_commit(display); > > + > > + pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, > > + INTEL_PIPE_CRC_SOURCE_AUTO); > > + igt_pipe_crc_collect_crc(pipe_crc, &ref_crc); > > + > > + /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. > */ > > + igt_plane_set_fb(primary, &fb1); > > + igt_display_commit(display); > > + > > + igt_pipe_crc_collect_crc(pipe_crc, &crc); > > + igt_assert_crc_equal(&crc, &ref_crc); > > + > > + /* Clean-up */ > > + igt_pipe_crc_free(pipe_crc); > > + igt_plane_set_fb(primary, NULL); > > + igt_output_set_pipe(output, PIPE_NONE); > > + igt_display_commit(display); > > + > > + igt_remove_fb(data->drm_fd, &fb0); > > + igt_remove_fb(data->drm_fd, &fb1); > > +} > > + > > data_t data = {0, }; > > > > igt_main > > @@ -209,6 +278,10 @@ igt_main > > > > igt_disallow_hang(data.drm_fd, hang); > > } > > + > > + igt_describe("Basic sanity check for CRC mismatches"); > > + igt_subtest_f("compare-crc-basic-%s", kmstest_pipe_name(pipe)) > > Please change the name to "compare-crc-sanitycheck-pipe-%s". For one, > calling it "basic" is redundant, this test binary already says > "basic". Another change is the per-pipe naming convention used > elsewhere, "pipe-%s". [Bhanu] Thanks for the review, I'll make these changes in next revision. > > This test should go to BAT. Do you want to add a > fast-feedback.testlist change separately or can it go to this patch? [Bhanu] Having a separate commit seems a good option for me. > > > -- > Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* [igt-dev] [PATCH v3 1/2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-08-06 12:44 ` [igt-dev] [PATCH v2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem 2020-08-06 8:16 ` Petri Latvala @ 2020-08-06 18:04 ` Bhanuprakash Modem 2020-08-06 18:04 ` [igt-dev] [PATCH v1 2/2] intel-ci: Add compare CRC sanity test to BAT Bhanuprakash Modem 2 siblings, 0 replies; 20+ messages in thread From: Bhanuprakash Modem @ 2020-08-06 18:04 UTC (permalink / raw) To: bhanuprakash.modem, igt-dev; +Cc: Petri Latvala We’ve seen multiple CRC related issues on older platforms and pre-silicon environment, most of the time we end up with debugging. This patch works as a crc-sanity test, which can verify that the CRC mechanism is clean from the platform side before debugging the actual CRC mismatches or other CRC related issues. This patch will create two framebuffers (fb0 & fb1) with the same color info, flip fb0 with primary plane & collect CRC as reference. Then flip fb1 with primary plane, collect the CRC and compare with the reference CRC. There should be no CRC mismatch. v2: * Run subtest to all pipes (Karthik & Swati) * Fix commit message & few comments (Karthik) * Use meaningful name for functions (Swati) * Remove unwanted checks (Karthik) v3: * Rename subtest to compare-crc-sanitycheck-pipe- (Petri) Cc: Swati Sharma <swati2.sharma@intel.com> Cc: Karthik B S <karthik.b.s@intel.com> Cc: Jeevan B <jeevan.b@intel.com> Cc: Petri Latvala <petri.latvala@intel.com> Cc: Arkadiusz Hiler <arek@hiler.eu> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> --- tests/kms_pipe_crc_basic.c | 73 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index cb93c1ad..c3c4cdd8 100644 --- a/tests/kms_pipe_crc_basic.c +++ b/tests/kms_pipe_crc_basic.c @@ -154,6 +154,75 @@ static void test_read_crc(data_t *data, enum pipe pipe, unsigned flags) } } +/* + * CRC-sanity test, to make sure there would be no CRC mismatches + * + * - Create two framebuffers (FB0 & FB1) with same color info + * - Flip FB0 with the Primary plane & collect the CRC as ref CRC. + * - Flip FB1 with the Primary plane, collect the CRC & compare with + * the ref CRC. + * + * No CRC mismatch should happen + */ +static void test_compare_crc(data_t *data, enum pipe pipe) +{ + igt_display_t *display = &data->display; + igt_plane_t *primary; + drmModeModeInfo *mode; + igt_crc_t ref_crc, crc; + igt_pipe_crc_t *pipe_crc = NULL; + struct igt_fb fb0, fb1; + igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); + + igt_require_f(output, "No connector found for pipe %s\n", + kmstest_pipe_name(pipe)); + + igt_require_pipe(display, pipe); + igt_display_reset(display); + igt_output_set_pipe(output, pipe); + + mode = igt_output_get_mode(output); + + /* Create two framebuffers with the same color info. */ + igt_create_color_fb(data->drm_fd, + mode->hdisplay, mode->vdisplay, + DRM_FORMAT_XRGB8888, + LOCAL_DRM_FORMAT_MOD_NONE, + 1.0, 1.0, 1.0, + &fb0); + igt_create_color_fb(data->drm_fd, + mode->hdisplay, mode->vdisplay, + DRM_FORMAT_XRGB8888, + LOCAL_DRM_FORMAT_MOD_NONE, + 1.0, 1.0, 1.0, + &fb1); + + /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */ + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + igt_plane_set_fb(primary, &fb0); + igt_display_commit(display); + + pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, + INTEL_PIPE_CRC_SOURCE_AUTO); + igt_pipe_crc_collect_crc(pipe_crc, &ref_crc); + + /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. */ + igt_plane_set_fb(primary, &fb1); + igt_display_commit(display); + + igt_pipe_crc_collect_crc(pipe_crc, &crc); + igt_assert_crc_equal(&crc, &ref_crc); + + /* Clean-up */ + igt_pipe_crc_free(pipe_crc); + igt_plane_set_fb(primary, NULL); + igt_output_set_pipe(output, PIPE_NONE); + igt_display_commit(display); + + igt_remove_fb(data->drm_fd, &fb0); + igt_remove_fb(data->drm_fd, &fb1); +} + data_t data = {0, }; igt_main @@ -209,6 +278,10 @@ igt_main igt_disallow_hang(data.drm_fd, hang); } + + igt_describe("Basic sanity check for CRC mismatches"); + igt_subtest_f("compare-crc-sanitycheck-pipe-%s", kmstest_pipe_name(pipe)) + test_compare_crc(&data, pipe); } igt_fixture { -- 2.20.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [igt-dev] [PATCH v1 2/2] intel-ci: Add compare CRC sanity test to BAT 2020-08-06 12:44 ` [igt-dev] [PATCH v2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem 2020-08-06 8:16 ` Petri Latvala 2020-08-06 18:04 ` [igt-dev] [PATCH v3 1/2] " Bhanuprakash Modem @ 2020-08-06 18:04 ` Bhanuprakash Modem 2020-08-06 10:20 ` Petri Latvala 2 siblings, 1 reply; 20+ messages in thread From: Bhanuprakash Modem @ 2020-08-06 18:04 UTC (permalink / raw) To: bhanuprakash.modem, igt-dev; +Cc: Petri Latvala We need to sanity-check for the CRC mismatches, otherwise the display validation tests are flawed. This patch will add CRC compare mismatch subtests to the fast-feedback list to make sure the CRC mechanism is clean from the platform. Cc: Swati Sharma <swati2.sharma@intel.com> Cc: Karthik B S <karthik.b.s@intel.com> Cc: Jeevan B <jeevan.b@intel.com> Cc: Petri Latvala <petri.latvala@intel.com> Cc: Arkadiusz Hiler <arek@hiler.eu> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> --- tests/intel-ci/fast-feedback.testlist | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index b796b264..b9d769d8 100644 --- a/tests/intel-ci/fast-feedback.testlist +++ b/tests/intel-ci/fast-feedback.testlist @@ -110,6 +110,9 @@ igt@kms_force_connector_basic@force-edid igt@kms_force_connector_basic@force-load-detect igt@kms_force_connector_basic@prune-stale-modes igt@kms_frontbuffer_tracking@basic +igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a +igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b +igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c igt@kms_pipe_crc_basic@hang-read-crc-pipe-a igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence -- 2.20.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [igt-dev] [PATCH v1 2/2] intel-ci: Add compare CRC sanity test to BAT 2020-08-06 18:04 ` [igt-dev] [PATCH v1 2/2] intel-ci: Add compare CRC sanity test to BAT Bhanuprakash Modem @ 2020-08-06 10:20 ` Petri Latvala 0 siblings, 0 replies; 20+ messages in thread From: Petri Latvala @ 2020-08-06 10:20 UTC (permalink / raw) To: Bhanuprakash Modem; +Cc: igt-dev On Thu, Aug 06, 2020 at 11:34:26PM +0530, Bhanuprakash Modem wrote: > We need to sanity-check for the CRC mismatches, otherwise > the display validation tests are flawed. > > This patch will add CRC compare mismatch subtests to the > fast-feedback list to make sure the CRC mechanism is clean > from the platform. > > Cc: Swati Sharma <swati2.sharma@intel.com> > Cc: Karthik B S <karthik.b.s@intel.com> > Cc: Jeevan B <jeevan.b@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> > Cc: Arkadiusz Hiler <arek@hiler.eu> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> > --- > tests/intel-ci/fast-feedback.testlist | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist > index b796b264..b9d769d8 100644 > --- a/tests/intel-ci/fast-feedback.testlist > +++ b/tests/intel-ci/fast-feedback.testlist > @@ -110,6 +110,9 @@ igt@kms_force_connector_basic@force-edid > igt@kms_force_connector_basic@force-load-detect > igt@kms_force_connector_basic@prune-stale-modes > igt@kms_frontbuffer_tracking@basic > +igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a > +igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b > +igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c Add pipe-d as well. Acked-by: Petri Latvala <petri.latvala@intel.com> Swati and Karthik provided comments on the first patch, so as soon as they say it's good now we can merge this. _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* [igt-dev] [PATCH v3 0/2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-07-29 22:29 [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem ` (6 preceding siblings ...) 2020-08-06 12:44 ` [igt-dev] [PATCH v2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem @ 2020-08-06 18:04 ` Bhanuprakash Modem 7 siblings, 0 replies; 20+ messages in thread From: Bhanuprakash Modem @ 2020-08-06 18:04 UTC (permalink / raw) To: bhanuprakash.modem, igt-dev This series will add a crc-sanity test to verify the CRC mechanism is clean from the platform and add the subtest to fast-feedback list. Bhanuprakash Modem (2): tests/kms_pipe_crc_basic: Sanity check for CRC mismatches intel-ci: Add compare CRC sanity test to BAT tests/intel-ci/fast-feedback.testlist | 3 ++ tests/kms_pipe_crc_basic.c | 73 +++++++++++++++++++++++++++ 2 files changed, 76 insertions(+) -- 2.20.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* [igt-dev] [PATCH v3 0/2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches @ 2020-08-06 18:07 Bhanuprakash Modem 2020-08-06 18:07 ` [igt-dev] [PATCH v3 1/2] " Bhanuprakash Modem 0 siblings, 1 reply; 20+ messages in thread From: Bhanuprakash Modem @ 2020-08-06 18:07 UTC (permalink / raw) To: bhanuprakash.modem, igt-dev This series will add a crc-sanity test to verify the CRC mechanism is clean from the platform and add the subtest to fast-feedback list. Bhanuprakash Modem (2): tests/kms_pipe_crc_basic: Sanity check for CRC mismatches intel-ci: Add compare CRC sanity test to BAT tests/intel-ci/fast-feedback.testlist | 3 ++ tests/kms_pipe_crc_basic.c | 73 +++++++++++++++++++++++++++ 2 files changed, 76 insertions(+) -- 2.20.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* [igt-dev] [PATCH v3 1/2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-08-06 18:07 Bhanuprakash Modem @ 2020-08-06 18:07 ` Bhanuprakash Modem 0 siblings, 0 replies; 20+ messages in thread From: Bhanuprakash Modem @ 2020-08-06 18:07 UTC (permalink / raw) To: bhanuprakash.modem, igt-dev; +Cc: Petri Latvala We’ve seen multiple CRC related issues on older platforms and pre-silicon environment, most of the time we end up with debugging. This patch works as a crc-sanity test, which can verify that the CRC mechanism is clean from the platform side before debugging the actual CRC mismatches or other CRC related issues. This patch will create two framebuffers (fb0 & fb1) with the same color info, flip fb0 with primary plane & collect CRC as reference. Then flip fb1 with primary plane, collect the CRC and compare with the reference CRC. There should be no CRC mismatch. v2: * Run subtest to all pipes (Karthik & Swati) * Fix commit message & few comments (Karthik) * Use meaningful name for functions (Swati) * Remove unwanted checks (Karthik) v3: * Rename subtest to compare-crc-sanitycheck-pipe- (Petri) Cc: Swati Sharma <swati2.sharma@intel.com> Cc: Karthik B S <karthik.b.s@intel.com> Cc: Jeevan B <jeevan.b@intel.com> Cc: Petri Latvala <petri.latvala@intel.com> Cc: Arkadiusz Hiler <arek@hiler.eu> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> --- tests/kms_pipe_crc_basic.c | 73 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index cb93c1ad..c3c4cdd8 100644 --- a/tests/kms_pipe_crc_basic.c +++ b/tests/kms_pipe_crc_basic.c @@ -154,6 +154,75 @@ static void test_read_crc(data_t *data, enum pipe pipe, unsigned flags) } } +/* + * CRC-sanity test, to make sure there would be no CRC mismatches + * + * - Create two framebuffers (FB0 & FB1) with same color info + * - Flip FB0 with the Primary plane & collect the CRC as ref CRC. + * - Flip FB1 with the Primary plane, collect the CRC & compare with + * the ref CRC. + * + * No CRC mismatch should happen + */ +static void test_compare_crc(data_t *data, enum pipe pipe) +{ + igt_display_t *display = &data->display; + igt_plane_t *primary; + drmModeModeInfo *mode; + igt_crc_t ref_crc, crc; + igt_pipe_crc_t *pipe_crc = NULL; + struct igt_fb fb0, fb1; + igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); + + igt_require_f(output, "No connector found for pipe %s\n", + kmstest_pipe_name(pipe)); + + igt_require_pipe(display, pipe); + igt_display_reset(display); + igt_output_set_pipe(output, pipe); + + mode = igt_output_get_mode(output); + + /* Create two framebuffers with the same color info. */ + igt_create_color_fb(data->drm_fd, + mode->hdisplay, mode->vdisplay, + DRM_FORMAT_XRGB8888, + LOCAL_DRM_FORMAT_MOD_NONE, + 1.0, 1.0, 1.0, + &fb0); + igt_create_color_fb(data->drm_fd, + mode->hdisplay, mode->vdisplay, + DRM_FORMAT_XRGB8888, + LOCAL_DRM_FORMAT_MOD_NONE, + 1.0, 1.0, 1.0, + &fb1); + + /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */ + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + igt_plane_set_fb(primary, &fb0); + igt_display_commit(display); + + pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, + INTEL_PIPE_CRC_SOURCE_AUTO); + igt_pipe_crc_collect_crc(pipe_crc, &ref_crc); + + /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. */ + igt_plane_set_fb(primary, &fb1); + igt_display_commit(display); + + igt_pipe_crc_collect_crc(pipe_crc, &crc); + igt_assert_crc_equal(&crc, &ref_crc); + + /* Clean-up */ + igt_pipe_crc_free(pipe_crc); + igt_plane_set_fb(primary, NULL); + igt_output_set_pipe(output, PIPE_NONE); + igt_display_commit(display); + + igt_remove_fb(data->drm_fd, &fb0); + igt_remove_fb(data->drm_fd, &fb1); +} + data_t data = {0, }; igt_main @@ -209,6 +278,10 @@ igt_main igt_disallow_hang(data.drm_fd, hang); } + + igt_describe("Basic sanity check for CRC mismatches"); + igt_subtest_f("compare-crc-sanitycheck-pipe-%s", kmstest_pipe_name(pipe)) + test_compare_crc(&data, pipe); } igt_fixture { -- 2.20.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [igt-dev] [PATCH v3 0/2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches @ 2020-08-06 18:33 Bhanuprakash Modem 2020-08-06 18:33 ` [igt-dev] [PATCH v3 1/2] " Bhanuprakash Modem 0 siblings, 1 reply; 20+ messages in thread From: Bhanuprakash Modem @ 2020-08-06 18:33 UTC (permalink / raw) To: bhanuprakash.modem, igt-dev This series will add a crc-sanity test to verify the CRC mechanism is clean from the platform and add the subtest to fast-feedback list. Bhanuprakash Modem (2): tests/kms_pipe_crc_basic: Sanity check for CRC mismatches intel-ci: Add compare CRC sanity test to BAT tests/intel-ci/fast-feedback.testlist | 4 ++ tests/kms_pipe_crc_basic.c | 73 +++++++++++++++++++++++++++ 2 files changed, 77 insertions(+) -- 2.20.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* [igt-dev] [PATCH v3 1/2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-08-06 18:33 [igt-dev] [PATCH v3 0/2] " Bhanuprakash Modem @ 2020-08-06 18:33 ` Bhanuprakash Modem 2020-08-06 10:43 ` Sharma, Swati2 2020-08-06 11:03 ` Karthik B S 0 siblings, 2 replies; 20+ messages in thread From: Bhanuprakash Modem @ 2020-08-06 18:33 UTC (permalink / raw) To: bhanuprakash.modem, igt-dev; +Cc: Petri Latvala We’ve seen multiple CRC related issues on older platforms and pre-silicon environment, most of the time we end up with debugging. This patch works as a crc-sanity test, which can verify that the CRC mechanism is clean from the platform side before debugging the actual CRC mismatches or other CRC related issues. This patch will create two framebuffers (fb0 & fb1) with the same color info, flip fb0 with primary plane & collect CRC as reference. Then flip fb1 with primary plane, collect the CRC and compare with the reference CRC. There should be no CRC mismatch. v2: * Run subtest to all pipes (Karthik & Swati) * Fix commit message & few comments (Karthik) * Use meaningful name for functions (Swati) * Remove unwanted checks (Karthik) v3: * Rename subtest to compare-crc-sanitycheck-pipe- (Petri) Cc: Swati Sharma <swati2.sharma@intel.com> Cc: Karthik B S <karthik.b.s@intel.com> Cc: Jeevan B <jeevan.b@intel.com> Cc: Petri Latvala <petri.latvala@intel.com> Cc: Arkadiusz Hiler <arek@hiler.eu> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> --- tests/kms_pipe_crc_basic.c | 73 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index cb93c1ad..c3c4cdd8 100644 --- a/tests/kms_pipe_crc_basic.c +++ b/tests/kms_pipe_crc_basic.c @@ -154,6 +154,75 @@ static void test_read_crc(data_t *data, enum pipe pipe, unsigned flags) } } +/* + * CRC-sanity test, to make sure there would be no CRC mismatches + * + * - Create two framebuffers (FB0 & FB1) with same color info + * - Flip FB0 with the Primary plane & collect the CRC as ref CRC. + * - Flip FB1 with the Primary plane, collect the CRC & compare with + * the ref CRC. + * + * No CRC mismatch should happen + */ +static void test_compare_crc(data_t *data, enum pipe pipe) +{ + igt_display_t *display = &data->display; + igt_plane_t *primary; + drmModeModeInfo *mode; + igt_crc_t ref_crc, crc; + igt_pipe_crc_t *pipe_crc = NULL; + struct igt_fb fb0, fb1; + igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); + + igt_require_f(output, "No connector found for pipe %s\n", + kmstest_pipe_name(pipe)); + + igt_require_pipe(display, pipe); + igt_display_reset(display); + igt_output_set_pipe(output, pipe); + + mode = igt_output_get_mode(output); + + /* Create two framebuffers with the same color info. */ + igt_create_color_fb(data->drm_fd, + mode->hdisplay, mode->vdisplay, + DRM_FORMAT_XRGB8888, + LOCAL_DRM_FORMAT_MOD_NONE, + 1.0, 1.0, 1.0, + &fb0); + igt_create_color_fb(data->drm_fd, + mode->hdisplay, mode->vdisplay, + DRM_FORMAT_XRGB8888, + LOCAL_DRM_FORMAT_MOD_NONE, + 1.0, 1.0, 1.0, + &fb1); + + /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */ + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); + igt_plane_set_fb(primary, &fb0); + igt_display_commit(display); + + pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, + INTEL_PIPE_CRC_SOURCE_AUTO); + igt_pipe_crc_collect_crc(pipe_crc, &ref_crc); + + /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. */ + igt_plane_set_fb(primary, &fb1); + igt_display_commit(display); + + igt_pipe_crc_collect_crc(pipe_crc, &crc); + igt_assert_crc_equal(&crc, &ref_crc); + + /* Clean-up */ + igt_pipe_crc_free(pipe_crc); + igt_plane_set_fb(primary, NULL); + igt_output_set_pipe(output, PIPE_NONE); + igt_display_commit(display); + + igt_remove_fb(data->drm_fd, &fb0); + igt_remove_fb(data->drm_fd, &fb1); +} + data_t data = {0, }; igt_main @@ -209,6 +278,10 @@ igt_main igt_disallow_hang(data.drm_fd, hang); } + + igt_describe("Basic sanity check for CRC mismatches"); + igt_subtest_f("compare-crc-sanitycheck-pipe-%s", kmstest_pipe_name(pipe)) + test_compare_crc(&data, pipe); } igt_fixture { -- 2.20.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [igt-dev] [PATCH v3 1/2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-08-06 18:33 ` [igt-dev] [PATCH v3 1/2] " Bhanuprakash Modem @ 2020-08-06 10:43 ` Sharma, Swati2 2020-08-06 11:03 ` Karthik B S 1 sibling, 0 replies; 20+ messages in thread From: Sharma, Swati2 @ 2020-08-06 10:43 UTC (permalink / raw) To: Bhanuprakash Modem, igt-dev; +Cc: Petri Latvala LGTM Reviewed-by: Swati Sharma <swati2.sharma@intel.com> On 07-Aug-20 12:03 AM, Bhanuprakash Modem wrote: > We’ve seen multiple CRC related issues on older platforms and > pre-silicon environment, most of the time we end up with debugging. > > This patch works as a crc-sanity test, which can verify that the > CRC mechanism is clean from the platform side before debugging the > actual CRC mismatches or other CRC related issues. > > This patch will create two framebuffers (fb0 & fb1) with the same > color info, flip fb0 with primary plane & collect CRC as reference. > Then flip fb1 with primary plane, collect the CRC and compare with > the reference CRC. There should be no CRC mismatch. > > v2: > * Run subtest to all pipes (Karthik & Swati) > * Fix commit message & few comments (Karthik) > * Use meaningful name for functions (Swati) > * Remove unwanted checks (Karthik) > v3: > * Rename subtest to compare-crc-sanitycheck-pipe- (Petri) > > Cc: Swati Sharma <swati2.sharma@intel.com> > Cc: Karthik B S <karthik.b.s@intel.com> > Cc: Jeevan B <jeevan.b@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> > Cc: Arkadiusz Hiler <arek@hiler.eu> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> > --- > tests/kms_pipe_crc_basic.c | 73 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > > diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c > index cb93c1ad..c3c4cdd8 100644 > --- a/tests/kms_pipe_crc_basic.c > +++ b/tests/kms_pipe_crc_basic.c > @@ -154,6 +154,75 @@ static void test_read_crc(data_t *data, enum pipe pipe, unsigned flags) > } > } > > +/* > + * CRC-sanity test, to make sure there would be no CRC mismatches > + * > + * - Create two framebuffers (FB0 & FB1) with same color info > + * - Flip FB0 with the Primary plane & collect the CRC as ref CRC. > + * - Flip FB1 with the Primary plane, collect the CRC & compare with > + * the ref CRC. > + * > + * No CRC mismatch should happen > + */ > +static void test_compare_crc(data_t *data, enum pipe pipe) > +{ > + igt_display_t *display = &data->display; > + igt_plane_t *primary; > + drmModeModeInfo *mode; > + igt_crc_t ref_crc, crc; > + igt_pipe_crc_t *pipe_crc = NULL; > + struct igt_fb fb0, fb1; > + igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); > + > + igt_require_f(output, "No connector found for pipe %s\n", > + kmstest_pipe_name(pipe)); > + > + igt_require_pipe(display, pipe); > + igt_display_reset(display); > + igt_output_set_pipe(output, pipe); > + > + mode = igt_output_get_mode(output); > + > + /* Create two framebuffers with the same color info. */ > + igt_create_color_fb(data->drm_fd, > + mode->hdisplay, mode->vdisplay, > + DRM_FORMAT_XRGB8888, > + LOCAL_DRM_FORMAT_MOD_NONE, > + 1.0, 1.0, 1.0, > + &fb0); > + igt_create_color_fb(data->drm_fd, > + mode->hdisplay, mode->vdisplay, > + DRM_FORMAT_XRGB8888, > + LOCAL_DRM_FORMAT_MOD_NONE, > + 1.0, 1.0, 1.0, > + &fb1); > + > + /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */ > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > + igt_plane_set_fb(primary, &fb0); > + igt_display_commit(display); > + > + pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, > + INTEL_PIPE_CRC_SOURCE_AUTO); > + igt_pipe_crc_collect_crc(pipe_crc, &ref_crc); > + > + /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. */ > + igt_plane_set_fb(primary, &fb1); > + igt_display_commit(display); > + > + igt_pipe_crc_collect_crc(pipe_crc, &crc); > + igt_assert_crc_equal(&crc, &ref_crc); > + > + /* Clean-up */ > + igt_pipe_crc_free(pipe_crc); > + igt_plane_set_fb(primary, NULL); > + igt_output_set_pipe(output, PIPE_NONE); > + igt_display_commit(display); > + > + igt_remove_fb(data->drm_fd, &fb0); > + igt_remove_fb(data->drm_fd, &fb1); > +} > + > data_t data = {0, }; > > igt_main > @@ -209,6 +278,10 @@ igt_main > > igt_disallow_hang(data.drm_fd, hang); > } > + > + igt_describe("Basic sanity check for CRC mismatches"); > + igt_subtest_f("compare-crc-sanitycheck-pipe-%s", kmstest_pipe_name(pipe)) > + test_compare_crc(&data, pipe); > } > > igt_fixture { > -- ~Swati Sharma _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [igt-dev] [PATCH v3 1/2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-08-06 18:33 ` [igt-dev] [PATCH v3 1/2] " Bhanuprakash Modem 2020-08-06 10:43 ` Sharma, Swati2 @ 2020-08-06 11:03 ` Karthik B S 2020-08-06 13:28 ` Petri Latvala 1 sibling, 1 reply; 20+ messages in thread From: Karthik B S @ 2020-08-06 11:03 UTC (permalink / raw) To: Bhanuprakash Modem, igt-dev; +Cc: Petri Latvala On 8/7/2020 12:03 AM, Bhanuprakash Modem wrote: > We’ve seen multiple CRC related issues on older platforms and > pre-silicon environment, most of the time we end up with debugging. > > This patch works as a crc-sanity test, which can verify that the > CRC mechanism is clean from the platform side before debugging the > actual CRC mismatches or other CRC related issues. > > This patch will create two framebuffers (fb0 & fb1) with the same > color info, flip fb0 with primary plane & collect CRC as reference. > Then flip fb1 with primary plane, collect the CRC and compare with > the reference CRC. There should be no CRC mismatch. > > v2: > * Run subtest to all pipes (Karthik & Swati) > * Fix commit message & few comments (Karthik) > * Use meaningful name for functions (Swati) > * Remove unwanted checks (Karthik) > v3: > * Rename subtest to compare-crc-sanitycheck-pipe- (Petri) > > Cc: Swati Sharma <swati2.sharma@intel.com> > Cc: Karthik B S <karthik.b.s@intel.com> > Cc: Jeevan B <jeevan.b@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> > Cc: Arkadiusz Hiler <arek@hiler.eu> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> > --- > tests/kms_pipe_crc_basic.c | 73 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > > diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c > index cb93c1ad..c3c4cdd8 100644 > --- a/tests/kms_pipe_crc_basic.c > +++ b/tests/kms_pipe_crc_basic.c > @@ -154,6 +154,75 @@ static void test_read_crc(data_t *data, enum pipe pipe, unsigned flags) > } > } > > +/* > + * CRC-sanity test, to make sure there would be no CRC mismatches > + * > + * - Create two framebuffers (FB0 & FB1) with same color info > + * - Flip FB0 with the Primary plane & collect the CRC as ref CRC. > + * - Flip FB1 with the Primary plane, collect the CRC & compare with > + * the ref CRC. > + * > + * No CRC mismatch should happen > + */ > +static void test_compare_crc(data_t *data, enum pipe pipe) > +{ > + igt_display_t *display = &data->display; > + igt_plane_t *primary; > + drmModeModeInfo *mode; > + igt_crc_t ref_crc, crc; > + igt_pipe_crc_t *pipe_crc = NULL; > + struct igt_fb fb0, fb1; > + igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); > + > + igt_require_f(output, "No connector found for pipe %s\n", > + kmstest_pipe_name(pipe)); > + > + igt_require_pipe(display, pipe); This check is redundant as you are already calling 'igt_get_single_output_for_pipe' before this. With this removed, LGTM. Reviewed-by: Karthik B S <karthik.b.s@intel.com> > + igt_display_reset(display); > + igt_output_set_pipe(output, pipe); > + > + mode = igt_output_get_mode(output); > + > + /* Create two framebuffers with the same color info. */ > + igt_create_color_fb(data->drm_fd, > + mode->hdisplay, mode->vdisplay, > + DRM_FORMAT_XRGB8888, > + LOCAL_DRM_FORMAT_MOD_NONE, > + 1.0, 1.0, 1.0, > + &fb0); > + igt_create_color_fb(data->drm_fd, > + mode->hdisplay, mode->vdisplay, > + DRM_FORMAT_XRGB8888, > + LOCAL_DRM_FORMAT_MOD_NONE, > + 1.0, 1.0, 1.0, > + &fb1); > + > + /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */ > + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY); > + igt_plane_set_fb(primary, &fb0); > + igt_display_commit(display); > + > + pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, > + INTEL_PIPE_CRC_SOURCE_AUTO); > + igt_pipe_crc_collect_crc(pipe_crc, &ref_crc); > + > + /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. */ > + igt_plane_set_fb(primary, &fb1); > + igt_display_commit(display); > + > + igt_pipe_crc_collect_crc(pipe_crc, &crc); > + igt_assert_crc_equal(&crc, &ref_crc); > + > + /* Clean-up */ > + igt_pipe_crc_free(pipe_crc); > + igt_plane_set_fb(primary, NULL); > + igt_output_set_pipe(output, PIPE_NONE); > + igt_display_commit(display); > + > + igt_remove_fb(data->drm_fd, &fb0); > + igt_remove_fb(data->drm_fd, &fb1); > +} > + > data_t data = {0, }; > > igt_main > @@ -209,6 +278,10 @@ igt_main > > igt_disallow_hang(data.drm_fd, hang); > } > + > + igt_describe("Basic sanity check for CRC mismatches"); > + igt_subtest_f("compare-crc-sanitycheck-pipe-%s", kmstest_pipe_name(pipe)) > + test_compare_crc(&data, pipe); > } > > igt_fixture { > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [igt-dev] [PATCH v3 1/2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches 2020-08-06 11:03 ` Karthik B S @ 2020-08-06 13:28 ` Petri Latvala 0 siblings, 0 replies; 20+ messages in thread From: Petri Latvala @ 2020-08-06 13:28 UTC (permalink / raw) To: Karthik B S; +Cc: igt-dev On Thu, Aug 06, 2020 at 04:33:01PM +0530, Karthik B S wrote: > > > On 8/7/2020 12:03 AM, Bhanuprakash Modem wrote: > > We’ve seen multiple CRC related issues on older platforms and > > pre-silicon environment, most of the time we end up with debugging. > > > > This patch works as a crc-sanity test, which can verify that the > > CRC mechanism is clean from the platform side before debugging the > > actual CRC mismatches or other CRC related issues. > > > > This patch will create two framebuffers (fb0 & fb1) with the same > > color info, flip fb0 with primary plane & collect CRC as reference. > > Then flip fb1 with primary plane, collect the CRC and compare with > > the reference CRC. There should be no CRC mismatch. > > > > v2: > > * Run subtest to all pipes (Karthik & Swati) > > * Fix commit message & few comments (Karthik) > > * Use meaningful name for functions (Swati) > > * Remove unwanted checks (Karthik) > > v3: > > * Rename subtest to compare-crc-sanitycheck-pipe- (Petri) > > > > Cc: Swati Sharma <swati2.sharma@intel.com> > > Cc: Karthik B S <karthik.b.s@intel.com> > > Cc: Jeevan B <jeevan.b@intel.com> > > Cc: Petri Latvala <petri.latvala@intel.com> > > Cc: Arkadiusz Hiler <arek@hiler.eu> > > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> > > --- > > tests/kms_pipe_crc_basic.c | 73 ++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 73 insertions(+) > > > > diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c > > index cb93c1ad..c3c4cdd8 100644 > > --- a/tests/kms_pipe_crc_basic.c > > +++ b/tests/kms_pipe_crc_basic.c > > @@ -154,6 +154,75 @@ static void test_read_crc(data_t *data, enum pipe pipe, unsigned flags) > > } > > } > > +/* > > + * CRC-sanity test, to make sure there would be no CRC mismatches > > + * > > + * - Create two framebuffers (FB0 & FB1) with same color info > > + * - Flip FB0 with the Primary plane & collect the CRC as ref CRC. > > + * - Flip FB1 with the Primary plane, collect the CRC & compare with > > + * the ref CRC. > > + * > > + * No CRC mismatch should happen > > + */ > > +static void test_compare_crc(data_t *data, enum pipe pipe) > > +{ > > + igt_display_t *display = &data->display; > > + igt_plane_t *primary; > > + drmModeModeInfo *mode; > > + igt_crc_t ref_crc, crc; > > + igt_pipe_crc_t *pipe_crc = NULL; > > + struct igt_fb fb0, fb1; > > + igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); > > + > > + igt_require_f(output, "No connector found for pipe %s\n", > > + kmstest_pipe_name(pipe)); > > + > > + igt_require_pipe(display, pipe); > > This check is redundant as you are already calling > 'igt_get_single_output_for_pipe' before this. > > With this removed, LGTM. > Reviewed-by: Karthik B S <karthik.b.s@intel.com> I was planning to remove this while merging but forgot =( -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2020-08-06 13:29 UTC | newest] Thread overview: 20+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-07-29 22:29 [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem 2020-07-29 15:03 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork 2020-07-30 11:27 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev2) Patchwork 2020-07-30 13:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2020-08-05 11:43 ` [igt-dev] [PATCH] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Karthik B S 2020-08-05 12:32 ` Sharma, Swati2 2020-08-06 5:16 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: Sanity check for CRC mismatches (rev3) Patchwork 2020-08-06 6:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2020-08-06 12:44 ` [igt-dev] [PATCH v2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem 2020-08-06 8:16 ` Petri Latvala 2020-08-06 8:30 ` Modem, Bhanuprakash 2020-08-06 18:04 ` [igt-dev] [PATCH v3 1/2] " Bhanuprakash Modem 2020-08-06 18:04 ` [igt-dev] [PATCH v1 2/2] intel-ci: Add compare CRC sanity test to BAT Bhanuprakash Modem 2020-08-06 10:20 ` Petri Latvala 2020-08-06 18:04 ` [igt-dev] [PATCH v3 0/2] tests/kms_pipe_crc_basic: Sanity check for CRC mismatches Bhanuprakash Modem -- strict thread matches above, loose matches on Subject: below -- 2020-08-06 18:07 Bhanuprakash Modem 2020-08-06 18:07 ` [igt-dev] [PATCH v3 1/2] " Bhanuprakash Modem 2020-08-06 18:33 [igt-dev] [PATCH v3 0/2] " Bhanuprakash Modem 2020-08-06 18:33 ` [igt-dev] [PATCH v3 1/2] " Bhanuprakash Modem 2020-08-06 10:43 ` Sharma, Swati2 2020-08-06 11:03 ` Karthik B S 2020-08-06 13:28 ` Petri Latvala
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox