public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 0/3] Fixes for some kms-related DG1 tests
@ 2021-08-19 11:59 Thomas Hellström
  2021-08-19 11:59 ` [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Thomas Hellström
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Thomas Hellström @ 2021-08-19 11:59 UTC (permalink / raw)
  To: igt-dev
  Cc: apoorva1.singh, zbigniew.kempczynski, Thomas Hellström,
	Daniel Vetter

A set of fixes to help DG1 BAT turn green.
At least With IGT softpinning changes, Patch 1 and 2 makes kms_addfb_basic
turn green or get skipped. Patch 3 is a first step towards getting
igt@kms_frontbuffer_tracking@basic working. It might be we should skip the
test completely for DG1 instead. Opinions?

Patch 2 originally carried the following FIXME:
Skipping subtests when get/set tiling IOCTLs are not supported is a
temporary workaround - we should extend these tests by using modifiers
to change the properties of the framebuffer.

Ramalingam C (1):
  lib/igt_fb: Support fbs backed by local memory

Vanshidhar Konda (2):
  lib/ioctl_wrappers: Query if device supports set/get legacy tiling
  tests/kms_addfb_basic: Skip tiling subtests on device without hw
    tiling

 lib/igt_fb.c            |  4 +++-
 lib/ioctl_wrappers.c    | 17 +++++++++++++++++
 lib/ioctl_wrappers.h    |  1 +
 tests/kms_addfb_basic.c |  4 ++++
 4 files changed, 25 insertions(+), 1 deletion(-)

Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Apoorva Singh <apoorva1.singh@intel.com>
-- 
2.31.1

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling
@ 2020-01-20 22:03 Imre Deak
  0 siblings, 0 replies; 10+ messages in thread
From: Imre Deak @ 2020-01-20 22:03 UTC (permalink / raw)
  To: igt-dev

From: Vanshidhar Konda <vanshidhar.r.konda@intel.com>

Add a method to query if the device supports setting and getting legacy
tiling formats for buffer objects.

Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 lib/ioctl_wrappers.c | 17 +++++++++++++++++
 lib/ioctl_wrappers.h |  1 +
 2 files changed, 18 insertions(+)

diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 627717d2..c1abb575 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -133,6 +133,23 @@ __gem_get_tiling(int fd, struct drm_i915_gem_get_tiling *arg)
 	return err;
 }
 
+/**
+ * gem_has_legacy_hw_tiling:
+ * @fd: open i915 drm file descriptor
+ *
+ * Feature check to query if the device supports setting/getting
+ * legacy tiling formats for buffer objects
+ *
+ * Returns: True if tiling is supported
+ */
+bool
+gem_has_legacy_hw_tiling(int fd)
+{
+	struct drm_i915_gem_get_tiling arg = {};
+
+	return (__gem_get_tiling(fd, &arg) != -EOPNOTSUPP);
+}
+
 /**
  * gem_get_tiling:
  * @fd: open i915 drm file descriptor
diff --git a/lib/ioctl_wrappers.h b/lib/ioctl_wrappers.h
index 7614e688..0ea77738 100644
--- a/lib/ioctl_wrappers.h
+++ b/lib/ioctl_wrappers.h
@@ -146,6 +146,7 @@ void gem_require_caching(int fd);
 void gem_require_ring(int fd, unsigned ring);
 bool gem_has_mocs_registers(int fd);
 void gem_require_mocs_registers(int fd);
+bool gem_has_legacy_hw_tiling(int fd);
 
 #define gem_has_ring(f, r) gem_context_has_engine(f, 0, r)
 
-- 
2.23.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-08-19 16:44 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-19 11:59 [igt-dev] [PATCH i-g-t 0/3] Fixes for some kms-related DG1 tests Thomas Hellström
2021-08-19 11:59 ` [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Thomas Hellström
2021-08-19 16:26   ` Ville Syrjälä
2021-08-19 11:59 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_addfb_basic: Skip tiling subtests on device without hw tiling Thomas Hellström
2021-08-19 16:42   ` Ville Syrjälä
2021-08-19 11:59 ` [igt-dev] [PATCH i-g-t 3/3] lib/igt_fb: Support fbs backed by local memory Thomas Hellström
2021-08-19 16:44   ` Ville Syrjälä
2021-08-19 12:38 ` [igt-dev] ✓ Fi.CI.BAT: success for Fixes for some kms-related DG1 tests Patchwork
2021-08-19 14:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2020-01-20 22:03 [igt-dev] [PATCH i-g-t 1/3] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Imre Deak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox