* [igt-dev] [PATCH i-g-t 0/3] Fix kms_cursor_legacy ENOSPC issue
@ 2023-01-11 18:12 Zbigniew Kempczyński
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 1/3] lib/intel_allocator: Fix alignment variable used in debug path Zbigniew Kempczyński
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Zbigniew Kempczyński @ 2023-01-11 18:12 UTC (permalink / raw)
To: igt-dev
Previously we had luck when framebuffer offset was after bb offset
so objects didn't overlap. When reloc allocator started to keep
offsets for same handle to avoid rebind batch from second spinner
started overlapping framebuffer in the allocator leading ENOSPC.
Additionally series has allocator debug fix which I noticed during
debugging this issue.
Zbigniew Kempczyński (3):
lib/intel_allocator: Fix alignment variable used in debug path
lib/igt_dummyload: Don't assume dependency object size
tests/kms_cursor_legacy: Add dependency size for spinner creation
lib/igt_dummyload.c | 4 +++-
lib/igt_dummyload.h | 1 +
lib/intel_allocator.c | 2 +-
tests/kms_cursor_legacy.c | 3 ++-
4 files changed, 7 insertions(+), 3 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 1/3] lib/intel_allocator: Fix alignment variable used in debug path
2023-01-11 18:12 [igt-dev] [PATCH i-g-t 0/3] Fix kms_cursor_legacy ENOSPC issue Zbigniew Kempczyński
@ 2023-01-11 18:12 ` Zbigniew Kempczyński
2023-01-12 12:17 ` Kamil Konieczny
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_dummyload: Don't assume dependency object size Zbigniew Kempczyński
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Zbigniew Kempczyński @ 2023-01-11 18:12 UTC (permalink / raw)
To: igt-dev
During work on allocator I've missed alignment was replaced by
default_alignment what makes a compilation error when debug path
is enabled.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/intel_allocator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/intel_allocator.c b/lib/intel_allocator.c
index 060a65ce18..2b08dd5996 100644
--- a/lib/intel_allocator.c
+++ b/lib/intel_allocator.c
@@ -351,7 +351,7 @@ static struct allocator *allocator_open(int fd, uint32_t ctx, uint32_t vm,
"default alignment: 0x%llx "
"not found, creating one\n",
fd, ctx, vm, (long long) start, (long long) end,
- (long long) alignment);
+ (long long) default_alignment);
ial = intel_allocator_create(fd, start, end, allocator_type,
allocator_strategy,
default_alignment);
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 2/3] lib/igt_dummyload: Don't assume dependency object size
2023-01-11 18:12 [igt-dev] [PATCH i-g-t 0/3] Fix kms_cursor_legacy ENOSPC issue Zbigniew Kempczyński
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 1/3] lib/intel_allocator: Fix alignment variable used in debug path Zbigniew Kempczyński
@ 2023-01-11 18:12 ` Zbigniew Kempczyński
2023-01-12 12:18 ` Kamil Konieczny
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_cursor_legacy: Add dependency size for spinner creation Zbigniew Kempczyński
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Zbigniew Kempczyński @ 2023-01-11 18:12 UTC (permalink / raw)
To: igt-dev
Most of the tests use page size for dependency object so spinner
had this value hardcoded as a default. But there're exceptions
where dependency object is bigger and for softpin path we need to
allow pass this size to properly acquire offsets from the allocator.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/igt_dummyload.c | 4 +++-
lib/igt_dummyload.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/igt_dummyload.c b/lib/igt_dummyload.c
index 17ae21f567..5f3c6b10c7 100644
--- a/lib/igt_dummyload.c
+++ b/lib/igt_dummyload.c
@@ -186,10 +186,12 @@ emit_recursive_batch(igt_spin_t *spin,
addr += BATCH_SIZE;
if (opts->dependency) {
+ uint64_t dep_size = opts->dependency_size ?: BATCH_SIZE;
+
igt_assert(!(opts->flags & IGT_SPIN_POLL_RUN));
if (ahnd)
addr_scratch = intel_allocator_alloc_with_strategy(ahnd, opts->dependency,
- BATCH_SIZE, 0,
+ dep_size, 0,
ALLOC_STRATEGY_LOW_TO_HIGH);
else
addr_scratch = addr;
diff --git a/lib/igt_dummyload.h b/lib/igt_dummyload.h
index b33507971b..b247ab02b2 100644
--- a/lib/igt_dummyload.h
+++ b/lib/igt_dummyload.h
@@ -49,6 +49,7 @@ typedef struct igt_spin_factory {
uint32_t ctx_id;
const intel_ctx_t *ctx;
uint32_t dependency;
+ uint64_t dependency_size;
unsigned int engine;
unsigned int flags;
int fence;
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 3/3] tests/kms_cursor_legacy: Add dependency size for spinner creation
2023-01-11 18:12 [igt-dev] [PATCH i-g-t 0/3] Fix kms_cursor_legacy ENOSPC issue Zbigniew Kempczyński
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 1/3] lib/intel_allocator: Fix alignment variable used in debug path Zbigniew Kempczyński
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_dummyload: Don't assume dependency object size Zbigniew Kempczyński
@ 2023-01-11 18:12 ` Zbigniew Kempczyński
2023-01-12 13:07 ` Kamil Konieczny
2023-01-12 13:23 ` Kamil Konieczny
2023-01-11 19:06 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix kms_cursor_legacy ENOSPC issue Patchwork
2023-01-12 2:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 2 replies; 10+ messages in thread
From: Zbigniew Kempczyński @ 2023-01-11 18:12 UTC (permalink / raw)
To: igt-dev
Fix the bug where lack of information about dependency object size
during spinner creation may lead to object overlapping and failing
with ENOSPC.
Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/7681
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
tests/kms_cursor_legacy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index 6b75e98cb8..f1e55906a0 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -1471,7 +1471,8 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
spin = igt_spin_new(display->drm_fd,
.ahnd = ahnd,
- .dependency = fb_info[1].gem_handle);
+ .dependency = fb_info[1].gem_handle,
+ .dependency_size = fb_info[1].size);
vblank_start = kmstest_get_vblank(display->drm_fd, pipe, DRM_VBLANK_NEXTONMISS);
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Fix kms_cursor_legacy ENOSPC issue
2023-01-11 18:12 [igt-dev] [PATCH i-g-t 0/3] Fix kms_cursor_legacy ENOSPC issue Zbigniew Kempczyński
` (2 preceding siblings ...)
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_cursor_legacy: Add dependency size for spinner creation Zbigniew Kempczyński
@ 2023-01-11 19:06 ` Patchwork
2023-01-12 2:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-01-11 19:06 UTC (permalink / raw)
To: Zbigniew Kempczyński; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 2716 bytes --]
== Series Details ==
Series: Fix kms_cursor_legacy ENOSPC issue
URL : https://patchwork.freedesktop.org/series/112687/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12574 -> IGTPW_8327
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/index.html
Participating hosts (35 -> 34)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8327 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-rkl-11600: NOTRUN -> [SKIP][1] ([i915#7828])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/fi-rkl-11600/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
#### Possible fixes ####
* igt@fbdev@write:
- fi-blb-e6850: [SKIP][2] ([fdo#109271]) -> [PASS][3] +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/fi-blb-e6850/igt@fbdev@write.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/fi-blb-e6850/igt@fbdev@write.html
* igt@i915_pm_rpm@module-reload:
- bat-dg1-5: [SKIP][4] -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/bat-dg1-5/igt@i915_pm_rpm@module-reload.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/bat-dg1-5/igt@i915_pm_rpm@module-reload.html
#### Warnings ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [INCOMPLETE][6] ([i915#4817]) -> [FAIL][7] ([fdo#103375])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7116 -> IGTPW_8327
CI-20190529: 20190529
CI_DRM_12574: bf7f7c53ac622a3f6d6738d062e59dd21ce28bd7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8327: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/index.html
IGT_7116: 79eb8984acd309108be713a8831e60667db67e21 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
-igt@perf@open-race
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/index.html
[-- Attachment #2: Type: text/html, Size: 3385 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Fix kms_cursor_legacy ENOSPC issue
2023-01-11 18:12 [igt-dev] [PATCH i-g-t 0/3] Fix kms_cursor_legacy ENOSPC issue Zbigniew Kempczyński
` (3 preceding siblings ...)
2023-01-11 19:06 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix kms_cursor_legacy ENOSPC issue Patchwork
@ 2023-01-12 2:07 ` Patchwork
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-01-12 2:07 UTC (permalink / raw)
To: Zbigniew Kempczyński; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 23354 bytes --]
== Series Details ==
Series: Fix kms_cursor_legacy ENOSPC issue
URL : https://patchwork.freedesktop.org/series/112687/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12574_full -> IGTPW_8327_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/index.html
Participating hosts (13 -> 9)
------------------------------
Missing (4): shard-rkl0 pig-kbl-iris pig-glk-j5005 pig-skl-6260u
Known issues
------------
Here are the changes found in IGTPW_8327_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: NOTRUN -> [FAIL][1] ([i915#2842])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-glk9/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_lmem_swapping@heavy-multi:
- shard-apl: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-apl7/igt@gem_lmem_swapping@heavy-multi.html
* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-glk6/igt@gem_lmem_swapping@heavy-verify-random-ccs.html
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][4] ([i915#2658])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-apl6/igt@gem_pread@exhaustion.html
- shard-glk: NOTRUN -> [WARN][5] ([i915#2658])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-glk6/igt@gem_pread@exhaustion.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][6] -> [DMESG-WARN][7] ([i915#5566] / [i915#716])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-apl2/igt@gen9_exec_parse@allowed-single.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-apl7/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-glk: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#658])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-glk7/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_suspend@basic-s3-without-i915:
- shard-snb: [PASS][9] -> [INCOMPLETE][10] ([i915#4528] / [i915#4817])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-snb7/igt@i915_suspend@basic-s3-without-i915.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-snb2/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#3886]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-apl2/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#3886]) +4 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-glk6/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium_color@ctm-blue-to-red:
- shard-glk: NOTRUN -> [SKIP][13] ([fdo#109271]) +54 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-glk6/igt@kms_chamelium_color@ctm-blue-to-red.html
* igt@kms_chamelium_hpd@hdmi-hpd-storm:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271]) +105 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-apl3/igt@kms_chamelium_hpd@hdmi-hpd-storm.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#658]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-apl6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-apl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#2437])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-apl3/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf@stress-open-close:
- shard-glk: [PASS][17] -> [INCOMPLETE][18] ([i915#5213])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-glk2/igt@perf@stress-open-close.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-glk4/igt@perf@stress-open-close.html
* igt@runner@aborted:
- shard-apl: NOTRUN -> [FAIL][19] ([fdo#109271] / [i915#4312])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-apl7/igt@runner@aborted.html
- shard-glk: NOTRUN -> [FAIL][20] ([i915#4312])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-glk4/igt@runner@aborted.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#2994]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-apl3/igt@sysfs_clients@fair-7.html
#### Possible fixes ####
* igt@drm_fdinfo@idle@rcs0:
- {shard-rkl}: [FAIL][22] ([i915#7742]) -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-4/igt@drm_fdinfo@idle@rcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-3/igt@drm_fdinfo@idle@rcs0.html
* igt@fbdev@unaligned-write:
- {shard-rkl}: [SKIP][24] ([i915#2582]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-5/igt@fbdev@unaligned-write.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-6/igt@fbdev@unaligned-write.html
* igt@gem_ctx_persistence@hang:
- {shard-rkl}: [SKIP][26] ([i915#6252]) -> [PASS][27] +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-5/igt@gem_ctx_persistence@hang.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-1/igt@gem_ctx_persistence@hang.html
* igt@gem_eio@unwedge-stress:
- {shard-dg1}: [FAIL][28] ([i915#5784]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-dg1-13/igt@gem_eio@unwedge-stress.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-dg1-15/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [FAIL][30] ([i915#2842]) -> [PASS][31] +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-glk3/igt@gem_exec_fair@basic-pace@vcs0.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-glk6/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_reloc@basic-cpu-wc:
- {shard-rkl}: [SKIP][32] ([i915#3281]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-3/igt@gem_exec_reloc@basic-cpu-wc.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-5/igt@gem_exec_reloc@basic-cpu-wc.html
* igt@gen9_exec_parse@bb-start-cmd:
- {shard-rkl}: [SKIP][34] ([i915#2527]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-3/igt@gen9_exec_parse@bb-start-cmd.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-5/igt@gen9_exec_parse@bb-start-cmd.html
* igt@i915_pm_dc@dc5-psr:
- {shard-rkl}: [SKIP][36] ([i915#658]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-5/igt@i915_pm_dc@dc5-psr.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-6/igt@i915_pm_dc@dc5-psr.html
* igt@i915_pm_dc@dc6-dpms:
- {shard-rkl}: [SKIP][38] ([i915#3361]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-5/igt@i915_pm_dc@dc6-dpms.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-3/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-dg1}: [FAIL][40] ([i915#3591]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-dg1-19/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- {shard-dg1}: [SKIP][42] ([i915#1397]) -> [PASS][43] +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-dg1-14/igt@i915_pm_rpm@dpms-non-lpsp.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-dg1-19/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- {shard-dg1}: [FAIL][44] ([i915#7681]) -> [PASS][45] +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-dg1-13/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-dg1-18/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][46] ([i915#2346]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- {shard-rkl}: [SKIP][48] ([i915#1849] / [i915#4098]) -> [PASS][49] +12 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-4/igt@kms_frontbuffer_tracking@fbc-badstride.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_properties@crtc-properties-atomic:
- {shard-rkl}: [SKIP][50] ([i915#1849]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-2/igt@kms_properties@crtc-properties-atomic.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-6/igt@kms_properties@crtc-properties-atomic.html
* igt@kms_psr@cursor_blt:
- {shard-rkl}: [SKIP][52] ([i915#1072]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-4/igt@kms_psr@cursor_blt.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-6/igt@kms_psr@cursor_blt.html
* igt@kms_vblank@pipe-b-query-idle:
- {shard-rkl}: [SKIP][54] ([i915#1845] / [i915#4098]) -> [PASS][55] +17 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-2/igt@kms_vblank@pipe-b-query-idle.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-6/igt@kms_vblank@pipe-b-query-idle.html
* igt@perf_pmu@idle@rcs0:
- {shard-dg1}: [FAIL][56] ([i915#4349]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-dg1-14/igt@perf_pmu@idle@rcs0.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-dg1-19/igt@perf_pmu@idle@rcs0.html
- {shard-rkl}: [FAIL][58] ([i915#4349]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-2/igt@perf_pmu@idle@rcs0.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-4/igt@perf_pmu@idle@rcs0.html
* igt@prime_vgem@basic-fence-flip:
- {shard-rkl}: [SKIP][60] ([fdo#109295] / [i915#3708] / [i915#4098]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-5/igt@prime_vgem@basic-fence-flip.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-6/igt@prime_vgem@basic-fence-flip.html
* igt@syncobj_timeline@reset-during-wait-for-submit:
- {shard-dg1}: [DMESG-WARN][62] ([i915#1982]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-dg1-13/igt@syncobj_timeline@reset-during-wait-for-submit.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-dg1-17/igt@syncobj_timeline@reset-during-wait-for-submit.html
* igt@testdisplay:
- {shard-rkl}: [SKIP][64] ([i915#4098]) -> [PASS][65] +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12574/shard-rkl-3/igt@testdisplay.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/shard-rkl-6/igt@testdisplay.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7681]: https://gitlab.freedesktop.org/drm/intel/issues/7681
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7116 -> IGTPW_8327
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12574: bf7f7c53ac622a3f6d6738d062e59dd21ce28bd7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8327: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/index.html
IGT_7116: 79eb8984acd309108be713a8831e60667db67e21 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8327/index.html
[-- Attachment #2: Type: text/html, Size: 18730 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] lib/intel_allocator: Fix alignment variable used in debug path
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 1/3] lib/intel_allocator: Fix alignment variable used in debug path Zbigniew Kempczyński
@ 2023-01-12 12:17 ` Kamil Konieczny
0 siblings, 0 replies; 10+ messages in thread
From: Kamil Konieczny @ 2023-01-12 12:17 UTC (permalink / raw)
To: igt-dev
On 2023-01-11 at 19:12:03 +0100, Zbigniew Kempczyński wrote:
> During work on allocator I've missed alignment was replaced by
> default_alignment what makes a compilation error when debug path
> is enabled.
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> lib/intel_allocator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/intel_allocator.c b/lib/intel_allocator.c
> index 060a65ce18..2b08dd5996 100644
> --- a/lib/intel_allocator.c
> +++ b/lib/intel_allocator.c
> @@ -351,7 +351,7 @@ static struct allocator *allocator_open(int fd, uint32_t ctx, uint32_t vm,
> "default alignment: 0x%llx "
> "not found, creating one\n",
> fd, ctx, vm, (long long) start, (long long) end,
> - (long long) alignment);
> + (long long) default_alignment);
> ial = intel_allocator_create(fd, start, end, allocator_type,
> allocator_strategy,
> default_alignment);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/3] lib/igt_dummyload: Don't assume dependency object size
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_dummyload: Don't assume dependency object size Zbigniew Kempczyński
@ 2023-01-12 12:18 ` Kamil Konieczny
0 siblings, 0 replies; 10+ messages in thread
From: Kamil Konieczny @ 2023-01-12 12:18 UTC (permalink / raw)
To: igt-dev
On 2023-01-11 at 19:12:04 +0100, Zbigniew Kempczyński wrote:
> Most of the tests use page size for dependency object so spinner
> had this value hardcoded as a default. But there're exceptions
> where dependency object is bigger and for softpin path we need to
> allow pass this size to properly acquire offsets from the allocator.
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> lib/igt_dummyload.c | 4 +++-
> lib/igt_dummyload.h | 1 +
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lib/igt_dummyload.c b/lib/igt_dummyload.c
> index 17ae21f567..5f3c6b10c7 100644
> --- a/lib/igt_dummyload.c
> +++ b/lib/igt_dummyload.c
> @@ -186,10 +186,12 @@ emit_recursive_batch(igt_spin_t *spin,
> addr += BATCH_SIZE;
>
> if (opts->dependency) {
> + uint64_t dep_size = opts->dependency_size ?: BATCH_SIZE;
> +
> igt_assert(!(opts->flags & IGT_SPIN_POLL_RUN));
> if (ahnd)
> addr_scratch = intel_allocator_alloc_with_strategy(ahnd, opts->dependency,
> - BATCH_SIZE, 0,
> + dep_size, 0,
> ALLOC_STRATEGY_LOW_TO_HIGH);
> else
> addr_scratch = addr;
> diff --git a/lib/igt_dummyload.h b/lib/igt_dummyload.h
> index b33507971b..b247ab02b2 100644
> --- a/lib/igt_dummyload.h
> +++ b/lib/igt_dummyload.h
> @@ -49,6 +49,7 @@ typedef struct igt_spin_factory {
> uint32_t ctx_id;
> const intel_ctx_t *ctx;
> uint32_t dependency;
> + uint64_t dependency_size;
> unsigned int engine;
> unsigned int flags;
> int fence;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] tests/kms_cursor_legacy: Add dependency size for spinner creation
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_cursor_legacy: Add dependency size for spinner creation Zbigniew Kempczyński
@ 2023-01-12 13:07 ` Kamil Konieczny
2023-01-12 13:23 ` Kamil Konieczny
1 sibling, 0 replies; 10+ messages in thread
From: Kamil Konieczny @ 2023-01-12 13:07 UTC (permalink / raw)
To: igt-dev
On 2023-01-11 at 19:12:05 +0100, Zbigniew Kempczyński wrote:
> Fix the bug where lack of information about dependency object size
> during spinner creation may lead to object overlapping and failing
> with ENOSPC.
>
> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/7681
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
https://patchwork.freedesktop.org/series/112687/
> ---
> tests/kms_cursor_legacy.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index 6b75e98cb8..f1e55906a0 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -1471,7 +1471,8 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
>
> spin = igt_spin_new(display->drm_fd,
> .ahnd = ahnd,
> - .dependency = fb_info[1].gem_handle);
> + .dependency = fb_info[1].gem_handle,
> + .dependency_size = fb_info[1].size);
>
> vblank_start = kmstest_get_vblank(display->drm_fd, pipe, DRM_VBLANK_NEXTONMISS);
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] tests/kms_cursor_legacy: Add dependency size for spinner creation
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_cursor_legacy: Add dependency size for spinner creation Zbigniew Kempczyński
2023-01-12 13:07 ` Kamil Konieczny
@ 2023-01-12 13:23 ` Kamil Konieczny
1 sibling, 0 replies; 10+ messages in thread
From: Kamil Konieczny @ 2023-01-12 13:23 UTC (permalink / raw)
To: igt-dev
On 2023-01-11 at 19:12:05 +0100, Zbigniew Kempczyński wrote:
> Fix the bug where lack of information about dependency object size
> during spinner creation may lead to object overlapping and failing
> with ENOSPC.
>
> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/7681
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> tests/kms_cursor_legacy.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index 6b75e98cb8..f1e55906a0 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -1471,7 +1471,8 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
>
> spin = igt_spin_new(display->drm_fd,
> .ahnd = ahnd,
> - .dependency = fb_info[1].gem_handle);
> + .dependency = fb_info[1].gem_handle,
> + .dependency_size = fb_info[1].size);
>
> vblank_start = kmstest_get_vblank(display->drm_fd, pipe, DRM_VBLANK_NEXTONMISS);
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-01-12 13:23 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-11 18:12 [igt-dev] [PATCH i-g-t 0/3] Fix kms_cursor_legacy ENOSPC issue Zbigniew Kempczyński
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 1/3] lib/intel_allocator: Fix alignment variable used in debug path Zbigniew Kempczyński
2023-01-12 12:17 ` Kamil Konieczny
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_dummyload: Don't assume dependency object size Zbigniew Kempczyński
2023-01-12 12:18 ` Kamil Konieczny
2023-01-11 18:12 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_cursor_legacy: Add dependency size for spinner creation Zbigniew Kempczyński
2023-01-12 13:07 ` Kamil Konieczny
2023-01-12 13:23 ` Kamil Konieczny
2023-01-11 19:06 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix kms_cursor_legacy ENOSPC issue Patchwork
2023-01-12 2:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox