[igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT

Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed

* [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT
@ 2023-04-13 16:27 Bhanuprakash Modem
  2023-04-13 16:27 ` [igt-dev] [i-g-t 1/7] lib/intel_bufops: Fix bops creation to support XE Bhanuprakash Modem
                   ` (10 more replies)
  0 siblings, 11 replies; 19+ messages in thread
From: Bhanuprakash Modem @ 2023-04-13 16:27 UTC (permalink / raw)
  To: igt-dev

Add kms tests to XE BAT and update tests to support XE device.
- kms_chamelium_*
- kms_cursor_legacy
- kms_flip
- kms_pipe_crc_basic
- kms_psr

Note: Tests are expected to fail, as intel_bb changes for XE is not
yet landed in IGT lib.

Bhanuprakash Modem (7):
  lib/intel_bufops: Fix bops creation to support XE
  lib/igt_fb: Add copy engine support for XE
  lib: Use i915 namespace for XE debugfs
  tests/kms_cursor_legacy: Add XE support
  tests/kms_flip: Add XE support
  tests/i915/kms_psr: Add XE support
  xe-fast-feedback: Add kms tests to XE BAT

 lib/igt_fb.c                             | 30 +++++++++++++++---
 lib/igt_fb.h                             |  2 ++
 lib/igt_kms.c                            |  2 +-
 lib/igt_psr.c                            |  4 +--
 lib/intel_bufops.c                       | 19 ++++++++++++
 tests/i915/kms_psr.c                     | 39 ++++++++++++++++++++----
 tests/i915/kms_psr2_sf.c                 |  2 +-
 tests/i915/kms_psr2_su.c                 |  2 +-
 tests/i915/kms_psr_stress_test.c         |  2 +-
 tests/intel-ci/xe-fast-feedback.testlist | 31 +++++++++++++++++++
 tests/kms_cursor_legacy.c                |  3 +-
 tests/kms_flip.c                         | 35 +++++++++++++++------
 12 files changed, 145 insertions(+), 26 deletions(-)

--
2.40.0

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [igt-dev] [i-g-t 1/7] lib/intel_bufops: Fix bops creation to support XE
  2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
@ 2023-04-13 16:27 ` Bhanuprakash Modem
  2023-04-17 10:57   ` Zbigniew Kempczyński
  2023-04-13 16:27 ` [igt-dev] [i-g-t 2/7] lib/igt_fb: Add copy engine support for XE Bhanuprakash Modem
                   ` (9 subsequent siblings)
  10 siblings, 1 reply; 19+ messages in thread
From: Bhanuprakash Modem @ 2023-04-13 16:27 UTC (permalink / raw)
  To: igt-dev

As XE won't support tiling, fix the bops creation logic to
support XE device.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 lib/intel_bufops.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c
index cdc7a1698b2..81f7b951813 100644
--- a/lib/intel_bufops.c
+++ b/lib/intel_bufops.c
@@ -1423,6 +1423,25 @@ static struct buf_ops *__buf_ops_create(int fd, bool check_idempotency)
 	igt_debug("generation: %d, supported tiles: 0x%02x\n",
 		  bops->intel_gen, bops->supported_tiles);
 
+	/* No tiling support in XE. */
+	if (is_xe_device(fd)) {
+		bops->supported_tiles = TILE_NONE;
+		bops->supported_hw_tiles = TILE_NONE;
+
+		bops->linear_to_x = NULL;
+		bops->x_to_linear = NULL;
+		bops->linear_to_y = NULL;
+		bops->y_to_linear = NULL;
+		bops->linear_to_tile4 = NULL;
+		bops->tile4_to_linear = NULL;
+		bops->linear_to_yf = NULL;
+		bops->yf_to_linear = NULL;
+		bops->linear_to_ys = NULL;
+		bops->ys_to_linear = NULL;
+
+		return bops;
+	}
+
 	/*
 	 * Warning!
 	 *
-- 
2.40.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [igt-dev] [i-g-t 2/7] lib/igt_fb: Add copy engine support for XE
  2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
  2023-04-13 16:27 ` [igt-dev] [i-g-t 1/7] lib/intel_bufops: Fix bops creation to support XE Bhanuprakash Modem
@ 2023-04-13 16:27 ` Bhanuprakash Modem
  2023-04-13 16:27 ` [igt-dev] [i-g-t 3/7] lib: Use i915 namespace for XE debugfs Bhanuprakash Modem
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 19+ messages in thread
From: Bhanuprakash Modem @ 2023-04-13 16:27 UTC (permalink / raw)
  To: igt-dev

Add copy engine support for kms framebuffer mappings.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 lib/igt_fb.c | 30 ++++++++++++++++++++++++++----
 lib/igt_fb.h |  2 ++
 2 files changed, 28 insertions(+), 4 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 7379b99aa8a..7bcba5c0cc8 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -45,6 +45,7 @@
 #include "igt_amd.h"
 #include "igt_x86.h"
 #include "igt_nouveau.h"
+#include "igt_syncobj.h"
 #include "ioctl_wrappers.h"
 #include "intel_batchbuffer.h"
 #include "intel_chipset.h"
@@ -2489,12 +2490,13 @@ static bool blitter_ok(const struct igt_fb *fb)
 
 static bool use_enginecopy(const struct igt_fb *fb)
 {
-	if (blitter_ok(fb))
+	if (!is_xe_device(fb->fd) && blitter_ok(fb))
 		return false;
 
 	return fb->modifier == I915_FORMAT_MOD_Yf_TILED ||
 	       is_ccs_modifier(fb->modifier) ||
-	       !gem_has_mappable_ggtt(fb->fd);
+	       (is_xe_device(fb->fd) && fb->modifier == DRM_FORMAT_MOD_LINEAR) ||
+	       (is_i915_device(fb->fd) && !gem_has_mappable_ggtt(fb->fd));
 }
 
 static bool use_blitter(const struct igt_fb *fb)
@@ -2504,7 +2506,7 @@ static bool use_blitter(const struct igt_fb *fb)
 
 	return fb->modifier == I915_FORMAT_MOD_Y_TILED ||
 	       fb->modifier == I915_FORMAT_MOD_Yf_TILED ||
-	       !gem_has_mappable_ggtt(fb->fd);
+	       (is_i915_device(fb->fd) && !gem_has_mappable_ggtt(fb->fd));
 }
 
 static void init_buf_ccs(struct intel_buf *buf, int ccs_idx,
@@ -2701,7 +2703,7 @@ static void blitcopy(const struct igt_fb *dst_fb,
 	src_tiling = igt_fb_mod_to_tiling(src_fb->modifier);
 	dst_tiling = igt_fb_mod_to_tiling(dst_fb->modifier);
 
-	if (!gem_has_relocations(dst_fb->fd)) {
+	if (is_i915_device(dst_fb->fd) && !gem_has_relocations(dst_fb->fd)) {
 		igt_require(gem_has_contexts(dst_fb->fd));
 		ctx = gem_context_create(dst_fb->fd);
 		ahnd = get_reloc_ahnd(dst_fb->fd, ctx);
@@ -2781,6 +2783,12 @@ static void free_linear_mapping(struct fb_blit_upload *blit)
 	} else if (is_nouveau_device(fd)) {
 		igt_nouveau_fb_blit(fb, &linear->fb);
 		igt_nouveau_delete_bo(&linear->fb);
+	} else if (is_xe_device(fd)) {
+		gem_munmap(linear->map, linear->fb.size);
+		copy_with_engine(blit, fb, &linear->fb);
+
+		/* TODO: Syncobj_wait to sync for last used engine. */
+		gem_close(fd, linear->fb.gem_handle);
 	} else {
 		gem_munmap(linear->map, linear->fb.size);
 		gem_set_domain(fd, linear->fb.gem_handle,
@@ -2858,6 +2866,11 @@ static void setup_linear_mapping(struct fb_blit_upload *blit)
 		igt_nouveau_fb_blit(&linear->fb, fb);
 
 		linear->map = igt_nouveau_mmap_bo(&linear->fb, PROT_READ | PROT_WRITE);
+	} else if (is_xe_device(fd)) {
+		copy_with_engine(blit, &linear->fb, fb);
+
+		linear->map = xe_bo_mmap_ext(fd, linear->fb.gem_handle,
+					     linear->fb.size, PROT_READ | PROT_WRITE);
 	} else {
 		/* Copy fb content to linear BO */
 		gem_set_domain(fd, linear->fb.gem_handle,
@@ -2915,6 +2928,9 @@ static void create_cairo_surface__gpu(int fd, struct igt_fb *fb)
  */
 int igt_dirty_fb(int fd, struct igt_fb *fb)
 {
+	if (fb->syncobj)
+		syncobj_wait(fd, &fb->syncobj, 1, INT64_MAX, 0, NULL);
+
 	return drmModeDirtyFB(fb->fd, fb->fb_id, NULL, 0);
 }
 
@@ -2964,6 +2980,9 @@ static void *map_bo(int fd, struct igt_fb *fb)
 				      PROT_READ | PROT_WRITE);
 	else if (is_nouveau_device(fd))
 		ptr = igt_nouveau_mmap_bo(fb, PROT_READ | PROT_WRITE);
+	else if (is_xe_device(fd))
+		ptr = xe_bo_mmap_ext(fd, fb->gem_handle,
+				     fb->size, PROT_READ | PROT_WRITE);
 	else
 		igt_assert(false);
 
@@ -4248,6 +4267,9 @@ void igt_remove_fb(int fd, struct igt_fb *fb)
 	if (!fb || !fb->fb_id)
 		return;
 
+	if (fb->syncobj)
+		syncobj_destroy(fd, fb->syncobj);
+
 	cairo_surface_destroy(fb->cairo_surface);
 	do_or_die(drmModeRmFB(fd, fb->fb_id));
 	if (fb->is_dumb)
diff --git a/lib/igt_fb.h b/lib/igt_fb.h
index 73bdfc8669d..a127a8128a4 100644
--- a/lib/igt_fb.h
+++ b/lib/igt_fb.h
@@ -62,6 +62,7 @@ typedef struct _igt_crc igt_crc_t;
  * @fb_id: KMS ID of the framebuffer
  * @fd: DRM device fd this framebuffer is created on
  * @gem_handle: GEM handler of the underlying backing storage
+ * @syncobj: Syncobj to sync to for last drawing operation
  * @is_dumb: Whether this framebuffer was allocated using the dumb buffer API
  * @drm_format: DRM FOURCC code
  * @width: width in pixels
@@ -84,6 +85,7 @@ typedef struct igt_fb {
 	uint32_t fb_id;
 	int fd;
 	uint32_t gem_handle;
+	uint32_t syncobj;
 	bool is_dumb;
 	uint32_t drm_format;
 	int width;
-- 
2.40.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [igt-dev] [i-g-t 3/7] lib: Use i915 namespace for XE debugfs
  2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
  2023-04-13 16:27 ` [igt-dev] [i-g-t 1/7] lib/intel_bufops: Fix bops creation to support XE Bhanuprakash Modem
  2023-04-13 16:27 ` [igt-dev] [i-g-t 2/7] lib/igt_fb: Add copy engine support for XE Bhanuprakash Modem
@ 2023-04-13 16:27 ` Bhanuprakash Modem
  2023-04-17  5:07   ` Karthik B S
                     ` (2 more replies)
  2023-04-13 16:27 ` [igt-dev] [i-g-t 4/7] tests/kms_cursor_legacy: Add XE support Bhanuprakash Modem
                   ` (7 subsequent siblings)
  10 siblings, 3 replies; 19+ messages in thread
From: Bhanuprakash Modem @ 2023-04-13 16:27 UTC (permalink / raw)
  To: igt-dev

As of now XE is going to use i915 namesapce for their debugfs.
Example: i915_current_bpc is applicable for both i915 & XE

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 lib/igt_kms.c | 2 +-
 lib/igt_psr.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 50655f136b8..720e68ca7c9 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -5706,7 +5706,7 @@ unsigned int igt_get_pipe_current_bpc(int drmfd, enum pipe pipe)
 	fd = igt_debugfs_pipe_dir(drmfd, pipe, O_RDONLY);
 	igt_assert(fd >= 0);
 
-	if (is_i915_device(drmfd))
+	if (is_intel_device(drmfd))
 		strcpy(debugfs_name, "i915_current_bpc");
 	else if (is_amdgpu_device(drmfd))
 		strcpy(debugfs_name, "amdgpu_current_bpc");
diff --git a/lib/igt_psr.c b/lib/igt_psr.c
index a2d88031268..13f7c567dc9 100644
--- a/lib/igt_psr.c
+++ b/lib/igt_psr.c
@@ -277,7 +277,7 @@ bool i915_psr2_selective_fetch_check(int drm_fd)
 	int debugfs_fd;
 	bool ret;
 
-	if (!is_i915_device(drm_fd))
+	if (!is_intel_device(drm_fd))
 		return false;
 
 	debugfs_fd = igt_debugfs_dir(drm_fd);
@@ -303,7 +303,7 @@ bool i915_psr2_sel_fetch_to_psr1(int drm_fd)
 	int debugfs_fd;
 	bool ret = false;
 
-	if (!is_i915_device(drm_fd))
+	if (!is_intel_device(drm_fd))
 		return ret;
 
 	debugfs_fd = igt_debugfs_dir(drm_fd);
-- 
2.40.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [igt-dev] [i-g-t 4/7] tests/kms_cursor_legacy: Add XE support
  2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
                   ` (2 preceding siblings ...)
  2023-04-13 16:27 ` [igt-dev] [i-g-t 3/7] lib: Use i915 namespace for XE debugfs Bhanuprakash Modem
@ 2023-04-13 16:27 ` Bhanuprakash Modem
  2023-04-17  5:03   ` Karthik B S
  2023-04-13 16:27 ` [igt-dev] [i-g-t 5/7] tests/kms_flip: " Bhanuprakash Modem
                   ` (6 subsequent siblings)
  10 siblings, 1 reply; 19+ messages in thread
From: Bhanuprakash Modem @ 2023-04-13 16:27 UTC (permalink / raw)
  To: igt-dev

Add XE driver support for kms tests.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_cursor_legacy.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index 5f430090815..cd247cf0088 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -308,7 +308,7 @@ enum flip_test {
 static bool cursor_slowpath(igt_display_t *display, enum flip_test mode)
 {
 	/* Intel display 9 and newer will handle cursor movement as fastsets */
-	if (is_i915_device(display->drm_fd) &&
+	if (is_intel_device(display->drm_fd) &&
 	    intel_display_ver(intel_get_drm_devid(display->drm_fd)) >= 9)
 	    return true;
 
@@ -1708,6 +1708,7 @@ igt_main
 	igt_describe("this test perform a busy bo update followed by a cursor update");
 	igt_subtest_group {
 		igt_fixture {
+			igt_require_i915(display.drm_fd);
 			igt_require_pipe_crc(display.drm_fd);
 			igt_display_require_output(&display);
 		}
-- 
2.40.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [igt-dev] [i-g-t 5/7] tests/kms_flip: Add XE support
  2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
                   ` (3 preceding siblings ...)
  2023-04-13 16:27 ` [igt-dev] [i-g-t 4/7] tests/kms_cursor_legacy: Add XE support Bhanuprakash Modem
@ 2023-04-13 16:27 ` Bhanuprakash Modem
  2023-04-18  9:34   ` Karthik B S
  2023-04-13 16:27 ` [igt-dev] [i-g-t 6/7] tests/i915/kms_psr: " Bhanuprakash Modem
                   ` (5 subsequent siblings)
  10 siblings, 1 reply; 19+ messages in thread
From: Bhanuprakash Modem @ 2023-04-13 16:27 UTC (permalink / raw)
  To: igt-dev

Add XE driver support for kms tests.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_flip.c | 35 ++++++++++++++++++++++++++---------
 1 file changed, 26 insertions(+), 9 deletions(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 5e82f4a2f84..5f5e84ba27c 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -44,6 +44,7 @@
 
 #include "i915/gem_create.h"
 #include "igt_stats.h"
+#include "xe/xe_query.h"
 
 #define TEST_DPMS		(1 << 0)
 
@@ -792,7 +793,8 @@ static bool run_test_step(struct test_output *o, unsigned int *events)
 
 	memset(&hang, 0, sizeof(hang));
 	if (do_flip && (o->flags & TEST_HANG)) {
-		igt_require_intel(drm_fd);
+		igt_require_i915(drm_fd);
+		/* TODO: Add XE support? */
 		ahnd = get_reloc_ahnd(drm_fd, 0);
 		hang = hang_gpu(drm_fd, ahnd);
 	}
@@ -1347,15 +1349,21 @@ restart:
 		o->fb_width *= 2;
 
 	modifier = DRM_FORMAT_MOD_LINEAR;
-	if (o->flags & TEST_FENCE_STRESS)
+	if (o->flags & TEST_FENCE_STRESS) {
+		igt_skip_on(!is_i915_device(drm_fd));
 		modifier = I915_FORMAT_MOD_X_TILED;
+	}
 
 	/* 256 MB is usually the maximum mappable aperture,
 	 * (make it 4x times that to ensure failure) */
 	if (o->flags & TEST_BO_TOOBIG) {
-		igt_skip_on(!is_i915_device(drm_fd));
+		igt_skip_on(!is_intel_device(drm_fd));
 		bo_size = 4*gem_mappable_aperture_size(drm_fd);
-		igt_require(bo_size < gem_global_aperture_size(drm_fd));
+
+		if (is_i915_device(drm_fd))
+			igt_require(bo_size < gem_global_aperture_size(drm_fd));
+		else
+			igt_require(bo_size < (1ULL << xe_va_bits(drm_fd)));
 	}
 
 	o->fb_ids[0] = igt_create_fb(drm_fd, o->fb_width, o->fb_height,
@@ -1557,9 +1565,10 @@ static int run_test(int duration, int flags)
 	struct test_output o;
 	int i, n, modes = 0;
 
-	igt_require((flags & TEST_HANG) == 0 || !is_wedged(drm_fd));
+	igt_require((flags & TEST_HANG) == 0 ||
+		    (is_i915_device(drm_fd) && !is_wedged(drm_fd)));
 	igt_require(!(flags & TEST_FENCE_STRESS) ||
-		    gem_available_fences(drm_fd));
+		    (is_i915_device(drm_fd) && gem_available_fences(drm_fd)));
 
 	resources = drmModeGetResources(drm_fd);
 	igt_require(resources);
@@ -1626,9 +1635,10 @@ static int run_pair(int duration, int flags)
 	struct test_output o;
 	int i, j, m, n, modes = 0;
 
-	igt_require((flags & TEST_HANG) == 0 || !is_wedged(drm_fd));
+	igt_require((flags & TEST_HANG) == 0 ||
+		    (is_i915_device(drm_fd) && !is_wedged(drm_fd)));
 	igt_require(!(flags & TEST_FENCE_STRESS) ||
-		    gem_available_fences(drm_fd));
+		    (is_i915_device(drm_fd) && gem_available_fences(drm_fd)));
 
 	resources = drmModeGetResources(drm_fd);
 	igt_require(resources);
@@ -1813,6 +1823,9 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
 		igt_install_exit_handler(kms_flip_exit_handler);
 		get_timestamp_format();
 
+		if (is_xe_device(drm_fd))
+			xe_device_get(drm_fd);
+
 		if (is_i915_device(drm_fd)) {
 			bops = buf_ops_create(drm_fd);
 		}
@@ -1878,6 +1891,10 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
 	}
 	igt_stop_signal_helper();
 
-	igt_fixture
+	igt_fixture {
+		if (is_xe_device(drm_fd))
+			xe_device_put(drm_fd);
+
 		close(drm_fd);
+	}
 }
-- 
2.40.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [igt-dev] [i-g-t 6/7] tests/i915/kms_psr: Add XE support
  2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
                   ` (4 preceding siblings ...)
  2023-04-13 16:27 ` [igt-dev] [i-g-t 5/7] tests/kms_flip: " Bhanuprakash Modem
@ 2023-04-13 16:27 ` Bhanuprakash Modem
  2023-04-13 16:27 ` [igt-dev] [i-g-t 7/7] xe-fast-feedback: Add kms tests to XE BAT Bhanuprakash Modem
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 19+ messages in thread
From: Bhanuprakash Modem @ 2023-04-13 16:27 UTC (permalink / raw)
  To: igt-dev

Add XE driver support for kms tests.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_psr.c             | 39 +++++++++++++++++++++++++++-----
 tests/i915/kms_psr2_sf.c         |  2 +-
 tests/i915/kms_psr2_su.c         |  2 +-
 tests/i915/kms_psr_stress_test.c |  2 +-
 4 files changed, 36 insertions(+), 9 deletions(-)

diff --git a/tests/i915/kms_psr.c b/tests/i915/kms_psr.c
index 3efe1faec8e..7d49377e95a 100644
--- a/tests/i915/kms_psr.c
+++ b/tests/i915/kms_psr.c
@@ -29,6 +29,7 @@
 #include <stdbool.h>
 #include <stdio.h>
 #include <string.h>
+#include "xe/xe_ioctl.h"
 
 enum operations {
 	PAGE_FLIP,
@@ -181,7 +182,8 @@ static void fill_blt(data_t *data, const struct igt_fb *fb, unsigned char color)
 	intel_bb_destroy(ibb);
 	intel_buf_destroy(dst);
 
-	gem_bo_busy(data->drm_fd, fb->gem_handle);
+	if (is_i915_device(data->drm_fd))
+		gem_bo_busy(data->drm_fd, fb->gem_handle);
 }
 
 static void fill_render(data_t *data, const struct igt_fb *fb,
@@ -204,7 +206,16 @@ static void fill_render(data_t *data, const struct igt_fb *fb,
 
 	src = intel_buf_create(data->bops, width, height, fb->plane_bpp[0],
 			       0, tiling, 0);
-	gem_write(data->drm_fd, src->handle, 0, buf, 4);
+
+	if (is_i915_device(data->drm_fd)) {
+		gem_write(data->drm_fd, src->handle, 0, buf, 4);
+	} else {
+		void *map = xe_bo_mmap_ext(data->drm_fd, src->handle, 4,
+					   PROT_READ | PROT_WRITE);
+
+		memcpy(map, buf, 4);
+		gem_munmap(map, 4);
+	}
 
 	rendercopy(ibb,
 		   src, 0, 0, 0xff, 0xff,
@@ -214,7 +225,8 @@ static void fill_render(data_t *data, const struct igt_fb *fb,
 	intel_buf_destroy(src);
 	intel_buf_destroy(dst);
 
-	gem_bo_busy(data->drm_fd, fb->gem_handle);
+	if (is_i915_device(data->drm_fd))
+		gem_bo_busy(data->drm_fd, fb->gem_handle);
 }
 
 static bool sink_support(data_t *data, enum psr_mode mode)
@@ -256,6 +268,11 @@ static bool drrs_disabled(data_t *data)
 {
 	char buf[512];
 
+	/*
+	 * FIXME: As of now, XE's debugfs is using i915 namespace, once Kernel
+	 * changes got landed, please update this logic to use XE specific
+	 * debugfs.
+	 */
 	igt_debugfs_simple_read(data->debugfs_fd, "i915_drrs_status",
 			 buf, sizeof(buf));
 
@@ -388,7 +405,8 @@ static void setup_test_plane(data_t *data, int test_plane)
 	igt_create_color_fb(data->drm_fd,
 			    data->mode->hdisplay, data->mode->vdisplay,
 			    DRM_FORMAT_XRGB8888,
-			    I915_FORMAT_MOD_X_TILED,
+			    is_i915_device(data->drm_fd) ?
+				I915_FORMAT_MOD_X_TILED : DRM_FORMAT_MOD_LINEAR,
 			    0.0, 1.0, 0.0,
 			    &data->fb_green);
 
@@ -416,7 +434,8 @@ static void setup_test_plane(data_t *data, int test_plane)
 		igt_create_color_fb(data->drm_fd,
 				    white_h, white_v,
 				    DRM_FORMAT_XRGB8888,
-				    I915_FORMAT_MOD_X_TILED,
+				    is_i915_device(data->drm_fd) ?
+					I915_FORMAT_MOD_X_TILED : DRM_FORMAT_MOD_LINEAR,
 				    1.0, 1.0, 1.0,
 				    &data->fb_white);
 		break;
@@ -510,7 +529,7 @@ igt_main_args("", long_options, help_str, opt_handler, &data)
 	};
 
 	igt_fixture {
-		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
 		data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
 		kmstest_set_vt_graphics_mode();
 		data.devid = intel_get_drm_devid(data.drm_fd);
@@ -542,6 +561,10 @@ igt_main_args("", long_options, help_str, opt_handler, &data)
 		}
 
 		for (op = PAGE_FLIP; op <= RENDER; op++) {
+			if (is_xe_device(data.drm_fd) &&
+			    (op == MMAP_CPU || op == MMAP_GTT))
+				continue;
+
 			igt_describe("Check if psr is detecting page-flipping,memory mapping and "
 					"rendering operations performed on primary planes");
 			igt_subtest_f("%sprimary_%s",
@@ -556,6 +579,10 @@ igt_main_args("", long_options, help_str, opt_handler, &data)
 		}
 
 		for (op = MMAP_GTT; op <= PLANE_ONOFF; op++) {
+			if (is_xe_device(data.drm_fd) &&
+			    (op == MMAP_CPU || op == MMAP_GTT))
+				continue;
+
 			igt_describe("Check if psr is detecting memory mapping,rendering "
 					"and plane operations performed on sprite planes");
 			igt_subtest_f("%ssprite_%s",
diff --git a/tests/i915/kms_psr2_sf.c b/tests/i915/kms_psr2_sf.c
index ffaae68b3e6..4cf9864409c 100644
--- a/tests/i915/kms_psr2_sf.c
+++ b/tests/i915/kms_psr2_sf.c
@@ -898,7 +898,7 @@ igt_main
 	igt_fixture {
 		drmModeResPtr res;
 
-		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
 		data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
 		kmstest_set_vt_graphics_mode();
 
diff --git a/tests/i915/kms_psr2_su.c b/tests/i915/kms_psr2_su.c
index 3e0a78f24b2..65e67b8c9be 100644
--- a/tests/i915/kms_psr2_su.c
+++ b/tests/i915/kms_psr2_su.c
@@ -297,7 +297,7 @@ igt_main
 	igt_fixture {
 		struct itimerspec interval;
 
-		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
 		data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
 		kmstest_set_vt_graphics_mode();
 
diff --git a/tests/i915/kms_psr_stress_test.c b/tests/i915/kms_psr_stress_test.c
index 26e222a27b6..a4cb3194ebe 100644
--- a/tests/i915/kms_psr_stress_test.c
+++ b/tests/i915/kms_psr_stress_test.c
@@ -331,7 +331,7 @@ igt_main
 	data_t data = {};
 
 	igt_fixture {
-		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);
 		data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
 		data.bops = buf_ops_create(data.drm_fd);
 		kmstest_set_vt_graphics_mode();
-- 
2.40.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [igt-dev] [i-g-t 7/7] xe-fast-feedback: Add kms tests to XE BAT
  2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
                   ` (5 preceding siblings ...)
  2023-04-13 16:27 ` [igt-dev] [i-g-t 6/7] tests/i915/kms_psr: " Bhanuprakash Modem
@ 2023-04-13 16:27 ` Bhanuprakash Modem
  2023-04-18  9:38   ` Karthik B S
  2023-04-13 17:39 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable KMS tests in " Patchwork
                   ` (3 subsequent siblings)
  10 siblings, 1 reply; 19+ messages in thread
From: Bhanuprakash Modem @ 2023-04-13 16:27 UTC (permalink / raw)
  To: igt-dev

Add kms tests to XE BAT.
- kms_chamelium_*
- kms_cursor_legacy
- kms_flip
- kms_pipe_crc_basic
- kms_psr

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/intel-ci/xe-fast-feedback.testlist | 31 ++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index 5db27c63452..c9ab687cf13 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -165,8 +165,39 @@ igt@kms_addfb_basic@unused-handle
 igt@kms_addfb_basic@unused-modifier
 igt@kms_addfb_basic@unused-offsets
 igt@kms_addfb_basic@unused-pitches
+igt@kms_chamelium_edid@dp-edid-read
+igt@kms_chamelium_edid@hdmi-edid-read
+igt@kms_chamelium_edid@vga-edid-read
+igt@kms_chamelium_frames@dp-crc-fast
+igt@kms_chamelium_frames@hdmi-crc-fast
+igt@kms_chamelium_hpd@common-hpd-after-suspend
+igt@kms_chamelium_hpd@dp-hpd-fast
+igt@kms_chamelium_hpd@hdmi-hpd-fast
+igt@kms_chamelium_hpd@vga-hpd-fast
+igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic
+igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy
+igt@kms_cursor_legacy@basic-flip-after-cursor-atomic
+igt@kms_cursor_legacy@basic-flip-after-cursor-legacy
+igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size
+igt@kms_cursor_legacy@basic-flip-before-cursor-atomic
+igt@kms_cursor_legacy@basic-flip-before-cursor-legacy
+igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size
+igt@kms_flip@basic-flip-vs-dpms
+igt@kms_flip@basic-flip-vs-modeset
+igt@kms_flip@basic-flip-vs-wf_vblank
+igt@kms_flip@basic-plain-flip
 igt@kms_force_connector_basic@force-connector-state
 igt@kms_force_connector_basic@force-edid
 igt@kms_force_connector_basic@force-load-detect
 igt@kms_force_connector_basic@prune-stale-modes
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck
+igt@kms_pipe_crc_basic@hang-read-crc
+igt@kms_pipe_crc_basic@nonblocking-crc
+igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence
+igt@kms_pipe_crc_basic@read-crc
+igt@kms_pipe_crc_basic@read-crc-frame-sequence
+igt@kms_pipe_crc_basic@suspend-read-crc
 igt@kms_prop_blob@basic
+igt@kms_psr@primary_page_flip
+igt@kms_psr@cursor_plane_move
+igt@kms_psr@sprite_plane_onoff
-- 
2.40.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for Enable KMS tests in XE BAT
  2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
                   ` (6 preceding siblings ...)
  2023-04-13 16:27 ` [igt-dev] [i-g-t 7/7] xe-fast-feedback: Add kms tests to XE BAT Bhanuprakash Modem
@ 2023-04-13 17:39 ` Patchwork
  2023-04-13 22:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2023-04-13 17:39 UTC (permalink / raw)
  To: Bhanuprakash Modem; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 4689 bytes --]

== Series Details ==

Series: Enable KMS tests in XE BAT
URL   : https://patchwork.freedesktop.org/series/116449/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13003 -> IGTPW_8800
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/index.html

Participating hosts (36 -> 35)
------------------------------

  Missing    (1): fi-snb-2520m 

Known issues
------------

  Here are the changes found in IGTPW_8800 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s0@smem:
    - bat-rpls-2:         NOTRUN -> [ABORT][1] ([i915#6687])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/bat-rpls-2/igt@gem_exec_suspend@basic-s0@smem.html

  * igt@i915_selftest@live@migrate:
    - bat-adlp-6:         [PASS][2] -> [DMESG-FAIL][3] ([i915#7699])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/bat-adlp-6/igt@i915_selftest@live@migrate.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/bat-adlp-6/igt@i915_selftest@live@migrate.html

  * igt@i915_selftest@live@slpc:
    - bat-rpls-2:         NOTRUN -> [DMESG-FAIL][4] ([i915#6997] / [i915#7913])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/bat-rpls-2/igt@i915_selftest@live@slpc.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-adlp-9:         NOTRUN -> [SKIP][5] ([i915#7828])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/bat-adlp-9/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
    - bat-dg2-8:          [PASS][6] -> [FAIL][7] ([i915#7932])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html

  * igt@kms_pipe_crc_basic@read-crc:
    - bat-adlp-9:         NOTRUN -> [SKIP][8] ([i915#3546]) +1 similar issue
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/bat-adlp-9/igt@kms_pipe_crc_basic@read-crc.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence:
    - bat-dg2-11:         NOTRUN -> [SKIP][9] ([i915#5354])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/bat-dg2-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@reset:
    - bat-rpls-2:         [ABORT][10] ([i915#4983] / [i915#7913] / [i915#7981]) -> [PASS][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/bat-rpls-2/igt@i915_selftest@live@reset.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/bat-rpls-2/igt@i915_selftest@live@reset.html

  * igt@i915_selftest@live@uncore:
    - bat-adlp-9:         [ABORT][12] -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/bat-adlp-9/igt@i915_selftest@live@uncore.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/bat-adlp-9/igt@i915_selftest@live@uncore.html

  * igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
    - bat-dg2-8:          [FAIL][14] ([i915#7932]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html

  
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
  [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
  [i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
  [i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7254 -> IGTPW_8800

  CI-20190529: 20190529
  CI_DRM_13003: 9452fe4b47da924d60188cd39d263e5a980db5df @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8800: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/index.html
  IGT_7254: 7fab01340a3f360abacd7914015be1ad485363d7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/index.html

[-- Attachment #2: Type: text/html, Size: 5664 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for Enable KMS tests in XE BAT
  2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
                   ` (7 preceding siblings ...)
  2023-04-13 17:39 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable KMS tests in " Patchwork
@ 2023-04-13 22:11 ` Patchwork
  2023-04-17 11:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable KMS tests in XE BAT (rev2) Patchwork
  2023-04-17 16:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2023-04-13 22:11 UTC (permalink / raw)
  To: Bhanuprakash Modem; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 17737 bytes --]

== Series Details ==

Series: Enable KMS tests in XE BAT
URL   : https://patchwork.freedesktop.org/series/116449/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13003_full -> IGTPW_8800_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/index.html

Participating hosts (7 -> 7)
------------------------------

  No changes in participating hosts

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8800_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@kms_flip@2x-flip-vs-fences:
    - {shard-dg1}:        [SKIP][1] ([i915#4859]) -> [SKIP][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-dg1-16/igt@kms_flip@2x-flip-vs-fences.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-dg1-16/igt@kms_flip@2x-flip-vs-fences.html

  
Known issues
------------

  Here are the changes found in IGTPW_8800_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fair@basic-deadline:
    - shard-glk:          [PASS][3] -> [FAIL][4] ([i915#2846])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-glk1/igt@gem_exec_fair@basic-deadline.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-glk8/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-vip@rcs0:
    - shard-glk:          NOTRUN -> [FAIL][5] ([i915#2842])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-glk2/igt@gem_exec_fair@basic-none-vip@rcs0.html

  * igt@gem_lmem_swapping@parallel-random-engines:
    - shard-glk:          NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-glk9/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@gem_lmem_swapping@smem-oom:
    - shard-apl:          NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-apl4/igt@gem_lmem_swapping@smem-oom.html

  * igt@gem_userptr_blits@vma-merge:
    - shard-apl:          NOTRUN -> [FAIL][8] ([i915#3318])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-apl1/igt@gem_userptr_blits@vma-merge.html

  * igt@i915_selftest@live@gt_heartbeat:
    - shard-glk:          [PASS][9] -> [DMESG-FAIL][10] ([i915#5334])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-glk1/igt@i915_selftest@live@gt_heartbeat.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-glk5/igt@i915_selftest@live@gt_heartbeat.html

  * igt@kms_big_fb@x-tiled-64bpp-rotate-90:
    - shard-glk:          NOTRUN -> [SKIP][11] ([fdo#109271]) +41 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-glk1/igt@kms_big_fb@x-tiled-64bpp-rotate-90.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip:
    - shard-apl:          NOTRUN -> [SKIP][12] ([fdo#109271]) +25 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-apl7/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip.html

  * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
    - shard-glk:          NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#3886]) +1 similar issue
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-glk5/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html

  * igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
    - shard-apl:          [PASS][14] -> [ABORT][15] ([i915#180])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html

  * igt@kms_vblank@pipe-c-wait-busy-hang:
    - shard-apl:          [PASS][16] -> [SKIP][17] ([fdo#109271]) +1 similar issue
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-apl2/igt@kms_vblank@pipe-c-wait-busy-hang.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-apl4/igt@kms_vblank@pipe-c-wait-busy-hang.html
    - shard-glk:          [PASS][18] -> [SKIP][19] ([fdo#109271])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-glk4/igt@kms_vblank@pipe-c-wait-busy-hang.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-glk1/igt@kms_vblank@pipe-c-wait-busy-hang.html

  * igt@kms_vblank@pipe-d-wait-idle:
    - shard-glk:          NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#533])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-glk3/igt@kms_vblank@pipe-d-wait-idle.html

  * igt@perf@stress-open-close@0-rcs0:
    - shard-glk:          NOTRUN -> [ABORT][21] ([i915#5213])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-glk8/igt@perf@stress-open-close@0-rcs0.html

  * igt@perf_pmu@module-unload:
    - shard-snb:          [PASS][22] -> [ABORT][23] ([i915#4528])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-snb4/igt@perf_pmu@module-unload.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-snb2/igt@perf_pmu@module-unload.html

  * igt@v3d/v3d_submit_cl@bad-multisync-extension:
    - shard-snb:          NOTRUN -> [SKIP][24] ([fdo#109271]) +14 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-snb4/igt@v3d/v3d_submit_cl@bad-multisync-extension.html

  
#### Possible fixes ####

  * igt@gem_ctx_exec@basic-nohangcheck:
    - {shard-tglu}:       [FAIL][25] ([i915#6268]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-tglu-2/igt@gem_ctx_exec@basic-nohangcheck.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-tglu-8/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - {shard-rkl}:        [FAIL][27] ([i915#2842]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-rkl-2/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-rkl-7/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-apl:          [ABORT][29] ([i915#5566]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-apl3/igt@gen9_exec_parse@allowed-single.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-apl6/igt@gen9_exec_parse@allowed-single.html

  * igt@i915_module_load@reload:
    - shard-snb:          [ABORT][31] ([i915#4528]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-snb4/igt@i915_module_load@reload.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-snb4/igt@i915_module_load@reload.html

  * igt@i915_pm_dc@dc9-dpms:
    - {shard-tglu}:       [SKIP][33] ([i915#4281]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-tglu-9/igt@i915_pm_dc@dc9-dpms.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-tglu-2/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_selftest@live@gt_heartbeat:
    - shard-apl:          [DMESG-FAIL][35] ([i915#5334]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-apl7/igt@i915_selftest@live@gt_heartbeat.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-apl7/igt@i915_selftest@live@gt_heartbeat.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
    - {shard-rkl}:        [FAIL][37] ([i915#3743]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-rkl-1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-glk:          [FAIL][39] ([i915#2346]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
    - shard-glk:          [FAIL][41] ([i915#79]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13003/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/shard-glk3/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
  [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
  [fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
  [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
  [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
  [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
  [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
  [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
  [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
  [i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5431]: https://gitlab.freedesktop.org/drm/intel/issues/5431
  [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
  [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
  [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7254 -> IGTPW_8800
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_13003: 9452fe4b47da924d60188cd39d263e5a980db5df @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8800: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/index.html
  IGT_7254: 7fab01340a3f360abacd7914015be1ad485363d7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8800/index.html

[-- Attachment #2: Type: text/html, Size: 12945 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [i-g-t 4/7] tests/kms_cursor_legacy: Add XE support
  2023-04-13 16:27 ` [igt-dev] [i-g-t 4/7] tests/kms_cursor_legacy: Add XE support Bhanuprakash Modem
@ 2023-04-17  5:03   ` Karthik B S
  0 siblings, 0 replies; 19+ messages in thread
From: Karthik B S @ 2023-04-17  5:03 UTC (permalink / raw)
  To: Bhanuprakash Modem, igt-dev


On 4/13/2023 9:57 PM, Bhanuprakash Modem wrote:
> Add XE driver support for kms tests.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_cursor_legacy.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index 5f430090815..cd247cf0088 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -308,7 +308,7 @@ enum flip_test {
>   static bool cursor_slowpath(igt_display_t *display, enum flip_test mode)
>   {
>   	/* Intel display 9 and newer will handle cursor movement as fastsets */
> -	if (is_i915_device(display->drm_fd) &&
> +	if (is_intel_device(display->drm_fd) &&
>   	    intel_display_ver(intel_get_drm_devid(display->drm_fd)) >= 9)
>   	    return true;
>   
> @@ -1708,6 +1708,7 @@ igt_main
>   	igt_describe("this test perform a busy bo update followed by a cursor update");
>   	igt_subtest_group {
>   		igt_fixture {
> +			igt_require_i915(display.drm_fd);

Hi,

Could you please remove the 'igt_require_intel' check inside 
'flip_vs_cursor_busy_crc', as with the above check that is redundant.

With this removed, the patch LGTM.

Reviewed-by: Karthik B S <karthik.b.s@intel.com>

Thanks,
Karthik.B.S
>   			igt_require_pipe_crc(display.drm_fd);
>   			igt_display_require_output(&display);
>   		}

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [i-g-t 3/7] lib: Use i915 namespace for XE debugfs
  2023-04-13 16:27 ` [igt-dev] [i-g-t 3/7] lib: Use i915 namespace for XE debugfs Bhanuprakash Modem
@ 2023-04-17  5:07   ` Karthik B S
  2023-04-17  7:05   ` [igt-dev] [i-g-t V2 " Bhanuprakash Modem
  2023-04-17 10:59   ` [igt-dev] [i-g-t " Zbigniew Kempczyński
  2 siblings, 0 replies; 19+ messages in thread
From: Karthik B S @ 2023-04-17  5:07 UTC (permalink / raw)
  To: Bhanuprakash Modem, igt-dev


On 4/13/2023 9:57 PM, Bhanuprakash Modem wrote:
> As of now XE is going to use i915 namesapce for their debugfs.
> Example: i915_current_bpc is applicable for both i915 & XE
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   lib/igt_kms.c | 2 +-
>   lib/igt_psr.c | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 50655f136b8..720e68ca7c9 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -5706,7 +5706,7 @@ unsigned int igt_get_pipe_current_bpc(int drmfd, enum pipe pipe)
>   	fd = igt_debugfs_pipe_dir(drmfd, pipe, O_RDONLY);
>   	igt_assert(fd >= 0);
>   
> -	if (is_i915_device(drmfd))
> +	if (is_intel_device(drmfd))
>   		strcpy(debugfs_name, "i915_current_bpc");
>   	else if (is_amdgpu_device(drmfd))
>   		strcpy(debugfs_name, "amdgpu_current_bpc");
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index a2d88031268..13f7c567dc9 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -277,7 +277,7 @@ bool i915_psr2_selective_fetch_check(int drm_fd)
>   	int debugfs_fd;
>   	bool ret;
>   
> -	if (!is_i915_device(drm_fd))
> +	if (!is_intel_device(drm_fd))
>   		return false;
>   
>   	debugfs_fd = igt_debugfs_dir(drm_fd);
> @@ -303,7 +303,7 @@ bool i915_psr2_sel_fetch_to_psr1(int drm_fd)
>   	int debugfs_fd;
>   	bool ret = false;
>   
> -	if (!is_i915_device(drm_fd))
> +	if (!is_intel_device(drm_fd))
>   		return ret;
>   
>   	debugfs_fd = igt_debugfs_dir(drm_fd);

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [igt-dev] [i-g-t V2 3/7] lib: Use i915 namespace for XE debugfs
  2023-04-13 16:27 ` [igt-dev] [i-g-t 3/7] lib: Use i915 namespace for XE debugfs Bhanuprakash Modem
  2023-04-17  5:07   ` Karthik B S
@ 2023-04-17  7:05   ` Bhanuprakash Modem
  2023-04-17 10:59   ` [igt-dev] [i-g-t " Zbigniew Kempczyński
  2 siblings, 0 replies; 19+ messages in thread
From: Bhanuprakash Modem @ 2023-04-17  7:05 UTC (permalink / raw)
  To: igt-dev

As of now XE is going to use i915 namesapce for their debugfs.
Example: i915_current_bpc is applicable for both i915 & XE

V2: - Rebase

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
---
 lib/igt_kms.c | 4 ++--
 lib/igt_psr.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 4b3eeffc7f3..a169b3288ca 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -5706,7 +5706,7 @@ unsigned int igt_get_pipe_current_bpc(int drmfd, enum pipe pipe)
 	fd = igt_debugfs_pipe_dir(drmfd, pipe, O_RDONLY);
 	igt_assert(fd >= 0);
 
-	if (is_i915_device(drmfd))
+	if (is_intel_device(drmfd))
 		strcpy(debugfs_name, "i915_current_bpc");
 	else if (is_amdgpu_device(drmfd))
 		strcpy(debugfs_name, "amdgpu_current_bpc");
@@ -5828,7 +5828,7 @@ int igt_get_max_dotclock(int fd)
 	char *s;
 	int dir, res, max_dotclock = 0;
 
-	if (!is_i915_device(fd))
+	if (!is_intel_device(fd))
 		return max_dotclock;
 
 	dir = igt_debugfs_dir(fd);
diff --git a/lib/igt_psr.c b/lib/igt_psr.c
index a2d88031268..13f7c567dc9 100644
--- a/lib/igt_psr.c
+++ b/lib/igt_psr.c
@@ -277,7 +277,7 @@ bool i915_psr2_selective_fetch_check(int drm_fd)
 	int debugfs_fd;
 	bool ret;
 
-	if (!is_i915_device(drm_fd))
+	if (!is_intel_device(drm_fd))
 		return false;
 
 	debugfs_fd = igt_debugfs_dir(drm_fd);
@@ -303,7 +303,7 @@ bool i915_psr2_sel_fetch_to_psr1(int drm_fd)
 	int debugfs_fd;
 	bool ret = false;
 
-	if (!is_i915_device(drm_fd))
+	if (!is_intel_device(drm_fd))
 		return ret;
 
 	debugfs_fd = igt_debugfs_dir(drm_fd);
-- 
2.40.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [i-g-t 1/7] lib/intel_bufops: Fix bops creation to support XE
  2023-04-13 16:27 ` [igt-dev] [i-g-t 1/7] lib/intel_bufops: Fix bops creation to support XE Bhanuprakash Modem
@ 2023-04-17 10:57   ` Zbigniew Kempczyński
  0 siblings, 0 replies; 19+ messages in thread
From: Zbigniew Kempczyński @ 2023-04-17 10:57 UTC (permalink / raw)
  To: Bhanuprakash Modem; +Cc: igt-dev

On Thu, Apr 13, 2023 at 09:57:26PM +0530, Bhanuprakash Modem wrote:
> As XE won't support tiling, fix the bops creation logic to
> support XE device.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

No, we want to do software tiling here.

I'm going to enablement series today.

--
Zbigniew

> ---
>  lib/intel_bufops.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c
> index cdc7a1698b2..81f7b951813 100644
> --- a/lib/intel_bufops.c
> +++ b/lib/intel_bufops.c
> @@ -1423,6 +1423,25 @@ static struct buf_ops *__buf_ops_create(int fd, bool check_idempotency)
>  	igt_debug("generation: %d, supported tiles: 0x%02x\n",
>  		  bops->intel_gen, bops->supported_tiles);
>  
> +	/* No tiling support in XE. */
> +	if (is_xe_device(fd)) {
> +		bops->supported_tiles = TILE_NONE;
> +		bops->supported_hw_tiles = TILE_NONE;
> +
> +		bops->linear_to_x = NULL;
> +		bops->x_to_linear = NULL;
> +		bops->linear_to_y = NULL;
> +		bops->y_to_linear = NULL;
> +		bops->linear_to_tile4 = NULL;
> +		bops->tile4_to_linear = NULL;
> +		bops->linear_to_yf = NULL;
> +		bops->yf_to_linear = NULL;
> +		bops->linear_to_ys = NULL;
> +		bops->ys_to_linear = NULL;
> +
> +		return bops;
> +	}
> +
>  	/*
>  	 * Warning!
>  	 *
> -- 
> 2.40.0
> 

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [i-g-t 3/7] lib: Use i915 namespace for XE debugfs
  2023-04-13 16:27 ` [igt-dev] [i-g-t 3/7] lib: Use i915 namespace for XE debugfs Bhanuprakash Modem
  2023-04-17  5:07   ` Karthik B S
  2023-04-17  7:05   ` [igt-dev] [i-g-t V2 " Bhanuprakash Modem
@ 2023-04-17 10:59   ` Zbigniew Kempczyński
  2 siblings, 0 replies; 19+ messages in thread
From: Zbigniew Kempczyński @ 2023-04-17 10:59 UTC (permalink / raw)
  To: Bhanuprakash Modem; +Cc: igt-dev

On Thu, Apr 13, 2023 at 09:57:28PM +0530, Bhanuprakash Modem wrote:
> As of now XE is going to use i915 namesapce for their debugfs.
                                    ^-- nit

With that:

Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

--
Zbigniew
> Example: i915_current_bpc is applicable for both i915 & XE
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  lib/igt_kms.c | 2 +-
>  lib/igt_psr.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 50655f136b8..720e68ca7c9 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -5706,7 +5706,7 @@ unsigned int igt_get_pipe_current_bpc(int drmfd, enum pipe pipe)
>  	fd = igt_debugfs_pipe_dir(drmfd, pipe, O_RDONLY);
>  	igt_assert(fd >= 0);
>  
> -	if (is_i915_device(drmfd))
> +	if (is_intel_device(drmfd))
>  		strcpy(debugfs_name, "i915_current_bpc");
>  	else if (is_amdgpu_device(drmfd))
>  		strcpy(debugfs_name, "amdgpu_current_bpc");
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index a2d88031268..13f7c567dc9 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -277,7 +277,7 @@ bool i915_psr2_selective_fetch_check(int drm_fd)
>  	int debugfs_fd;
>  	bool ret;
>  
> -	if (!is_i915_device(drm_fd))
> +	if (!is_intel_device(drm_fd))
>  		return false;
>  
>  	debugfs_fd = igt_debugfs_dir(drm_fd);
> @@ -303,7 +303,7 @@ bool i915_psr2_sel_fetch_to_psr1(int drm_fd)
>  	int debugfs_fd;
>  	bool ret = false;
>  
> -	if (!is_i915_device(drm_fd))
> +	if (!is_intel_device(drm_fd))
>  		return ret;
>  
>  	debugfs_fd = igt_debugfs_dir(drm_fd);
> -- 
> 2.40.0
> 

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for Enable KMS tests in XE BAT (rev2)
  2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
                   ` (8 preceding siblings ...)
  2023-04-13 22:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2023-04-17 11:01 ` Patchwork
  2023-04-17 16:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2023-04-17 11:01 UTC (permalink / raw)
  To: Bhanuprakash Modem; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 11197 bytes --]

== Series Details ==

Series: Enable KMS tests in XE BAT (rev2)
URL   : https://patchwork.freedesktop.org/series/116449/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13020 -> IGTPW_8809
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/index.html

Participating hosts (35 -> 36)
------------------------------

  Additional (2): fi-tgl-1115g4 bat-adls-5 
  Missing    (1): fi-snb-2520m 

Known issues
------------

  Here are the changes found in IGTPW_8809 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@basic-hwmon:
    - bat-adls-5:         NOTRUN -> [SKIP][1] ([i915#7456])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adls-5/igt@debugfs_test@basic-hwmon.html
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][2] ([i915#7456])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/fi-tgl-1115g4/igt@debugfs_test@basic-hwmon.html

  * igt@dmabuf@all-tests@dma_fence:
    - bat-adln-1:         [PASS][3] -> [DMESG-FAIL][4] ([i915#8143])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/bat-adln-1/igt@dmabuf@all-tests@dma_fence.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adln-1/igt@dmabuf@all-tests@dma_fence.html

  * igt@dmabuf@all-tests@sanitycheck:
    - bat-adln-1:         [PASS][5] -> [ABORT][6] ([i915#8058] / [i915#8144])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/bat-adln-1/igt@dmabuf@all-tests@sanitycheck.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adln-1/igt@dmabuf@all-tests@sanitycheck.html

  * igt@gem_exec_suspend@basic-s3@smem:
    - bat-adlp-9:         [PASS][7] -> [FAIL][8] ([fdo#103375]) +5 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/bat-adlp-9/igt@gem_exec_suspend@basic-s3@smem.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adlp-9/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@gem_huc_copy@huc-copy:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][9] ([i915#2190])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@parallel-random-engines:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][10] ([i915#4613]) +3 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/fi-tgl-1115g4/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@gem_lmem_swapping@random-engines:
    - bat-adls-5:         NOTRUN -> [SKIP][11] ([i915#4613]) +3 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adls-5/igt@gem_lmem_swapping@random-engines.html

  * igt@gem_tiled_pread_basic:
    - bat-adls-5:         NOTRUN -> [SKIP][12] ([i915#3282])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adls-5/igt@gem_tiled_pread_basic.html

  * igt@i915_pm_backlight@basic-brightness:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][13] ([i915#7561])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html

  * igt@i915_pm_rps@basic-api:
    - bat-dg2-11:         [PASS][14] -> [FAIL][15] ([i915#8308])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/bat-dg2-11/igt@i915_pm_rps@basic-api.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-dg2-11/igt@i915_pm_rps@basic-api.html

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-kbl-guc:         [PASS][16] -> [DMESG-FAIL][17] ([i915#5334] / [i915#7872])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/fi-kbl-guc/igt@i915_selftest@live@gt_heartbeat.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/fi-kbl-guc/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@hangcheck:
    - bat-adls-5:         NOTRUN -> [DMESG-WARN][18] ([i915#5591])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adls-5/igt@i915_selftest@live@hangcheck.html

  * igt@i915_selftest@live@mman:
    - bat-rpls-2:         [PASS][19] -> [TIMEOUT][20] ([i915#6794])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/bat-rpls-2/igt@i915_selftest@live@mman.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-rpls-2/igt@i915_selftest@live@mman.html

  * igt@i915_suspend@basic-s3-without-i915:
    - fi-tgl-1115g4:      NOTRUN -> [INCOMPLETE][21] ([i915#7443])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/fi-tgl-1115g4/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_chamelium_edid@dp-edid-read:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][22] ([i915#7828]) +7 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/fi-tgl-1115g4/igt@kms_chamelium_edid@dp-edid-read.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-rpls-2:         NOTRUN -> [SKIP][23] ([i915#7828])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-rpls-2/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
    - bat-dg2-11:         NOTRUN -> [SKIP][24] ([i915#7828])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-dg2-11/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@kms_chamelium_hpd@vga-hpd-fast:
    - bat-adls-5:         NOTRUN -> [SKIP][25] ([i915#7828]) +8 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adls-5/igt@kms_chamelium_hpd@vga-hpd-fast.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][26] ([i915#4103]) +1 similar issue
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - bat-adls-5:         NOTRUN -> [SKIP][27] ([i915#4103]) +1 similar issue
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adls-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_force_connector_basic@force-load-detect:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][28] ([fdo#109285])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
    - bat-adls-5:         NOTRUN -> [SKIP][29] ([fdo#109285])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adls-5/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_pipe_crc_basic@suspend-read-crc:
    - bat-rpls-2:         NOTRUN -> [SKIP][30] ([i915#1845])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-rpls-2/igt@kms_pipe_crc_basic@suspend-read-crc.html

  * igt@kms_psr@cursor_plane_move:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][31] ([fdo#110189]) +3 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/fi-tgl-1115g4/igt@kms_psr@cursor_plane_move.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-adls-5:         NOTRUN -> [SKIP][32] ([i915#3555] / [i915#4579])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adls-5/igt@kms_setmode@basic-clone-single-crtc.html
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][33] ([i915#3555] / [i915#4579])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-read:
    - bat-adls-5:         NOTRUN -> [SKIP][34] ([fdo#109295] / [i915#3291]) +2 similar issues
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adls-5/igt@prime_vgem@basic-read.html

  * igt@prime_vgem@basic-userptr:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][35] ([fdo#109295] / [i915#3301])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html
    - bat-adls-5:         NOTRUN -> [SKIP][36] ([fdo#109295] / [i915#3301])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-adls-5/igt@prime_vgem@basic-userptr.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@hangcheck:
    - bat-dg2-11:         [ABORT][37] ([i915#7913] / [i915#7979]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-dg2-11/igt@i915_selftest@live@hangcheck.html

  
#### Warnings ####

  * igt@i915_selftest@live@reset:
    - bat-rpls-1:         [ABORT][39] ([i915#4983]) -> [ABORT][40] ([i915#4983] / [i915#7981])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/bat-rpls-1/igt@i915_selftest@live@reset.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/bat-rpls-1/igt@i915_selftest@live@reset.html

  
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
  [i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
  [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
  [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7979]: https://gitlab.freedesktop.org/drm/intel/issues/7979
  [i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
  [i915#8058]: https://gitlab.freedesktop.org/drm/intel/issues/8058
  [i915#8143]: https://gitlab.freedesktop.org/drm/intel/issues/8143
  [i915#8144]: https://gitlab.freedesktop.org/drm/intel/issues/8144
  [i915#8308]: https://gitlab.freedesktop.org/drm/intel/issues/8308


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7258 -> IGTPW_8809

  CI-20190529: 20190529
  CI_DRM_13020: 3e4aefa137a3ae4ee40a89e5b7274cc4d3c02e6f @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8809: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/index.html
  IGT_7258: ad2eb276eda849b7a7985229009a816c7608186c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/index.html

[-- Attachment #2: Type: text/html, Size: 13422 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for Enable KMS tests in XE BAT (rev2)
  2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
                   ` (9 preceding siblings ...)
  2023-04-17 11:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable KMS tests in XE BAT (rev2) Patchwork
@ 2023-04-17 16:43 ` Patchwork
  10 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2023-04-17 16:43 UTC (permalink / raw)
  To: Bhanuprakash Modem; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 14287 bytes --]

== Series Details ==

Series: Enable KMS tests in XE BAT (rev2)
URL   : https://patchwork.freedesktop.org/series/116449/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13020_full -> IGTPW_8809_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/index.html

Participating hosts (8 -> 8)
------------------------------

  No changes in participating hosts

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8809_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@kms_flip@2x-flip-vs-fences-interruptible:
    - {shard-dg1}:        [SKIP][1] ([i915#4859]) -> [SKIP][2] +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/shard-dg1-18/igt@kms_flip@2x-flip-vs-fences-interruptible.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-dg1-18/igt@kms_flip@2x-flip-vs-fences-interruptible.html

  * igt@kms_flip@flip-vs-fences-interruptible:
    - {shard-dg1}:        NOTRUN -> [SKIP][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-dg1-15/igt@kms_flip@flip-vs-fences-interruptible.html

  
Known issues
------------

  Here are the changes found in IGTPW_8809_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fair@basic-deadline:
    - shard-glk:          [PASS][4] -> [FAIL][5] ([i915#2846])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/shard-glk9/igt@gem_exec_fair@basic-deadline.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-glk1/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-apl:          [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-glk:          [PASS][8] -> [FAIL][9] ([i915#2842])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
    - shard-glk:          NOTRUN -> [SKIP][10] ([fdo#109271])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-glk3/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html

  
#### Possible fixes ####

  * igt@drm_fdinfo@most-busy-check-all@rcs0:
    - {shard-rkl}:        [FAIL][11] ([i915#7742]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/shard-rkl-3/igt@drm_fdinfo@most-busy-check-all@rcs0.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-rkl-6/igt@drm_fdinfo@most-busy-check-all@rcs0.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-glk:          [FAIL][13] ([i915#2842]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/shard-glk7/igt@gem_exec_fair@basic-none-share@rcs0.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-glk5/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-none@vecs0:
    - {shard-rkl}:        [FAIL][15] ([i915#2842]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/shard-rkl-2/igt@gem_exec_fair@basic-none@vecs0.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-rkl-3/igt@gem_exec_fair@basic-none@vecs0.html

  * igt@i915_pm_rpm@modeset-lpsp:
    - {shard-rkl}:        [SKIP][17] ([i915#1397]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/shard-rkl-2/igt@i915_pm_rpm@modeset-lpsp.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-glk:          [FAIL][19] ([i915#2346]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_cursor_legacy@forked-bo@pipe-b:
    - {shard-rkl}:        [INCOMPLETE][21] ([i915#8011]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/shard-rkl-7/igt@kms_cursor_legacy@forked-bo@pipe-b.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-rkl-2/igt@kms_cursor_legacy@forked-bo@pipe-b.html

  * igt@kms_hdmi_inject@inject-audio:
    - {shard-tglu}:       [SKIP][23] ([i915#433]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/shard-tglu-8/igt@kms_hdmi_inject@inject-audio.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-tglu-9/igt@kms_hdmi_inject@inject-audio.html

  * igt@kms_plane_scaling@i915-max-src-size@pipe-a-hdmi-a-1:
    - {shard-tglu}:       [FAIL][25] ([i915#8292]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13020/shard-tglu-9/igt@kms_plane_scaling@i915-max-src-size@pipe-a-hdmi-a-1.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/shard-tglu-6/igt@kms_plane_scaling@i915-max-src-size@pipe-a-hdmi-a-1.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
  [i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
  [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
  [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
  [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
  [i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
  [i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
  [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
  [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
  [i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
  [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
  [i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
  [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
  [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
  [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
  [i915#8150]: https://gitlab.freedesktop.org/drm/intel/issues/8150
  [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
  [i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
  [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
  [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7258 -> IGTPW_8809
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_13020: 3e4aefa137a3ae4ee40a89e5b7274cc4d3c02e6f @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8809: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/index.html
  IGT_7258: ad2eb276eda849b7a7985229009a816c7608186c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8809/index.html

[-- Attachment #2: Type: text/html, Size: 8333 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [i-g-t 5/7] tests/kms_flip: Add XE support
  2023-04-13 16:27 ` [igt-dev] [i-g-t 5/7] tests/kms_flip: " Bhanuprakash Modem
@ 2023-04-18  9:34   ` Karthik B S
  0 siblings, 0 replies; 19+ messages in thread
From: Karthik B S @ 2023-04-18  9:34 UTC (permalink / raw)
  To: Bhanuprakash Modem, igt-dev


On 4/13/2023 9:57 PM, Bhanuprakash Modem wrote:
> Add XE driver support for kms tests.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_flip.c | 35 ++++++++++++++++++++++++++---------
>   1 file changed, 26 insertions(+), 9 deletions(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 5e82f4a2f84..5f5e84ba27c 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -44,6 +44,7 @@
>   
>   #include "i915/gem_create.h"
>   #include "igt_stats.h"
> +#include "xe/xe_query.h"
>   
>   #define TEST_DPMS		(1 << 0)
>   
> @@ -792,7 +793,8 @@ static bool run_test_step(struct test_output *o, unsigned int *events)
>   
>   	memset(&hang, 0, sizeof(hang));
>   	if (do_flip && (o->flags & TEST_HANG)) {
> -		igt_require_intel(drm_fd);
> +		igt_require_i915(drm_fd);
> +		/* TODO: Add XE support? */

Hi,

As we're expecting to add XE support shortly, instead of adding TODO I 
would suggest keeping the original check and allow the test to fail on Xe.

>   		ahnd = get_reloc_ahnd(drm_fd, 0);
>   		hang = hang_gpu(drm_fd, ahnd);
>   	}
> @@ -1347,15 +1349,21 @@ restart:
>   		o->fb_width *= 2;
>   
>   	modifier = DRM_FORMAT_MOD_LINEAR;
> -	if (o->flags & TEST_FENCE_STRESS)
> +	if (o->flags & TEST_FENCE_STRESS) {
> +		igt_skip_on(!is_i915_device(drm_fd));
I get this check, but I would prefer an xe specific check instead of 
'NOT i915' check, as this a xe specific patch.
And if  any clean up required other than this we can handle it in a 
separate patch?

Thanks,
Karthik.B.S

>   		modifier = I915_FORMAT_MOD_X_TILED;
> +	}
>   
>   	/* 256 MB is usually the maximum mappable aperture,
>   	 * (make it 4x times that to ensure failure) */
>   	if (o->flags & TEST_BO_TOOBIG) {
> -		igt_skip_on(!is_i915_device(drm_fd));
> +		igt_skip_on(!is_intel_device(drm_fd));
>   		bo_size = 4*gem_mappable_aperture_size(drm_fd);
> -		igt_require(bo_size < gem_global_aperture_size(drm_fd));
> +
> +		if (is_i915_device(drm_fd))
> +			igt_require(bo_size < gem_global_aperture_size(drm_fd));
> +		else
> +			igt_require(bo_size < (1ULL << xe_va_bits(drm_fd)));
>   	}
>   
>   	o->fb_ids[0] = igt_create_fb(drm_fd, o->fb_width, o->fb_height,
> @@ -1557,9 +1565,10 @@ static int run_test(int duration, int flags)
>   	struct test_output o;
>   	int i, n, modes = 0;
>   
> -	igt_require((flags & TEST_HANG) == 0 || !is_wedged(drm_fd));
> +	igt_require((flags & TEST_HANG) == 0 ||
> +		    (is_i915_device(drm_fd) && !is_wedged(drm_fd)));
>   	igt_require(!(flags & TEST_FENCE_STRESS) ||
> -		    gem_available_fences(drm_fd));
> +		    (is_i915_device(drm_fd) && gem_available_fences(drm_fd)));
>   
>   	resources = drmModeGetResources(drm_fd);
>   	igt_require(resources);
> @@ -1626,9 +1635,10 @@ static int run_pair(int duration, int flags)
>   	struct test_output o;
>   	int i, j, m, n, modes = 0;
>   
> -	igt_require((flags & TEST_HANG) == 0 || !is_wedged(drm_fd));
> +	igt_require((flags & TEST_HANG) == 0 ||
> +		    (is_i915_device(drm_fd) && !is_wedged(drm_fd)));
>   	igt_require(!(flags & TEST_FENCE_STRESS) ||
> -		    gem_available_fences(drm_fd));
> +		    (is_i915_device(drm_fd) && gem_available_fences(drm_fd)));
>   
>   	resources = drmModeGetResources(drm_fd);
>   	igt_require(resources);
> @@ -1813,6 +1823,9 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
>   		igt_install_exit_handler(kms_flip_exit_handler);
>   		get_timestamp_format();
>   
> +		if (is_xe_device(drm_fd))
> +			xe_device_get(drm_fd);
> +
>   		if (is_i915_device(drm_fd)) {
>   			bops = buf_ops_create(drm_fd);
>   		}
> @@ -1878,6 +1891,10 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
>   	}
>   	igt_stop_signal_helper();
>   
> -	igt_fixture
> +	igt_fixture {
> +		if (is_xe_device(drm_fd))
> +			xe_device_put(drm_fd);
> +
>   		close(drm_fd);
> +	}
>   }

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [igt-dev] [i-g-t 7/7] xe-fast-feedback: Add kms tests to XE BAT
  2023-04-13 16:27 ` [igt-dev] [i-g-t 7/7] xe-fast-feedback: Add kms tests to XE BAT Bhanuprakash Modem
@ 2023-04-18  9:38   ` Karthik B S
  0 siblings, 0 replies; 19+ messages in thread
From: Karthik B S @ 2023-04-18  9:38 UTC (permalink / raw)
  To: Bhanuprakash Modem, igt-dev


On 4/13/2023 9:57 PM, Bhanuprakash Modem wrote:
> Add kms tests to XE BAT.
> - kms_chamelium_*
> - kms_cursor_legacy
> - kms_flip
> - kms_pipe_crc_basic
> - kms_psr
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/intel-ci/xe-fast-feedback.testlist | 31 ++++++++++++++++++++++++
>   1 file changed, 31 insertions(+)
>
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 5db27c63452..c9ab687cf13 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -165,8 +165,39 @@ igt@kms_addfb_basic@unused-handle
>   igt@kms_addfb_basic@unused-modifier
>   igt@kms_addfb_basic@unused-offsets
>   igt@kms_addfb_basic@unused-pitches
> +igt@kms_chamelium_edid@dp-edid-read
> +igt@kms_chamelium_edid@hdmi-edid-read
> +igt@kms_chamelium_edid@vga-edid-read
> +igt@kms_chamelium_frames@dp-crc-fast
> +igt@kms_chamelium_frames@hdmi-crc-fast
> +igt@kms_chamelium_hpd@common-hpd-after-suspend
> +igt@kms_chamelium_hpd@dp-hpd-fast
> +igt@kms_chamelium_hpd@hdmi-hpd-fast
> +igt@kms_chamelium_hpd@vga-hpd-fast
> +igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic
> +igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy
> +igt@kms_cursor_legacy@basic-flip-after-cursor-atomic
> +igt@kms_cursor_legacy@basic-flip-after-cursor-legacy
> +igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size
> +igt@kms_cursor_legacy@basic-flip-before-cursor-atomic
> +igt@kms_cursor_legacy@basic-flip-before-cursor-legacy
> +igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size
> +igt@kms_flip@basic-flip-vs-dpms
> +igt@kms_flip@basic-flip-vs-modeset
> +igt@kms_flip@basic-flip-vs-wf_vblank
> +igt@kms_flip@basic-plain-flip
>   igt@kms_force_connector_basic@force-connector-state
>   igt@kms_force_connector_basic@force-edid
>   igt@kms_force_connector_basic@force-load-detect
>   igt@kms_force_connector_basic@prune-stale-modes
> +igt@kms_pipe_crc_basic@compare-crc-sanitycheck
> +igt@kms_pipe_crc_basic@hang-read-crc
> +igt@kms_pipe_crc_basic@nonblocking-crc
> +igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence
> +igt@kms_pipe_crc_basic@read-crc
> +igt@kms_pipe_crc_basic@read-crc-frame-sequence
> +igt@kms_pipe_crc_basic@suspend-read-crc
>   igt@kms_prop_blob@basic
> +igt@kms_psr@primary_page_flip
> +igt@kms_psr@cursor_plane_move
> +igt@kms_psr@sprite_plane_onoff

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2023-04-18  9:38 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-13 16:27 [igt-dev] [i-g-t 0/7] Enable KMS tests in XE BAT Bhanuprakash Modem
2023-04-13 16:27 ` [igt-dev] [i-g-t 1/7] lib/intel_bufops: Fix bops creation to support XE Bhanuprakash Modem
2023-04-17 10:57   ` Zbigniew Kempczyński
2023-04-13 16:27 ` [igt-dev] [i-g-t 2/7] lib/igt_fb: Add copy engine support for XE Bhanuprakash Modem
2023-04-13 16:27 ` [igt-dev] [i-g-t 3/7] lib: Use i915 namespace for XE debugfs Bhanuprakash Modem
2023-04-17  5:07   ` Karthik B S
2023-04-17  7:05   ` [igt-dev] [i-g-t V2 " Bhanuprakash Modem
2023-04-17 10:59   ` [igt-dev] [i-g-t " Zbigniew Kempczyński
2023-04-13 16:27 ` [igt-dev] [i-g-t 4/7] tests/kms_cursor_legacy: Add XE support Bhanuprakash Modem
2023-04-17  5:03   ` Karthik B S
2023-04-13 16:27 ` [igt-dev] [i-g-t 5/7] tests/kms_flip: " Bhanuprakash Modem
2023-04-18  9:34   ` Karthik B S
2023-04-13 16:27 ` [igt-dev] [i-g-t 6/7] tests/i915/kms_psr: " Bhanuprakash Modem
2023-04-13 16:27 ` [igt-dev] [i-g-t 7/7] xe-fast-feedback: Add kms tests to XE BAT Bhanuprakash Modem
2023-04-18  9:38   ` Karthik B S
2023-04-13 17:39 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable KMS tests in " Patchwork
2023-04-13 22:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-04-17 11:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable KMS tests in XE BAT (rev2) Patchwork
2023-04-17 16:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox