* [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test
@ 2023-04-24 14:16 Hersen Wu
2023-04-24 16:46 ` Rodrigo Siqueira Jordao
0 siblings, 1 reply; 10+ messages in thread
From: Hersen Wu @ 2023-04-24 14:16 UTC (permalink / raw)
To: igt-dev, rodrigo.siqueira, aurabindo.pillai, alex.hung,
hamza.mahfooz
Cc: Hersen Wu
with 4k dp connected, amdgpu kernel warning mesaage dp_blank timeout
happens intermittently. link configuration <1, 162> could not support
4k mode. dp safe mode 640x480@60hz could be used for all link
configuration test.
Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
---
tests/amdgpu/amd_link_settings.c | 25 ++++++++++++++++++++++++-
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/tests/amdgpu/amd_link_settings.c b/tests/amdgpu/amd_link_settings.c
index 14c8c4d7..ec5e6fe5 100644
--- a/tests/amdgpu/amd_link_settings.c
+++ b/tests/amdgpu/amd_link_settings.c
@@ -159,6 +159,24 @@ static void run_link_training_config(data_t *data, igt_output_t *output)
}
}
+static const drmModeModeInfo dp_safe_mode_640_480 = {
+ .name = "640x480",
+ .vrefresh = 60,
+ .clock = 25200,
+
+ .hdisplay = 640,
+ .hsync_start = 656,
+ .hsync_end = 752,
+ .htotal = 800,
+
+ .vdisplay = 480,
+ .vsync_start = 490,
+ .vsync_end = 492,
+ .vtotal = 525,
+
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
static void test_link_training_configs(data_t *data)
{
const drmModeModeInfo *orig_mode;
@@ -177,7 +195,12 @@ static void test_link_training_configs(data_t *data)
/* Init only if display supports link_settings */
test_init(data, output);
- orig_mode = igt_output_get_mode(output);
+ /* run_link_training_config run test from <1, 1.62>
+ * to highest link configuration. to make sure mode timing
+ * be fitted into <1, 1.62> and higher configuration, use
+ * dp safe mode 640x480@60hz
+ */
+ orig_mode = &dp_safe_mode_640_480;
igt_assert(orig_mode);
igt_output_override_mode(output, orig_mode);
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test
@ 2023-04-24 16:32 Hersen Wu
2023-04-24 17:40 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test (rev2) Patchwork
2023-04-24 20:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
0 siblings, 2 replies; 10+ messages in thread
From: Hersen Wu @ 2023-04-24 16:32 UTC (permalink / raw)
To: igt-dev, rodrigo.siqueira, aurabindo.pillai, alex.hung,
hamza.mahfooz
Cc: Hersen Wu
with 4k dp connected, amdgpu kernel warning mesaage dp_blank timeout
happens intermittently. link configuration <1, 1.62> could not support
4k mode. dp safe mode 640x480@60hz could be used for all link
configuration test.
Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
---
tests/amdgpu/amd_link_settings.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/tests/amdgpu/amd_link_settings.c b/tests/amdgpu/amd_link_settings.c
index 14c8c4d7..28aa5da5 100644
--- a/tests/amdgpu/amd_link_settings.c
+++ b/tests/amdgpu/amd_link_settings.c
@@ -159,6 +159,21 @@ static void run_link_training_config(data_t *data, igt_output_t *output)
}
}
+static const drmModeModeInfo dp_safe_mode_640_480 = {
+ .name = "640x480",
+ .vrefresh = 60,
+ .clock = 25200,
+ .hdisplay = 640,
+ .hsync_start = 656,
+ .hsync_end = 752,
+ .htotal = 800,
+ .vdisplay = 480,
+ .vsync_start = 490,
+ .vsync_end = 492,
+ .vtotal = 525,
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
static void test_link_training_configs(data_t *data)
{
const drmModeModeInfo *orig_mode;
@@ -177,7 +192,12 @@ static void test_link_training_configs(data_t *data)
/* Init only if display supports link_settings */
test_init(data, output);
- orig_mode = igt_output_get_mode(output);
+ /* run_link_training_config run test from <1, 1.62>
+ * to highest link configuration. to make sure mode timing
+ * be fitted into <1, 1.62> and higher configuration, use
+ * dp safe mode 640x480@60hz
+ */
+ orig_mode = &dp_safe_mode_640_480;
igt_assert(orig_mode);
igt_output_override_mode(output, orig_mode);
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test
2023-04-24 14:16 Hersen Wu
@ 2023-04-24 16:46 ` Rodrigo Siqueira Jordao
2023-04-24 19:08 ` Wu, Hersen
0 siblings, 1 reply; 10+ messages in thread
From: Rodrigo Siqueira Jordao @ 2023-04-24 16:46 UTC (permalink / raw)
To: Hersen Wu, igt-dev, aurabindo.pillai, alex.hung, hamza.mahfooz
On 4/24/23 08:16, Hersen Wu wrote:
> with 4k dp connected, amdgpu kernel warning mesaage dp_blank timeout
/mesaage/message/
> happens intermittently. link configuration <1, 162> could not support
Do you mean 1.62?
> 4k mode. dp safe mode 640x480@60hz could be used for all link
Is this safe mode defined in the spec?
Also, after set to this safe mode this test stop to be intermittently?
> configuration test.
>
> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
> ---
> tests/amdgpu/amd_link_settings.c | 25 ++++++++++++++++++++++++-
> 1 file changed, 24 insertions(+), 1 deletion(-)
>
> diff --git a/tests/amdgpu/amd_link_settings.c b/tests/amdgpu/amd_link_settings.c
> index 14c8c4d7..ec5e6fe5 100644
> --- a/tests/amdgpu/amd_link_settings.c
> +++ b/tests/amdgpu/amd_link_settings.c
> @@ -159,6 +159,24 @@ static void run_link_training_config(data_t *data, igt_output_t *output)
> }
> }
>
> +static const drmModeModeInfo dp_safe_mode_640_480 = {
> + .name = "640x480",
> + .vrefresh = 60,
> + .clock = 25200,
> +
> + .hdisplay = 640,
> + .hsync_start = 656,
> + .hsync_end = 752,
> + .htotal = 800,
> +
> + .vdisplay = 480,
> + .vsync_start = 490,
> + .vsync_end = 492,
> + .vtotal = 525,
> +
> + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> static void test_link_training_configs(data_t *data)
> {
> const drmModeModeInfo *orig_mode;
> @@ -177,7 +195,12 @@ static void test_link_training_configs(data_t *data)
> /* Init only if display supports link_settings */
> test_init(data, output);
>
> - orig_mode = igt_output_get_mode(output);
> + /* run_link_training_config run test from <1, 1.62>
> + * to highest link configuration. to make sure mode timing
> + * be fitted into <1, 1.62> and higher configuration, use
> + * dp safe mode 640x480@60hz
> + */
> + orig_mode = &dp_safe_mode_640_480;
> igt_assert(orig_mode);
> igt_output_override_mode(output, orig_mode);
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test (rev2)
2023-04-24 16:32 [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test Hersen Wu
@ 2023-04-24 17:40 ` Patchwork
2023-04-24 20:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
1 sibling, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-04-24 17:40 UTC (permalink / raw)
To: Hersen Wu; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 4433 bytes --]
== Series Details ==
Series: tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test (rev2)
URL : https://patchwork.freedesktop.org/series/116892/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13054 -> IGTPW_8849
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/index.html
Participating hosts (38 -> 37)
------------------------------
Additional (1): fi-kbl-soraka
Missing (2): bat-mtlp-8 fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8849 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][3] -> [ABORT][4] ([i915#7911] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/fi-bsw-nick/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][5] ([i915#1886])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: NOTRUN -> [ABORT][6] ([i915#4983] / [i915#8384])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271]) +16 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
- bat-dg2-8: [PASS][8] -> [FAIL][9] ([i915#7932])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
#### Possible fixes ####
* igt@i915_selftest@live@migrate:
- bat-adlp-6: [DMESG-FAIL][10] ([i915#7699]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/bat-adlp-6/igt@i915_selftest@live@migrate.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/bat-adlp-6/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][12] ([i915#4983] / [i915#7911]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/bat-rpls-1/igt@i915_selftest@live@requests.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/bat-rpls-1/igt@i915_selftest@live@requests.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7266 -> IGTPW_8849
CI-20190529: 20190529
CI_DRM_13054: 8cabe2adb8e028197f9535daffd3d5ff98d51d8b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8849: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/index.html
IGT_7266: 94411dd85f9ad6d76fb7b2097197122703a3914c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/index.html
[-- Attachment #2: Type: text/html, Size: 5513 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test
2023-04-24 16:46 ` Rodrigo Siqueira Jordao
@ 2023-04-24 19:08 ` Wu, Hersen
2023-04-25 21:32 ` Wu, Hersen
0 siblings, 1 reply; 10+ messages in thread
From: Wu, Hersen @ 2023-04-24 19:08 UTC (permalink / raw)
To: Siqueira, Rodrigo, igt-dev@lists.freedesktop.org,
Pillai, Aurabindo, Hung, Alex, Mahfooz, Hamza
[AMD Official Use Only - General]
Reply in-line.
-----Original Message-----
From: Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
Sent: Monday, April 24, 2023 12:46 PM
To: Wu, Hersen <hersenxs.wu@amd.com>; igt-dev@lists.freedesktop.org; Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; Hung, Alex <Alex.Hung@amd.com>; Mahfooz, Hamza <Hamza.Mahfooz@amd.com>
Subject: Re: [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test
On 4/24/23 08:16, Hersen Wu wrote:
> with 4k dp connected, amdgpu kernel warning mesaage dp_blank timeout
/mesaage/message/
> happens intermittently. link configuration <1, 162> could not support
Do you mean 1.62?
[Hersen] typos. Fix in review version2.
> 4k mode. dp safe mode 640x480@60hz could be used for all link
Is this safe mode defined in the spec?
[Hersen] DP safe mode is defined within DP specification and DP Link Layer Compliance Test Specification.
Also, after set to this safe mode this test stop to be intermittently?
{Hersen] Run 30 loops of test, the issue could not be reproduced.
> configuration test.
>
> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
> ---
> tests/amdgpu/amd_link_settings.c | 25 ++++++++++++++++++++++++-
> 1 file changed, 24 insertions(+), 1 deletion(-)
>
> diff --git a/tests/amdgpu/amd_link_settings.c b/tests/amdgpu/amd_link_settings.c
> index 14c8c4d7..ec5e6fe5 100644
> --- a/tests/amdgpu/amd_link_settings.c
> +++ b/tests/amdgpu/amd_link_settings.c
> @@ -159,6 +159,24 @@ static void run_link_training_config(data_t *data, igt_output_t *output)
> }
> }
>
> +static const drmModeModeInfo dp_safe_mode_640_480 = {
> + .name = "640x480",
> + .vrefresh = 60,
> + .clock = 25200,
> +
> + .hdisplay = 640,
> + .hsync_start = 656,
> + .hsync_end = 752,
> + .htotal = 800,
> +
> + .vdisplay = 480,
> + .vsync_start = 490,
> + .vsync_end = 492,
> + .vtotal = 525,
> +
> + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> static void test_link_training_configs(data_t *data)
> {
> const drmModeModeInfo *orig_mode;
> @@ -177,7 +195,12 @@ static void test_link_training_configs(data_t *data)
> /* Init only if display supports link_settings */
> test_init(data, output);
>
> - orig_mode = igt_output_get_mode(output);
> + /* run_link_training_config run test from <1, 1.62>
> + * to highest link configuration. to make sure mode timing
> + * be fitted into <1, 1.62> and higher configuration, use
> + * dp safe mode 640x480@60hz
> + */
> + orig_mode = &dp_safe_mode_640_480;
> igt_assert(orig_mode);
> igt_output_override_mode(output, orig_mode);
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test (rev2)
2023-04-24 16:32 [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test Hersen Wu
2023-04-24 17:40 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test (rev2) Patchwork
@ 2023-04-24 20:59 ` Patchwork
1 sibling, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-04-24 20:59 UTC (permalink / raw)
To: Wu, Hersen; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 16223 bytes --]
== Series Details ==
Series: tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test (rev2)
URL : https://patchwork.freedesktop.org/series/116892/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13054_full -> IGTPW_8849_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8849_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-1-pipe-b-vga-1} (NEW):
- shard-snb: NOTRUN -> [FAIL][1] +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-snb1/igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-1-pipe-b-vga-1.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_mmap_offset@clear@smem0:
- {shard-dg1}: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-dg1-14/igt@gem_mmap_offset@clear@smem0.html
New tests
---------
New tests have been introduced between CI_DRM_13054_full and IGTPW_8849_full:
### New IGT tests (4) ###
* igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-1-pipe-b-vga-1:
- Statuses : 1 fail(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-a-vga-1-pipe-b-hdmi-a-1:
- Statuses : 1 fail(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-b-hdmi-a-1-pipe-a-vga-1:
- Statuses : 1 fail(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-b-vga-1-pipe-a-hdmi-a-1:
- Statuses : 1 fail(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_8849_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-apl: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-apl2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-apl1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][5] -> [ABORT][6] ([i915#5566])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-glk6/igt@gen9_exec_parse@allowed-single.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-glk1/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][7] -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-apl1/igt@i915_pm_dc@dc9-dpms.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-apl4/igt@i915_pm_dc@dc9-dpms.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][9] -> [FAIL][10] ([i915#2346])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#79])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-nonexisting-fb:
- shard-snb: NOTRUN -> [SKIP][13] ([fdo#109271]) +24 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-snb2/igt@kms_flip@2x-nonexisting-fb.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][14] -> [FAIL][15] ([i915#2122])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-glk3/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-glk2/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_plane_scaling@i915-max-src-size:
- shard-apl: NOTRUN -> [SKIP][16] ([fdo#109271])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-apl7/igt@kms_plane_scaling@i915-max-src-size.html
- shard-glk: NOTRUN -> [SKIP][17] ([fdo#109271])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-glk7/igt@kms_plane_scaling@i915-max-src-size.html
#### Possible fixes ####
* igt@gem_barrier_race@remote-request@rcs0:
- {shard-dg1}: [ABORT][18] ([i915#8234]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-dg1-18/igt@gem_barrier_race@remote-request@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-dg1-16/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_exec_fair@basic-none@bcs0:
- {shard-rkl}: [FAIL][20] ([i915#2842]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-rkl-6/igt@gem_exec_fair@basic-none@bcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-rkl-4/igt@gem_exec_fair@basic-none@bcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][22] ([i915#2842]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-tglu}: [SKIP][24] ([i915#4281]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-tglu-3/igt@i915_pm_dc@dc9-dpms.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-tglu-9/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@modeset-non-lpsp:
- {shard-rkl}: [SKIP][26] ([i915#1397]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-rkl-3/igt@i915_pm_rpm@modeset-non-lpsp.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1:
- shard-glk: [FAIL][28] ([i915#2521]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-glk1/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-glk4/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][30] ([i915#2346]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5431]: https://gitlab.freedesktop.org/drm/intel/issues/5431
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8308]: https://gitlab.freedesktop.org/drm/intel/issues/8308
[i915#8311]: https://gitlab.freedesktop.org/drm/intel/issues/8311
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7266 -> IGTPW_8849
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13054: 8cabe2adb8e028197f9535daffd3d5ff98d51d8b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8849: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/index.html
IGT_7266: 94411dd85f9ad6d76fb7b2097197122703a3914c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8849/index.html
[-- Attachment #2: Type: text/html, Size: 10625 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test
2023-04-24 19:08 ` Wu, Hersen
@ 2023-04-25 21:32 ` Wu, Hersen
0 siblings, 0 replies; 10+ messages in thread
From: Wu, Hersen @ 2023-04-25 21:32 UTC (permalink / raw)
To: Siqueira, Rodrigo, igt-dev@lists.freedesktop.org,
Pillai, Aurabindo, Hung, Alex, Mahfooz, Hamza
[AMD Official Use Only - General]
For DP bandwidth vs video timing, you please refer to https://en.wikipedia.org/wiki/DisplayPort
Here is rough calculation of video timing and DP lane bandwidth.
video mode timing needs bandwidth in bits:
pixel_clock x bit_per_color x 3
3840x2160@60hz pixel clock could be 594Mhz. For bits_per_color =8.
594x1,000,000 x 8 x 3 = 14,256 x 1,000,000
DP lane support bandwidth in bits. Be aware that 10 bits of DP lane (including control bit etc.) consists of 1 DP symbol (8bits).
20 percent of DP lane bandwidth is used for control, not for pixel data.
(link_rate X Lane_count) * (8 /10)
<1 Lane, 1.62GHz> DP lane:
((1 x 1.62 x 1,000,000,000) * (8 /10) = 1,296 x ,1000,1000
-----Original Message-----
From: Wu, Hersen
Sent: Monday, April 24, 2023 3:09 PM
To: Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; igt-dev@lists.freedesktop.org; Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; Hung, Alex <Alex.Hung@amd.com>; Mahfooz, Hamza <Hamza.Mahfooz@amd.com>
Subject: RE: [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test
[AMD Official Use Only - General]
Reply in-line.
-----Original Message-----
From: Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
Sent: Monday, April 24, 2023 12:46 PM
To: Wu, Hersen <hersenxs.wu@amd.com>; igt-dev@lists.freedesktop.org; Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; Hung, Alex <Alex.Hung@amd.com>; Mahfooz, Hamza <Hamza.Mahfooz@amd.com>
Subject: Re: [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test
On 4/24/23 08:16, Hersen Wu wrote:
> with 4k dp connected, amdgpu kernel warning mesaage dp_blank timeout
/mesaage/message/
> happens intermittently. link configuration <1, 162> could not support
Do you mean 1.62?
[Hersen] typos. Fix in review version2.
> 4k mode. dp safe mode 640x480@60hz could be used for all link
Is this safe mode defined in the spec?
[Hersen] DP safe mode is defined within DP specification and DP Link Layer Compliance Test Specification.
Also, after set to this safe mode this test stop to be intermittently?
{Hersen] Run 30 loops of test, the issue could not be reproduced.
> configuration test.
>
> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
> ---
> tests/amdgpu/amd_link_settings.c | 25 ++++++++++++++++++++++++-
> 1 file changed, 24 insertions(+), 1 deletion(-)
>
> diff --git a/tests/amdgpu/amd_link_settings.c b/tests/amdgpu/amd_link_settings.c
> index 14c8c4d7..ec5e6fe5 100644
> --- a/tests/amdgpu/amd_link_settings.c
> +++ b/tests/amdgpu/amd_link_settings.c
> @@ -159,6 +159,24 @@ static void run_link_training_config(data_t *data, igt_output_t *output)
> }
> }
>
> +static const drmModeModeInfo dp_safe_mode_640_480 = {
> + .name = "640x480",
> + .vrefresh = 60,
> + .clock = 25200,
> +
> + .hdisplay = 640,
> + .hsync_start = 656,
> + .hsync_end = 752,
> + .htotal = 800,
> +
> + .vdisplay = 480,
> + .vsync_start = 490,
> + .vsync_end = 492,
> + .vtotal = 525,
> +
> + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> static void test_link_training_configs(data_t *data)
> {
> const drmModeModeInfo *orig_mode;
> @@ -177,7 +195,12 @@ static void test_link_training_configs(data_t *data)
> /* Init only if display supports link_settings */
> test_init(data, output);
>
> - orig_mode = igt_output_get_mode(output);
> + /* run_link_training_config run test from <1, 1.62>
> + * to highest link configuration. to make sure mode timing
> + * be fitted into <1, 1.62> and higher configuration, use
> + * dp safe mode 640x480@60hz
> + */
> + orig_mode = &dp_safe_mode_640_480;
> igt_assert(orig_mode);
> igt_output_override_mode(output, orig_mode);
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test
@ 2023-04-25 21:44 Hersen Wu
0 siblings, 0 replies; 10+ messages in thread
From: Hersen Wu @ 2023-04-25 21:44 UTC (permalink / raw)
To: igt-dev, rodrigo.siqueira, aurabindo.pillai, alex.hung,
hamza.mahfooz
Cc: Hersen Wu
with 4k dp connected, amdgpu kernel warning messaage dp_blank timeout
happens intermittently. link configuration <1, 1.62> could not support
4k mode. dp safe mode 640x480@60hz could be used for all link
configuration test.
video timing bw in bits: pixel_clock x bits_per_color x 3
dp lane bw in bits: link_rate x lane_count x 8 / 10
Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
---
tests/amdgpu/amd_link_settings.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/tests/amdgpu/amd_link_settings.c b/tests/amdgpu/amd_link_settings.c
index 14c8c4d7..28aa5da5 100644
--- a/tests/amdgpu/amd_link_settings.c
+++ b/tests/amdgpu/amd_link_settings.c
@@ -159,6 +159,21 @@ static void run_link_training_config(data_t *data, igt_output_t *output)
}
}
+static const drmModeModeInfo dp_safe_mode_640_480 = {
+ .name = "640x480",
+ .vrefresh = 60,
+ .clock = 25200,
+ .hdisplay = 640,
+ .hsync_start = 656,
+ .hsync_end = 752,
+ .htotal = 800,
+ .vdisplay = 480,
+ .vsync_start = 490,
+ .vsync_end = 492,
+ .vtotal = 525,
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
static void test_link_training_configs(data_t *data)
{
const drmModeModeInfo *orig_mode;
@@ -177,7 +192,12 @@ static void test_link_training_configs(data_t *data)
/* Init only if display supports link_settings */
test_init(data, output);
- orig_mode = igt_output_get_mode(output);
+ /* run_link_training_config run test from <1, 1.62>
+ * to highest link configuration. to make sure mode timing
+ * be fitted into <1, 1.62> and higher configuration, use
+ * dp safe mode 640x480@60hz
+ */
+ orig_mode = &dp_safe_mode_640_480;
igt_assert(orig_mode);
igt_output_override_mode(output, orig_mode);
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test
@ 2023-04-25 21:47 Hersen Wu
2023-04-25 22:57 ` Alex Hung
0 siblings, 1 reply; 10+ messages in thread
From: Hersen Wu @ 2023-04-25 21:47 UTC (permalink / raw)
To: igt-dev, rodrigo.siqueira, aurabindo.pillai, alex.hung,
hamza.mahfooz
Cc: Hersen Wu
with 4k dp connected, amdgpu kernel warning message dp_blank timeout
happens intermittently. link configuration <1, 1.62> could not support
4k mode. dp safe mode 640x480@60hz could be used for all link
configuration test.
video timing bw in bits: pixel_clock x bits_per_color x 3
dp lane bw in bits: link_rate x lane_count x 8 / 10
Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
---
tests/amdgpu/amd_link_settings.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/tests/amdgpu/amd_link_settings.c b/tests/amdgpu/amd_link_settings.c
index 14c8c4d7..28aa5da5 100644
--- a/tests/amdgpu/amd_link_settings.c
+++ b/tests/amdgpu/amd_link_settings.c
@@ -159,6 +159,21 @@ static void run_link_training_config(data_t *data, igt_output_t *output)
}
}
+static const drmModeModeInfo dp_safe_mode_640_480 = {
+ .name = "640x480",
+ .vrefresh = 60,
+ .clock = 25200,
+ .hdisplay = 640,
+ .hsync_start = 656,
+ .hsync_end = 752,
+ .htotal = 800,
+ .vdisplay = 480,
+ .vsync_start = 490,
+ .vsync_end = 492,
+ .vtotal = 525,
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
static void test_link_training_configs(data_t *data)
{
const drmModeModeInfo *orig_mode;
@@ -177,7 +192,12 @@ static void test_link_training_configs(data_t *data)
/* Init only if display supports link_settings */
test_init(data, output);
- orig_mode = igt_output_get_mode(output);
+ /* run_link_training_config run test from <1, 1.62>
+ * to highest link configuration. to make sure mode timing
+ * be fitted into <1, 1.62> and higher configuration, use
+ * dp safe mode 640x480@60hz
+ */
+ orig_mode = &dp_safe_mode_640_480;
igt_assert(orig_mode);
igt_output_override_mode(output, orig_mode);
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test
2023-04-25 21:47 [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test Hersen Wu
@ 2023-04-25 22:57 ` Alex Hung
0 siblings, 0 replies; 10+ messages in thread
From: Alex Hung @ 2023-04-25 22:57 UTC (permalink / raw)
To: Hersen Wu, igt-dev, rodrigo.siqueira, aurabindo.pillai,
hamza.mahfooz
Reviewed-by: Alex Hung <alex.hung@amd.com>
On 2023-04-25 15:47, Hersen Wu wrote:
> with 4k dp connected, amdgpu kernel warning message dp_blank timeout
> happens intermittently. link configuration <1, 1.62> could not support
> 4k mode. dp safe mode 640x480@60hz could be used for all link
> configuration test.
>
> video timing bw in bits: pixel_clock x bits_per_color x 3
> dp lane bw in bits: link_rate x lane_count x 8 / 10
>
> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
> ---
> tests/amdgpu/amd_link_settings.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/tests/amdgpu/amd_link_settings.c b/tests/amdgpu/amd_link_settings.c
> index 14c8c4d7..28aa5da5 100644
> --- a/tests/amdgpu/amd_link_settings.c
> +++ b/tests/amdgpu/amd_link_settings.c
> @@ -159,6 +159,21 @@ static void run_link_training_config(data_t *data, igt_output_t *output)
> }
> }
>
> +static const drmModeModeInfo dp_safe_mode_640_480 = {
> + .name = "640x480",
> + .vrefresh = 60,
> + .clock = 25200,
> + .hdisplay = 640,
> + .hsync_start = 656,
> + .hsync_end = 752,
> + .htotal = 800,
> + .vdisplay = 480,
> + .vsync_start = 490,
> + .vsync_end = 492,
> + .vtotal = 525,
> + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> static void test_link_training_configs(data_t *data)
> {
> const drmModeModeInfo *orig_mode;
> @@ -177,7 +192,12 @@ static void test_link_training_configs(data_t *data)
> /* Init only if display supports link_settings */
> test_init(data, output);
>
> - orig_mode = igt_output_get_mode(output);
> + /* run_link_training_config run test from <1, 1.62>
> + * to highest link configuration. to make sure mode timing
> + * be fitted into <1, 1.62> and higher configuration, use
> + * dp safe mode 640x480@60hz
> + */
> + orig_mode = &dp_safe_mode_640_480;
> igt_assert(orig_mode);
> igt_output_override_mode(output, orig_mode);
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-04-25 22:57 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-24 16:32 [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test Hersen Wu
2023-04-24 17:40 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test (rev2) Patchwork
2023-04-24 20:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-04-25 21:47 [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_link_settings: use mode 640x480 for link configuration test Hersen Wu
2023-04-25 22:57 ` Alex Hung
2023-04-25 21:44 Hersen Wu
2023-04-24 14:16 Hersen Wu
2023-04-24 16:46 ` Rodrigo Siqueira Jordao
2023-04-24 19:08 ` Wu, Hersen
2023-04-25 21:32 ` Wu, Hersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox