* [igt-dev] [PATCH i-g-t v3] tests/xe_create: Add multiple engines create/destroy subtest
@ 2023-06-07 18:23 Zbigniew Kempczyński
2023-06-07 21:12 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/xe_create: Add multiple engines create/destroy subtest (rev3) Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Zbigniew Kempczyński @ 2023-06-07 18:23 UTC (permalink / raw)
To: igt-dev
Exercise basic engine concurrency create/destroy functionality.
v2: use different random seeds in children to avoid same engine
pattern selection (Kamil)
check execution time and report failure if it's too long (Kamil)
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
tests/xe/xe_create.c | 106 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 106 insertions(+)
diff --git a/tests/xe/xe_create.c b/tests/xe/xe_create.c
index ae21154646..d85a22567c 100644
--- a/tests/xe/xe_create.c
+++ b/tests/xe/xe_create.c
@@ -88,6 +88,106 @@ static void create_invalid_size(int fd)
xe_vm_destroy(fd, vm);
}
+enum engine_destroy {
+ NOLEAK,
+ LEAK
+};
+
+static uint32_t __xe_engine_create(int fd, uint32_t vm,
+ struct drm_xe_engine_class_instance *instance,
+ uint64_t ext,
+ uint32_t *enginep)
+{
+ struct drm_xe_engine_create create = {
+ .extensions = ext,
+ .vm_id = vm,
+ .width = 1,
+ .num_placements = 1,
+ .instances = to_user_pointer(instance),
+ };
+ int err = 0;
+
+ if (igt_ioctl(fd, DRM_IOCTL_XE_ENGINE_CREATE, &create) == 0) {
+ *enginep = create.engine_id;
+ } else {
+ igt_warn("Can't create engine, errno: %d\n", errno);
+ err = -errno;
+ igt_assume(err);
+ }
+ errno = 0;
+
+ return err;
+}
+
+#define MAXENGINES 2048
+#define MAXTIME 2
+
+/**
+ * SUBTEST: create-engines-%s
+ * Description: Check process ability of multiple engines creation
+ * Run type: FULL
+ *
+ * arg[1]:
+ *
+ * @noleak: destroy engines in the code
+ * @leak: destroy engines in close() path
+ */
+static void create_engines(int fd, enum engine_destroy ed)
+{
+ struct timespec tv = { };
+ uint32_t num_engines, engines_per_process, vm;
+ int nproc = sysconf(_SC_NPROCESSORS_ONLN), seconds;
+ bool failed = false;
+
+ fd = drm_reopen_driver(fd);
+ num_engines = xe_number_hw_engines(fd);
+ vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
+
+ engines_per_process = max_t(uint32_t, 1, MAXENGINES / nproc);
+ igt_debug("nproc: %u, engines per process: %u\n", nproc, engines_per_process);
+
+ igt_nsec_elapsed(&tv);
+
+ igt_fork(n, nproc) {
+ struct drm_xe_engine_class_instance *hwe;
+ uint32_t engine, engines[engines_per_process];
+ int idx, err, i;
+
+ srandom(n);
+
+ for (i = 0; i < engines_per_process; i++) {
+ idx = rand() % num_engines;
+ hwe = xe_hw_engine(fd, idx);
+ err = __xe_engine_create(fd, vm, hwe, 0, &engine);
+ igt_debug("[%2d] Create engine: err=%d, engine=%u [idx = %d]\n",
+ n, err, engine, i);
+ if (err)
+ break;
+
+ if (ed == NOLEAK)
+ engines[i] = engine;
+ }
+
+ if (ed == NOLEAK) {
+ while (--i >= 0) {
+ igt_debug("[%2d] Destroy engine: %u\n", n, engines[i]);
+ xe_engine_destroy(fd, engines[i]);
+ }
+ }
+ }
+ igt_waitchildren();
+
+ xe_vm_destroy(fd, vm);
+ close(fd);
+
+ seconds = igt_seconds_elapsed(&tv);
+ if (seconds >= MAXTIME)
+ failed = true;
+
+ igt_assert_f(!failed, "Creating %d engines tooks too long: %d [limit: %d]\n",
+ MAXENGINES, seconds, MAXTIME);
+}
+
/**
* SUBTEST: create-massive-size
* Description: Verifies xe bo create returns expected error code on massive
@@ -121,6 +221,12 @@ igt_main
create_invalid_size(xe);
}
+ igt_subtest("create-engines-noleak")
+ create_engines(xe, NOLEAK);
+
+ igt_subtest("create-engines-leak")
+ create_engines(xe, LEAK);
+
igt_subtest("create-massive-size") {
create_massive_size(xe);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/xe_create: Add multiple engines create/destroy subtest (rev3)
2023-06-07 18:23 [igt-dev] [PATCH i-g-t v3] tests/xe_create: Add multiple engines create/destroy subtest Zbigniew Kempczyński
@ 2023-06-07 21:12 ` Patchwork
2023-06-08 13:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-06-09 13:22 ` [igt-dev] [PATCH i-g-t v3] tests/xe_create: Add multiple engines create/destroy subtest Kamil Konieczny
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-06-07 21:12 UTC (permalink / raw)
To: Zbigniew Kempczyński; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 8058 bytes --]
== Series Details ==
Series: tests/xe_create: Add multiple engines create/destroy subtest (rev3)
URL : https://patchwork.freedesktop.org/series/118931/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13244 -> IGTPW_9131
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/index.html
Participating hosts (36 -> 36)
------------------------------
Additional (1): bat-rpls-2
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_9131 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-rpls-2: NOTRUN -> [SKIP][1] ([i915#7456])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@read:
- bat-rpls-2: NOTRUN -> [SKIP][2] ([i915#2582]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@fbdev@read.html
* igt@gem_lmem_swapping@verify-random:
- bat-rpls-2: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@gem_lmem_swapping@verify-random.html
* igt@gem_tiled_pread_basic:
- bat-rpls-2: NOTRUN -> [SKIP][4] ([i915#3282])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-rpls-2: NOTRUN -> [SKIP][5] ([i915#7561])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-rpls-2: NOTRUN -> [SKIP][6] ([i915#6621])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: NOTRUN -> [DMESG-FAIL][7] ([i915#4258] / [i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@requests:
- bat-rpls-2: NOTRUN -> [ABORT][8] ([i915#7913])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@i915_selftest@live@requests.html
* igt@kms_busy@basic:
- bat-rpls-2: NOTRUN -> [SKIP][9] ([i915#1845]) +14 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@kms_busy@basic.html
* igt@kms_chamelium_edid@hdmi-edid-read:
- bat-rpls-2: NOTRUN -> [SKIP][10] ([i915#7828]) +7 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@kms_chamelium_edid@hdmi-edid-read.html
* igt@kms_flip@basic-flip-vs-dpms:
- bat-rpls-2: NOTRUN -> [SKIP][11] ([i915#3637]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-rpls-2: NOTRUN -> [SKIP][12] ([fdo#109285])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- bat-rpls-2: NOTRUN -> [SKIP][13] ([i915#1849])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [PASS][14] -> [FAIL][15] ([i915#7932]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
* igt@kms_psr@sprite_plane_onoff:
- bat-rpls-2: NOTRUN -> [SKIP][16] ([i915#1072]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rpls-2: NOTRUN -> [SKIP][17] ([i915#3555] / [i915#4579])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-rpls-2: NOTRUN -> [SKIP][18] ([fdo#109295] / [i915#1845] / [i915#3708])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-read:
- bat-rpls-2: NOTRUN -> [SKIP][19] ([fdo#109295] / [i915#3708]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-2/igt@prime_vgem@basic-fence-read.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_mocs:
- {bat-mtlp-6}: [DMESG-FAIL][20] ([i915#7059]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: [DMESG-WARN][22] ([i915#6367]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/bat-rpls-1/igt@i915_selftest@live@slpc.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/bat-rpls-1/igt@i915_selftest@live@slpc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4309]: https://gitlab.freedesktop.org/drm/intel/issues/4309
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7321 -> IGTPW_9131
CI-20190529: 20190529
CI_DRM_13244: 622f268216a3f3606524ca6b6b77216590a34ee2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9131: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/index.html
IGT_7321: f52cfd53f353fdaca537c810fbc35e09ffd07345 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@xe_create@create-engines-leak
+igt@xe_create@create-engines-noleak
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/index.html
[-- Attachment #2: Type: text/html, Size: 9097 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/xe_create: Add multiple engines create/destroy subtest (rev3)
2023-06-07 18:23 [igt-dev] [PATCH i-g-t v3] tests/xe_create: Add multiple engines create/destroy subtest Zbigniew Kempczyński
2023-06-07 21:12 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/xe_create: Add multiple engines create/destroy subtest (rev3) Patchwork
@ 2023-06-08 13:16 ` Patchwork
2023-06-09 13:22 ` [igt-dev] [PATCH i-g-t v3] tests/xe_create: Add multiple engines create/destroy subtest Kamil Konieczny
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-06-08 13:16 UTC (permalink / raw)
To: Zbigniew Kempczyński; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 15398 bytes --]
== Series Details ==
Series: tests/xe_create: Add multiple engines create/destroy subtest (rev3)
URL : https://patchwork.freedesktop.org/series/118931/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13244_full -> IGTPW_9131_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in IGTPW_9131_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-glk9/igt@gem_exec_fair@basic-pace@vcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-glk9/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][3] -> [ABORT][4] ([i915#5566])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-glk4/igt@gen9_exec_parse@allowed-single.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-glk1/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_rps@reset:
- shard-snb: [PASS][5] -> [DMESG-FAIL][6] ([i915#8319])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-snb4/igt@i915_pm_rps@reset.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-snb5/igt@i915_pm_rps@reset.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#79])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: [PASS][9] -> [FAIL][10] ([i915#79])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-apl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579]) +5 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-snb1/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-upscale-with-pixel-format-20x20@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][12] ([fdo#109271]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-snb6/igt@kms_plane_scaling@plane-upscale-with-pixel-format-20x20@pipe-a-vga-1.html
* igt@kms_setmode@basic@pipe-a-vga-1:
- shard-snb: NOTRUN -> [FAIL][13] ([i915#5465]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-snb4/igt@kms_setmode@basic@pipe-a-vga-1.html
* igt@perf_pmu@rc6-suspend:
- shard-apl: [PASS][14] -> [ABORT][15] ([i915#180])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-apl3/igt@perf_pmu@rc6-suspend.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-apl3/igt@perf_pmu@rc6-suspend.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][16] ([i915#7742]) -> [PASS][17] +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-rkl-6/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_barrier_race@remote-request@rcs0:
- {shard-tglu}: [ABORT][18] ([i915#8211] / [i915#8234]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-tglu-6/igt@gem_barrier_race@remote-request@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-tglu-2/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_freq@sysfs:
- {shard-dg1}: [FAIL][20] ([i915#6786]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-dg1-17/igt@gem_ctx_freq@sysfs.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-dg1-16/igt@gem_ctx_freq@sysfs.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][22] ([i915#2846]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-glk7/igt@gem_exec_fair@basic-deadline.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-glk7/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][24] ([i915#2842]) -> [PASS][25] +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][26] ([i915#2842]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-rkl-1/igt@gem_exec_fair@basic-pace@rcs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-rkl-7/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_gttfill@basic:
- {shard-dg1}: [DMESG-WARN][28] -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-dg1-19/igt@gem_exec_gttfill@basic.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-dg1-14/igt@gem_exec_gttfill@basic.html
* igt@gem_lmem_swapping@parallel-multi@lmem0:
- {shard-dg1}: [DMESG-WARN][30] ([i915#4391]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-dg1-19/igt@gem_lmem_swapping@parallel-multi@lmem0.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-dg1-16/igt@gem_lmem_swapping@parallel-multi@lmem0.html
* igt@gem_lmem_swapping@parallel-random-verify@lmem0:
- {shard-dg1}: [DMESG-WARN][32] ([i915#4423]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-dg1-13/igt@gem_lmem_swapping@parallel-random-verify@lmem0.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-dg1-16/igt@gem_lmem_swapping@parallel-random-verify@lmem0.html
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- {shard-dg1}: [FAIL][34] ([i915#3591]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-dg1-13/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-dg1-17/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][36] ([i915#1397]) -> [PASS][37] +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-rkl-2/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- {shard-dg1}: [SKIP][38] ([i915#1397]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-dg1-12/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][40] ([i915#2346]) -> [PASS][41] +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
- shard-apl: [FAIL][42] ([i915#1188]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-apl4/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-apl4/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
* igt@perf_pmu@most-busy-idle-check-all@rcs0:
- {shard-dg1}: [FAIL][44] ([i915#5234]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13244/shard-dg1-14/igt@perf_pmu@most-busy-idle-check-all@rcs0.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/shard-dg1-15/igt@perf_pmu@most-busy-idle-check-all@rcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5234]: https://gitlab.freedesktop.org/drm/intel/issues/5234
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8319]: https://gitlab.freedesktop.org/drm/intel/issues/8319
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7321 -> IGTPW_9131
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13244: 622f268216a3f3606524ca6b6b77216590a34ee2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9131: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/index.html
IGT_7321: f52cfd53f353fdaca537c810fbc35e09ffd07345 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9131/index.html
[-- Attachment #2: Type: text/html, Size: 12673 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v3] tests/xe_create: Add multiple engines create/destroy subtest
2023-06-07 18:23 [igt-dev] [PATCH i-g-t v3] tests/xe_create: Add multiple engines create/destroy subtest Zbigniew Kempczyński
2023-06-07 21:12 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/xe_create: Add multiple engines create/destroy subtest (rev3) Patchwork
2023-06-08 13:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2023-06-09 13:22 ` Kamil Konieczny
2023-06-12 5:35 ` Zbigniew Kempczyński
2 siblings, 1 reply; 5+ messages in thread
From: Kamil Konieczny @ 2023-06-09 13:22 UTC (permalink / raw)
To: igt-dev
Hi Zbigniew,
On 2023-06-07 at 20:23:13 +0200, Zbigniew Kempczyński wrote:
> Exercise basic engine concurrency create/destroy functionality.
>
> v2: use different random seeds in children to avoid same engine
> pattern selection (Kamil)
> check execution time and report failure if it's too long (Kamil)
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> tests/xe/xe_create.c | 106 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 106 insertions(+)
>
> diff --git a/tests/xe/xe_create.c b/tests/xe/xe_create.c
> index ae21154646..d85a22567c 100644
> --- a/tests/xe/xe_create.c
> +++ b/tests/xe/xe_create.c
> @@ -88,6 +88,106 @@ static void create_invalid_size(int fd)
> xe_vm_destroy(fd, vm);
> }
>
> +enum engine_destroy {
> + NOLEAK,
> + LEAK
> +};
> +
> +static uint32_t __xe_engine_create(int fd, uint32_t vm,
> + struct drm_xe_engine_class_instance *instance,
> + uint64_t ext,
> + uint32_t *enginep)
> +{
> + struct drm_xe_engine_create create = {
> + .extensions = ext,
> + .vm_id = vm,
> + .width = 1,
> + .num_placements = 1,
> + .instances = to_user_pointer(instance),
> + };
> + int err = 0;
> +
> + if (igt_ioctl(fd, DRM_IOCTL_XE_ENGINE_CREATE, &create) == 0) {
> + *enginep = create.engine_id;
> + } else {
> + igt_warn("Can't create engine, errno: %d\n", errno);
> + err = -errno;
> + igt_assume(err);
> + }
> + errno = 0;
> +
> + return err;
> +}
> +
> +#define MAXENGINES 2048
> +#define MAXTIME 2
> +
> +/**
> + * SUBTEST: create-engines-%s
> + * Description: Check process ability of multiple engines creation
> + * Run type: FULL
> + *
> + * arg[1]:
> + *
> + * @noleak: destroy engines in the code
> + * @leak: destroy engines in close() path
> + */
> +static void create_engines(int fd, enum engine_destroy ed)
> +{
> + struct timespec tv = { };
> + uint32_t num_engines, engines_per_process, vm;
> + int nproc = sysconf(_SC_NPROCESSORS_ONLN), seconds;
> + bool failed = false;
> +
> + fd = drm_reopen_driver(fd);
> + num_engines = xe_number_hw_engines(fd);
> + vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
> +
> + engines_per_process = max_t(uint32_t, 1, MAXENGINES / nproc);
> + igt_debug("nproc: %u, engines per process: %u\n", nproc, engines_per_process);
> +
> + igt_nsec_elapsed(&tv);
> +
> + igt_fork(n, nproc) {
> + struct drm_xe_engine_class_instance *hwe;
> + uint32_t engine, engines[engines_per_process];
> + int idx, err, i;
> +
> + srandom(n);
> +
> + for (i = 0; i < engines_per_process; i++) {
> + idx = rand() % num_engines;
> + hwe = xe_hw_engine(fd, idx);
> + err = __xe_engine_create(fd, vm, hwe, 0, &engine);
> + igt_debug("[%2d] Create engine: err=%d, engine=%u [idx = %d]\n",
> + n, err, engine, i);
> + if (err)
> + break;
> +
> + if (ed == NOLEAK)
> + engines[i] = engine;
> + }
> +
> + if (ed == NOLEAK) {
> + while (--i >= 0) {
> + igt_debug("[%2d] Destroy engine: %u\n", n, engines[i]);
> + xe_engine_destroy(fd, engines[i]);
> + }
> + }
> + }
> + igt_waitchildren();
> +
> + xe_vm_destroy(fd, vm);
> + close(fd);
> +
> + seconds = igt_seconds_elapsed(&tv);
> + if (seconds >= MAXTIME)
> + failed = true;
--------------- ^
This is the only place when you set it to true and use it
below, so maybe drop this var ?
> +
> + igt_assert_f(!failed, "Creating %d engines tooks too long: %d [limit: %d]\n",
-------------------- ^
igt_assert_f(seconds <= MAXTIME, ...)
Regards,
Kamil
> + MAXENGINES, seconds, MAXTIME);
> +}
> +
> /**
> * SUBTEST: create-massive-size
> * Description: Verifies xe bo create returns expected error code on massive
> @@ -121,6 +221,12 @@ igt_main
> create_invalid_size(xe);
> }
>
> + igt_subtest("create-engines-noleak")
> + create_engines(xe, NOLEAK);
> +
> + igt_subtest("create-engines-leak")
> + create_engines(xe, LEAK);
> +
> igt_subtest("create-massive-size") {
> create_massive_size(xe);
> }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v3] tests/xe_create: Add multiple engines create/destroy subtest
2023-06-09 13:22 ` [igt-dev] [PATCH i-g-t v3] tests/xe_create: Add multiple engines create/destroy subtest Kamil Konieczny
@ 2023-06-12 5:35 ` Zbigniew Kempczyński
0 siblings, 0 replies; 5+ messages in thread
From: Zbigniew Kempczyński @ 2023-06-12 5:35 UTC (permalink / raw)
To: Kamil Konieczny, igt-dev, Zbigniew Kempczyński
On Fri, Jun 09, 2023 at 03:22:27PM +0200, Kamil Konieczny wrote:
> Hi Zbigniew,
>
> On 2023-06-07 at 20:23:13 +0200, Zbigniew Kempczyński wrote:
> > Exercise basic engine concurrency create/destroy functionality.
> >
> > v2: use different random seeds in children to avoid same engine
> > pattern selection (Kamil)
> > check execution time and report failure if it's too long (Kamil)
> >
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> > ---
> > tests/xe/xe_create.c | 106 +++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 106 insertions(+)
> >
> > diff --git a/tests/xe/xe_create.c b/tests/xe/xe_create.c
> > index ae21154646..d85a22567c 100644
> > --- a/tests/xe/xe_create.c
> > +++ b/tests/xe/xe_create.c
> > @@ -88,6 +88,106 @@ static void create_invalid_size(int fd)
> > xe_vm_destroy(fd, vm);
> > }
> >
> > +enum engine_destroy {
> > + NOLEAK,
> > + LEAK
> > +};
> > +
> > +static uint32_t __xe_engine_create(int fd, uint32_t vm,
> > + struct drm_xe_engine_class_instance *instance,
> > + uint64_t ext,
> > + uint32_t *enginep)
> > +{
> > + struct drm_xe_engine_create create = {
> > + .extensions = ext,
> > + .vm_id = vm,
> > + .width = 1,
> > + .num_placements = 1,
> > + .instances = to_user_pointer(instance),
> > + };
> > + int err = 0;
> > +
> > + if (igt_ioctl(fd, DRM_IOCTL_XE_ENGINE_CREATE, &create) == 0) {
> > + *enginep = create.engine_id;
> > + } else {
> > + igt_warn("Can't create engine, errno: %d\n", errno);
> > + err = -errno;
> > + igt_assume(err);
> > + }
> > + errno = 0;
> > +
> > + return err;
> > +}
> > +
> > +#define MAXENGINES 2048
> > +#define MAXTIME 2
> > +
> > +/**
> > + * SUBTEST: create-engines-%s
> > + * Description: Check process ability of multiple engines creation
> > + * Run type: FULL
> > + *
> > + * arg[1]:
> > + *
> > + * @noleak: destroy engines in the code
> > + * @leak: destroy engines in close() path
> > + */
> > +static void create_engines(int fd, enum engine_destroy ed)
> > +{
> > + struct timespec tv = { };
> > + uint32_t num_engines, engines_per_process, vm;
> > + int nproc = sysconf(_SC_NPROCESSORS_ONLN), seconds;
> > + bool failed = false;
> > +
> > + fd = drm_reopen_driver(fd);
> > + num_engines = xe_number_hw_engines(fd);
> > + vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
> > +
> > + engines_per_process = max_t(uint32_t, 1, MAXENGINES / nproc);
> > + igt_debug("nproc: %u, engines per process: %u\n", nproc, engines_per_process);
> > +
> > + igt_nsec_elapsed(&tv);
> > +
> > + igt_fork(n, nproc) {
> > + struct drm_xe_engine_class_instance *hwe;
> > + uint32_t engine, engines[engines_per_process];
> > + int idx, err, i;
> > +
> > + srandom(n);
> > +
> > + for (i = 0; i < engines_per_process; i++) {
> > + idx = rand() % num_engines;
> > + hwe = xe_hw_engine(fd, idx);
> > + err = __xe_engine_create(fd, vm, hwe, 0, &engine);
> > + igt_debug("[%2d] Create engine: err=%d, engine=%u [idx = %d]\n",
> > + n, err, engine, i);
> > + if (err)
> > + break;
> > +
> > + if (ed == NOLEAK)
> > + engines[i] = engine;
> > + }
> > +
> > + if (ed == NOLEAK) {
> > + while (--i >= 0) {
> > + igt_debug("[%2d] Destroy engine: %u\n", n, engines[i]);
> > + xe_engine_destroy(fd, engines[i]);
> > + }
> > + }
> > + }
> > + igt_waitchildren();
> > +
> > + xe_vm_destroy(fd, vm);
> > + close(fd);
> > +
> > + seconds = igt_seconds_elapsed(&tv);
> > + if (seconds >= MAXTIME)
> > + failed = true;
> --------------- ^
> This is the only place when you set it to true and use it
> below, so maybe drop this var ?
>
> > +
> > + igt_assert_f(!failed, "Creating %d engines tooks too long: %d [limit: %d]\n",
> -------------------- ^
> igt_assert_f(seconds <= MAXTIME, ...)
>
Sure, with your change looks better.
--
Zbigniew
> Regards,
> Kamil
>
> > + MAXENGINES, seconds, MAXTIME);
> > +}
> > +
> > /**
> > * SUBTEST: create-massive-size
> > * Description: Verifies xe bo create returns expected error code on massive
> > @@ -121,6 +221,12 @@ igt_main
> > create_invalid_size(xe);
> > }
> >
> > + igt_subtest("create-engines-noleak")
> > + create_engines(xe, NOLEAK);
> > +
> > + igt_subtest("create-engines-leak")
> > + create_engines(xe, LEAK);
> > +
> > igt_subtest("create-massive-size") {
> > create_massive_size(xe);
> > }
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-12 5:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-07 18:23 [igt-dev] [PATCH i-g-t v3] tests/xe_create: Add multiple engines create/destroy subtest Zbigniew Kempczyński
2023-06-07 21:12 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/xe_create: Add multiple engines create/destroy subtest (rev3) Patchwork
2023-06-08 13:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-06-09 13:22 ` [igt-dev] [PATCH i-g-t v3] tests/xe_create: Add multiple engines create/destroy subtest Kamil Konieczny
2023-06-12 5:35 ` Zbigniew Kempczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox