[igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner

[igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner

[Nidhi Gupta]

Pipe D is invalid in big joiner and because of that currently
test throws as skip for all the pipes and as it is within the
dynamic subtest block.
Fixed in IGT to skip the big joiner validity check for pipe-D
and execute for the rest of the pipes as it is.

Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
 tests/kms_plane_cursor.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
index 59b105c6..38918bb7 100644
--- a/tests/kms_plane_cursor.c
+++ b/tests/kms_plane_cursor.c
@@ -86,7 +86,10 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
 	data->cursor = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_CURSOR);
 
 	igt_output_set_pipe(data->output, data->pipe_id);
-	igt_require(i915_pipe_output_combo_valid(display));
+
+	/*Pipe D is invalid in big joiner*/
+	if (data->pipe_id != PIPE_D)
+		igt_require(i915_pipe_output_combo_valid(display));
 
 	igt_info("Using (pipe %s + %s) to run the subtest.\n",
 		 kmstest_pipe_name(data->pipe_id), igt_output_name(data->output));
-- 
2.39.0

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner

[Modem, Bhanuprakash]

Hi Nidhi,

On Wed-14-06-2023 05:22 pm, Nidhi Gupta wrote:
> Pipe D is invalid in big joiner and because of that currently
> test throws as skip for all the pipes and as it is within the
> dynamic subtest block.
> Fixed in IGT to skip the big joiner validity check for pipe-D
> and execute for the rest of the pipes as it is.
> 
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
>   tests/kms_plane_cursor.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
> index 59b105c6..38918bb7 100644
> --- a/tests/kms_plane_cursor.c
> +++ b/tests/kms_plane_cursor.c
> @@ -86,7 +86,10 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
>   	data->cursor = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_CURSOR);
>   
>   	igt_output_set_pipe(data->output, data->pipe_id);
> -	igt_require(i915_pipe_output_combo_valid(display));
> +
> +	/*Pipe D is invalid in big joiner*/
> +	if (data->pipe_id != PIPE_D)
> +		igt_require(i915_pipe_output_combo_valid(display));

Why do we need to call this helper for pipe-A/B/C as we already know 
these pipes can support bigjoiner? If upcoming hardware enables pip-E/F, 
then how this logic can handle?

i915_pipe_output_combo_valid() itself is taken care of last pipe (pipe-D 
in case of adl/dg2). Maybe you need to think about a way to check before 
calling the igt_dynamic().

- Bhanu

>   
>   	igt_info("Using (pipe %s + %s) to run the subtest.\n",
>   		 kmstest_pipe_name(data->pipe_id), igt_output_name(data->output));

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane_cursor: Pipe-D is invalid in big joiner

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 6195 bytes --]

== Series Details ==

Series: tests/kms_plane_cursor: Pipe-D is invalid in big joiner
URL   : https://patchwork.freedesktop.org/series/119335/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13270 -> IGTPW_9167
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_9167 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_9167, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/index.html

Participating hosts (43 -> 42)
------------------------------

  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_9167:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_exec_parallel@engines@userptr:
    - bat-mtlp-6:         [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-mtlp-6/igt@gem_exec_parallel@engines@userptr.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/bat-mtlp-6/igt@gem_exec_parallel@engines@userptr.html

  * igt@kms_prop_blob@basic:
    - fi-kbl-soraka:      [PASS][3] -> [INCOMPLETE][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/fi-kbl-soraka/igt@kms_prop_blob@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/fi-kbl-soraka/igt@kms_prop_blob@basic.html

  
Known issues
------------

  Here are the changes found in IGTPW_9167 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@gt_mocs:
    - bat-mtlp-8:         [PASS][5] -> [DMESG-FAIL][6] ([i915#7059])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html

  * igt@i915_selftest@live@reset:
    - bat-rpls-2:         [PASS][7] -> [ABORT][8] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-rpls-2/igt@i915_selftest@live@reset.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/bat-rpls-2/igt@i915_selftest@live@reset.html

  * igt@i915_selftest@live@slpc:
    - bat-rpls-1:         NOTRUN -> [DMESG-WARN][9] ([i915#6367])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/bat-rpls-1/igt@i915_selftest@live@slpc.html

  * igt@i915_suspend@basic-s3-without-i915:
    - bat-rpls-1:         NOTRUN -> [ABORT][10] ([i915#6687] / [i915#7978])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-dg2-11:         NOTRUN -> [SKIP][11] ([i915#7828])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/bat-dg2-11/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
    - bat-dg2-11:         NOTRUN -> [SKIP][12] ([i915#1845] / [i915#5354]) +2 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html

  * igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
    - bat-dg2-8:          [PASS][13] -> [FAIL][14] ([i915#7932])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_mocs:
    - bat-mtlp-6:         [DMESG-FAIL][15] ([i915#7059]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html

  * igt@i915_selftest@live@hangcheck:
    - bat-rpls-1:         [ABORT][17] ([i915#7677]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-rpls-1/igt@i915_selftest@live@hangcheck.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/bat-rpls-1/igt@i915_selftest@live@hangcheck.html
    - bat-dg2-11:         [ABORT][19] ([i915#7913] / [i915#7979]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/bat-dg2-11/igt@i915_selftest@live@hangcheck.html

  
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
  [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
  [i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
  [i915#7979]: https://gitlab.freedesktop.org/drm/intel/issues/7979
  [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7329 -> IGTPW_9167

  CI-20190529: 20190529
  CI_DRM_13270: a8b181a60198ccf04a1ad1c34f46be4c2a5e64b7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_9167: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/index.html
  IGT_7329: d58b208c72b91a5d9cb7877363242a181a012182 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9167/index.html

[-- Attachment #2: Type: text/html, Size: 7225 bytes --]

[igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner

[Nidhi Gupta]

Pipe D is invalid in big joiner and because of that currently
test throws as skip for all the pipes as it is within the
dynamic subtest block.
Fixed in IGT by not executing the subtest if valid combo of pipe
and output not found for big joiner and go on to check for the
next pipe.

Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
 tests/kms_plane_cursor.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
index 59b105c6..b1f3cecc 100644
--- a/tests/kms_plane_cursor.c
+++ b/tests/kms_plane_cursor.c
@@ -86,7 +86,6 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
 	data->cursor = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_CURSOR);
 
 	igt_output_set_pipe(data->output, data->pipe_id);
-	igt_require(i915_pipe_output_combo_valid(display));
 
 	igt_info("Using (pipe %s + %s) to run the subtest.\n",
 		 kmstest_pipe_name(data->pipe_id), igt_output_name(data->output));
@@ -268,6 +267,7 @@ igt_main
 	static const int cursor_sizes[] = { 64, 128, 256 };
 	data_t data = { .max_curw = 64, .max_curh = 64 };
 	enum pipe pipe;
+	bool result;
 	igt_output_t *output;
 	int i, j;
 	struct {
@@ -312,6 +312,13 @@ igt_main
 
 				test_init(&data, pipe, output);
 
+				result = i915_pipe_output_combo_valid(&data.display);
+				if (result == false) {
+					igt_info("pipe %s + %s is not a valid combo for big joiner\n",
+						kmstest_pipe_name(data.pipe_id), igt_output_name(data.output));
+					continue;
+				}
+
 				for (j = 0; j < ARRAY_SIZE(cursor_sizes); j++) {
 					int size = cursor_sizes[j];
 
-- 
2.39.0

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner

[Modem, Bhanuprakash]

Hi Nidhi,

On Thu-15-06-2023 10:54 am, Nidhi Gupta wrote:
> Pipe D is invalid in big joiner and because of that currently
> test throws as skip for all the pipes as it is within the
> dynamic subtest block.
> Fixed in IGT by not executing the subtest if valid combo of pipe
> and output not found for big joiner and go on to check for the
> next pipe.

Please drop Pipe-D from commit subject & message, and write as a generic.

Also, please maintain the rev information.

Example:
V2: - Changes made from Initial version

> 
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
>   tests/kms_plane_cursor.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
> index 59b105c6..b1f3cecc 100644
> --- a/tests/kms_plane_cursor.c
> +++ b/tests/kms_plane_cursor.c
> @@ -86,7 +86,6 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
>   	data->cursor = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_CURSOR);
>   
>   	igt_output_set_pipe(data->output, data->pipe_id);
> -	igt_require(i915_pipe_output_combo_valid(display));
>   
>   	igt_info("Using (pipe %s + %s) to run the subtest.\n",
>   		 kmstest_pipe_name(data->pipe_id), igt_output_name(data->output));
> @@ -268,6 +267,7 @@ igt_main
>   	static const int cursor_sizes[] = { 64, 128, 256 };
>   	data_t data = { .max_curw = 64, .max_curh = 64 };
>   	enum pipe pipe;
> +	bool result;
>   	igt_output_t *output;
>   	int i, j;
>   	struct {
> @@ -312,6 +312,13 @@ igt_main
>   
>   				test_init(&data, pipe, output);

Test initialization is not required, if it is an invalid config.

>   
> +				result = i915_pipe_output_combo_valid(&data.display);
> +				if (result == false) {

No need of new variable 'result', instead you can use
if (!i915_pipe_output_combo_valid(&data.display))
	continue;

> +					igt_info("pipe %s + %s is not a valid combo for big joiner\n",
----------------------------------------^
Use igt_debug() if you really need this print, else please drop it.

- Bhanu

> +						kmstest_pipe_name(data.pipe_id), igt_output_name(data.output));
> +					continue;
> +				}
> +
>   				for (j = 0; j < ARRAY_SIZE(cursor_sizes); j++) {
>   					int size = cursor_sizes[j];
>