* [igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner
@ 2023-06-14 11:52 Nidhi Gupta
2023-06-14 14:19 ` Modem, Bhanuprakash
0 siblings, 1 reply; 5+ messages in thread
From: Nidhi Gupta @ 2023-06-14 11:52 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta
Pipe D is invalid in big joiner and because of that currently
test throws as skip for all the pipes and as it is within the
dynamic subtest block.
Fixed in IGT to skip the big joiner validity check for pipe-D
and execute for the rest of the pipes as it is.
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/kms_plane_cursor.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
index 59b105c6..38918bb7 100644
--- a/tests/kms_plane_cursor.c
+++ b/tests/kms_plane_cursor.c
@@ -86,7 +86,10 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
data->cursor = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_CURSOR);
igt_output_set_pipe(data->output, data->pipe_id);
- igt_require(i915_pipe_output_combo_valid(display));
+
+ /*Pipe D is invalid in big joiner*/
+ if (data->pipe_id != PIPE_D)
+ igt_require(i915_pipe_output_combo_valid(display));
igt_info("Using (pipe %s + %s) to run the subtest.\n",
kmstest_pipe_name(data->pipe_id), igt_output_name(data->output));
--
2.39.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner
2023-06-14 11:52 Nidhi Gupta
@ 2023-06-14 14:19 ` Modem, Bhanuprakash
0 siblings, 0 replies; 5+ messages in thread
From: Modem, Bhanuprakash @ 2023-06-14 14:19 UTC (permalink / raw)
To: Nidhi Gupta, igt-dev
Hi Nidhi,
On Wed-14-06-2023 05:22 pm, Nidhi Gupta wrote:
> Pipe D is invalid in big joiner and because of that currently
> test throws as skip for all the pipes and as it is within the
> dynamic subtest block.
> Fixed in IGT to skip the big joiner validity check for pipe-D
> and execute for the rest of the pipes as it is.
>
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
> tests/kms_plane_cursor.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
> index 59b105c6..38918bb7 100644
> --- a/tests/kms_plane_cursor.c
> +++ b/tests/kms_plane_cursor.c
> @@ -86,7 +86,10 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
> data->cursor = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_CURSOR);
>
> igt_output_set_pipe(data->output, data->pipe_id);
> - igt_require(i915_pipe_output_combo_valid(display));
> +
> + /*Pipe D is invalid in big joiner*/
> + if (data->pipe_id != PIPE_D)
> + igt_require(i915_pipe_output_combo_valid(display));
Why do we need to call this helper for pipe-A/B/C as we already know
these pipes can support bigjoiner? If upcoming hardware enables pip-E/F,
then how this logic can handle?
i915_pipe_output_combo_valid() itself is taken care of last pipe (pipe-D
in case of adl/dg2). Maybe you need to think about a way to check before
calling the igt_dynamic().
- Bhanu
>
> igt_info("Using (pipe %s + %s) to run the subtest.\n",
> kmstest_pipe_name(data->pipe_id), igt_output_name(data->output));
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner
@ 2023-06-15 5:24 Nidhi Gupta
2023-06-15 8:07 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane_cursor: Pipe-D is invalid in big joiner (rev2) Patchwork
2023-06-19 6:00 ` [igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner Modem, Bhanuprakash
0 siblings, 2 replies; 5+ messages in thread
From: Nidhi Gupta @ 2023-06-15 5:24 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta
Pipe D is invalid in big joiner and because of that currently
test throws as skip for all the pipes as it is within the
dynamic subtest block.
Fixed in IGT by not executing the subtest if valid combo of pipe
and output not found for big joiner and go on to check for the
next pipe.
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/kms_plane_cursor.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
index 59b105c6..b1f3cecc 100644
--- a/tests/kms_plane_cursor.c
+++ b/tests/kms_plane_cursor.c
@@ -86,7 +86,6 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
data->cursor = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_CURSOR);
igt_output_set_pipe(data->output, data->pipe_id);
- igt_require(i915_pipe_output_combo_valid(display));
igt_info("Using (pipe %s + %s) to run the subtest.\n",
kmstest_pipe_name(data->pipe_id), igt_output_name(data->output));
@@ -268,6 +267,7 @@ igt_main
static const int cursor_sizes[] = { 64, 128, 256 };
data_t data = { .max_curw = 64, .max_curh = 64 };
enum pipe pipe;
+ bool result;
igt_output_t *output;
int i, j;
struct {
@@ -312,6 +312,13 @@ igt_main
test_init(&data, pipe, output);
+ result = i915_pipe_output_combo_valid(&data.display);
+ if (result == false) {
+ igt_info("pipe %s + %s is not a valid combo for big joiner\n",
+ kmstest_pipe_name(data.pipe_id), igt_output_name(data.output));
+ continue;
+ }
+
for (j = 0; j < ARRAY_SIZE(cursor_sizes); j++) {
int size = cursor_sizes[j];
--
2.39.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane_cursor: Pipe-D is invalid in big joiner (rev2)
2023-06-15 5:24 [igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner Nidhi Gupta
@ 2023-06-15 8:07 ` Patchwork
2023-06-19 6:00 ` [igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner Modem, Bhanuprakash
1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-06-15 8:07 UTC (permalink / raw)
To: Nidhi Gupta; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 8666 bytes --]
== Series Details ==
Series: tests/kms_plane_cursor: Pipe-D is invalid in big joiner (rev2)
URL : https://patchwork.freedesktop.org/series/119335/
State : failure
== Summary ==
CI Bug Log - changes from IGT_7330 -> IGTPW_9175
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_9175 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_9175, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/index.html
Participating hosts (43 -> 42)
------------------------------
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_9175:
### IGT changes ###
#### Possible regressions ####
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-b-dp-1:
- bat-dg2-8: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-b-dp-1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-b-dp-1.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-dg2-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html
* igt@kms_pipe_crc_basic@read-crc@pipe-b-dp-1:
- bat-dg2-8: [PASS][4] -> [DMESG-WARN][5] +4 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/bat-dg2-8/igt@kms_pipe_crc_basic@read-crc@pipe-b-dp-1.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-dg2-8/igt@kms_pipe_crc_basic@read-crc@pipe-b-dp-1.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1:
- fi-kbl-7567u: [PASS][6] -> [FAIL][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/fi-kbl-7567u/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/fi-kbl-7567u/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1.html
Known issues
------------
Here are the changes found in IGTPW_9175 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_auth@basic-auth:
- bat-adlp-11: [PASS][8] -> [ABORT][9] ([i915#8011])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/bat-adlp-11/igt@core_auth@basic-auth.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-adlp-11/igt@core_auth@basic-auth.html
* igt@i915_module_load@load:
- bat-adlp-11: [PASS][10] -> [DMESG-WARN][11] ([i915#4423])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/bat-adlp-11/igt@i915_module_load@load.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-adlp-11/igt@i915_module_load@load.html
* igt@i915_selftest@live@requests:
- bat-mtlp-8: [PASS][12] -> [DMESG-FAIL][13] ([i915#8497])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/bat-mtlp-8/igt@i915_selftest@live@requests.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-mtlp-8/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][14] ([i915#6687])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_pipe_crc_basic@hang-read-crc@pipe-d-dp-1:
- bat-dg2-8: [PASS][15] -> [DMESG-WARN][16] ([i915#7507])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/bat-dg2-8/igt@kms_pipe_crc_basic@hang-read-crc@pipe-d-dp-1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-dg2-8/igt@kms_pipe_crc_basic@hang-read-crc@pipe-d-dp-1.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1:
- bat-dg2-8: [PASS][17] -> [DMESG-WARN][18] ([i915#8585])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-a-dp-1:
- bat-dg2-8: [PASS][19] -> [DMESG-FAIL][20] ([i915#7507])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-a-dp-1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-a-dp-1.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
- bat-dg2-8: [PASS][21] -> [FAIL][22] ([i915#7932]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][23] ([i915#5334]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
- fi-kbl-soraka: [DMESG-FAIL][25] ([i915#5334] / [i915#7872]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: [ABORT][27] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/bat-rpls-2/igt@i915_selftest@live@reset.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-3:
- bat-dg2-11: [INCOMPLETE][29] ([i915#7908]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-3.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-3.html
#### Warnings ####
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: [SKIP][31] ([i915#3555] / [i915#4579]) -> [ABORT][32] ([i915#4579] / [i915#8260])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7330/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7507]: https://gitlab.freedesktop.org/drm/intel/issues/7507
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7908]: https://gitlab.freedesktop.org/drm/intel/issues/7908
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8585]: https://gitlab.freedesktop.org/drm/intel/issues/8585
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7330 -> IGTPW_9175
CI-20190529: 20190529
CI_DRM_13270: a8b181a60198ccf04a1ad1c34f46be4c2a5e64b7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9175: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/index.html
IGT_7330: 592a0e56412b3323fb103ce3cc9977035c29f402 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9175/index.html
[-- Attachment #2: Type: text/html, Size: 9887 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner
2023-06-15 5:24 [igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner Nidhi Gupta
2023-06-15 8:07 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane_cursor: Pipe-D is invalid in big joiner (rev2) Patchwork
@ 2023-06-19 6:00 ` Modem, Bhanuprakash
1 sibling, 0 replies; 5+ messages in thread
From: Modem, Bhanuprakash @ 2023-06-19 6:00 UTC (permalink / raw)
To: Nidhi Gupta, igt-dev
Hi Nidhi,
On Thu-15-06-2023 10:54 am, Nidhi Gupta wrote:
> Pipe D is invalid in big joiner and because of that currently
> test throws as skip for all the pipes as it is within the
> dynamic subtest block.
> Fixed in IGT by not executing the subtest if valid combo of pipe
> and output not found for big joiner and go on to check for the
> next pipe.
Please drop Pipe-D from commit subject & message, and write as a generic.
Also, please maintain the rev information.
Example:
V2: - Changes made from Initial version
>
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
> tests/kms_plane_cursor.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
> index 59b105c6..b1f3cecc 100644
> --- a/tests/kms_plane_cursor.c
> +++ b/tests/kms_plane_cursor.c
> @@ -86,7 +86,6 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
> data->cursor = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_CURSOR);
>
> igt_output_set_pipe(data->output, data->pipe_id);
> - igt_require(i915_pipe_output_combo_valid(display));
>
> igt_info("Using (pipe %s + %s) to run the subtest.\n",
> kmstest_pipe_name(data->pipe_id), igt_output_name(data->output));
> @@ -268,6 +267,7 @@ igt_main
> static const int cursor_sizes[] = { 64, 128, 256 };
> data_t data = { .max_curw = 64, .max_curh = 64 };
> enum pipe pipe;
> + bool result;
> igt_output_t *output;
> int i, j;
> struct {
> @@ -312,6 +312,13 @@ igt_main
>
> test_init(&data, pipe, output);
Test initialization is not required, if it is an invalid config.
>
> + result = i915_pipe_output_combo_valid(&data.display);
> + if (result == false) {
No need of new variable 'result', instead you can use
if (!i915_pipe_output_combo_valid(&data.display))
continue;
> + igt_info("pipe %s + %s is not a valid combo for big joiner\n",
----------------------------------------^
Use igt_debug() if you really need this print, else please drop it.
- Bhanu
> + kmstest_pipe_name(data.pipe_id), igt_output_name(data.output));
> + continue;
> + }
> +
> for (j = 0; j < ARRAY_SIZE(cursor_sizes); j++) {
> int size = cursor_sizes[j];
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-19 6:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-15 5:24 [igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner Nidhi Gupta
2023-06-15 8:07 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane_cursor: Pipe-D is invalid in big joiner (rev2) Patchwork
2023-06-19 6:00 ` [igt-dev] [PATCH i-g-t] tests/kms_plane_cursor: Pipe-D is invalid in big joiner Modem, Bhanuprakash
-- strict thread matches above, loose matches on Subject: below --
2023-06-14 11:52 Nidhi Gupta
2023-06-14 14:19 ` Modem, Bhanuprakash
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox