Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Riana Tauro <riana.tauro@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: badal.nilawar@intel.com
Subject: [igt-dev] [PATCH i-g-t 1/2] tests/xe: Add GT id to C6 assertions
Date: Tue,  5 Sep 2023 10:50:57 +0530	[thread overview]
Message-ID: <20230905052058.2216763-2-riana.tauro@intel.com> (raw)
In-Reply-To: <20230905052058.2216763-1-riana.tauro@intel.com>

Add GT id to igt assertions in xe_pm_residency that
checks if a GT is in a required C State.
This helps to identify which GT is causing a failure.

No functional changes.

Signed-off-by: Riana Tauro <riana.tauro@intel.com>
---
 tests/intel/xe_pm_residency.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/intel/xe_pm_residency.c b/tests/intel/xe_pm_residency.c
index bf8230114..a538d1917 100644
--- a/tests/intel/xe_pm_residency.c
+++ b/tests/intel/xe_pm_residency.c
@@ -100,7 +100,7 @@ static void test_idle_residency(int fd, int gt, enum test_type flag)
 {
 	unsigned long elapsed_ms, residency_start, residency_end;
 
-	igt_assert_f(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 1), "GT not in C6\n");
+	igt_assert_f(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 1), "GT %d not in C6\n", gt);
 
 	if (flag == TEST_S2IDLE) {
 		/*
@@ -156,7 +156,7 @@ static void toggle_gt_c6(int fd, int n)
 		/* check if all gts are in C0 after forcewake is acquired */
 		xe_for_each_gt(fd, gt)
 			igt_assert_f(!xe_is_gt_in_c6(fd, gt),
-				     "Forcewake acquired, GT should be in C0\n");
+				     "Forcewake acquired, GT %d should be in C0\n", gt);
 
 		if (n == NUM_REPS)
 			measure_power(&gpu, &gt_c0_power);
@@ -165,7 +165,7 @@ static void toggle_gt_c6(int fd, int n)
 		/* check if all gts are in C6 after forcewake is released */
 		xe_for_each_gt(fd, gt)
 			igt_assert_f(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 1),
-				     "Forcewake released, GT should be in C6\n");
+				     "Forcewake released, GT %d should be in C6\n", gt);
 
 		if (n == NUM_REPS)
 			measure_power(&gpu, &gt_c6_power);
@@ -194,7 +194,7 @@ igt_main
 	igt_describe("Validate GT C6 on idle");
 	igt_subtest("gt-c6-on-idle")
 		xe_for_each_gt(fd, gt)
-			igt_assert_f(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 1), "GT not in C6\n");
+			igt_assert_f(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 1), "GT %d not in C6\n", gt);
 
 	igt_describe("Validate idle residency measured over suspend cycle is within the tolerance");
 	igt_subtest("gt-c6-freeze") {
-- 
2.40.0

  reply	other threads:[~2023-09-05  5:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05  5:20 [igt-dev] [PATCH i-g-t 0/2] Add GT id to identify failures Riana Tauro
2023-09-05  5:20 ` Riana Tauro [this message]
2023-09-05  7:40   ` [igt-dev] [PATCH i-g-t 1/2] tests/xe: Add GT id to C6 assertions Sundaresan, Sujaritha
2023-09-05  5:20 ` [igt-dev] [PATCH i-g-t 2/2] tests/xe: Add GT id to identify failures Riana Tauro
2023-09-05  7:41   ` Sundaresan, Sujaritha
2023-09-05  5:44 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2023-09-05  6:16 ` [igt-dev] [PATCH i-g-t 0/2] " Gupta, Anshuman
2023-09-05  6:51   ` Riana Tauro
2023-09-05  6:54     ` Gupta, Anshuman
2023-09-05  6:16 ` [igt-dev] ✗ CI.xeBAT: failure for " Patchwork
2023-09-05 10:56   ` Tauro, Riana
2023-09-06  7:56     ` Yedireswarapu, SaiX Nandan
2023-09-05  6:25 ` [igt-dev] ✗ Fi.CI.BAT: " Patchwork
2023-09-06  7:36 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-09-06 10:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230905052058.2216763-2-riana.tauro@intel.com \
    --to=riana.tauro@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox