From: Riana Tauro <riana.tauro@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: badal.nilawar@intel.com
Subject: [igt-dev] [PATCH i-g-t 2/2] tests/xe: Add GT id to identify failures
Date: Tue, 5 Sep 2023 10:50:58 +0530 [thread overview]
Message-ID: <20230905052058.2216763-3-riana.tauro@intel.com> (raw)
In-Reply-To: <20230905052058.2216763-1-riana.tauro@intel.com>
Add GT id to igt assertions in xe_guc_pc that
checks if a GT is in a required C State.
This helps to identify which GT is causing a failure.
No functional changes.
Signed-off-by: Riana Tauro <riana.tauro@intel.com>
---
tests/intel/xe_guc_pc.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/tests/intel/xe_guc_pc.c b/tests/intel/xe_guc_pc.c
index 032816921..151e6cb0a 100644
--- a/tests/intel/xe_guc_pc.c
+++ b/tests/intel/xe_guc_pc.c
@@ -240,7 +240,8 @@ static void test_freq_fixed(int fd, int gt_id, bool gt_idle)
if (gt_idle) {
/* Wait for GT to go in C6 as previous get_freq wakes up GT*/
- igt_assert(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 10));
+ igt_assert_f(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 10),
+ "GT %d should be in C6\n", gt_id);
igt_assert(get_freq(fd, gt_id, "act") == 0);
} else {
igt_assert(get_freq(fd, gt_id, "act") == rpn);
@@ -252,7 +253,8 @@ static void test_freq_fixed(int fd, int gt_id, bool gt_idle)
igt_assert(get_freq(fd, gt_id, "cur") == rpe);
if (gt_idle) {
- igt_assert(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 10));
+ igt_assert_f(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 10),
+ "GT %d should be in C6\n", gt_id);
igt_assert(get_freq(fd, gt_id, "act") == 0);
} else {
igt_assert(get_freq(fd, gt_id, "act") == rpe);
@@ -269,7 +271,8 @@ static void test_freq_fixed(int fd, int gt_id, bool gt_idle)
igt_assert(get_freq(fd, gt_id, "cur") == rp0);
if (gt_idle) {
- igt_assert(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 10));
+ igt_assert_f(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 10),
+ "GT %d should be in C6\n", gt_id);
igt_assert(get_freq(fd, gt_id, "act") == 0);
}
@@ -301,7 +304,8 @@ static void test_freq_range(int fd, int gt_id, bool gt_idle)
igt_assert(rpn <= cur && cur <= rpe);
if (gt_idle) {
- igt_assert(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 10));
+ igt_assert_f(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 10),
+ "GT %d should be in C6\n", gt_id);
igt_assert(get_freq(fd, gt_id, "act") == 0);
} else {
act = get_freq(fd, gt_id, "act");
@@ -411,7 +415,8 @@ igt_main
igt_subtest("freq_fixed_idle") {
xe_for_each_gt(fd, gt) {
- igt_require(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 10));
+ igt_require_f(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 10),
+ "GT %d should be in C6\n", gt);
test_freq_fixed(fd, gt, true);
}
}
@@ -432,7 +437,8 @@ igt_main
igt_subtest("freq_range_idle") {
xe_for_each_gt(fd, gt) {
- igt_require(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 10));
+ igt_require_f(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 10),
+ "GT %d should be in C6\n", gt);
test_freq_range(fd, gt, true);
}
}
--
2.40.0
next prev parent reply other threads:[~2023-09-05 5:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 5:20 [igt-dev] [PATCH i-g-t 0/2] Add GT id to identify failures Riana Tauro
2023-09-05 5:20 ` [igt-dev] [PATCH i-g-t 1/2] tests/xe: Add GT id to C6 assertions Riana Tauro
2023-09-05 7:40 ` Sundaresan, Sujaritha
2023-09-05 5:20 ` Riana Tauro [this message]
2023-09-05 7:41 ` [igt-dev] [PATCH i-g-t 2/2] tests/xe: Add GT id to identify failures Sundaresan, Sujaritha
2023-09-05 5:44 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2023-09-05 6:16 ` [igt-dev] [PATCH i-g-t 0/2] " Gupta, Anshuman
2023-09-05 6:51 ` Riana Tauro
2023-09-05 6:54 ` Gupta, Anshuman
2023-09-05 6:16 ` [igt-dev] ✗ CI.xeBAT: failure for " Patchwork
2023-09-05 10:56 ` Tauro, Riana
2023-09-06 7:56 ` Yedireswarapu, SaiX Nandan
2023-09-05 6:25 ` [igt-dev] ✗ Fi.CI.BAT: " Patchwork
2023-09-06 7:36 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-09-06 10:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905052058.2216763-3-riana.tauro@intel.com \
--to=riana.tauro@intel.com \
--cc=badal.nilawar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox