[igt-dev] [PATCH i-g-t 0/2] Improve IGT runner dry-run logic

[igt-dev] [PATCH i-g-t 0/2] Improve IGT runner dry-run logic

[Mauro Carvalho Chehab]

From: Mauro Carvalho Chehab <mchehab@kernel.org>

The IGT dry-run logic is currently almost useless, as it doesn't
produce any output with the planned jobs. It also currently requires
root access, but this is not needed.

Mauro Carvalho Chehab (2):
  igt_runner: don't require root for dry_run
  igt_runner: output planned job_list tasks in dry-run mode

 runner/executor.c | 6 ++++++
 runner/settings.c | 1 +
 2 files changed, 7 insertions(+)

-- 
2.41.0

[igt-dev] [PATCH i-g-t 1/2] igt_runner: don't require root for dry_run

[Mauro Carvalho Chehab]

From: Mauro Carvalho Chehab <mchehab@kernel.org>

When --dry-run option is used, there's no need to require root,
as no tests will actually be executed.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 runner/settings.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/runner/settings.c b/runner/settings.c
index 23aa82963344..788957948b4f 100644
--- a/runner/settings.c
+++ b/runner/settings.c
@@ -687,6 +687,7 @@ bool parse_options(int argc, char **argv,
 			break;
 		case OPT_DRY_RUN:
 			settings->dry_run = true;
+			settings->allow_non_root = true;
 			break;
 		case OPT_ALLOW_NON_ROOT:
 			settings->allow_non_root = true;
-- 
2.41.0

[igt-dev] [PATCH i-g-t 2/2] igt_runner: output planned job_list tasks in dry-run mode

[Mauro Carvalho Chehab]

From: Mauro Carvalho Chehab <mchehab@kernel.org>

If igt_runner is executed in dry-run mode, show what jobs
were planned to be executed. That helps debugging issues at
the runner job plan logic.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 runner/executor.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/runner/executor.c b/runner/executor.c
index d3e6296dd6d8..3b9e39f4001b 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -2287,6 +2287,12 @@ bool execute(struct execute_state *state,
 	bool status = true;
 
 	if (state->dry) {
+		for (; state->next < job_list->size; state->next++) {
+			char *job_name;
+
+			job_name = entry_display_name(&job_list->entries[state->next]);
+			outf("dry-run: %s\n", job_name);
+		}
 		outf("Dry run, not executing. Invoke igt_resume if you want to execute.\n");
 		return true;
 	}
-- 
2.41.0

Re: [igt-dev] [PATCH i-g-t 1/2] igt_runner: don't require root for dry_run

[Kamil Konieczny]

Hi Mauro,
On 2023-10-20 at 12:20:32 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> When --dry-run option is used, there's no need to require root,
> as no tests will actually be executed.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

LGTM,
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> ---
>  runner/settings.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/runner/settings.c b/runner/settings.c
> index 23aa82963344..788957948b4f 100644
> --- a/runner/settings.c
> +++ b/runner/settings.c
> @@ -687,6 +687,7 @@ bool parse_options(int argc, char **argv,
>  			break;
>  		case OPT_DRY_RUN:
>  			settings->dry_run = true;
> +			settings->allow_non_root = true;
>  			break;
>  		case OPT_ALLOW_NON_ROOT:
>  			settings->allow_non_root = true;
> -- 
> 2.41.0
> 

Re: [igt-dev] [PATCH i-g-t 2/2] igt_runner: output planned job_list tasks in dry-run mode

[Kamil Konieczny]

Hi Mauro,
On 2023-10-20 at 12:20:33 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> If igt_runner is executed in dry-run mode, show what jobs
> were planned to be executed. That helps debugging issues at
> the runner job plan logic.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

I will add Pteri on cc.

Regards,
Kamil

> ---
>  runner/executor.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/runner/executor.c b/runner/executor.c
> index d3e6296dd6d8..3b9e39f4001b 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -2287,6 +2287,12 @@ bool execute(struct execute_state *state,
>  	bool status = true;
>  
>  	if (state->dry) {
> +		for (; state->next < job_list->size; state->next++) {
> +			char *job_name;
> +
> +			job_name = entry_display_name(&job_list->entries[state->next]);
> +			outf("dry-run: %s\n", job_name);
> +		}
>  		outf("Dry run, not executing. Invoke igt_resume if you want to execute.\n");
>  		return true;
>  	}
> -- 
> 2.41.0
> 

Re: [igt-dev] [PATCH i-g-t 2/2] igt_runner: output planned job_list tasks in dry-run mode

[Petri Latvala]

On Fri, Oct 20, 2023 at 12:20:33PM +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> If igt_runner is executed in dry-run mode, show what jobs
> were planned to be executed. That helps debugging issues at
> the runner job plan logic.

If you only need this for debugging, look at the job list file the dry
run created.


-- 
Petri Latvala


> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  runner/executor.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/runner/executor.c b/runner/executor.c
> index d3e6296dd6d8..3b9e39f4001b 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -2287,6 +2287,12 @@ bool execute(struct execute_state *state,
>  	bool status = true;
>  
>  	if (state->dry) {
> +		for (; state->next < job_list->size; state->next++) {
> +			char *job_name;
> +
> +			job_name = entry_display_name(&job_list->entries[state->next]);
> +			outf("dry-run: %s\n", job_name);
> +		}
>  		outf("Dry run, not executing. Invoke igt_resume if you want to execute.\n");
>  		return true;
>  	}
> -- 
> 2.41.0
> 

[igt-dev] ✓ Fi.CI.BAT: success for Improve IGT runner dry-run logic

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 2986 bytes --]

== Series Details ==

Series: Improve IGT runner dry-run logic
URL   : https://patchwork.freedesktop.org/series/125391/
State : success

== Summary ==

CI Bug Log - changes from IGT_7551 -> IGTPW_10039
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10039/index.html

Participating hosts (36 -> 32)
------------------------------

  Missing    (4): fi-hsw-4770 bat-kbl-2 fi-bsw-n3050 bat-dg1-5 

Known issues
------------

  Here are the changes found in IGTPW_10039 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_pipe_crc_basic@suspend-read-crc:
    - bat-dg2-9:          NOTRUN -> [SKIP][1] ([i915#1845] / [i915#9197])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10039/bat-dg2-9/igt@kms_pipe_crc_basic@suspend-read-crc.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s0@smem:
    - bat-dg2-9:          [INCOMPLETE][2] ([i915#9275]) -> [PASS][3]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7551/bat-dg2-9/igt@gem_exec_suspend@basic-s0@smem.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10039/bat-dg2-9/igt@gem_exec_suspend@basic-s0@smem.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
    - bat-rplp-1:         [ABORT][4] ([i915#8668]) -> [PASS][5]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7551/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10039/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#8981]: https://gitlab.freedesktop.org/drm/intel/issues/8981
  [i915#9197]: https://gitlab.freedesktop.org/drm/intel/issues/9197
  [i915#9275]: https://gitlab.freedesktop.org/drm/intel/issues/9275


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7551 -> IGTPW_10039

  CI-20190529: 20190529
  CI_DRM_13777: 1b4fd688d213556268c50f853746c94c9a0cfee7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_10039: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10039/index.html
  IGT_7551: 15e7d92ca5f98d10feffa27a76724c33cbd68da5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git


Testlist changes
----------------

-igt@xe_mmap@cpu-caching-coh
-igt@xe_pat@pat-index-all
-igt@xe_pat@pat-index-common
-igt@xe_pat@pat-index-xe2
-igt@xe_pat@pat-index-xehpc
-igt@xe_pat@pat-index-xelp
-igt@xe_pat@pat-index-xelpg
-igt@xe_pat@userptr-coh-none

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10039/index.html

[-- Attachment #2: Type: text/html, Size: 3545 bytes --]

[igt-dev] ✗ CI.xeBAT: failure for Improve IGT runner dry-run logic

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 2935 bytes --]

== Series Details ==

Series: Improve IGT runner dry-run logic
URL   : https://patchwork.freedesktop.org/series/125391/
State : failure

== Summary ==

CI Bug Log - changes from XEIGT_7551_BAT -> XEIGTPW_10039_BAT
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with XEIGTPW_10039_BAT absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in XEIGTPW_10039_BAT, please notify your bug team (lgci.bug.filing@intel.com) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Participating hosts (4 -> 4)
------------------------------

  No changes in participating hosts

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in XEIGTPW_10039_BAT:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_force_connector_basic@force-connector-state:
    - bat-dg2-oem2:       [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7551/bat-dg2-oem2/igt@kms_force_connector_basic@force-connector-state.html
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10039/bat-dg2-oem2/igt@kms_force_connector_basic@force-connector-state.html

  
Known issues
------------

  Here are the changes found in XEIGTPW_10039_BAT that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
    - bat-adlp-7:         [FAIL][3] ([Intel XE#480]) -> [PASS][4] +2 other tests pass
   [3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7551/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
   [4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10039/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html

  * {igt@xe_create@create-execqueues-noleak}:
    - bat-adlp-7:         [FAIL][5] ([Intel XE#524]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7551/bat-adlp-7/igt@xe_create@create-execqueues-noleak.html
   [6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10039/bat-adlp-7/igt@xe_create@create-execqueues-noleak.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [Intel XE#480]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/480
  [Intel XE#524]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/524


Build changes
-------------

  * IGT: IGT_7551 -> IGTPW_10039

  IGTPW_10039: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10039/index.html
  IGT_7551: 15e7d92ca5f98d10feffa27a76724c33cbd68da5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-442-a0a80950176b39dbc76f8faa92fddf6caaa06191: a0a80950176b39dbc76f8faa92fddf6caaa06191

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10039/index.html

[-- Attachment #2: Type: text/html, Size: 3584 bytes --]