Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Paul <sean@poorly.run>
To: igt-dev@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>
Subject: [igt-dev] [PATCH v2 5/8] tests/kms_vrr: Change the pattern displayed in the test
Date: Mon, 23 Oct 2023 20:56:35 +0000	[thread overview]
Message-ID: <20231023205910.3556533-6-sean@poorly.run> (raw)
In-Reply-To: <20231023205910.3556533-1-sean@poorly.run>

From: Sean Paul <seanpaul@chromium.org>

Upgrade the tiny box in the top left corner to some vertical color
bars with horizontal grey and white bars at the bottom.

Cc: Mark Yacoub <markyacoub@chromium.org>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>

Changes in v2 (Bhanu):
- Removed hardcoded bar heights
- Made number of vertical bars configurable
- Fill in the entire screen horizontally
---
 tests/kms_vrr.c | 45 +++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 41 insertions(+), 4 deletions(-)

diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index af61c312e..34d75d648 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -232,11 +232,31 @@ static void set_vrr_on_pipe(data_t *data, enum pipe pipe, bool enabled)
 	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
+static void paint_bar(cairo_t *cr, unsigned int x, unsigned int y,
+		      unsigned int w, unsigned int h,
+		      unsigned int bar, unsigned int num_bars,
+		      float start_r, float start_g, float start_b,
+		      float end_r, float end_g, float end_b)
+{
+	float progress = (float)bar / (float)num_bars;
+	float color[] = {
+		start_r + progress * (end_r - start_r),
+		start_g + progress * (end_g - start_g),
+		start_b + progress * (end_b - start_b)
+	};
+	igt_paint_color(cr, x, y, w, h,
+			color[0] > 0 ? color[0] : 0.0,
+			color[1] > 0 ? color[1] : 0.0,
+			color[2] > 0 ? color[2] : 0.0);
+}
+
 /* Prepare the display for testing on the given pipe. */
 static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
 {
+	static const unsigned int num_bars = 256;
 	drmModeModeInfo mode;
 	cairo_t *cr;
+	int bar_width, bar_height, bar_remaining, horizontal_bar_height;
 
 	/* Reset output */
 	igt_display_reset(&data->display);
@@ -279,11 +299,28 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
 			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
 			    0.50, 0.50, 0.50, &data->fb[1]);
 
+	bar_width = mode.hdisplay / num_bars;
+	horizontal_bar_height = mode.vdisplay / 8;
+	bar_height = mode.vdisplay - horizontal_bar_height * 2;
+	bar_remaining = mode.hdisplay % bar_width;
 	cr = igt_get_cairo_ctx(data->drm_fd, &data->fb[0]);
-
-	igt_paint_color(cr, 0, 0, mode.hdisplay / 10, mode.vdisplay / 10,
-			1.00, 0.00, 0.00);
-
+	for (int j = 0; j < num_bars; ++j) {
+		unsigned int width = bar_width;
+		if (j == num_bars - 1)
+			width += bar_remaining;
+
+		/* Red->Green->Blue gradient */
+		if (j < num_bars / 2)
+			paint_bar(cr, j * bar_width, 0, width, bar_height,
+				  j, num_bars / 2,
+				  1.0, 0.0, 0.0, 0.0, 1.0, 0.0);
+		else
+			paint_bar(cr, j * bar_width, 0, width, bar_height,
+				  j - num_bars / 2, num_bars / 2,
+				  0.0, 1.0, 0.0, 0.0, 0.0, 1.0);
+	}
+	igt_paint_color(cr, 0, mode.vdisplay - horizontal_bar_height,
+			mode.hdisplay, horizontal_bar_height, 1.00, 1.00, 1.00);
 	igt_put_cairo_ctx(cr);
 
 	/* Take care of any required modesetting before the test begins. */
-- 
Sean Paul, Software Engineer, Google / Chromium OS

  parent reply	other threads:[~2023-10-23 20:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23 20:56 [igt-dev] [PATCH v2 0/8] tests/kms_vrr: Modify kms_vrr to allow flicker profiling Sean Paul
2023-10-23 20:56 ` [igt-dev] [PATCH v2 1/8] tests/kms_vrr: Move fb0 and fb1 to an array Sean Paul
2023-10-23 20:56 ` [igt-dev] [PATCH v2 2/8] tests/kms_vrr: Move vtest_ns into data_t Sean Paul
2023-10-23 20:56 ` [igt-dev] [PATCH v2 3/8] tests/kms_vrr: Allow test rate to be altered from the command line Sean Paul
2023-10-23 20:56 ` [igt-dev] [PATCH v2 4/8] tests/kms_vrr: Allow test duration to be specified " Sean Paul
2023-11-16  8:25   ` Modem, Bhanuprakash
2023-10-23 20:56 ` Sean Paul [this message]
2023-11-16  8:25   ` [igt-dev] [PATCH v2 5/8] tests/kms_vrr: Change the pattern displayed in the test Modem, Bhanuprakash
2023-12-18  4:36     ` Modem, Bhanuprakash
2023-12-18  4:36       ` Modem, Bhanuprakash
2023-10-23 20:56 ` [igt-dev] [PATCH v2 6/8] tests/kms_vrr: Add ability to flip static image for flicker profiling Sean Paul
2023-11-16  8:24   ` Modem, Bhanuprakash
2023-10-23 20:56 ` [igt-dev] [PATCH v2 7/8] tests/kms_vrr: Allow for multiple rates in a test Sean Paul
2023-11-16  8:24   ` Modem, Bhanuprakash
2023-10-23 20:56 ` [igt-dev] [PATCH v2 8/8] tests/kms_vrr: Add a max/min test to oscillate between rates Sean Paul
2023-11-16  8:24   ` Modem, Bhanuprakash
2023-10-24  7:42 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_vrr: Modify kms_vrr to allow flicker profiling Patchwork
2023-10-24  7:45 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2023-11-14 16:19 ` [igt-dev] [PATCH v2 0/8] " Sean Paul
2023-12-14  6:41   ` Modem, Bhanuprakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231023205910.3556533-6-sean@poorly.run \
    --to=sean@poorly.run \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox