From: Sean Paul <sean@poorly.run>
To: igt-dev@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>
Subject: [igt-dev] [PATCH v2 8/8] tests/kms_vrr: Add a max/min test to oscillate between rates
Date: Mon, 23 Oct 2023 20:56:38 +0000 [thread overview]
Message-ID: <20231023205910.3556533-9-sean@poorly.run> (raw)
In-Reply-To: <20231023205910.3556533-1-sean@poorly.run>
From: Sean Paul <seanpaul@chromium.org>
The new MAXMIN test will oscillate between the max and min
refresh rates every frame to stress test the panel. This is
useful for manual profiling of flicker.
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Changes in v2:
- Added to the set
---
tests/kms_vrr.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index b986087f0..58bed4f20 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -89,6 +89,7 @@ enum {
TEST_SUSPEND = 1 << 2,
TEST_FLIPLINE = 1 << 3,
TEST_NEGATIVE = 1 << 4,
+ TEST_MAXMIN = 1 << 6,
};
typedef struct range {
@@ -529,6 +530,14 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
(range.min - 5), rate[0], result);
}
+ if (flags & TEST_MAXMIN) {
+ uint64_t maxmin_rates[] = {vtest_ns.max, vtest_ns.min};
+ result = flip_and_measure(data, output, pipe, maxmin_rates, 2, data->duration_ns);
+ igt_assert_f(result < 50,
+ "Refresh rate (%u Hz) %"PRIu64"ns/%"PRIu64"ns: Target VRR on threshold exceeded, result was %u%%\n",
+ (range.min - 5), maxmin_rates[0], maxmin_rates[1], result);
+ }
+
/*
* If we request VRR on a non-VRR panel, it is unlikely to reject the
* modeset. And the expected behavior is the same as disabling VRR on
@@ -654,6 +663,11 @@ igt_main_args("d:r:s", long_opts, help_str, opt_handler, &data)
igt_subtest_with_dynamic("negative-basic")
run_vrr_test(&data, test_basic, TEST_NEGATIVE);
+ igt_describe("Oscillates between highest and lowest refresh each frame for manual "
+ "flicker profiling");
+ igt_subtest_with_dynamic("max-min")
+ run_vrr_test(&data, test_basic, TEST_MAXMIN);
+
igt_fixture {
igt_display_fini(&data.display);
drm_close_driver(data.drm_fd);
--
Sean Paul, Software Engineer, Google / Chromium OS
next prev parent reply other threads:[~2023-10-23 20:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 20:56 [igt-dev] [PATCH v2 0/8] tests/kms_vrr: Modify kms_vrr to allow flicker profiling Sean Paul
2023-10-23 20:56 ` [igt-dev] [PATCH v2 1/8] tests/kms_vrr: Move fb0 and fb1 to an array Sean Paul
2023-10-23 20:56 ` [igt-dev] [PATCH v2 2/8] tests/kms_vrr: Move vtest_ns into data_t Sean Paul
2023-10-23 20:56 ` [igt-dev] [PATCH v2 3/8] tests/kms_vrr: Allow test rate to be altered from the command line Sean Paul
2023-10-23 20:56 ` [igt-dev] [PATCH v2 4/8] tests/kms_vrr: Allow test duration to be specified " Sean Paul
2023-11-16 8:25 ` Modem, Bhanuprakash
2023-10-23 20:56 ` [igt-dev] [PATCH v2 5/8] tests/kms_vrr: Change the pattern displayed in the test Sean Paul
2023-11-16 8:25 ` Modem, Bhanuprakash
2023-12-18 4:36 ` Modem, Bhanuprakash
2023-12-18 4:36 ` Modem, Bhanuprakash
2023-10-23 20:56 ` [igt-dev] [PATCH v2 6/8] tests/kms_vrr: Add ability to flip static image for flicker profiling Sean Paul
2023-11-16 8:24 ` Modem, Bhanuprakash
2023-10-23 20:56 ` [igt-dev] [PATCH v2 7/8] tests/kms_vrr: Allow for multiple rates in a test Sean Paul
2023-11-16 8:24 ` Modem, Bhanuprakash
2023-10-23 20:56 ` Sean Paul [this message]
2023-11-16 8:24 ` [igt-dev] [PATCH v2 8/8] tests/kms_vrr: Add a max/min test to oscillate between rates Modem, Bhanuprakash
2023-10-24 7:42 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_vrr: Modify kms_vrr to allow flicker profiling Patchwork
2023-10-24 7:45 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2023-11-14 16:19 ` [igt-dev] [PATCH v2 0/8] " Sean Paul
2023-12-14 6:41 ` Modem, Bhanuprakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023205910.3556533-9-sean@poorly.run \
--to=sean@poorly.run \
--cc=igt-dev@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox