From: Francois Dugast <francois.dugast@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH v4 18/20] drm-uapi/xe: Fix various struct padding for 64b alignment
Date: Wed, 29 Nov 2023 14:54:55 +0000 [thread overview]
Message-ID: <20231129145457.7-19-francois.dugast@intel.com> (raw)
In-Reply-To: <20231129145457.7-1-francois.dugast@intel.com>
Align with commit ("drm/xe/uapi: Fix various struct padding for
64b alignment")
Signed-off-by: Francois Dugast <francois.dugast@intel.com>
---
include/drm-uapi/xe_drm.h | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
index 555560e43..f5078fd99 100644
--- a/include/drm-uapi/xe_drm.h
+++ b/include/drm-uapi/xe_drm.h
@@ -211,8 +211,6 @@ struct drm_xe_mem_region {
* a unique pair.
*/
__u16 instance;
- /** @pad: MBZ */
- __u32 pad;
/**
* @min_page_size: Min page-size in bytes for this region.
*
@@ -381,6 +379,8 @@ struct drm_xe_gt {
__u16 tile_id;
/** @gt_id: Unique ID of this GT within the PCI Device */
__u16 gt_id;
+ /** @pad: MBZ */
+ __u16 pad[3];
/** @reference_clock: A clock frequency for timestamp */
__u32 reference_clock;
/**
@@ -715,6 +715,9 @@ struct drm_xe_vm_bind_op {
*/
__u32 prefetch_mem_region_instance;
+ /** @pad: MBZ */
+ __u32 pad2;
+
/** @reserved: Reserved */
__u64 reserved[3];
};
@@ -733,12 +736,12 @@ struct drm_xe_vm_bind {
*/
__u32 exec_queue_id;
- /** @num_binds: number of binds in this IOCTL */
- __u32 num_binds;
-
/** @pad: MBZ */
__u32 pad;
+ /** @num_binds: number of binds in this IOCTL */
+ __u32 num_binds;
+
union {
/** @bind: used if num_binds == 1 */
struct drm_xe_vm_bind_op bind;
@@ -750,12 +753,12 @@ struct drm_xe_vm_bind {
__u64 vector_of_binds;
};
+ /** @pad: MBZ */
+ __u32 pad2;
+
/** @num_syncs: amount of syncs to wait on */
__u32 num_syncs;
- /** @pad2: MBZ */
- __u32 pad2;
-
/** @syncs: pointer to struct drm_xe_sync array */
__u64 syncs;
--
2.34.1
next prev parent reply other threads:[~2023-11-29 14:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 14:54 [igt-dev] [PATCH v4 00/20] uAPI Alignment - Cleanup and future proof Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 01/20] drm-uapi/xe: Extend drm_xe_vm_bind_op Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 02/20] xe_ioctl: Converge bo_create to the most used version Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 03/20] xe_ioctl: Rename *xe_bo_create_flags to simply xe_bo_create Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 04/20] xe_query: Add missing include Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 05/20] xe_query: Kill visible_vram_if_possible Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 06/20] drm-uapi/xe: Separate bo_create placement from flags Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 07/20] xe: s/hw_engine/engine Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 08/20] drm-uapi/xe: Make DRM_XE_DEVICE_QUERY_ENGINES future proof Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 09/20] drm-uapi/xe: Reject bo creation of unaligned size Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 10/20] drm-uapi/xe: Align on a common way to return arrays (memory regions) Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 11/20] drm-uapi/xe: Align on a common way to return arrays (gt) Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 12/20] drm-uapi/xe: Align on a common way to return arrays (engines) Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 13/20] drm-uapi/xe: Split xe_sync types from flags Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 14/20] drm-uapi/xe: Kill tile_mask Francois Dugast
2023-11-29 9:05 ` Matthew Brost
2023-11-29 14:54 ` [igt-dev] [PATCH v4 15/20] drm-uapi/xe: Crystal Reference Clock updates Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 16/20] drm-uapi/xe: Remove bogus engine list from the wait_user_fence IOCTL Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 17/20] drm-uapi/xe: Add Tile ID information to the GT info query Francois Dugast
2023-11-29 14:54 ` Francois Dugast [this message]
2023-11-29 14:54 ` [igt-dev] [PATCH v4 19/20] drm-uapi/xe: Move xe_exec after xe_exec_queue Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 20/20] tests/intel/xe: Adjust to KMD uAPI changes for long-running VMs Francois Dugast
2023-11-29 15:16 ` [igt-dev] ✗ Fi.CI.BUILD: failure for uAPI Alignment - Cleanup and future proof (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129145457.7-19-francois.dugast@intel.com \
--to=francois.dugast@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox