Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Dugast <francois.dugast@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [igt-dev] [PATCH v4 04/20] xe_query: Add missing include
Date: Wed, 29 Nov 2023 14:54:41 +0000	[thread overview]
Message-ID: <20231129145457.7-5-francois.dugast@intel.com> (raw)
In-Reply-To: <20231129145457.7-1-francois.dugast@intel.com>

From: Rodrigo Vivi <rodrigo.vivi@intel.com>

When trying to use xe_for_each_mem_region from a caller
that is not importing the igt_aux.h, the following build issue
will occur:

../lib/xe/xe_query.h:76:38: error: implicit declaration of function ‘igt_fls’ [-Werror=implicit-function-declaration]
   76 |         for (uint64_t __i = 0; __i < igt_fls(__memreg); __i++) \

So, to avoid a dependency chain, let's include from the file
that is using the helper.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Francois Dugast <francois.dugast@intel.com>
---
 lib/xe/xe_query.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/xe/xe_query.h b/lib/xe/xe_query.h
index 38e9aa440..7b3fc3100 100644
--- a/lib/xe/xe_query.h
+++ b/lib/xe/xe_query.h
@@ -11,6 +11,8 @@
 
 #include <stdint.h>
 #include <xe_drm.h>
+
+#include "igt_aux.h"
 #include "igt_list.h"
 #include "igt_sizes.h"
 
-- 
2.34.1

  parent reply	other threads:[~2023-11-29 14:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29 14:54 [igt-dev] [PATCH v4 00/20] uAPI Alignment - Cleanup and future proof Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 01/20] drm-uapi/xe: Extend drm_xe_vm_bind_op Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 02/20] xe_ioctl: Converge bo_create to the most used version Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 03/20] xe_ioctl: Rename *xe_bo_create_flags to simply xe_bo_create Francois Dugast
2023-11-29 14:54 ` Francois Dugast [this message]
2023-11-29 14:54 ` [igt-dev] [PATCH v4 05/20] xe_query: Kill visible_vram_if_possible Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 06/20] drm-uapi/xe: Separate bo_create placement from flags Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 07/20] xe: s/hw_engine/engine Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 08/20] drm-uapi/xe: Make DRM_XE_DEVICE_QUERY_ENGINES future proof Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 09/20] drm-uapi/xe: Reject bo creation of unaligned size Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 10/20] drm-uapi/xe: Align on a common way to return arrays (memory regions) Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 11/20] drm-uapi/xe: Align on a common way to return arrays (gt) Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 12/20] drm-uapi/xe: Align on a common way to return arrays (engines) Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 13/20] drm-uapi/xe: Split xe_sync types from flags Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 14/20] drm-uapi/xe: Kill tile_mask Francois Dugast
2023-11-29  9:05   ` Matthew Brost
2023-11-29 14:54 ` [igt-dev] [PATCH v4 15/20] drm-uapi/xe: Crystal Reference Clock updates Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 16/20] drm-uapi/xe: Remove bogus engine list from the wait_user_fence IOCTL Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 17/20] drm-uapi/xe: Add Tile ID information to the GT info query Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 18/20] drm-uapi/xe: Fix various struct padding for 64b alignment Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 19/20] drm-uapi/xe: Move xe_exec after xe_exec_queue Francois Dugast
2023-11-29 14:54 ` [igt-dev] [PATCH v4 20/20] tests/intel/xe: Adjust to KMD uAPI changes for long-running VMs Francois Dugast
2023-11-29 15:16 ` [igt-dev] ✗ Fi.CI.BUILD: failure for uAPI Alignment - Cleanup and future proof (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231129145457.7-5-francois.dugast@intel.com \
    --to=francois.dugast@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox