[PATCH] tests/kms_sysfs_edid_timing: increase thresholds

[PATCH] tests/kms_sysfs_edid_timing: increase thresholds

[Charlton Lin]

A customer panel consistently exceeds 150ms. Additionally, the
timing may be impacted by certain power states.

Increase all thresholds to accommodate.

Cc: Sharma, Swati2 <swati2.sharma@intel.com>
Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
Cc: Mark Yacoub <markyacoub@chromium.org>
Signed-off-by: Charlton Lin <charlton.lin@intel.com>
---
 tests/kms_sysfs_edid_timing.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
index 775211089f81..582133ea002e 100644
--- a/tests/kms_sysfs_edid_timing.c
+++ b/tests/kms_sysfs_edid_timing.c
@@ -26,9 +26,9 @@
 #include <fcntl.h>
 #include <sys/stat.h>
 
-#define THRESHOLD_PER_CONNECTOR		150
-#define THRESHOLD_PER_CONNECTOR_MEAN	140
-#define THRESHOLD_ALL_CONNECTORS_MEAN	100
+#define THRESHOLD_PER_CONNECTOR		1500
+#define THRESHOLD_PER_CONNECTOR_MEAN	1400
+#define THRESHOLD_ALL_CONNECTORS_MEAN	1000
 #define CHECK_TIMES			15
 
 IGT_TEST_DESCRIPTION("This test checks the time it takes to reprobe each "
-- 
2.25.1

Re: [PATCH] tests/kms_sysfs_edid_timing: increase thresholds

[Kamil Konieczny]

Hi Charlton,
On 2023-12-08 at 14:42:05 -0800, Charlton Lin wrote:

Please subscribe to igt-dev list, also when sending igt patches
add i-g-t after PATCH:

[PATCH i-g-t] tests/kms_sysfs_edid_timing: increase thresholds

> A customer panel consistently exceeds 150ms. Additionally, the
> timing may be impacted by certain power states.
> 
> Increase all thresholds to accommodate.
> 
> Cc: Sharma, Swati2 <swati2.sharma@intel.com>
----- ^^^^^^^^^^^^^^
This breaks your git send-email, correct is:

Cc: Swati Sharma <swati2.sharma@intel.com>

> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
> Cc: Mark Yacoub <markyacoub@chromium.org>

I don't see this in header? Added to cc.

> Signed-off-by: Charlton Lin <charlton.lin@intel.com>
> ---
>  tests/kms_sysfs_edid_timing.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index 775211089f81..582133ea002e 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -26,9 +26,9 @@
>  #include <fcntl.h>
>  #include <sys/stat.h>
>  
> -#define THRESHOLD_PER_CONNECTOR		150
> -#define THRESHOLD_PER_CONNECTOR_MEAN	140
> -#define THRESHOLD_ALL_CONNECTORS_MEAN	100
> +#define THRESHOLD_PER_CONNECTOR		1500
> +#define THRESHOLD_PER_CONNECTOR_MEAN	1400
> +#define THRESHOLD_ALL_CONNECTORS_MEAN	1000

This is like increasing it ten times, add this to description.
I am not KMS nor panel expert but is it really that long?

Regards,
Kamil

>  #define CHECK_TIMES			15
>  
>  IGT_TEST_DESCRIPTION("This test checks the time it takes to reprobe each "
> -- 
> 2.25.1
> 

Re: [PATCH] tests/kms_sysfs_edid_timing: increase thresholds

[Jani Nikula]

On Mon, 11 Dec 2023, Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
> On 2023-12-08 at 14:42:05 -0800, Charlton Lin wrote:
>> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
>> index 775211089f81..582133ea002e 100644
>> --- a/tests/kms_sysfs_edid_timing.c
>> +++ b/tests/kms_sysfs_edid_timing.c
>> @@ -26,9 +26,9 @@
>>  #include <fcntl.h>
>>  #include <sys/stat.h>
>>  
>> -#define THRESHOLD_PER_CONNECTOR		150
>> -#define THRESHOLD_PER_CONNECTOR_MEAN	140
>> -#define THRESHOLD_ALL_CONNECTORS_MEAN	100
>> +#define THRESHOLD_PER_CONNECTOR		1500
>> +#define THRESHOLD_PER_CONNECTOR_MEAN	1400
>> +#define THRESHOLD_ALL_CONNECTORS_MEAN	1000
>
> This is like increasing it ten times, add this to description.
> I am not KMS nor panel expert but is it really that long?

Would be worth investigating *why* this specific panel takes so long,
instead of allowing *all* panels to do so. We might add a regression
that slows down probing and nobody would notice.

BR,
Jani.


-- 
Jani Nikula, Intel

✗ Fi.CI.BUILD: failure for tests/kms_sysfs_edid_timing: increase thresholds

[Patchwork]

== Series Details ==

Series: tests/kms_sysfs_edid_timing: increase thresholds
URL   : https://patchwork.freedesktop.org/series/127628/
State : failure

== Summary ==

Applying: tests/kms_sysfs_edid_timing: increase thresholds
Using index info to reconstruct a base tree...
M	tests/kms_sysfs_edid_timing.c
Falling back to patching base and 3-way merge...
Auto-merging tests/kms_sysfs_edid_timing.c
CONFLICT (content): Merge conflict in tests/kms_sysfs_edid_timing.c
Patch failed at 0001 tests/kms_sysfs_edid_timing: increase thresholds
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".