[PATCH i-g-t] tests/kms_display_modes: Fix the plane setup in extended-mode-basic

[PATCH i-g-t] tests/kms_display_modes: Fix the plane setup in extended-mode-basic

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The test forgets to set the output size of the planes. The
default plane output size will be taken from the fb dimensions
which means we end up upscaling the planes, which may not work
on all hardware.

Set the planes' output size to match the input size to avoid this.
The frambuffer was specifically created wide enough to cover both
outputs with 1:1 scaling.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9841
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_display_modes.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
index 1f0f811c8367..f1d8ab03d501 100644
--- a/tests/kms_display_modes.c
+++ b/tests/kms_display_modes.c
@@ -180,10 +180,12 @@ static void run_extendedmode_basic(data_t *data,
 	igt_plane_set_fb(plane[0], &fb);
 	igt_fb_set_position(&fb, plane[0], 0, 0);
 	igt_fb_set_size(&fb, plane[0], mode[0]->hdisplay, mode[0]->vdisplay);
+	igt_plane_set_size(plane[0], mode[0]->hdisplay, mode[0]->vdisplay);
 
 	igt_plane_set_fb(plane[1], &fb);
 	igt_fb_set_position(&fb, plane[1], mode[0]->hdisplay, 0);
 	igt_fb_set_size(&fb, plane[1], mode[1]->hdisplay, mode[1]->vdisplay);
+	igt_plane_set_size(plane[1], mode[1]->hdisplay, mode[1]->vdisplay);
 
 	igt_display_commit2(display, COMMIT_ATOMIC);
 
-- 
2.41.0

Re: [PATCH i-g-t] tests/kms_display_modes: Fix the plane setup in extended-mode-basic

[Modem, Bhanuprakash]

On 20-12-2023 09:13 pm, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> The test forgets to set the output size of the planes. The
> default plane output size will be taken from the fb dimensions
> which means we end up upscaling the planes, which may not work
> on all hardware.
> 
> Set the planes' output size to match the input size to avoid this.
> The frambuffer was specifically created wide enough to cover both
> outputs with 1:1 scaling.
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9841
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

> ---
>   tests/kms_display_modes.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> index 1f0f811c8367..f1d8ab03d501 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -180,10 +180,12 @@ static void run_extendedmode_basic(data_t *data,
>   	igt_plane_set_fb(plane[0], &fb);
>   	igt_fb_set_position(&fb, plane[0], 0, 0);
>   	igt_fb_set_size(&fb, plane[0], mode[0]->hdisplay, mode[0]->vdisplay);
> +	igt_plane_set_size(plane[0], mode[0]->hdisplay, mode[0]->vdisplay);
>   
>   	igt_plane_set_fb(plane[1], &fb);
>   	igt_fb_set_position(&fb, plane[1], mode[0]->hdisplay, 0);
>   	igt_fb_set_size(&fb, plane[1], mode[1]->hdisplay, mode[1]->vdisplay);
> +	igt_plane_set_size(plane[1], mode[1]->hdisplay, mode[1]->vdisplay);
>   
>   	igt_display_commit2(display, COMMIT_ATOMIC);
>   

Re: [PATCH i-g-t] tests/kms_display_modes: Fix the plane setup in extended-mode-basic

[Modem, Bhanuprakash]

On 20-12-2023 09:13 pm, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> The test forgets to set the output size of the planes. The
> default plane output size will be taken from the fb dimensions
> which means we end up upscaling the planes, which may not work
> on all hardware.
> 
> Set the planes' output size to match the input size to avoid this.
> The frambuffer was specifically created wide enough to cover both
> outputs with 1:1 scaling.
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9841
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

> ---
>   tests/kms_display_modes.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> index 1f0f811c8367..f1d8ab03d501 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -180,10 +180,12 @@ static void run_extendedmode_basic(data_t *data,
>   	igt_plane_set_fb(plane[0], &fb);
>   	igt_fb_set_position(&fb, plane[0], 0, 0);
>   	igt_fb_set_size(&fb, plane[0], mode[0]->hdisplay, mode[0]->vdisplay);
> +	igt_plane_set_size(plane[0], mode[0]->hdisplay, mode[0]->vdisplay);
>   
>   	igt_plane_set_fb(plane[1], &fb);
>   	igt_fb_set_position(&fb, plane[1], mode[0]->hdisplay, 0);
>   	igt_fb_set_size(&fb, plane[1], mode[1]->hdisplay, mode[1]->vdisplay);
> +	igt_plane_set_size(plane[1], mode[1]->hdisplay, mode[1]->vdisplay);
>   
>   	igt_display_commit2(display, COMMIT_ATOMIC);
>