[PATCH i-g-t 1/2] lib/i915/intel_drrs: Update DRRS capability check

[PATCH i-g-t 1/2] lib/i915/intel_drrs: Update DRRS capability check

[Bhanuprakash Modem]

From debugfs "i915_drrs_status" read the DRRS capability as
"DRRS capable: yes", instead of "DRRS enabled: yes".

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 lib/i915/intel_drrs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/i915/intel_drrs.c b/lib/i915/intel_drrs.c
index 9c6aefbf6..ac8dd5e61 100644
--- a/lib/i915/intel_drrs.c
+++ b/lib/i915/intel_drrs.c
@@ -30,7 +30,7 @@ bool intel_is_drrs_supported(int device, enum pipe pipe)
 	igt_debugfs_simple_read(dir, "i915_drrs_status", buf, sizeof(buf));
 	close(dir);
 
-	return strstr(buf, "DRRS enabled: yes");
+	return strstr(buf, "DRRS capable: yes");
 }
 
 /**
-- 
2.43.0

[PATCH i-g-t 2/2] tests/intel/kms_dirtyfb: Fix DRRS status check

[Bhanuprakash Modem]

Fix assertion check for DRRS status.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/intel/kms_dirtyfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
index 26b82e50a..0e315bfb4 100644
--- a/tests/intel/kms_dirtyfb.c
+++ b/tests/intel/kms_dirtyfb.c
@@ -154,7 +154,7 @@ static void check_feature(data_t *data)
 			     "PSR still disabled\n");
 		break;
 	case FEATURE_DRRS:
-		igt_assert_f(intel_is_drrs_inactive(data->drm_fd, data->pipe),
+		igt_assert_f(!intel_is_drrs_inactive(data->drm_fd, data->pipe),
 			     "DRRS INACTIVE\n");
 		break;
 	case FEATURE_DEFAULT:
-- 
2.43.0

✓ CI.xeBAT: success for series starting with [i-g-t,1/2] lib/i915/intel_drrs: Update DRRS capability check

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

== Series Details ==

Series: series starting with [i-g-t,1/2] lib/i915/intel_drrs: Update DRRS capability check
URL   : https://patchwork.freedesktop.org/series/130198/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7718_BAT -> XEIGTPW_10710_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (4 -> 4)
------------------------------

  No changes in participating hosts


Changes
-------

  No changes found


Build changes
-------------

  * IGT: IGT_7718 -> IGTPW_10710
  * Linux: xe-803-f12bce6493b6443870b55f36b1462d65e450d29d -> xe-807-e2b02e89746d8eff8c244f938eecd0f1db8eb805

  IGTPW_10710: 10710
  IGT_7718: 40e8b9122853f455c84afcfa56469a6bc9a0d564 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-803-f12bce6493b6443870b55f36b1462d65e450d29d: f12bce6493b6443870b55f36b1462d65e450d29d
  xe-807-e2b02e89746d8eff8c244f938eecd0f1db8eb805: e2b02e89746d8eff8c244f938eecd0f1db8eb805

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10710/index.html

[-- Attachment #2: Type: text/html, Size: 1661 bytes --]

✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/i915/intel_drrs: Update DRRS capability check

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 7027 bytes --]

== Series Details ==

Series: series starting with [i-g-t,1/2] lib/i915/intel_drrs: Update DRRS capability check
URL   : https://patchwork.freedesktop.org/series/130198/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_14307 -> IGTPW_10710
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/index.html

Participating hosts (38 -> 37)
------------------------------

  Additional (1): fi-glk-j4005 
  Missing    (2): fi-apl-guc fi-snb-2520m 

Known issues
------------

  Here are the changes found in IGTPW_10710 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_huc_copy@huc-copy:
    - fi-glk-j4005:       NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/fi-glk-j4005/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - fi-glk-j4005:       NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 other tests skip
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/fi-glk-j4005/igt@gem_lmem_swapping@basic.html

  * igt@gem_lmem_swapping@parallel-random-engines:
    - bat-adlm-1:         NOTRUN -> [SKIP][3] ([i915#4613]) +3 other tests skip
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-adlm-1/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@gem_tiled_pread_basic:
    - bat-adlm-1:         NOTRUN -> [SKIP][4] ([i915#3282])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-adlm-1/igt@gem_tiled_pread_basic.html

  * igt@i915_pm_rps@basic-api:
    - bat-adlm-1:         NOTRUN -> [SKIP][5] ([i915#6621])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-adlm-1/igt@i915_pm_rps@basic-api.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-glk-j4005:       NOTRUN -> [SKIP][6] ([fdo#109271]) +6 other tests skip
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/fi-glk-j4005/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
    - bat-adlm-1:         NOTRUN -> [SKIP][7] ([i915#9875] / [i915#9900]) +16 other tests skip
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-adlm-1/igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size.html

  * igt@kms_flip@basic-plain-flip:
    - bat-adlm-1:         NOTRUN -> [SKIP][8] ([i915#3637]) +3 other tests skip
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-adlm-1/igt@kms_flip@basic-plain-flip.html

  * igt@kms_force_connector_basic@force-load-detect:
    - bat-adlm-1:         NOTRUN -> [SKIP][9] ([fdo#109285])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-adlm-1/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_frontbuffer_tracking@basic:
    - bat-adlm-1:         NOTRUN -> [SKIP][10] ([i915#1849] / [i915#4342])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-adlm-1/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_pm_backlight@basic-brightness:
    - bat-adlm-1:         NOTRUN -> [SKIP][11] ([i915#5354])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-adlm-1/igt@kms_pm_backlight@basic-brightness.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-adlm-1:         NOTRUN -> [SKIP][12] ([i915#3555])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-adlm-1/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-fence-flip:
    - bat-adlm-1:         NOTRUN -> [SKIP][13] ([i915#3708] / [i915#9900])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-adlm-1/igt@prime_vgem@basic-fence-flip.html

  * igt@prime_vgem@basic-write:
    - bat-adlm-1:         NOTRUN -> [SKIP][14] ([i915#3708]) +2 other tests skip
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-adlm-1/igt@prime_vgem@basic-write.html

  
#### Possible fixes ####

  * igt@gem_exec_create@basic@smem:
    - {bat-arls-1}:       [DMESG-WARN][15] ([i915#10194]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14307/bat-arls-1/igt@gem_exec_create@basic@smem.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-arls-1/igt@gem_exec_create@basic@smem.html

  * igt@gem_exec_parallel@engines@contexts:
    - bat-adlm-1:         [INCOMPLETE][17] ([i915#10137]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14307/bat-adlm-1/igt@gem_exec_parallel@engines@contexts.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/bat-adlm-1/igt@gem_exec_parallel@engines@contexts.html

  * igt@i915_pm_rpm@module-reload:
    - fi-kbl-7567u:       [CRASH][19] ([i915#9947]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14307/fi-kbl-7567u/igt@i915_pm_rpm@module-reload.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/fi-kbl-7567u/igt@i915_pm_rpm@module-reload.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [i915#10137]: https://gitlab.freedesktop.org/drm/intel/issues/10137
  [i915#10194]: https://gitlab.freedesktop.org/drm/intel/issues/10194
  [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673
  [i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732
  [i915#9875]: https://gitlab.freedesktop.org/drm/intel/issues/9875
  [i915#9900]: https://gitlab.freedesktop.org/drm/intel/issues/9900
  [i915#9947]: https://gitlab.freedesktop.org/drm/intel/issues/9947


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7718 -> IGTPW_10710

  CI-20190529: 20190529
  CI_DRM_14307: b429bc6c8b05fe2346f4e6c3bd7b1ff4063c476f @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_10710: 10710
  IGT_7718: 40e8b9122853f455c84afcfa56469a6bc9a0d564 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git


Testlist changes
----------------

+igt@core_getversion
-igt@core_getversion@basic
-igt@core_getversion@multigpu

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10710/index.html

[-- Attachment #2: Type: text/html, Size: 8264 bytes --]

Re: [i-g-t,2/2] tests/intel/kms_dirtyfb: Fix DRRS status check

[Joshi, Kunal1]

On 2/21/2024 4:53 PM, Bhanuprakash Modem wrote:
> Fix assertion check for DRRS status.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Both patch LGTM
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
>   tests/intel/kms_dirtyfb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> index 26b82e50a..0e315bfb4 100644
> --- a/tests/intel/kms_dirtyfb.c
> +++ b/tests/intel/kms_dirtyfb.c
> @@ -154,7 +154,7 @@ static void check_feature(data_t *data)
>   			     "PSR still disabled\n");
>   		break;
>   	case FEATURE_DRRS:
> -		igt_assert_f(intel_is_drrs_inactive(data->drm_fd, data->pipe),
> +		igt_assert_f(!intel_is_drrs_inactive(data->drm_fd, data->pipe),
>   			     "DRRS INACTIVE\n");
>   		break;
>   	case FEATURE_DEFAULT: