* [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats
2023-10-10 13:45 [igt-dev] [PATCH i-g-t] tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier Melanie Lobo
@ 2024-04-05 9:52 ` Melanie Lobo
2024-04-05 10:26 ` [PATCH 0/2] Support for FP16 format in MTL Melanie Lobo
1 sibling, 0 replies; 4+ messages in thread
From: Melanie Lobo @ 2024-04-05 9:52 UTC (permalink / raw)
To: igt-dev
Cc: juha-pekka.heikkila, vidya.srinivas, swati2.sharma,
bhanuprakash.modem, Melanie Lobo, Juha-Pekka Heikkila
MTL supports FP16 format which is a binary floating-point computer
number format that occupies 16 bits in computer memory. In this test
platform shall render compression in display engine to receive
FP16 compressed formats.
This was tested with kernel patch,
https://patchwork.freedesktop.org/patch/563854
Test-with: 20231012062620.23886-1-melanie.lobo@intel.com
cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
cc: Swati Sharma <swati2.sharma@intel.com>
Signed-off-by: Melanie Lobo <melanie.lobo@intel.com>
---
lib/intel_aux_pgtable.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/intel_aux_pgtable.c b/lib/intel_aux_pgtable.c
index 3cbb0e26f35c..1741c41af9a9 100644
--- a/lib/intel_aux_pgtable.c
+++ b/lib/intel_aux_pgtable.c
@@ -22,6 +22,7 @@
#define AUX_FORMAT_AYUV 0x09
#define AUX_FORMAT_ARGB_8B 0x0A
#define AUX_FORMAT_NV12_21 0x0F
+#define AUX_FORMAT_XRGB16161616_64B 0x10
struct pgtable_level_desc {
int idx_shift;
@@ -306,6 +307,10 @@ static uint64_t pgt_get_l1_flags(const struct intel_buf *buf, int surface_idx)
entry.e.format = AUX_FORMAT_ARGB_8B;
entry.e.depth = bpp_to_depth_val(32);
break;
+ case 64:
+ entry.e.format = AUX_FORMAT_XRGB16161616_64B;
+ entry.e.depth = bpp_to_depth_val(64);
+ break;
default:
igt_assert(0);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats
@ 2024-04-05 10:03 Melanie Lobo
0 siblings, 0 replies; 4+ messages in thread
From: Melanie Lobo @ 2024-04-05 10:03 UTC (permalink / raw)
To: igt-dev
Cc: juha-pekka.heikkila, vidya.srinivas, Melanie Lobo,
Juha-Pekka Heikkila, Bhanuprakash Modem, Swati Sharma
MTL supports FP16 format which is a binary floating-point computer
number format that occupies 16 bits in computer memory. In this test
platform shall render compression in display engine to receive
FP16 compressed formats.
This was tested with kernel patch,
https://patchwork.freedesktop.org/patch/563854
Test-with: 20231012062620.23886-1-melanie.lobo@intel.com
cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
cc: Swati Sharma <swati2.sharma@intel.com>
Signed-off-by: Melanie Lobo <melanie.lobo@intel.com>
---
lib/intel_aux_pgtable.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/intel_aux_pgtable.c b/lib/intel_aux_pgtable.c
index 3cbb0e26f35c..1741c41af9a9 100644
--- a/lib/intel_aux_pgtable.c
+++ b/lib/intel_aux_pgtable.c
@@ -22,6 +22,7 @@
#define AUX_FORMAT_AYUV 0x09
#define AUX_FORMAT_ARGB_8B 0x0A
#define AUX_FORMAT_NV12_21 0x0F
+#define AUX_FORMAT_XRGB16161616_64B 0x10
struct pgtable_level_desc {
int idx_shift;
@@ -306,6 +307,10 @@ static uint64_t pgt_get_l1_flags(const struct intel_buf *buf, int surface_idx)
entry.e.format = AUX_FORMAT_ARGB_8B;
entry.e.depth = bpp_to_depth_val(32);
break;
+ case 64:
+ entry.e.format = AUX_FORMAT_XRGB16161616_64B;
+ entry.e.depth = bpp_to_depth_val(64);
+ break;
default:
igt_assert(0);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats
2024-04-05 10:26 ` [PATCH 0/2] Support for FP16 format in MTL Melanie Lobo
@ 2024-04-05 10:26 ` Melanie Lobo
2024-04-05 17:17 ` Kamil Konieczny
0 siblings, 1 reply; 4+ messages in thread
From: Melanie Lobo @ 2024-04-05 10:26 UTC (permalink / raw)
To: igt-dev
Cc: juha-pekka.heikkila, vidya.srinivas, swati2.sharma,
bhanuprakash.modem, Melanie Lobo, Juha-Pekka Heikkila
MTL supports FP16 format which is a binary floating-point computer
number format that occupies 16 bits in computer memory. In this test
platform shall render compression in display engine to receive
FP16 compressed formats.
This was tested with kernel patch,
https://patchwork.freedesktop.org/patch/563854
Test-with: 20231012062620.23886-1-melanie.lobo@intel.com
cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
cc: Swati Sharma <swati2.sharma@intel.com>
Signed-off-by: Melanie Lobo <melanie.lobo@intel.com>
---
lib/intel_aux_pgtable.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/intel_aux_pgtable.c b/lib/intel_aux_pgtable.c
index 3cbb0e26f35c..1741c41af9a9 100644
--- a/lib/intel_aux_pgtable.c
+++ b/lib/intel_aux_pgtable.c
@@ -22,6 +22,7 @@
#define AUX_FORMAT_AYUV 0x09
#define AUX_FORMAT_ARGB_8B 0x0A
#define AUX_FORMAT_NV12_21 0x0F
+#define AUX_FORMAT_XRGB16161616_64B 0x10
struct pgtable_level_desc {
int idx_shift;
@@ -306,6 +307,10 @@ static uint64_t pgt_get_l1_flags(const struct intel_buf *buf, int surface_idx)
entry.e.format = AUX_FORMAT_ARGB_8B;
entry.e.depth = bpp_to_depth_val(32);
break;
+ case 64:
+ entry.e.format = AUX_FORMAT_XRGB16161616_64B;
+ entry.e.depth = bpp_to_depth_val(64);
+ break;
default:
igt_assert(0);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats
2024-04-05 10:26 ` [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats Melanie Lobo
@ 2024-04-05 17:17 ` Kamil Konieczny
0 siblings, 0 replies; 4+ messages in thread
From: Kamil Konieczny @ 2024-04-05 17:17 UTC (permalink / raw)
To: igt-dev
Cc: Melanie Lobo, juha-pekka.heikkila, vidya.srinivas, swati2.sharma,
bhanuprakash.modem, Juha-Pekka Heikkila
Hi Melanie,
On 2024-04-05 at 15:56:21 +0530, Melanie Lobo wrote:
one nit about subject:
[PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats
This imho should be:
[PATCH 1/2] lib/intel_aux_pgtable: Add FP16 compressed XRGB format
> MTL supports FP16 format which is a binary floating-point computer
> number format that occupies 16 bits in computer memory. In this test
--------------------------------------------------------- ^^^^^^^^^^^^
> platform shall render compression in display engine to receive
> FP16 compressed formats.
Drop this sentence from this patch, here you are adding change to lib,
not a test. I would rather see here a format your are adding, write
that it is XRGB16161616_64B.
Regards,
Kamil
>
> This was tested with kernel patch,
> https://patchwork.freedesktop.org/patch/563854
>
> Test-with: 20231012062620.23886-1-melanie.lobo@intel.com
>
> cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> cc: Swati Sharma <swati2.sharma@intel.com>
>
> Signed-off-by: Melanie Lobo <melanie.lobo@intel.com>
> ---
> lib/intel_aux_pgtable.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/lib/intel_aux_pgtable.c b/lib/intel_aux_pgtable.c
> index 3cbb0e26f35c..1741c41af9a9 100644
> --- a/lib/intel_aux_pgtable.c
> +++ b/lib/intel_aux_pgtable.c
> @@ -22,6 +22,7 @@
> #define AUX_FORMAT_AYUV 0x09
> #define AUX_FORMAT_ARGB_8B 0x0A
> #define AUX_FORMAT_NV12_21 0x0F
> +#define AUX_FORMAT_XRGB16161616_64B 0x10
>
> struct pgtable_level_desc {
> int idx_shift;
> @@ -306,6 +307,10 @@ static uint64_t pgt_get_l1_flags(const struct intel_buf *buf, int surface_idx)
> entry.e.format = AUX_FORMAT_ARGB_8B;
> entry.e.depth = bpp_to_depth_val(32);
> break;
> + case 64:
> + entry.e.format = AUX_FORMAT_XRGB16161616_64B;
> + entry.e.depth = bpp_to_depth_val(64);
> + break;
> default:
> igt_assert(0);
> }
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-05 17:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-05 10:03 [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats Melanie Lobo
-- strict thread matches above, loose matches on Subject: below --
2023-10-10 13:45 [igt-dev] [PATCH i-g-t] tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier Melanie Lobo
2024-04-05 9:52 ` [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats Melanie Lobo
2024-04-05 10:26 ` [PATCH 0/2] Support for FP16 format in MTL Melanie Lobo
2024-04-05 10:26 ` [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats Melanie Lobo
2024-04-05 17:17 ` Kamil Konieczny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox