Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier
@ 2023-10-10 13:45 Melanie Lobo
  2023-10-11 20:09 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier (rev2) Patchwork
                   ` (38 more replies)
  0 siblings, 39 replies; 67+ messages in thread
From: Melanie Lobo @ 2023-10-10 13:45 UTC (permalink / raw)
  To: igt-dev; +Cc: juha-pekka.heikkila

MTL supports new FP16 format which is a binary floating-point computer
number format that occupies 16 bits in computer memory.

Change-Id: I7fa8169d54cbd9e6dcdf765065659e541a31e481
Signed-off-by: Melanie Lobo <melanie.lobo@intel.com>
---
 lib/intel_aux_pgtable.c           |  5 +++++
 tests/intel/kms_flip_scaled_crc.c | 16 ++++++++++++++++
 2 files changed, 21 insertions(+)

diff --git a/lib/intel_aux_pgtable.c b/lib/intel_aux_pgtable.c
index 7c79521344de..a612df407692 100644
--- a/lib/intel_aux_pgtable.c
+++ b/lib/intel_aux_pgtable.c
@@ -21,6 +21,7 @@
 #define AUX_FORMAT_AYUV		0x09
 #define AUX_FORMAT_ARGB_8B	0x0A
 #define AUX_FORMAT_NV12_21	0x0F
+#define AUX_FORMAT_XRGB16161616_64B 0x10
 
 struct pgtable_level_desc {
 	int idx_shift;
@@ -305,6 +306,10 @@ static uint64_t pgt_get_l1_flags(const struct intel_buf *buf, int surface_idx)
 			entry.e.format = AUX_FORMAT_ARGB_8B;
 			entry.e.depth = bpp_to_depth_val(32);
 			break;
+		case 64:
+			entry.e.format = AUX_FORMAT_XRGB16161616_64B;
+			entry.e.depth = bpp_to_depth_val(64);
+			break;
 		default:
 			igt_assert(0);
 		}
diff --git a/tests/intel/kms_flip_scaled_crc.c b/tests/intel/kms_flip_scaled_crc.c
index 2997b63fac40..0d5e994af2b7 100644
--- a/tests/intel/kms_flip_scaled_crc.c
+++ b/tests/intel/kms_flip_scaled_crc.c
@@ -590,6 +590,22 @@ const struct {
 		0.5,
 		1.0,
 	},
+	{
+		"flip-64bpp-4tile-to-32bpp-4tilemtlrcccs-upscaling",
+		"Flip from 64bpp non scaled fb to 32bpp upscaled fb to stress CD clock programming",
+		I915_FORMAT_MOD_4_TILED, DRM_FORMAT_XRGB16161616F,
+		I915_FORMAT_MOD_4_TILED_MTL_RC_CCS, DRM_FORMAT_XRGB16161616F,
+		0.5,
+		1.0,
+	},
+	{
+		"flip-64bpp-4tile-to-32bpp-4tilemtlrcccs-downscaling",
+		"Flip from 64bpp non scaled fb to 32bpp downscaled fb to stress CD clock programming",
+		I915_FORMAT_MOD_4_TILED, DRM_FORMAT_XRGB16161616F,
+		I915_FORMAT_MOD_4_TILED_MTL_RC_CCS, DRM_FORMAT_XRGB16161616F,
+		1.0,
+		2.0,
+	},
 };
 
 static void setup_fb(data_t *data, struct igt_fb *newfb, uint32_t width,
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 67+ messages in thread
* [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats
@ 2024-04-05 10:03 Melanie Lobo
  0 siblings, 0 replies; 67+ messages in thread
From: Melanie Lobo @ 2024-04-05 10:03 UTC (permalink / raw)
  To: igt-dev
  Cc: juha-pekka.heikkila, vidya.srinivas, Melanie Lobo,
	Juha-Pekka Heikkila, Bhanuprakash Modem, Swati Sharma

MTL supports FP16 format which is a binary floating-point computer
number format that occupies 16 bits in computer memory. In this test
platform shall render compression in display engine to receive
FP16 compressed formats.

This was tested with kernel patch,
https://patchwork.freedesktop.org/patch/563854

Test-with: 20231012062620.23886-1-melanie.lobo@intel.com

cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
cc: Swati Sharma <swati2.sharma@intel.com>

Signed-off-by: Melanie Lobo <melanie.lobo@intel.com>
---
 lib/intel_aux_pgtable.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/intel_aux_pgtable.c b/lib/intel_aux_pgtable.c
index 3cbb0e26f35c..1741c41af9a9 100644
--- a/lib/intel_aux_pgtable.c
+++ b/lib/intel_aux_pgtable.c
@@ -22,6 +22,7 @@
 #define AUX_FORMAT_AYUV		0x09
 #define AUX_FORMAT_ARGB_8B	0x0A
 #define AUX_FORMAT_NV12_21	0x0F
+#define AUX_FORMAT_XRGB16161616_64B 0x10
 
 struct pgtable_level_desc {
 	int idx_shift;
@@ -306,6 +307,10 @@ static uint64_t pgt_get_l1_flags(const struct intel_buf *buf, int surface_idx)
 			entry.e.format = AUX_FORMAT_ARGB_8B;
 			entry.e.depth = bpp_to_depth_val(32);
 			break;
+		case 64:
+			entry.e.format = AUX_FORMAT_XRGB16161616_64B;
+			entry.e.depth = bpp_to_depth_val(64);
+			break;
 		default:
 			igt_assert(0);
 		}
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 67+ messages in thread
end of thread, other threads:[~2024-06-04  9:42 UTC | newest]

Thread overview: 67+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-10 13:45 [igt-dev] [PATCH i-g-t] tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier Melanie Lobo
2023-10-11 20:09 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier (rev2) Patchwork
2023-10-11 20:24 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2023-10-12  8:25 ` [igt-dev] [PATCH] intel/kms_flip_scaled_crc.c: Add support for FP16 compressed formats in MTL Melanie Lobo
2023-10-12 12:21   ` Kamil Konieczny
2023-10-18 10:41     ` Lobo, Melanie
2023-10-18 10:52 ` [igt-dev] [PATCH] tests/intel/kms_flip_scaled_crc: Add support for FP16 compressed formats Melanie Lobo
2023-10-18 15:35   ` Kamil Konieczny
2023-10-18 15:35 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier (rev5) Patchwork
2023-10-18 17:14 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-19 18:06 ` [igt-dev] [PATCH] tests/intel/kms_flip_scaled_crc: Add support for FP16 compressed formats Melanie Lobo
2023-10-23  5:39   ` Sharma, Swati2
2023-10-23 10:24     ` Lobo, Melanie
2023-10-23 10:29       ` Sharma, Swati2
2023-10-24  5:32         ` Lobo, Melanie
2023-10-23 17:52 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier (rev6) Patchwork
2023-10-23 18:17 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-10-23 19:19 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-10-24  2:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-10-24  5:43 ` [igt-dev] [PATCH] tests/intel/kms_flip_scaled_crc: Add support for FP16 compressed formats Melanie Lobo
2023-10-24  7:46 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier (rev7) Patchwork
2023-11-07  8:54 ` [igt-dev] [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats Melanie Lobo
2023-11-07  8:56 ` Melanie Lobo
2023-11-07  8:56   ` [igt-dev] [PATCH 2/2] tests/intel/kms_flip_scaled_crc: Add " Melanie Lobo
2023-11-07  9:03 ` [igt-dev] [PATCH 0/2] Add support for FP16 compressed format Melanie Lobo
2023-11-07  9:03   ` [igt-dev] [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats Melanie Lobo
2023-11-07  9:03   ` [igt-dev] [PATCH 2/2] tests/intel/kms_flip_scaled_crc: Add " Melanie Lobo
2023-11-07  9:05 ` [igt-dev] [PATCH 0/2] Add support for FP16 compressed format Melanie Lobo
2023-11-07  9:05   ` [igt-dev] [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats Melanie Lobo
2023-11-07  9:05   ` [igt-dev] [PATCH 2/2] tests/intel/kms_flip_scaled_crc: Add " Melanie Lobo
2023-11-07 10:27 ` [igt-dev] ✓ CI.xeBAT: success for tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier (rev12) Patchwork
2023-11-07 10:28 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2024-04-05  9:52 ` [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats Melanie Lobo
2024-04-05  9:52   ` [PATCH 2/2] tests/intel/kms_flip_scaled_crc: Add " Melanie Lobo
2024-04-05 10:15 ` ✓ CI.xeBAT: success for tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier (rev14) Patchwork
2024-04-05 10:23 ` ✓ Fi.CI.BAT: " Patchwork
2024-04-05 10:26 ` [PATCH 0/2] Support for FP16 format in MTL Melanie Lobo
2024-04-05 10:26   ` [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats Melanie Lobo
2024-04-05 17:17     ` Kamil Konieczny
2024-04-05 10:26   ` [PATCH 2/2] tests/intel/kms_flip_scaled_crc: Add " Melanie Lobo
2024-04-05 17:32     ` Kamil Konieczny
2024-04-05 10:46 ` ✓ CI.xeBAT: success for tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier (rev16) Patchwork
2024-04-05 11:07 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-05 17:12 ` ✗ Fi.CI.IGT: failure for tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier (rev14) Patchwork
2024-04-17 10:03 ` [PATCH 0/2] Support for FP16 format in MTL Melanie Lobo
2024-04-17 10:03   ` [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 XRGB16161616_64B format Melanie Lobo
2024-04-17 10:03   ` [PATCH 2/2] tests/intel/kms_flip_scaled_crc: Add tests for FP16 XRGB16161616_64B compressed format Melanie Lobo
2024-04-17 10:45 ` [PATCH 0/2] Adding FP16 XRGB16161616_64B tests in MTL Melanie Lobo
2024-04-17 10:45   ` [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 XRGB16161616_64B format Melanie Lobo
2024-04-17 10:45   ` [PATCH 2/2] tests/intel/kms_flip_scaled_crc: Add tests for FP16 XRGB16161616_64B compressed format Melanie Lobo
2024-04-17 12:18 ` ✓ Fi.CI.BAT: success for tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier (rev18) Patchwork
2024-04-17 12:58 ` ✓ CI.xeBAT: " Patchwork
2024-04-18  1:44 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-18 20:39 ` ✗ CI.xeFULL: " Patchwork
2024-06-03  7:41 ` ✗ Fi.CI.BUILD: failure for tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier (rev19) Patchwork
2024-06-03  7:44 ` ✗ GitLab.Pipeline: warning " Patchwork
2024-06-03  7:49 ` [PATCH 0/2] Support for RGB16161616_64B compressed formats Melanie Lobo
2024-06-03  7:49   ` [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for RGB16161616_64B format Melanie Lobo
2024-06-03  7:49   ` [PATCH 2/2] tests/intel/kms_flip_scaled_crc: Add support for RGB16161616_64B compressed formats Melanie Lobo
2024-06-03  7:58 ` [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for RGB16161616_64B format Melanie Lobo
2024-06-03  7:58   ` [PATCH 2/2] tests/intel/kms_flip_scaled_crc: Add support for RGB16161616_64B compressed formats Melanie Lobo
2024-06-03  8:13 ` [PATCH 0/2] Support " Melanie Lobo
2024-06-03  8:13   ` [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for RGB16161616_64B format Melanie Lobo
2024-06-03  8:13   ` [PATCH 2/2] tests/intel/kms_flip_scaled_crc: Add support for RGB16161616_64B compressed formats Melanie Lobo
2024-06-04  7:21 ` ✗ Fi.CI.BUILD: failure for tests/intel/kms_flip_scaled_crc: Add support for FP16 format of MTL compressed modifier (rev22) Patchwork
2024-06-04  9:42 ` ✗ GitLab.Pipeline: warning " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-04-05 10:03 [PATCH 1/2] lib/intel_aux_pgtable: Library to add support for FP16 compressed formats Melanie Lobo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox