From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
Kunal Joshi <kunal1.joshi@intel.com>
Subject: [i-g-t V2 2/6] lib/igt_kms: Force joiner support in bigjoiner checks
Date: Thu, 18 Apr 2024 14:49:55 +0530 [thread overview]
Message-ID: <20240418091959.781560-3-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240418091959.781560-1-bhanuprakash.modem@intel.com>
As we recently introduced the option (through debugfs) to
force the bigjoiner, needs to extend the support in bigjoiner
checks to handle the force joiner.
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/igt_kms.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 4c43921ce..9258e8f3f 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6338,6 +6338,7 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
struct {
enum pipe idx;
drmModeModeInfo *mode;
+ bool force_joiner;
} pipes[IGT_MAX_PIPES];
int max_dotclock;
@@ -6355,6 +6356,7 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
pipes[pipes_in_use].idx = output->pending_pipe;
pipes[pipes_in_use].mode = igt_output_get_mode(output);
+ pipes[pipes_in_use].force_joiner = igt_check_force_joiner_status(display->drm_fd, output->name);
pipes_in_use++;
}
@@ -6366,21 +6368,24 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
max_dotclock = igt_get_max_dotclock(display->drm_fd);
/*
- * if mode resolution > 5K (or) mode.clock > max dot-clock, then ignore
+ * if force joiner (or) mode resolution > 5K (or) mode.clock > max dot-clock,
+ * then ignore
* - if the consecutive pipe is not available
* - last crtc in single/multi-connector config
* - consecutive crtcs in multi-connector config
*
* in multi-connector config ignore if
- * - previous crtc (mode resolution > 5K or mode.clock > max dot-clock) and
+ * - previous crtc (force joiner or mode resolution > 5K or mode.clock > max dot-clock) and
* - current & previous crtcs are consecutive
*/
for (i = 0; i < pipes_in_use; i++) {
- if ((igt_bigjoiner_possible(pipes[i].mode, max_dotclock) &&
+ if (((pipes[i].force_joiner ||
+ igt_bigjoiner_possible(pipes[i].mode, max_dotclock)) &&
((pipes[i].idx >= (total_pipes - 1)) ||
(!display->pipes[pipes[i].idx + 1].enabled) ||
((i < (pipes_in_use - 1)) && (abs(pipes[i + 1].idx - pipes[i].idx) <= 1)))) ||
- ((i > 0) && igt_bigjoiner_possible(pipes[i - 1].mode, max_dotclock) &&
+ ((i > 0) && (pipes[i - 1].force_joiner ||
+ igt_bigjoiner_possible(pipes[i - 1].mode, max_dotclock)) &&
((!display->pipes[pipes[i - 1].idx + 1].enabled) ||
(abs(pipes[i].idx - pipes[i - 1].idx) <= 1)))) {
igt_debug("Pipe/Output combo is not possible with selected mode(s).\n");
--
2.43.2
next prev parent reply other threads:[~2024-04-18 9:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 9:19 [i-g-t V2 0/6] Force joiner support in bigjoiner checks Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 1/6] lib/igt_kms: New helper to check force joiner status Bhanuprakash Modem
2024-04-18 9:19 ` Bhanuprakash Modem [this message]
2024-04-18 9:19 ` [i-g-t V2 3/6] tests/intel/kms_pm_lpsp: Force joiner support in bigjoiner checks Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 4/6] tests/kms_flip: " Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 5/6] tests/kms_setmode: " Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 6/6] HAX: Test force joiner on BAT Bhanuprakash Modem
2024-04-18 13:35 ` [i-g-t V3 " Bhanuprakash Modem
2024-04-18 11:04 ` ✗ Fi.CI.BAT: failure for Force joiner support in bigjoiner checks (rev3) Patchwork
2024-04-18 11:32 ` ✓ CI.xeBAT: success " Patchwork
2024-04-19 0:05 ` ✗ Fi.CI.BAT: failure for Force joiner support in bigjoiner checks (rev4) Patchwork
2024-04-19 0:09 ` ✓ CI.xeBAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418091959.781560-3-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox