From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
Kunal Joshi <kunal1.joshi@intel.com>
Subject: [i-g-t V2 5/6] tests/kms_setmode: Force joiner support in bigjoiner checks
Date: Thu, 18 Apr 2024 14:49:58 +0530 [thread overview]
Message-ID: <20240418091959.781560-6-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240418091959.781560-1-bhanuprakash.modem@intel.com>
As we recently introduced the option (through debugfs) to
force the bigjoiner, needs to extend the support in bigjoiner
checks to handle the force joiner.
V2: - Fix connector name
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_setmode.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 490bfd3dd..95c5bfadc 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -709,24 +709,38 @@ static void test_one_combination(const struct test_config *tconf,
for (i = 0; i < crtc_count; i++) {
struct crtc_config *crtc = &crtcs[i];
+ char conn_name[24], prev_conn_name[24];
+
+ snprintf(conn_name, sizeof(conn_name),
+ "%s-%d",
+ kmstest_connector_type_str(crtcs[i].cconfs->connector->connector_type),
+ crtcs[i].cconfs->connector->connector_type_id);
+
+ if (i > 0)
+ snprintf(prev_conn_name, sizeof(prev_conn_name),
+ "%s-%d",
+ kmstest_connector_type_str(crtcs[i - 1].cconfs->connector->connector_type),
+ crtcs[i - 1].cconfs->connector->connector_type_id);
/*
* Handle BW limitations on intel hardware:
*
- * if mode resolution > 5K (or) mode clock > max_dotclock,
+ * if force joiner (or) mode resolution > 5K (or) mode clock > max_dotclock,
* then ignore
* - last crtc in single/multi-connector config
* - consecutive crtcs in multi-connector config
*
* in multi-connector config ignore if
- * - previous crtc (mode resolution > 5K (or)
+ * - previous crtc (force joiner (or) mode resolution > 5K (or)
* mode clock > max_dotclock) and
* - current & previous crtcs are consecutive
*/
- if ((igt_bigjoiner_possible(&crtc->mode, max_dotclock) &&
+ if (((igt_check_force_joiner_status(drm_fd, conn_name) ||
+ igt_bigjoiner_possible(&crtc->mode, max_dotclock)) &&
((crtc->crtc_idx >= (tconf->resources->count_crtcs - 1)) ||
((i < (crtc_count - 1)) && (abs(crtcs[i + 1].crtc_idx - crtc->crtc_idx) <= 1)))) ||
- ((i > 0) && igt_bigjoiner_possible(&crtc[i - 1].mode, max_dotclock) &&
+ ((i > 0) && (igt_check_force_joiner_status(drm_fd, prev_conn_name) ||
+ igt_bigjoiner_possible(&crtc[i - 1].mode, max_dotclock)) &&
(abs(crtc->crtc_idx - crtcs[i - 1].crtc_idx) <= 1))) {
igt_info("Combo: %s is not possible with selected mode(s).\n", test_name);
goto out;
--
2.43.2
next prev parent reply other threads:[~2024-04-18 9:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 9:19 [i-g-t V2 0/6] Force joiner support in bigjoiner checks Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 1/6] lib/igt_kms: New helper to check force joiner status Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 2/6] lib/igt_kms: Force joiner support in bigjoiner checks Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 3/6] tests/intel/kms_pm_lpsp: " Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 4/6] tests/kms_flip: " Bhanuprakash Modem
2024-04-18 9:19 ` Bhanuprakash Modem [this message]
2024-04-18 9:19 ` [i-g-t V2 6/6] HAX: Test force joiner on BAT Bhanuprakash Modem
2024-04-18 13:35 ` [i-g-t V3 " Bhanuprakash Modem
2024-04-18 11:04 ` ✗ Fi.CI.BAT: failure for Force joiner support in bigjoiner checks (rev3) Patchwork
2024-04-18 11:32 ` ✓ CI.xeBAT: success " Patchwork
2024-04-19 0:05 ` ✗ Fi.CI.BAT: failure for Force joiner support in bigjoiner checks (rev4) Patchwork
2024-04-19 0:09 ` ✓ CI.xeBAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418091959.781560-6-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox