From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Subject: [i-g-t V3 6/6] HAX: Test force joiner on BAT
Date: Thu, 18 Apr 2024 19:05:13 +0530 [thread overview]
Message-ID: <20240418133513.812544-1-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240418091959.781560-7-bhanuprakash.modem@intel.com>
Expectation: All pipe-D tests should skip.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/igt_kms.c | 6 +++---
lib/igt_kms.h | 2 +-
tests/intel/kms_big_joiner.c | 2 +-
tests/kms_flip.c | 29 ++++++++++++++++++++++++++++-
tests/kms_pipe_crc_basic.c | 10 ++++++++++
5 files changed, 43 insertions(+), 6 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 9258e8f3f..8edbf2dce 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6241,13 +6241,13 @@ bool bigjoiner_mode_found(int drm_fd, drmModeConnector *connector,
* Returns:
* true if the debugfs is available, false otherwise.
*/
-bool igt_has_force_joiner_debugfs(int drmfd, igt_output_t *output)
+bool igt_has_force_joiner_debugfs(int drmfd, char *conn_name)
{
char buf[512];
int debugfs_fd, ret;
- igt_assert_f(output->name, "Connector name cannot be NULL\n");
- debugfs_fd = igt_debugfs_connector_dir(drmfd, output->name, O_RDONLY);
+ igt_assert_f(conn_name, "Connector name cannot be NULL\n");
+ debugfs_fd = igt_debugfs_connector_dir(drmfd, conn_name, O_RDONLY);
if (debugfs_fd < 0)
return false;
ret = igt_debugfs_simple_read(debugfs_fd, "i915_bigjoiner_force_enable", buf, sizeof(buf));
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index b8f7c745b..8e34caa60 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -1214,7 +1214,7 @@ int igt_get_max_dotclock(int fd);
bool igt_bigjoiner_possible(drmModeModeInfo *mode, int max_dotclock);
bool bigjoiner_mode_found(int drm_fd, drmModeConnector *connector,
int max_dotclock, drmModeModeInfo *mode);
-bool igt_has_force_joiner_debugfs(int drmfd, igt_output_t *output);
+bool igt_has_force_joiner_debugfs(int drmfd, char *conn_name);
bool igt_force_and_check_bigjoiner_status(int drmfd, char *connector_name, bool enable);
bool igt_check_force_joiner_status(int drmfd, char *connector_name);
bool igt_check_bigjoiner_support(igt_display_t *display);
diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
index 078f76ac1..33e4046e3 100644
--- a/tests/intel/kms_big_joiner.c
+++ b/tests/intel/kms_big_joiner.c
@@ -320,7 +320,7 @@ igt_main
data.big_joiner_output[data.big_joiner_output_count++] = output;
igt_output_override_mode(output, &mode);
} else {
- if (igt_has_force_joiner_debugfs(data.drm_fd, output)) {
+ if (igt_has_force_joiner_debugfs(data.drm_fd, output->name)) {
force_joiner_supported = true;
data.non_big_joiner_output[data.non_big_joiner_output_count++] = output;
}
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 57f6cff7a..d819779e5 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1748,12 +1748,17 @@ static void run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
"%s-%d",
kmstest_connector_type_str(o->kconnector[i]->connector_type),
o->kconnector[i]->connector_type_id);
+ if (igt_has_force_joiner_debugfs(drm_fd, conn_name))
+ igt_force_and_check_bigjoiner_status(drm_fd, conn_name, true);
- if (i > 0)
+ if (i > 0) {
snprintf(prev_conn_name, sizeof(prev_conn_name),
"%s-%d",
kmstest_connector_type_str(o->kconnector[i - 1]->connector_type),
o->kconnector[i - 1]->connector_type_id);
+ if (igt_has_force_joiner_debugfs(drm_fd, prev_conn_name))
+ igt_force_and_check_bigjoiner_status(drm_fd, prev_conn_name, true);
+ }
if (((igt_check_force_joiner_status(drm_fd, conn_name) ||
igt_bigjoiner_possible(&o->kmode[i], max_dotclock)) &&
@@ -2124,6 +2129,28 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
igt_stop_signal_helper();
igt_fixture {
+ resources = drmModeGetResources(drm_fd);
+ if (resources) {
+ for (i = 0; i < resources->count_connectors; i++) {
+ drmModeConnector *connector = drmModeGetConnectorCurrent(drm_fd, resources->connectors[i]);
+ char conn_name[24];
+
+ if (!connector)
+ continue;
+
+ if (connector->connection == DRM_MODE_CONNECTED) {
+ snprintf(conn_name, sizeof(conn_name),
+ "%s-%d",
+ kmstest_connector_type_str(connector->connector_type),
+ connector->connector_type_id);
+ if (igt_check_force_joiner_status(drm_fd, conn_name))
+ igt_force_and_check_bigjoiner_status(drm_fd, conn_name, false);
+ }
+ }
+
+ drmModeFreeResources(resources);
+ }
+
igt_display_fini(&display);
drm_close_driver(drm_fd);
}
diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index 0c19745bc..a5a2d61a1 100644
--- a/tests/kms_pipe_crc_basic.c
+++ b/tests/kms_pipe_crc_basic.c
@@ -411,6 +411,11 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
data.debugfs = igt_debugfs_dir(data.drm_fd);
+ for_each_connected_output(&data.display, output) {
+ if (igt_has_force_joiner_debugfs(data.drm_fd, output->name))
+ igt_force_and_check_bigjoiner_status(data.drm_fd, output->name, true);
+ }
+
/* Get active pipes. */
for_each_pipe(&data.display, pipe)
active_pipes[last_pipe++] = pipe;
@@ -499,6 +504,11 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
}
igt_fixture {
+ for_each_connected_output(&data.display, output) {
+ if (igt_check_force_joiner_status(data.drm_fd, output->name))
+ igt_force_and_check_bigjoiner_status(data.drm_fd, output->name, false);
+ }
+
igt_display_fini(&data.display);
drm_close_driver(data.drm_fd);
}
--
2.43.2
next prev parent reply other threads:[~2024-04-18 13:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 9:19 [i-g-t V2 0/6] Force joiner support in bigjoiner checks Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 1/6] lib/igt_kms: New helper to check force joiner status Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 2/6] lib/igt_kms: Force joiner support in bigjoiner checks Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 3/6] tests/intel/kms_pm_lpsp: " Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 4/6] tests/kms_flip: " Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 5/6] tests/kms_setmode: " Bhanuprakash Modem
2024-04-18 9:19 ` [i-g-t V2 6/6] HAX: Test force joiner on BAT Bhanuprakash Modem
2024-04-18 13:35 ` Bhanuprakash Modem [this message]
2024-04-18 11:04 ` ✗ Fi.CI.BAT: failure for Force joiner support in bigjoiner checks (rev3) Patchwork
2024-04-18 11:32 ` ✓ CI.xeBAT: success " Patchwork
2024-04-19 0:05 ` ✗ Fi.CI.BAT: failure for Force joiner support in bigjoiner checks (rev4) Patchwork
2024-04-19 0:09 ` ✓ CI.xeBAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418133513.812544-1-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox