From: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Bommu Krishnaiah <krishnaiah.bommu@intel.com>,
Oak Zeng <oak.zeng@intel.com>,
Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Subject: [PATCH i-g-t v3 03/10] tests/intel/xe_svm: Add SVM basic tests using malloc and mmap
Date: Fri, 17 May 2024 17:16:51 +0530 [thread overview]
Message-ID: <20240517114658.810283-4-krishnaiah.bommu@intel.com> (raw)
In-Reply-To: <20240517114658.810283-1-krishnaiah.bommu@intel.com>
Adds subtests to verify the basic functionality of Shared Virtual Memory (SVM)
in the xe driver. The tests ensure that memory allocated with malloc or mmap can be correctly
used for GPU command submission and data verification.
Subtests:
- svm-basic-malloc: Verifies SVM functionality using memory allocated with malloc.
- svm-basic-mmap: Verifies SVM functionality using memory allocated with mmap.
The verification is done by writing a specific value to the allocated memory via GPU and
checking if the value is correctly stored.
Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
Cc: Oak Zeng <oak.zeng@intel.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
---
include/drm-uapi/xe_drm.h | 1 +
tests/intel/xe_svm.c | 52 +++++++++++++++++++++++++++++++++++++++
2 files changed, 53 insertions(+)
diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
index 0b709b374..69c8792bb 100644
--- a/include/drm-uapi/xe_drm.h
+++ b/include/drm-uapi/xe_drm.h
@@ -973,6 +973,7 @@ struct drm_xe_vm_bind_op {
#define DRM_XE_VM_BIND_FLAG_IMMEDIATE (1 << 1)
#define DRM_XE_VM_BIND_FLAG_NULL (1 << 2)
#define DRM_XE_VM_BIND_FLAG_DUMPABLE (1 << 3)
+#define DRM_XE_VM_BIND_FLAG_SYSTEM_ALLOCATOR (1 << 4)
/** @flags: Bind flags */
__u32 flags;
diff --git a/tests/intel/xe_svm.c b/tests/intel/xe_svm.c
index 6302af95b..741961529 100644
--- a/tests/intel/xe_svm.c
+++ b/tests/intel/xe_svm.c
@@ -21,6 +21,12 @@
*
* SUBTEST: xe-basic
* Description: Basic test to verify store dword functionality using helper functions
+ *
+ * SUBTEST: svm-basic-malloc
+ * Description: Verify SVM basic functionality using malloc.
+ *
+ * SUBTEST: svm-basic-mmap
+ * Description: Verify SVM basic functionality using mmap.
*/
#include <fcntl.h>
@@ -75,6 +81,44 @@ static void xe_basic(int fd, uint32_t vm, struct drm_xe_engine_class_instance *e
xe_destroy_buffer(&dst_buf);
}
+/**
+ * @brief Tests SVM functionality using malloc or mmap.
+ *
+ * This function tests the ability to use malloc or mmap allocated memory
+ * for direct GPU command submission and data verification.
+ */
+static void svm_basic(int fd, uint32_t vm, struct drm_xe_engine_class_instance *eci, bool test_mmap)
+{
+ uint64_t gpu_va = 0x1a0000;
+ size_t bo_size = xe_bb_size(fd, PAGE_ALIGN_UFENCE);
+ uint32_t *dst;
+
+ struct xe_buffer cmd_buf = {
+ .fd = fd,
+ .gpu_addr = (void *)(uintptr_t)gpu_va,
+ .vm = vm,
+ .size = bo_size,
+ .placement = vram_if_possible(fd, eci->gt_id),
+ .flag = DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM,
+ };
+
+ if (test_mmap)
+ dst = mmap(NULL, 4, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0);
+ else
+ dst = aligned_alloc(xe_get_default_alignment(fd), 4);
+
+ xe_create_cmdbuf(&cmd_buf, insert_store, (uint64_t)dst, 0xc0ffee, eci);
+ xe_submit_cmd(&cmd_buf);
+
+ igt_assert_eq(*dst, 0xc0ffee);
+
+ xe_destroy_cmdbuf(&cmd_buf);
+ if (test_mmap)
+ munmap(dst, 4);
+ else
+ free(dst);
+}
+
igt_main
{
int fd;
@@ -91,6 +135,14 @@ igt_main
xe_for_each_engine(fd, hwe)
xe_basic(fd, vm, hwe);
+ igt_subtest_f("svm-basic-malloc")
+ xe_for_each_engine(fd, hwe)
+ svm_basic(fd, vm, hwe, false);
+
+ igt_subtest_f("svm-basic-mmap")
+ xe_for_each_engine(fd, hwe)
+ svm_basic(fd, vm, hwe, true);
+
igt_fixture {
xe_vm_destroy(fd, vm);
drm_close_driver(fd);
--
2.25.1
next prev parent reply other threads:[~2024-05-17 11:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 11:46 [PATCH i-g-t v3 00/10] tests/intel/xe_svm: Add tests for Shared Virtual Memory (SVM) Bommu Krishnaiah
2024-05-17 11:46 ` [PATCH i-g-t v3 01/10] lib/xe/xe_util: Introduce helper functions for buffer creation and command submission etc Bommu Krishnaiah
2024-05-17 14:09 ` Zeng, Oak
2024-05-17 18:05 ` Kamil Konieczny
2024-05-17 11:46 ` [PATCH i-g-t v3 02/10] tests/intel/xe_svm: basic xe-basic test Bommu Krishnaiah
2024-05-17 14:23 ` Zeng, Oak
2024-05-20 8:51 ` Piecielska, Katarzyna
2024-05-17 11:46 ` Bommu Krishnaiah [this message]
2024-05-17 14:39 ` [PATCH i-g-t v3 03/10] tests/intel/xe_svm: Add SVM basic tests using malloc and mmap Zeng, Oak
2024-05-17 17:07 ` Bommu, Krishnaiah
2024-05-17 11:46 ` [PATCH i-g-t v3 04/10] tests/intel/xe_svm: add random access test for SVM Bommu Krishnaiah
2024-05-17 14:48 ` Zeng, Oak
2024-05-17 11:46 ` [PATCH i-g-t v3 05/10] tests/intel/xe_svm: add huge page " Bommu Krishnaiah
2024-05-18 2:01 ` Zeng, Oak
2024-05-17 11:46 ` [PATCH i-g-t v3 06/10] tests/intel/xe_svm: Add support for GPU atomic access test for svm Bommu Krishnaiah
2024-05-18 2:16 ` Zeng, Oak
2024-05-17 11:46 ` [PATCH i-g-t v3 07/10] tests/intel/xe_svm: Add svm-invalid-va test to verify SVM functionality with invalid address access Bommu Krishnaiah
2024-05-18 2:19 ` Zeng, Oak
2024-05-17 11:46 ` [PATCH i-g-t v3 08/10] tests/intel/xe_svm: Add svm-benchmark test to measure SVM performance with a simple benchmark Bommu Krishnaiah
2024-05-18 2:27 ` Zeng, Oak
2024-05-17 11:46 ` [PATCH i-g-t v3 09/10] tests/intel/xe_svm: Add svm-mprotect test to verify SVM functionality with read-only memory access Bommu Krishnaiah
2024-05-17 11:46 ` [PATCH i-g-t v3 10/10] tests/intel/xe_svm: Add svm-sparse-access test to verify sparsely accessing two memory locations with SVM Bommu Krishnaiah
2024-05-17 12:35 ` ✗ GitLab.Pipeline: warning for tests/intel/xe_svm: Add tests for Shared Virtual Memory (SVM) Patchwork
2024-05-17 12:52 ` ✓ CI.xeBAT: success " Patchwork
2024-05-17 13:06 ` ✓ Fi.CI.BAT: " Patchwork
2024-05-17 14:48 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-17 20:00 ` ✗ Fi.CI.IGT: " Patchwork
2024-05-22 11:38 ` [PATCH i-g-t v3 00/10] " Matthew Brost
2024-05-22 11:42 ` Matthew Brost
2024-05-22 16:53 ` Zeng, Oak
2024-05-23 17:26 ` Matthew Brost
2024-05-24 3:12 ` Zeng, Oak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517114658.810283-4-krishnaiah.bommu@intel.com \
--to=krishnaiah.bommu@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=oak.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox