Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 20/20] tools/intel_vbt_decode: Decode device handle as a bitmask
Date: Fri, 31 May 2024 17:23:54 +0300	[thread overview]
Message-ID: <20240531142354.16528-21-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240531142354.16528-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Some VBT blocks contain bitmasks of device handles (where multiple
bits can be set simultanously). Allow decoding such things by
having child_device_handle() take in the whole bitmask instead of
assuming just one bit.

We'll cheat a bit with a static buffer for the output string.
That should be fine given the simplicity of the tool.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tools/intel_vbt_decode.c | 29 +++++++++++++++++++++++++----
 1 file changed, 25 insertions(+), 4 deletions(-)

diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
index b0c30ffcbc0a..40c05fbadacb 100644
--- a/tools/intel_vbt_decode.c
+++ b/tools/intel_vbt_decode.c
@@ -820,9 +820,17 @@ static const int num_child_device_handles =
 static const char *child_device_handle(struct context *context,
 				       uint16_t handle)
 {
-	int i;
+	static char buffer[64];
+	size_t len = sizeof(buffer);
+	char *ptr = buffer;
+	bool first = true;
+
+	if (handle == 0)
+		return "none";
+
+	for (int i = 0; i < num_child_device_handles; i++) {
+		int r;
 
-	for (i = 0; i < num_child_device_handles; i++) {
 		if (!(child_device_handles[i].handle & handle))
 			continue;
 
@@ -834,10 +842,23 @@ static const char *child_device_handle(struct context *context,
 		    context->bdb->version > child_device_handles[i].max_ver)
 			continue;
 
-		return child_device_handles[i].name;
+		handle &= ~child_device_handles[i].handle;
+
+		r = snprintf(ptr, len, "%s%s", first ? "" : ",",
+			     child_device_handles[i].name);
+		if (r < 0 || r >= len)
+			break;
+
+		first = false;
+		ptr += r;
+		len -= r;
 	}
 
-	return "unknown";
+	if (handle)
+		snprintf(ptr, len, "%sunknown(0x%x)",
+			 first ? "" : ",", handle);
+
+	return buffer;
 }
 
 static const char *dvo_port_names[] = {
-- 
2.44.1


  parent reply	other threads:[~2024-05-31 14:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31 14:23 [PATCH i-g-t 00/20] tools/intel_vbt_decode: Refactoring and prep work for decoding more blocks Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 01/20] tools/intel_vbt_decode: Finish the s/lvds/lfp/ rename Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 02/20] tools/intel_vbt_decode: s/dump_sdvo_panel_dtd()/dump_sdvo_lvds_dtd()/ Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 03/20] lib: Define DIV_ROUND_CLOSEST() Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 04/20] tools/intel_vbt_decode: Fix some tabs Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 05/20] tools/intel_vbt_decode: Add missing newline Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 06/20] tools/intel_vbt_decode: Indent ALS dump Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 07/20] tools/intel_vbt_decode: Use "(LFP<n>)" to indicate LFP panel type Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 08/20] tools/intel_vbt_decode: Decode the "not HDMI" bit right way up Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 09/20] tools/intel_vbt_decode: Extract dump_pnp_id() Ville Syrjala
2024-05-31 14:48   ` Jani Nikula
2024-06-05 11:41     ` Ville Syrjälä
2024-05-31 14:23 ` [PATCH i-g-t 10/20] tools/intel_vbt_decode: Reuse print_detail_timing_data() Ville Syrjala
2024-05-31 14:50   ` Jani Nikula
2024-05-31 14:23 ` [PATCH i-g-t 11/20] tools/intel_vbt_decode: Dump the new eDP DSC disable bit Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 12/20] tools/intel_vbt_decode: Allow dumpers to delcate min version for the block Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 13/20] tools/intel_vbt_decode: Use .min_bdb_version to filter out PSR block on pre-165 VBTs Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 14/20] tools/intel_vbt_decode: Sort dumper table Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 15/20] tools/intel_vbt_decode: Use struct bdb_sdvo_lvds_dtd Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 16/20] tools/intel_vbt_decode: Track the SDVO panel type Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 17/20] tools/intel_vbt_decode: Use find_raw_section() to determine block presence Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 18/20] tools/intel_vbt_decode: Make device handle names more compact Ville Syrjala
2024-05-31 14:23 ` [PATCH i-g-t 19/20] tools/intel_vbt_decode: Declare min/max version for child dev handles Ville Syrjala
2024-05-31 14:23 ` Ville Syrjala [this message]
2024-05-31 15:10   ` [PATCH i-g-t 20/20] tools/intel_vbt_decode: Decode device handle as a bitmask Jani Nikula
2024-05-31 15:11 ` [PATCH i-g-t 00/20] tools/intel_vbt_decode: Refactoring and prep work for decoding more blocks Jani Nikula
2024-05-31 16:53 ` ✗ GitLab.Pipeline: warning for " Patchwork
2024-05-31 17:19 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-05-31 17:24 ` ✓ CI.xeBAT: success " Patchwork
2024-05-31 19:02 ` ✗ CI.xeFULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240531142354.16528-21-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox