Re: [PATCH i-g-t 00/20] tools/intel_vbt_decode: Refactoring and prep work for decoding more blocks

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 31 May 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> A bunch of refactoring/cleanups/etc. to intel_vbt_decode. I have
> a followup also lined up that implementes decoding of nearly all
> known blocks, but figured I'll get all the other stuff out of the
> way first.

Some minor nitpicks that can be ignored or clean up later, series is

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


>
> Ville Syrjälä (20):
>   tools/intel_vbt_decode: Finish the s/lvds/lfp/ rename
>   tools/intel_vbt_decode: s/dump_sdvo_panel_dtd()/dump_sdvo_lvds_dtd()/
>   lib: Define DIV_ROUND_CLOSEST()
>   tools/intel_vbt_decode: Fix some tabs
>   tools/intel_vbt_decode: Add missing newline
>   tools/intel_vbt_decode: Indent ALS dump
>   tools/intel_vbt_decode: Use "(LFP<n>)" to indicate LFP panel type
>   tools/intel_vbt_decode: Decode the "not HDMI" bit right way up
>   tools/intel_vbt_decode: Extract dump_pnp_id()
>   tools/intel_vbt_decode: Reuse print_detail_timing_data()
>   tools/intel_vbt_decode: Dump the new eDP DSC disable bit
>   tools/intel_vbt_decode: Allow dumpers to delcate min version for the
>     block
>   tools/intel_vbt_decode: Use .min_bdb_version to filter out PSR block
>     on pre-165 VBTs
>   tools/intel_vbt_decode: Sort dumper table
>   tools/intel_vbt_decode: Use struct bdb_sdvo_lvds_dtd
>   tools/intel_vbt_decode: Track the SDVO panel type
>   tools/intel_vbt_decode: Use find_raw_section() to determine block
>     presence
>   tools/intel_vbt_decode: Make device handle names more compact
>   tools/intel_vbt_decode: Declare min/max version for child dev handles
>   tools/intel_vbt_decode: Decode device handle as a bitmask
>
>  lib/igt_aux.h            |   1 +
>  tools/intel_vbt_decode.c | 395 ++++++++++++++++++++++-----------------
>  2 files changed, 224 insertions(+), 172 deletions(-)

-- 
Jani Nikula, Intel