Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tests/xe_exec_sip: increase timeout margin for tests
@ 2024-10-11 13:36 Andrzej Hajda
  2024-10-11 15:50 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Andrzej Hajda @ 2024-10-11 13:36 UTC (permalink / raw)
  To: igt-dev; +Cc: Kamil Konieczny, Andrzej Hajda

In case engine reset happens 4s timeout margin sometimes is not enough and test
fails. It happens mostly on LNL due to devcoredump creation.
On CI it does not pass 5s, lets increase it to 8s to be on safe side.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 tests/intel/xe_exec_sip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/intel/xe_exec_sip.c b/tests/intel/xe_exec_sip.c
index 2294468c2983..50265c0c6a45 100644
--- a/tests/intel/xe_exec_sip.c
+++ b/tests/intel/xe_exec_sip.c
@@ -274,8 +274,8 @@ static void test_sip(enum shader_type shader_type, enum sip_type sip_type,
 
 	vm_id = xe_vm_create(fd, 0, 0);
 
-	/* Get timeout for job, and add 4s to ensure timeout processes in subtest. */
-	timeout = xe_sysfs_get_job_timeout_ms(fd, eci) + 4ull * MSEC_PER_SEC;
+	/* Get timeout for job, and add 8s to ensure timeout processes in subtest. */
+	timeout = xe_sysfs_get_job_timeout_ms(fd, eci) + 8ull * MSEC_PER_SEC;
 	timeout *= NSEC_PER_MSEC;
 	timeout *= igt_run_in_simulation() ? 10 : 1;
 

---
base-commit: cc3fa4e36bb0445565f40f989540b9deacb92e12
change-id: 20241011-xe_exec_sip_increase_timeout_margin-a64bcb49752d

Best regards,
-- 
Andrzej Hajda <andrzej.hajda@intel.com>


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] tests/xe_exec_sip: increase timeout margin for tests
@ 2024-12-06  8:17 Andrzej Hajda
  2024-12-06 16:51 ` Kamil Konieczny
  0 siblings, 1 reply; 10+ messages in thread
From: Andrzej Hajda @ 2024-12-06  8:17 UTC (permalink / raw)
  To: igt-dev; +Cc: Kamil Konieczny, Andrzej Hajda

In case engine reset happens 4s timeout margin sometimes is not enough
and test fails. It happens mostly on LNL/BMG due to devcoredump creation.
On CI it does not pass 5s, let's increase it to 8s to be on safe side.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 tests/intel/xe_exec_sip_eudebug.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/intel/xe_exec_sip_eudebug.c b/tests/intel/xe_exec_sip_eudebug.c
index d056a14a2d7f..c317112b4154 100644
--- a/tests/intel/xe_exec_sip_eudebug.c
+++ b/tests/intel/xe_exec_sip_eudebug.c
@@ -263,8 +263,8 @@ static void test_sip(enum shader_type shader_type, enum sip_type sip_type,
 	debugger_enabled = xe_eudebug_debugger_available(fd);
 	vm_id = xe_vm_create(fd, debugger_enabled ? DRM_XE_VM_CREATE_FLAG_LR_MODE : 0, 0);
 
-	/* Get timeout for job, and add 4s to ensure timeout processes in subtest. */
-	timeout = xe_sysfs_get_job_timeout_ms(fd, eci) + 4ull * MSEC_PER_SEC;
+	/* Get timeout for job, and add 8s for devcoredump processing. */
+	timeout = xe_sysfs_get_job_timeout_ms(fd, eci) + 8ull * MSEC_PER_SEC;
 	timeout *= NSEC_PER_MSEC;
 	timeout *= igt_run_in_simulation() ? 10 : 1;
 

---
base-commit: e776f39da6b3666a2834f7e02a1eed9a87f21d74
change-id: 20241206-xe_exec_sip_eudebug_increase_timeout_for_devcoredump-64e46bd9721d

Best regards,
-- 
Andrzej Hajda <andrzej.hajda@intel.com>


^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-12-06 16:51 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-11 13:36 [PATCH] tests/xe_exec_sip: increase timeout margin for tests Andrzej Hajda
2024-10-11 15:50 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-10-11 16:27 ` ✓ CI.xeBAT: " Patchwork
2024-10-11 20:35 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-14  8:35   ` Hajda, Andrzej
2024-10-12  9:45 ` ✗ Fi.CI.IGT: " Patchwork
2024-10-14  8:36   ` Hajda, Andrzej
2024-10-14  9:53 ` [PATCH] " Kamil Konieczny
  -- strict thread matches above, loose matches on Subject: below --
2024-12-06  8:17 Andrzej Hajda
2024-12-06 16:51 ` Kamil Konieczny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox