Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2 0/2] tests/intel/kms_big_fb: Intel display version 20 onwards doesn't do hflip with tile4
@ 2024-11-22  5:33 Pranay Samala
  2024-11-22  5:33 ` [PATCH i-g-t v2 1/2] " Pranay Samala
                   ` (5 more replies)
  0 siblings, 6 replies; 13+ messages in thread
From: Pranay Samala @ 2024-11-22  5:33 UTC (permalink / raw)
  To: igt-dev
  Cc: karthik.b.s, swati2.sharma, jeevan.b, sameer.lattannavar,
	pranay.samala

Intel display version 20 onwards, Tile4 no longer can be used with
horizontal flip.

Bspec: 69853

v2: Fix the shadowing global declaration warn (Jeevan)

Pranay Samala (2):
  tests/intel/kms_big_fb: Intel display version 20 onwards doesn't do
    hflip with tile4
  HAX: Do not merge

 tests/intel-ci/fast-feedback.testlist    |  5 +++++
 tests/intel-ci/xe-fast-feedback.testlist |  5 +++++
 tests/intel/kms_big_fb.c                 | 15 +++++++++++++++
 3 files changed, 25 insertions(+)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH i-g-t v2 1/2] tests/intel/kms_frontbuffer_tracking: Add skip condition for bmg platform
@ 2025-01-09  5:53 Mohammed Thasleem
  2025-01-09  5:53 ` [PATCH i-g-t v2 2/2] HAX: DO NOT MERGE Mohammed Thasleem
  0 siblings, 1 reply; 13+ messages in thread
From: Mohammed Thasleem @ 2025-01-09  5:53 UTC (permalink / raw)
  To: igt-dev; +Cc: Mohammed Thasleem

FBC test isn't supported on bmg, skip the test on this platform.

v2: Add workaround id: Wa_16023588340. (Swati)
v3: Add workaround id in code.

Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
 tests/intel/kms_frontbuffer_tracking.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index e41ee0a80..2d47194dd 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -2756,6 +2756,10 @@ static void prepare_subtest_data(const struct test_mode *t,
 
 static void prepare_subtest_screens(const struct test_mode *t)
 {
+	/* FBC disabled: Wa_16023588340 */
+	igt_skip_on_f((IS_BATTLEMAGE(drm.devid) && t->feature == FEATURE_FBC),
+		      "FBC isn't supported on BMG\n");
+
 	if (t->pipes == PIPE_DUAL)
 		enable_both_screens_and_wait(t);
 	else
@@ -2800,6 +2804,10 @@ static void prepare_subtest(const struct test_mode *t,
  */
 static void rte_subtest(const struct test_mode *t)
 {
+	/* FBC disabled: Wa_16023588340 */
+	igt_skip_on_f((IS_BATTLEMAGE(drm.devid) && t->feature == FEATURE_FBC),
+		      "FBC isn't supported on BMG\n");
+
 	prepare_subtest_data(t, NULL);
 
 	unset_all_crtcs();
@@ -4285,6 +4293,10 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 			t.flip = -1;
 			t.tiling = opt.tiling;
 
+			/* FBC disabled: Wa_16023588340 */
+			igt_skip_on_f((IS_BATTLEMAGE(drm.devid) && t.feature == FEATURE_FBC),
+				      "FBC isn't supported on BMG\n");
+
 			for_each_pipe(&drm.display, pipe) {
 				if (pipe == default_pipe) {
 					igt_info("pipe-%s: FBC validated in other subtest\n", kmstest_pipe_name(pipe));
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH i-g-t v2 1/2] tests/kms_flip: Updating the skip message
@ 2024-11-06 10:00 Pranay Samala
  2024-11-06 10:00 ` [PATCH i-g-t v2 2/2] HAX: Do not merge Pranay Samala
  0 siblings, 1 reply; 13+ messages in thread
From: Pranay Samala @ 2024-11-06 10:00 UTC (permalink / raw)
  To: igt-dev; +Cc: karthik.b.s, ramanaidu.naladala, sameer.lattannavar,
	pranay.samala

Debugging would be easier if we had logs available for
test failures and skips. This patch rephrases the skip
message for better understanding.

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/kms_flip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index cbabbe74f..88cd41083 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1896,7 +1896,7 @@ static void run_pair(int duration, int flags)
 
 	/* If we have fewer than 2 connected outputs then we won't have any
 	 * configuration at all. So skip in that case. */
-	igt_require_f(modes, "At least two displays required\n");
+	igt_require_f(modes, "At least two displays with same modes are required\n");
 
 	if (duration) {
 		duration = duration * 1000 / modes;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH i-g-t v2 1/2] tests/kms_atomic_transition: Use extended flag for local execution
@ 2024-11-06  9:19 Pranay Samala
  2024-11-06  9:19 ` [PATCH i-g-t v2 2/2] HAX: Do not merge Pranay Samala
  0 siblings, 1 reply; 13+ messages in thread
From: Pranay Samala @ 2024-11-06  9:19 UTC (permalink / raw)
  To: igt-dev; +Cc: karthik.b.s, kunal1.joshi, sameer.lattannavar, pranay.samala

There is no need to reduce the debug log level for local executions.
This flag is used to prevent the reduction of the debug log level in
local environments, while it will lower the log level in CI environments.

To avoid reducing the debug log level in local executions, the extended
flag must be explicitly used.

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/kms_atomic_transition.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index f4f8afc66..f11e846d8 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -1189,13 +1189,15 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		for_each_connected_output(&data.display, output)
 			count++;
 
-		dir = igt_sysfs_drm_module_params_open();
-		if (dir >= 0) {
-			current_log_level = igt_drm_debug_level_get(dir);
-			close(dir);
-
-			if (current_log_level > 10)
-				igt_drm_debug_level_update(10);
+		if (!data.extended) {
+			dir = igt_sysfs_drm_module_params_open();
+			if (dir >= 0) {
+				current_log_level = igt_drm_debug_level_get(dir);
+				close(dir);
+
+				if (current_log_level > 10)
+					igt_drm_debug_level_update(10);
+			}
 		}
 	}
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH i-g-t v2 1/2] tests/chamelium/kms_chamelium_edid: Use extended flag to reduce the number of edid
@ 2024-10-18  3:59 Pranay Samala
  2024-10-18  3:59 ` [PATCH i-g-t v2 2/2] HAX: Do not merge Pranay Samala
  0 siblings, 1 reply; 13+ messages in thread
From: Pranay Samala @ 2024-10-18  3:59 UTC (permalink / raw)
  To: igt-dev
  Cc: karthik.b.s, kunal1.joshi, swati2.sharma, sameer.lattannavar,
	pranay.samala

This test iterates on all the available edids of HDMI.
Due to CI test timeut limitation, we are reducing the
number of edids to execute to avoid result as timeout.

Using extended flag to achieve this. The test will execute
only 25 edids when this flag is not used as CI doesnt uses
this flag.
In local execution to execute on all edids, we have to give
this flag at the runtime.

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/chamelium/kms_chamelium_edid.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/tests/chamelium/kms_chamelium_edid.c b/tests/chamelium/kms_chamelium_edid.c
index 8438f5f15..1bdde1768 100644
--- a/tests/chamelium/kms_chamelium_edid.c
+++ b/tests/chamelium/kms_chamelium_edid.c
@@ -122,6 +122,7 @@
  */
 
 #define MODE_CLOCK_ACCURACY 0.05 /* 5% */
+static bool extended;
 
 static void get_connectors_link_status_failed(chamelium_data_t *data,
 					      bool *link_status_failed)
@@ -273,6 +274,9 @@ static void edid_stress_resolution(chamelium_data_t *data,
 			      data->ports, data->port_count);
 
 
+	if (!extended)
+		edids_list_len = 25;
+
 	for (i = 0; i < edids_list_len; ++i) {
 		struct chamelium_edid *chamelium_edid;
 		drmModeModeInfo mode;
@@ -504,8 +508,22 @@ static void test_mode_timings(chamelium_data_t *data,
 	} while (++i < count_modes);
 }
 
+static int opt_handler(int opt, int opt_index, void *_data)
+{
+	switch (opt) {
+	case 'e':
+		extended = true;
+		break;
+	}
+
+	return IGT_OPT_HANDLER_SUCCESS;
+}
+
+const char *help_str =
+	"  -e \tExtended tests.\n";
+
 IGT_TEST_DESCRIPTION("Testing EDID with a Chamelium board");
-igt_main
+igt_main_args("e", NULL, help_str, opt_handler, NULL)
 {
 	chamelium_data_t data;
 	struct chamelium_port *port;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2025-01-09  5:53 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-22  5:33 [PATCH i-g-t v2 0/2] tests/intel/kms_big_fb: Intel display version 20 onwards doesn't do hflip with tile4 Pranay Samala
2024-11-22  5:33 ` [PATCH i-g-t v2 1/2] " Pranay Samala
2024-11-26  4:51   ` B, Jeevan
2024-11-22  5:34 ` [PATCH i-g-t v2 2/2] HAX: Do not merge Pranay Samala
2024-11-22  6:43 ` ✗ Xe.CI.BAT: failure for tests/intel/kms_big_fb: Intel display version 20 onwards doesn't do hflip with tile4 (rev2) Patchwork
2024-11-22  8:01 ` ✓ i915.CI.BAT: success " Patchwork
2024-11-22 22:38 ` ✗ Xe.CI.Full: failure " Patchwork
2024-11-26 23:21   ` Matt Roper
2024-11-24 14:40 ` ✗ i915.CI.Full: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2025-01-09  5:53 [PATCH i-g-t v2 1/2] tests/intel/kms_frontbuffer_tracking: Add skip condition for bmg platform Mohammed Thasleem
2025-01-09  5:53 ` [PATCH i-g-t v2 2/2] HAX: DO NOT MERGE Mohammed Thasleem
2024-11-06 10:00 [PATCH i-g-t v2 1/2] tests/kms_flip: Updating the skip message Pranay Samala
2024-11-06 10:00 ` [PATCH i-g-t v2 2/2] HAX: Do not merge Pranay Samala
2024-11-06  9:19 [PATCH i-g-t v2 1/2] tests/kms_atomic_transition: Use extended flag for local execution Pranay Samala
2024-11-06  9:19 ` [PATCH i-g-t v2 2/2] HAX: Do not merge Pranay Samala
2024-10-18  3:59 [PATCH i-g-t v2 1/2] tests/chamelium/kms_chamelium_edid: Use extended flag to reduce the number of edid Pranay Samala
2024-10-18  3:59 ` [PATCH i-g-t v2 2/2] HAX: Do not merge Pranay Samala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox