Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v10 0/4] test/intel/xe_sysfs: Restore sysfs params correctly
@ 2024-12-04 22:23 Jonathan Cavitt
  2024-12-04 22:23 ` [PATCH v10 1/4] lib/igt_sysfs: Add engine list helpers Jonathan Cavitt
                   ` (6 more replies)
  0 siblings, 7 replies; 14+ messages in thread
From: Jonathan Cavitt @ 2024-12-04 22:23 UTC (permalink / raw)
  To: igt-dev
  Cc: jonathan.cavitt, saurabhg.gupta, alex.zuo, kamil.konieczny,
	vinay.belgaumkar, tejas.upadhyay

The xe_sysfs_timeslice_duration, xe_sysfs_preempt_timeout, and
xe_sysfs_scheduler tests do not correctly restore modified sysfs params on
test failure.
Additionally, xe_sysfs_timeslice_duration modifies but does not restore
preempt_timeout_us.
Finally, while xe_sysfs_scheduler does attempt to restore all modified
sysfs params at the end of the tests, no guarantee is made that the
restorations are successful.
Repair these issues.

v3: Fix several formatting issues (Kamil)

v4: Do not compare possibly unassigned variable (Kamil)
    Whitespace and commit name fixes (Kamil)

v5: Add new helper funciton, igt_sysfs_get_next_engine
    Fix igt_sysfs_scanf/printf usage in tests (Kamil)

v6: Replace helper function igt_sysfs_get_next_engine with new helper
    functions that return and destroy engine lists (Kamil)

v7: Also fix xe_sysfs_scheduler

v8: Update igt_sysfs_get_engine_list to no longer require reporting
    size (Kamil)
    Remove assertion for some sysfs writes to succeed, as we only
    require that the end result is correct.

v9: Store engine lists (Kamil)

v10: Minor formatting fix

Jonathan Cavitt (4):
  lib/igt_sysfs: Add engine list helpers
  tests/intel/xe_sysfs*: Restore values on test failure
  tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout
  tests/intel/xe_sysfs_scheduler: Assert sysfs params are restored

 lib/igt_sysfs.c                           | 61 ++++++++++++++++
 lib/igt_sysfs.h                           |  3 +
 tests/intel/xe_sysfs_preempt_timeout.c    | 65 ++++++++++++++---
 tests/intel/xe_sysfs_scheduler.c          | 89 ++++++++++++++++++++---
 tests/intel/xe_sysfs_timeslice_duration.c | 81 ++++++++++++++++++---
 5 files changed, 269 insertions(+), 30 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2024-12-06 17:14 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-04 22:23 [PATCH v10 0/4] test/intel/xe_sysfs: Restore sysfs params correctly Jonathan Cavitt
2024-12-04 22:23 ` [PATCH v10 1/4] lib/igt_sysfs: Add engine list helpers Jonathan Cavitt
2024-12-04 22:23 ` [PATCH v10 2/4] tests/intel/xe_sysfs*: Restore values on test failure Jonathan Cavitt
2024-12-04 22:23 ` [PATCH v10 3/4] tests/intel/xe_sysfs_timeslice_duration: Restore preempt timeout Jonathan Cavitt
2024-12-05 12:15   ` Upadhyay, Tejas
2024-12-05 15:17     ` Cavitt, Jonathan
2024-12-06  5:46       ` Upadhyay, Tejas
2024-12-04 22:23 ` [PATCH v10 4/4] tests/intel/xe_sysfs_scheduler: Assert sysfs params are restored Jonathan Cavitt
2024-12-05 12:17   ` Upadhyay, Tejas
2024-12-04 23:25 ` ✗ i915.CI.BAT: failure for test/intel/xe_sysfs: Restore sysfs params correctly Patchwork
2024-12-06 17:14   ` Cavitt, Jonathan
2024-12-04 23:30 ` ✓ Xe.CI.BAT: success " Patchwork
2024-12-05  3:34 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-06 17:13   ` Cavitt, Jonathan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox