From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t 5/5] tests/intel/kms_cdclk: Use igt_get_max_cdclk()
Date: Thu, 13 Feb 2025 16:38:14 +0530 [thread overview]
Message-ID: <20250213110814.351186-6-swati2.sharma@intel.com> (raw)
In-Reply-To: <20250213110814.351186-1-swati2.sharma@intel.com>
Replace hardcoded max cdclk freq with one computed from debugfs.
in igt_get_max_cdclk(). Also, add same condition for
all_outputs subtest.
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/intel/kms_cdclk.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/intel/kms_cdclk.c b/tests/intel/kms_cdclk.c
index eeb1ecd69..3596fd30c 100644
--- a/tests/intel/kms_cdclk.c
+++ b/tests/intel/kms_cdclk.c
@@ -53,7 +53,6 @@ IGT_TEST_DESCRIPTION("Test cdclk features : crawling and squashing");
#define HDISPLAY_4K 3840
#define VDISPLAY_4K 2160
#define VREFRESH 60
-#define MAX_CDCLK_4K 307200
/* Test flags */
enum {
@@ -250,7 +249,7 @@ static void test_mode_transition(data_t *data, enum pipe pipe, igt_output_t *out
igt_info("CD clock frequency %d -> %d\n", cdclk_ref, cdclk_new);
/* cdclk should bump */
- if (cdclk_new != MAX_CDCLK_4K)
+ if (cdclk_new != igt_get_max_cdclk(debugfs_fd))
igt_assert_lt(cdclk_ref, cdclk_new);
/* cleanup */
@@ -341,7 +340,8 @@ static void test_mode_transition_on_all_outputs(data_t *data)
igt_info("CD clock frequency %d -> %d\n", cdclk_ref, cdclk_new);
/* cdclk should bump */
- igt_assert_lt(cdclk_ref, cdclk_new);
+ if (cdclk_new != igt_get_max_cdclk(debugfs_fd))
+ igt_assert_lt(cdclk_ref, cdclk_new);
do_cleanup_display(display);
igt_remove_fb(data->drm_fd, &fb);
--
2.25.1
next prev parent reply other threads:[~2025-02-13 11:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 11:08 [PATCH i-g-t 0/5] tests/intel/kms_cdclk: Refactor mode setting and CD clock verification Swati Sharma
2025-02-13 11:08 ` [PATCH i-g-t 1/5] lib/igt_kms: Add highres() and lowres() func Swati Sharma
2025-02-17 8:12 ` Nautiyal, Ankit K
2025-02-13 11:08 ` [PATCH i-g-t 2/5] tests/intel/kms_cdclk: Add conditions to filter valid outputs Swati Sharma
2025-02-17 8:17 ` Nautiyal, Ankit K
2025-02-13 11:08 ` [PATCH i-g-t 3/5] tests/intel/kms_cdclk: Introduce set_mode() Swati Sharma
2025-02-13 11:08 ` [PATCH i-g-t 4/5] lib/igt_kms: Add igt_get_max_cdclk() Swati Sharma
2025-02-17 8:35 ` Nautiyal, Ankit K
2025-02-13 11:08 ` Swati Sharma [this message]
2025-02-17 8:36 ` [PATCH i-g-t 5/5] tests/intel/kms_cdclk: Use igt_get_max_cdclk() Nautiyal, Ankit K
2025-02-13 12:33 ` ✓ Xe.CI.BAT: success for tests/intel/kms_cdclk: Refactor mode setting and CD clock verification (rev3) Patchwork
2025-02-13 12:50 ` ✓ i915.CI.BAT: " Patchwork
2025-02-13 20:09 ` ✗ i915.CI.Full: failure " Patchwork
2025-02-14 4:35 ` ✗ Xe.CI.Full: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-02-17 21:35 [PATCH i-g-t 0/5] tests/intel/kms_cdclk: Refactor mode setting and CD clock verification Swati Sharma
2025-02-17 21:35 ` [PATCH i-g-t 5/5] tests/intel/kms_cdclk: Use igt_get_max_cdclk() Swati Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213110814.351186-6-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox