From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, santhosh.reddy.guddati@intel.com,
swati2.sharma@intel.com, jeevan.b@intel.com,
jani.saarinen@intel.com
Subject: [PATCH i-g-t v1 5/5] lib/i915/fbc: fbc psr combo support update for xe3
Date: Thu, 20 Feb 2025 14:21:31 +0200 [thread overview]
Message-ID: <20250220122131.221907-6-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20250220122131.221907-1-vinod.govindapillai@intel.com>
Because of the FBC dirty rect support in xe3, the FBC and PSR
are not recommended to be enabled together. So if PSR2 selective
fetch is enabled, FBC will not be activated in xe3.
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
lib/i915/intel_fbc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
index 90fe5943c..3971e4920 100644
--- a/lib/i915/intel_fbc.c
+++ b/lib/i915/intel_fbc.c
@@ -167,7 +167,10 @@ bool intel_fbc_plane_size_supported(int fd, uint32_t width, uint32_t height)
*/
bool intel_fbc_psr_combo_supported(int device)
{
- if (intel_display_ver(intel_get_drm_devid(device)) >= 20)
+ int ver = intel_display_ver(intel_get_drm_devid(device));
+
+ /* In Xe3 FBC PSR combo not supported because of FBC dirty rect */
+ if (ver >= 20 && ver < 30)
return true;
return false;
--
2.43.0
next prev parent reply other threads:[~2025-02-20 12:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 12:21 [PATCH i-g-t v1 0/5] updates tp FBC PSR combo checks Vinod Govindapillai
2025-02-20 12:21 ` [PATCH i-g-t v1 1/5] lib/i915/fbc: fbc psr combo support check helper function Vinod Govindapillai
2025-02-25 9:12 ` [i-g-t,v1,1/5] " Joshi, Kunal1
2025-02-20 12:21 ` [PATCH i-g-t v1 2/5] tests/intel/kms_psr: update to FBC support check Vinod Govindapillai
2025-02-25 9:14 ` [i-g-t,v1,2/5] " Joshi, Kunal1
2025-02-20 12:21 ` [PATCH i-g-t v1 3/5] tests/intel/kms_frontbuffer_tracking: " Vinod Govindapillai
2025-02-25 9:15 ` [i-g-t,v1,3/5] " Joshi, Kunal1
2025-02-20 12:21 ` [PATCH i-g-t v1 4/5] tests/intel/kms_psr2_sf: " Vinod Govindapillai
2025-02-25 9:17 ` [i-g-t,v1,4/5] " Joshi, Kunal1
2025-02-20 12:21 ` Vinod Govindapillai [this message]
2025-02-25 9:17 ` [i-g-t, v1, 5/5] lib/i915/fbc: fbc psr combo support update for xe3 Joshi, Kunal1
2025-02-20 17:18 ` ✗ i915.CI.BAT: failure for updates tp FBC PSR combo checks Patchwork
2025-02-20 17:21 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-21 8:53 ` ✓ i915.CI.BAT: " Patchwork
2025-02-21 10:09 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-21 10:38 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220122131.221907-6-vinod.govindapillai@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.saarinen@intel.com \
--cc=jeevan.b@intel.com \
--cc=santhosh.reddy.guddati@intel.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox