Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Joshi, Kunal1" <kunal1.joshi@intel.com>
To: Vinod Govindapillai <vinod.govindapillai@intel.com>,
	igt-dev@lists.freedesktop.org
Cc: santhosh.reddy.guddati@intel.com, swati2.sharma@intel.com,
	jeevan.b@intel.com, jani.saarinen@intel.com
Subject: Re: [i-g-t,v1,2/5] tests/intel/kms_psr: update to FBC support check
Date: Tue, 25 Feb 2025 14:44:09 +0530	[thread overview]
Message-ID: <80e14d54-2256-443b-8968-ef51f32e981f@intel.com> (raw)
In-Reply-To: <20250220122131.221907-3-vinod.govindapillai@intel.com>


On 20-02-2025 17:51, Vinod Govindapillai wrote:
> Utilize the library function to check if the FBC PSR combination
> is supported in a platform and re-roder the condition check.
>
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
>   tests/intel/kms_psr.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tests/intel/kms_psr.c b/tests/intel/kms_psr.c
> index ad49c18f0..124d7be18 100644
> --- a/tests/intel/kms_psr.c
> +++ b/tests/intel/kms_psr.c
> @@ -823,10 +823,9 @@ igt_main
>   		data.bops = buf_ops_create(data.drm_fd);
>   		igt_display_require(&data.display, data.drm_fd);
>   		igt_require_f(output_supports_psr(&data), "Sink does not support PSR/PSR2/PR\n");
> -		if ((intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 20) &&
> -		    (intel_fbc_supported_on_chipset(data.drm_fd, pipe))) {
> +		if (intel_fbc_supported_on_chipset(data.drm_fd, pipe) &&
> +		    intel_fbc_psr_combo_supported(data.drm_fd))
>   			data.fbc_flag = true;
> -		}
>   	}
>   
>   	for (y = 0; y < ARRAY_SIZE(fbc_status); y++) {

  reply	other threads:[~2025-02-25  9:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20 12:21 [PATCH i-g-t v1 0/5] updates tp FBC PSR combo checks Vinod Govindapillai
2025-02-20 12:21 ` [PATCH i-g-t v1 1/5] lib/i915/fbc: fbc psr combo support check helper function Vinod Govindapillai
2025-02-25  9:12   ` [i-g-t,v1,1/5] " Joshi, Kunal1
2025-02-20 12:21 ` [PATCH i-g-t v1 2/5] tests/intel/kms_psr: update to FBC support check Vinod Govindapillai
2025-02-25  9:14   ` Joshi, Kunal1 [this message]
2025-02-20 12:21 ` [PATCH i-g-t v1 3/5] tests/intel/kms_frontbuffer_tracking: " Vinod Govindapillai
2025-02-25  9:15   ` [i-g-t,v1,3/5] " Joshi, Kunal1
2025-02-20 12:21 ` [PATCH i-g-t v1 4/5] tests/intel/kms_psr2_sf: " Vinod Govindapillai
2025-02-25  9:17   ` [i-g-t,v1,4/5] " Joshi, Kunal1
2025-02-20 12:21 ` [PATCH i-g-t v1 5/5] lib/i915/fbc: fbc psr combo support update for xe3 Vinod Govindapillai
2025-02-25  9:17   ` [i-g-t, v1, " Joshi, Kunal1
2025-02-20 17:18 ` ✗ i915.CI.BAT: failure for updates tp FBC PSR combo checks Patchwork
2025-02-20 17:21 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-21  8:53 ` ✓ i915.CI.BAT: " Patchwork
2025-02-21 10:09 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-21 10:38 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80e14d54-2256-443b-8968-ef51f32e981f@intel.com \
    --to=kunal1.joshi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.saarinen@intel.com \
    --cc=jeevan.b@intel.com \
    --cc=santhosh.reddy.guddati@intel.com \
    --cc=swati2.sharma@intel.com \
    --cc=vinod.govindapillai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox