From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t] tests/kms_flip: Add flip-vs-dpms-on-nop subtest
Date: Fri, 28 Feb 2025 21:42:40 +0200 [thread overview]
Message-ID: <20250228194240.20023-1-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Verify that redundant DPMS ON requests don't result in
actual commits (and thus frame drops). This behaviour
is guaranteed by the kernel for atomic drivers.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_flip.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 3ad4d0afb1f6..59740aca25bd 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -176,6 +176,7 @@
* @single-buffer-flip-vs-dpms-off-vs-modeset: pageflip of same buffer along with
* the modeset and dpms off
* @dpms-vs-vblank-race: vblank along with the dpms & modeset
+ * @flip-vs-dpms-on-nop: pageflip and issue nop DPMS ON
*/
/**
@@ -240,6 +241,7 @@
*/
#define TEST_DPMS (1 << 0)
+#define TEST_DPMS_ON_NOP (1 << 1)
#define TEST_PAN (1 << 3)
#define TEST_MODESET (1 << 4)
@@ -957,7 +959,7 @@ static bool run_test_step(struct test_output *o, unsigned int *events)
if (o->flags & TEST_MODESET)
igt_assert(set_mode(o, o->fb_ids[o->current_fb_id], 0, 0) == 0);
- if (o->flags & TEST_DPMS)
+ if (o->flags & (TEST_DPMS | TEST_DPMS_ON_NOP))
set_dpms(o, DRM_MODE_DPMS_ON);
if (o->flags & TEST_VBLANK_RACE) {
@@ -2020,6 +2022,7 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
"plain-flip-fb-recreate" },
{ 30, TEST_FLIP | TEST_RMFB | TEST_MODESET , "flip-vs-rmfb" },
{ 2, TEST_FLIP | TEST_DPMS | TEST_EINVAL | TEST_BASIC, "flip-vs-dpms" },
+ { 2, TEST_FLIP | TEST_DPMS_ON_NOP | TEST_CHECK_TS, "flip-vs-dpms-on-nop" },
{ 30, TEST_FLIP | TEST_PAN, "flip-vs-panning" },
{ 2, TEST_FLIP | TEST_MODESET | TEST_EINVAL | TEST_BASIC, "flip-vs-modeset" },
{ 30, TEST_FLIP | TEST_VBLANK_EXPIRED_SEQ,
--
2.45.3
next reply other threads:[~2025-02-28 19:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 19:42 Ville Syrjala [this message]
2025-03-01 0:14 ` ✓ Xe.CI.BAT: success for tests/kms_flip: Add flip-vs-dpms-on-nop subtest Patchwork
2025-03-01 0:29 ` ✓ i915.CI.BAT: " Patchwork
2025-03-01 9:42 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-01 13:45 ` ✗ i915.CI.Full: " Patchwork
2025-04-01 8:14 ` [PATCH i-g-t] " Sharma, Swati2
2025-04-01 16:24 ` Ville Syrjälä
2025-04-02 10:26 ` Sharma, Swati2
2025-04-07 7:36 ` Sharma, Swati2
2025-04-01 18:52 ` ✓ Xe.CI.BAT: success for tests/kms_flip: Add flip-vs-dpms-on-nop subtest (rev2) Patchwork
2025-04-01 19:08 ` ✓ i915.CI.BAT: " Patchwork
2025-04-01 22:06 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-01 22:19 ` ✗ i915.CI.Full: " Patchwork
2025-04-02 19:50 ` ✓ i915.CI.BAT: success for tests/kms_flip: Add flip-vs-dpms-on-nop subtest (rev3) Patchwork
2025-04-02 20:02 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-02 21:58 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-02 22:29 ` ✗ Xe.CI.Full: " Patchwork
2025-04-06 23:20 ` ✗ Xe.CI.Full: failure for tests/kms_flip: Add flip-vs-dpms-on-nop subtest (rev2) Patchwork
2025-04-07 0:36 ` ✗ Xe.CI.Full: failure for tests/kms_flip: Add flip-vs-dpms-on-nop subtest (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228194240.20023-1-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox