Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <andrzej.hajda@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>
Subject: [PATCH 1/4] lib/iga64: fix send macro for DG2 platforms
Date: Fri, 14 Mar 2025 15:59:08 +0100	[thread overview]
Message-ID: <20250314-iga64_misc-v1-1-b2d1337b808d@intel.com> (raw)
In-Reply-To: <20250314-iga64_misc-v1-0-b2d1337b808d@intel.com>

src1 argument should be in form of null:0 for some platforms,
use special macro src1_null for it.

iga64 -Xauto-deps -Wall -p=12p71 lib/iga64_generated_codes.c.d/iga64_assembly_media_block_write_aip.12p71.asm
line 3.31: warning: Src1.Length should suffix src1 register (e.g. r10:4)
(W) send.dc1 (1) null r4 null 0x0 0x40A8000

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 lib/iga64_generated_codes.c | 2 +-
 lib/iga64_macros.h          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/iga64_generated_codes.c b/lib/iga64_generated_codes.c
index a74a8864e5ca..551dead2be17 100644
--- a/lib/iga64_generated_codes.c
+++ b/lib/iga64_generated_codes.c
@@ -3,7 +3,7 @@
 
 #include "gpgpu_shader.h"
 
-#define MD5_SUM_IGA64_ASMS 80bb609ce27131259d19629dc74e349f
+#define MD5_SUM_IGA64_ASMS 22a5a4671242c3257209f4051f1c0c7e
 
 struct iga64_template const iga64_code_gpgpu_fill[] = {
 	{ .gen_ver = 2000, .size = 44, .code = (const uint32_t []) {
diff --git a/lib/iga64_macros.h b/lib/iga64_macros.h
index ac482e47c05e..8e452cf634f9 100644
--- a/lib/iga64_macros.h
+++ b/lib/iga64_macros.h
@@ -70,7 +70,7 @@
 #define SET_SHARED_SPACE_ADDR(dst, y, width) SET_SHARED_MEDIA_BLOCK_MSG_HDR(dst, y, width)
 #define SET_THREAD_SPACE_ADDR(dst, x, y, width) SET_THREAD_MEDIA_BLOCK_MSG_HDR(dst, x, y, width)
 #define LOAD_SPACE_DW(dst, src) send.dc1 (1)	dst	src	src1_null 0x0	0x2190000
-#define STORE_SPACE_DW(dst, src) send.dc1 (1)	null	dst	null	0x0	0x40A8000
+#define STORE_SPACE_DW(dst, src) send.dc1 (1)	null	dst	src1_null 0x0	0x40A8000
 #else
 #define SET_SHARED_SPACE_ADDR(dst, y, width) SET_SHARED_MEDIA_A2DBLOCK_PAYLOAD(dst, y, width)
 #define SET_THREAD_SPACE_ADDR(dst, x, y, width) SET_THREAD_MEDIA_A2DBLOCK_PAYLOAD(dst, x, y, width)

-- 
2.34.1


  reply	other threads:[~2025-03-14 14:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 14:59 [PATCH 0/4] lib/iga64: miscelanious improvements Andrzej Hajda
2025-03-14 14:59 ` Andrzej Hajda [this message]
2025-03-21 12:58   ` [PATCH 1/4] lib/iga64: fix send macro for DG2 platforms Zbigniew Kempczyński
2025-03-24 13:32     ` Kamil Konieczny
2025-03-14 14:59 ` [PATCH 2/4] scripts/generate_iga64_codes: make script less chatty Andrzej Hajda
2025-03-20 17:00   ` Kamil Konieczny
2025-03-14 14:59 ` [PATCH 3/4] scripts/generate_iga64_codes: fix handling empty asms Andrzej Hajda
2025-03-20 17:01   ` Kamil Konieczny
2025-03-14 14:59 ` [PATCH 4/4] scripts/generate_iga64_codes: remove parenthesis around ARG macro body Andrzej Hajda
2025-03-20 17:02   ` Kamil Konieczny
2025-03-15  2:23 ` ✓ Xe.CI.BAT: success for lib/iga64: miscelanious improvements Patchwork
2025-03-15  2:40 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-24 13:33   ` Kamil Konieczny
2025-03-15 12:07 ` ✗ Xe.CI.Full: " Patchwork
2025-03-24 13:35   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250314-iga64_misc-v1-1-b2d1337b808d@intel.com \
    --to=andrzej.hajda@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox