Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <andrzej.hajda@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>
Subject: [PATCH 3/4] scripts/generate_iga64_codes: fix handling empty asms
Date: Fri, 14 Mar 2025 15:59:10 +0100	[thread overview]
Message-ID: <20250314-iga64_misc-v1-3-b2d1337b808d@intel.com> (raw)
In-Reply-To: <20250314-iga64_misc-v1-0-b2d1337b808d@intel.com>

Script incorrectly handled empty asms in case of the newest
platforms.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 scripts/generate_iga64_codes | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/generate_iga64_codes b/scripts/generate_iga64_codes
index 16bdc6fd6d0f..bfef0e5c2853 100755
--- a/scripts/generate_iga64_codes
+++ b/scripts/generate_iga64_codes
@@ -104,7 +104,7 @@ for asm in "${ASMS[@]}"; do
     asm_name="${asm%%:*}"
     asm_code="${asm_name/assembly/code}"
     asm_body="${asm#*:}"
-    cur_code=""
+    cur_code="NONE"
     cur_ver=""
     echo -e "\nstruct iga64_template const $asm_code[] = {" >>$OUTPUT
     for gen in $GEN_VERSIONS; do
@@ -117,7 +117,7 @@ for asm in "${ASMS[@]}"; do
         done
         SHOW_CMD=1 compile_iga64 > "$WD/$asm_name.$gen_name.bin" || die "Cannot write to $WD/$asm_name.$gen_name.bin"
         code="$(hexdump -v -e '"\t\t" 4/4 "0x%08x, " "\n"' $WD/$asm_name.$gen_name.bin)"
-        [ -z "$cur_code" ] && cur_code="$code"
+        [ "$cur_code" = "NONE" ] && cur_code="$code"
         [ "$cur_code" != "$code" ] && {
             echo -e "\t{ .gen_ver = $cur_ver, .size = $(dword_count "$cur_code"), .code = (const uint32_t []) {\n$cur_code\n\t}}," >>$OUTPUT
             cur_code="$code"

-- 
2.34.1


  parent reply	other threads:[~2025-03-14 14:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 14:59 [PATCH 0/4] lib/iga64: miscelanious improvements Andrzej Hajda
2025-03-14 14:59 ` [PATCH 1/4] lib/iga64: fix send macro for DG2 platforms Andrzej Hajda
2025-03-21 12:58   ` Zbigniew Kempczyński
2025-03-24 13:32     ` Kamil Konieczny
2025-03-14 14:59 ` [PATCH 2/4] scripts/generate_iga64_codes: make script less chatty Andrzej Hajda
2025-03-20 17:00   ` Kamil Konieczny
2025-03-14 14:59 ` Andrzej Hajda [this message]
2025-03-20 17:01   ` [PATCH 3/4] scripts/generate_iga64_codes: fix handling empty asms Kamil Konieczny
2025-03-14 14:59 ` [PATCH 4/4] scripts/generate_iga64_codes: remove parenthesis around ARG macro body Andrzej Hajda
2025-03-20 17:02   ` Kamil Konieczny
2025-03-15  2:23 ` ✓ Xe.CI.BAT: success for lib/iga64: miscelanious improvements Patchwork
2025-03-15  2:40 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-24 13:33   ` Kamil Konieczny
2025-03-15 12:07 ` ✗ Xe.CI.Full: " Patchwork
2025-03-24 13:35   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250314-iga64_misc-v1-3-b2d1337b808d@intel.com \
    --to=andrzej.hajda@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox