From: Andrzej Hajda <andrzej.hajda@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
"Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>
Subject: [PATCH 2/4] scripts/generate_iga64_codes: make script less chatty
Date: Fri, 14 Mar 2025 15:59:09 +0100 [thread overview]
Message-ID: <20250314-iga64_misc-v1-2-b2d1337b808d@intel.com> (raw)
In-Reply-To: <20250314-iga64_misc-v1-0-b2d1337b808d@intel.com>
Script generated three redundant lines per compilation.
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
scripts/generate_iga64_codes | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/scripts/generate_iga64_codes b/scripts/generate_iga64_codes
index 3f207e9ff1a8..16bdc6fd6d0f 100755
--- a/scripts/generate_iga64_codes
+++ b/scripts/generate_iga64_codes
@@ -96,7 +96,7 @@ compile_iga64() {
eval "$cmd" <<<"$asm_body" || die "cpp error for $asm_name.$gen_name\ncmd: $cmd"
cmd="iga64 -Xauto-deps -Wall -p=$gen_name"
cmd+=" $WD/$asm_name.$gen_name.asm"
- warn "$cmd"
+ [ -n "$SHOW_CMD" ] && warn "$cmd"
eval "$cmd" || die "iga64 error for $asm_name.$gen_name\ncmd: $cmd"
}
@@ -110,13 +110,12 @@ for asm in "${ASMS[@]}"; do
for gen in $GEN_VERSIONS; do
gen_ver="${gen%%:*}"
gen_name="${gen#*:}"
- warn "Generating $asm_code for platform $gen_name"
# Verify generated code will not contain IGA64_ARGs.
for d in $(IGA64_ARG0=0 compile_iga64 | hexdump -v -e '1/4 "0x%08x\n"'); do
(( (d & IGA64_ARG_MASK) == IGA64_ARG0 )) || continue
die "Assembly for $asm_name.$gen_name contains instruction which compiles to $d, conflicts with IGA64_ARG0/mask $IGA64_ARG0/$IGA64_ARG_MASK\ncmd: $cmd"
done
- compile_iga64 > "$WD/$asm_name.$gen_name.bin" || die "Cannot write to $WD/$asm_name.$gen_name.bin"
+ SHOW_CMD=1 compile_iga64 > "$WD/$asm_name.$gen_name.bin" || die "Cannot write to $WD/$asm_name.$gen_name.bin"
code="$(hexdump -v -e '"\t\t" 4/4 "0x%08x, " "\n"' $WD/$asm_name.$gen_name.bin)"
[ -z "$cur_code" ] && cur_code="$code"
[ "$cur_code" != "$code" ] && {
--
2.34.1
next prev parent reply other threads:[~2025-03-14 14:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 14:59 [PATCH 0/4] lib/iga64: miscelanious improvements Andrzej Hajda
2025-03-14 14:59 ` [PATCH 1/4] lib/iga64: fix send macro for DG2 platforms Andrzej Hajda
2025-03-21 12:58 ` Zbigniew Kempczyński
2025-03-24 13:32 ` Kamil Konieczny
2025-03-14 14:59 ` Andrzej Hajda [this message]
2025-03-20 17:00 ` [PATCH 2/4] scripts/generate_iga64_codes: make script less chatty Kamil Konieczny
2025-03-14 14:59 ` [PATCH 3/4] scripts/generate_iga64_codes: fix handling empty asms Andrzej Hajda
2025-03-20 17:01 ` Kamil Konieczny
2025-03-14 14:59 ` [PATCH 4/4] scripts/generate_iga64_codes: remove parenthesis around ARG macro body Andrzej Hajda
2025-03-20 17:02 ` Kamil Konieczny
2025-03-15 2:23 ` ✓ Xe.CI.BAT: success for lib/iga64: miscelanious improvements Patchwork
2025-03-15 2:40 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-24 13:33 ` Kamil Konieczny
2025-03-15 12:07 ` ✗ Xe.CI.Full: " Patchwork
2025-03-24 13:35 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314-iga64_misc-v1-2-b2d1337b808d@intel.com \
--to=andrzej.hajda@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox