From: Sunil Khatri <sunil.khatri@amd.com>
To: igt-dev@lists.freedesktop.org
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Vitaly Prosyak" <vitaly.prosyak@amd.com>,
"Sunil Khatri" <sunil.khatri@amd.com>
Subject: [PATCH v3 17/19] lib/amdgpu: make the local functions as static
Date: Fri, 28 Mar 2025 13:54:14 +0530 [thread overview]
Message-ID: <20250328082416.1469810-17-sunil.khatri@amd.com> (raw)
In-Reply-To: <20250328082416.1469810-1-sunil.khatri@amd.com>
functions like amdgpu_alloc_doorbell and
amdgpu_bo_unmap_and_free_uq are internal function
only hence making then static and removing from
amd_user_queue.h
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
---
lib/amdgpu/amd_user_queue.c | 15 +++++++++------
lib/amdgpu/amd_user_queue.h | 8 --------
2 files changed, 9 insertions(+), 14 deletions(-)
diff --git a/lib/amdgpu/amd_user_queue.c b/lib/amdgpu/amd_user_queue.c
index 0235b07ac..5812a1be3 100644
--- a/lib/amdgpu/amd_user_queue.c
+++ b/lib/amdgpu/amd_user_queue.c
@@ -8,8 +8,9 @@
#include "amd_PM4.h"
#include "ioctl_wrappers.h"
-void amdgpu_alloc_doorbell(amdgpu_device_handle device_handle, struct amdgpu_userq_bo *doorbell_bo,
- unsigned int size, unsigned int domain)
+static void amdgpu_alloc_doorbell(amdgpu_device_handle device_handle,
+ struct amdgpu_userq_bo *doorbell_bo,
+ unsigned int size, unsigned int domain)
{
struct amdgpu_bo_alloc_request req = {0};
amdgpu_bo_handle buf_handle;
@@ -88,10 +89,12 @@ error_va_alloc:
return r;
}
-void amdgpu_bo_unmap_and_free_uq(amdgpu_device_handle device_handle, amdgpu_bo_handle bo,
- amdgpu_va_handle va_handle, uint64_t mc_addr, uint64_t size,
- uint32_t timeline_syncobj_handle, uint64_t point,
- uint64_t syncobj_handles_array, uint32_t num_syncobj_handles)
+static void amdgpu_bo_unmap_and_free_uq(amdgpu_device_handle device_handle,
+ amdgpu_bo_handle bo, amdgpu_va_handle va_handle,
+ uint64_t mc_addr, uint64_t size,
+ uint32_t timeline_syncobj_handle,
+ uint64_t point, uint64_t syncobj_handles_array,
+ uint32_t num_syncobj_handles)
{
amdgpu_bo_cpu_unmap(bo);
amdgpu_bo_va_op_raw2(device_handle, bo, 0, size, mc_addr, 0, AMDGPU_VA_OP_UNMAP,
diff --git a/lib/amdgpu/amd_user_queue.h b/lib/amdgpu/amd_user_queue.h
index 539a78819..b29e97ccf 100644
--- a/lib/amdgpu/amd_user_queue.h
+++ b/lib/amdgpu/amd_user_queue.h
@@ -34,20 +34,12 @@
#define amdgpu_pkt_end() \
*ring_context->wptr_cpu += __num_dw_written
-void amdgpu_alloc_doorbell(amdgpu_device_handle device_handle, struct amdgpu_userq_bo *doorbell_bo,
- unsigned int size, unsigned int domain);
-
int amdgpu_bo_alloc_and_map_uq(amdgpu_device_handle device_handle, unsigned int size,
unsigned int alignment, unsigned int heap, uint64_t alloc_flags,
uint64_t mapping_flags, amdgpu_bo_handle *bo, void **cpu,
uint64_t *mc_address, amdgpu_va_handle *va_handle,
uint32_t timeline_syncobj_handle, uint64_t point);
-void amdgpu_bo_unmap_and_free_uq(amdgpu_device_handle device_handle, amdgpu_bo_handle bo,
- amdgpu_va_handle va_handle, uint64_t mc_addr, uint64_t size,
- uint32_t timeline_syncobj_handle, uint64_t point,
- uint64_t syncobj_handles_array, uint32_t num_syncobj_handles);
-
int amdgpu_timeline_syncobj_wait(amdgpu_device_handle device_handle,
uint32_t timeline_syncobj_handle, uint64_t point);
--
2.43.0
next prev parent reply other threads:[~2025-03-28 8:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 8:23 [PATCH v3 01/19] drm-uapi/amdgpu: sync with drm-next Sunil Khatri
2025-03-28 8:23 ` [PATCH v3 02/19] " Sunil Khatri
2025-03-31 19:11 ` vitaly prosyak
2025-04-01 4:39 ` Khatri, Sunil
2025-04-01 4:50 ` vitaly prosyak
2025-04-01 5:46 ` Khatri, Sunil
2025-04-01 16:09 ` Kamil Konieczny
2025-03-28 8:24 ` [PATCH v3 03/19] lib/amdgpu: Add user mode queue support in ring context Sunil Khatri
2025-03-28 8:24 ` [PATCH v3 04/19] lib/amdgpu: Add support of amd user queues Sunil Khatri
2025-04-01 4:21 ` vitaly prosyak
2025-04-01 4:41 ` Khatri, Sunil
2025-03-28 8:24 ` [PATCH v3 05/19] lib/amdgpu: add func amdgpu_bo_alloc_and_map_sync Sunil Khatri
2025-03-28 8:24 ` [PATCH v3 06/19] tests/amdgpu: Add user queue support for gfx and compute Sunil Khatri
2025-03-28 8:24 ` [PATCH v3 07/19] tests/amdgpu: Add UMQ submission tests " Sunil Khatri
2025-03-28 8:24 ` [PATCH v3 08/19] tests/amdgpu: Add amdgpu_sync_dependency_test with UMQ Sunil Khatri
2025-03-28 8:24 ` [PATCH v3 09/19] tests/amdgpu: use memory API's from amd_memory.h Sunil Khatri
2025-03-28 8:24 ` [PATCH v3 10/19] lib/amdgpu: add macro for adding cmds in user queue Sunil Khatri
2025-03-28 8:24 ` [PATCH v3 11/19] lib/amdgpu: use macro to add cmds in the user ring Sunil Khatri
2025-03-28 8:24 ` [PATCH v3 12/19] tests/amdgpu: Add amdgpu_cp_nops tests for UMQ Sunil Khatri
2025-03-28 8:24 ` [PATCH v3 13/19] drm-uapi/amdgpu: sync with drm-next Sunil Khatri
2025-04-01 16:06 ` Kamil Konieczny
2025-04-01 23:52 ` vitaly prosyak
2025-04-02 10:51 ` Kamil Konieczny
2025-04-01 23:57 ` vitaly prosyak
2025-03-28 8:24 ` [PATCH v3 14/19] lib/amdgpu: use right API to get the correct size Sunil Khatri
2025-03-28 8:24 ` [PATCH v3 15/19] lib/amdgpu: use a memory fence to serialize write Sunil Khatri
2025-03-28 8:24 ` [PATCH v3 16/19] tests/amdgpu: disable check for IP presense with no kernel queue Sunil Khatri
2025-03-28 8:24 ` Sunil Khatri [this message]
2025-03-28 8:24 ` [PATCH v3 18/19] lib/amdgpu: enable UMQ function under macro Sunil Khatri
2025-03-28 8:24 ` [PATCH v3 19/19] tests/amdgpu: Disable the UMQ tests under a macro Sunil Khatri
2025-03-28 13:01 ` ✓ Xe.CI.BAT: success for series starting with [v3,01/19] drm-uapi/amdgpu: sync with drm-next Patchwork
2025-03-28 13:12 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-29 0:43 ` ✗ Xe.CI.Full: " Patchwork
2025-04-01 23:46 ` [PATCH v3 01/19] " vitaly prosyak
2025-04-06 18:47 ` ✗ Xe.CI.Full: failure for series starting with [v3,01/19] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328082416.1469810-17-sunil.khatri@amd.com \
--to=sunil.khatri@amd.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=vitaly.prosyak@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox