Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6
@ 2025-02-17 17:08 Mohammed Thasleem
  2025-02-17 19:43 ` ✗ GitLab.Pipeline: warning for " Patchwork
                   ` (31 more replies)
  0 siblings, 32 replies; 37+ messages in thread
From: Mohammed Thasleem @ 2025-02-17 17:08 UTC (permalink / raw)
  To: igt-dev; +Cc: Mohammed Thasleem

DC6 counter was removed MTL onwards, so pkc10 counter is used
to validated DC6 tests but with the new approach of kmd changes
created DC6 debugfs entry counter to validated DC6 tests and
removeing the existing pkc10 code.

Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
 tests/intel/kms_pm_dc.c | 77 +++++++++--------------------------------
 1 file changed, 17 insertions(+), 60 deletions(-)

diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
index 9551cc6b9..1e87a4b7a 100644
--- a/tests/intel/kms_pm_dc.c
+++ b/tests/intel/kms_pm_dc.c
@@ -271,6 +271,7 @@ static uint32_t read_dc_counter(uint32_t debugfs_fd, int dc_flag)
 {
 	char buf[4096];
 	char *str;
+	data_t data = {};
 
 	igt_debugfs_simple_read(debugfs_fd, "i915_dmc_info", buf, sizeof(buf));
 
@@ -278,8 +279,13 @@ static uint32_t read_dc_counter(uint32_t debugfs_fd, int dc_flag)
 		str = strstr(buf, "DC3 -> DC5 count");
 		igt_assert_f(str, "DC5 counter is not available\n");
 	} else if (dc_flag & CHECK_DC6) {
-		str = strstr(buf, "DC5 -> DC6 count");
-		igt_assert_f(str, "DC6 counter is not available\n");
+		if (intel_display_ver(data.devid) >= 14) {
+			str = strstr(buf, "DC6 Residency Counter");
+			igt_assert_f(str, "DC6 Residency Counter is not available\n");
+		} else {
+			str = strstr(buf, "DC5 -> DC6 count");
+			igt_assert_f(str, "DC6 counter is not available\n");
+		}
 	} else if (dc_flag & CHECK_DC3CO) {
 		str = strstr(buf, "DC3CO count");
 		igt_assert_f(str, "DC3CO counter is not available\n");
@@ -371,6 +377,7 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data)
 static void require_dc_counter(int debugfs_fd, int dc_flag)
 {
 	char buf[4096];
+	data_t data = {};
 
 	igt_debugfs_simple_read(debugfs_fd, "i915_dmc_info",
 				buf, sizeof(buf));
@@ -385,8 +392,12 @@ static void require_dc_counter(int debugfs_fd, int dc_flag)
 			      "DC5 counter is not available\n");
 		break;
 	case CHECK_DC6:
-		igt_skip_on_f(!strstr(buf, "DC5 -> DC6 count"),
-			      "DC6 counter is not available\n");
+		if (intel_display_ver(data.devid) >= 14)
+			igt_skip_on_f(!strstr(buf, "DC6 Residency Counter"),
+				      "DC6 Residency Counter is not available\n");
+		else
+			igt_skip_on_f(!strstr(buf, "DC5 -> DC6 count"),
+				      "DC6 counter is not available\n");
 		break;
 	default:
 		igt_assert_f(0, "Unknown DC counter %d\n", dc_flag);
@@ -411,20 +422,6 @@ static void test_dc3co_vpb_simulation(data_t *data)
 	cleanup_dc3co_fbs(data);
 }
 
-static void psr_dpms(data_t *data, int mode)
-{
-	igt_output_t *output;
-
-	for_each_connected_output(&data->display, output) {
-		drmModeConnectorPtr connector = output->config.connector;
-
-		if (connector->connector_type == DRM_MODE_CONNECTOR_eDP)
-			continue;
-
-		kmstest_set_connector_dpms(data->drm_fd, connector, mode);
-	}
-}
-
 static void test_dc5_retention_flops(data_t *data, int dc_flag)
 {
 	uint32_t dc_counter_before_psr;
@@ -707,40 +704,6 @@ static void test_deep_pkgc_state(data_t *data)
 	igt_assert_f(pkgc_flag, "PKGC10 is not achieved.\n");
 }
 
-static void test_pkgc_state_dpms(data_t *data)
-{
-	unsigned int timeout_sec = 6;
-	unsigned int prev_value = 0, cur_value = 0;
-
-	prev_value = read_pkgc_counter(data->debugfs_root_fd);
-	setup_dc_dpms(data);
-	dpms_off(data);
-	igt_wait((cur_value = read_pkgc_counter(data->debugfs_root_fd)) > prev_value,
-		  timeout_sec * 1000, 100);
-	igt_assert_f(cur_value > prev_value, "PKGC10 is not achieved.\n");
-	dpms_on(data);
-	cleanup_dc_dpms(data);
-}
-
-static void test_pkgc_state_psr(data_t *data)
-{
-	unsigned int timeout_sec = 6;
-	unsigned int prev_value = 0, cur_value = 0;
-
-	prev_value = read_pkgc_counter(data->debugfs_root_fd);
-	setup_output(data);
-	setup_primary(data);
-	igt_require(!psr_disabled_check(data->debugfs_fd));
-	igt_assert(psr_wait_entry(data->debugfs_fd, data->op_psr_mode, NULL));
-	psr_dpms(data, DRM_MODE_DPMS_OFF);
-	igt_wait((cur_value = read_pkgc_counter(data->debugfs_root_fd)) > prev_value,
-		  timeout_sec * 1000, 100);
-	igt_assert_f(cur_value > prev_value, "PKGC10 is not achieved.\n");
-	psr_sink_error_check(data->debugfs_fd, data->op_psr_mode, data->output);
-	psr_dpms(data, DRM_MODE_DPMS_ON);
-	cleanup_dc_psr(data);
-}
-
 static void kms_poll_state_restore(int sig)
 {
 	int sysfs_fd;
@@ -804,10 +767,7 @@ igt_main
 		psr_enable(data.drm_fd, data.debugfs_fd, data.op_psr_mode, NULL);
 		igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
 			      "PC8+ residencies not supported\n");
-		if (intel_display_ver(data.devid) >= 14)
-			test_pkgc_state_psr(&data);
-		else
-			test_dc_state_psr(&data, CHECK_DC6);
+		test_dc_state_psr(&data, CHECK_DC6);
 	}
 
 	igt_describe("This test validates display engine entry to PKGC10 state "
@@ -852,10 +812,7 @@ igt_main
 	igt_subtest("dc6-dpms") {
 		igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
 			      "PC8+ residencies not supported\n");
-		if (intel_display_ver(data.devid) >= 14)
-			test_pkgc_state_dpms(&data);
-		else
-			test_dc_state_dpms(&data, CHECK_DC6);
+		test_dc_state_dpms(&data, CHECK_DC6);
 
 	}
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 37+ messages in thread
end of thread, other threads:[~2025-04-11 12:11 UTC | newest]

Thread overview: 37+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-17 17:08 [PATCH i-g-t] tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6 Mohammed Thasleem
2025-02-17 19:43 ` ✗ GitLab.Pipeline: warning for " Patchwork
2025-02-17 19:56 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-17 20:13 ` ✓ i915.CI.BAT: " Patchwork
2025-02-18  0:54 ` ✗ i915.CI.Full: failure " Patchwork
2025-02-18 12:14 ` ✗ Xe.CI.Full: " Patchwork
2025-03-12 21:04 ` [PATCH i-g-t v2] " Mohammed Thasleem
2025-03-25 16:26   ` Imre Deak
2025-03-13  3:59 ` ✓ Xe.CI.BAT: success for tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6 (rev2) Patchwork
2025-03-13  4:22 ` ✗ i915.CI.BAT: failure " Patchwork
2025-03-14 11:50 ` ✗ Xe.CI.Full: " Patchwork
2025-03-30 10:28 ` [PATCH i-g-t v3] tests/intel/kms_pm_dc: Remove PKGC10 dependency to validate DC6 Mohammed Thasleem
2025-03-30 10:45 ` Mohammed Thasleem
2025-03-31 10:13   ` Imre Deak
2025-03-30 11:26 ` ✓ i915.CI.BAT: success for tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6 (rev3) Patchwork
2025-03-30 11:33 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-30 11:49 ` ✓ Xe.CI.BAT: success for tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6 (rev4) Patchwork
2025-03-30 12:00 ` ✓ i915.CI.BAT: " Patchwork
2025-03-30 12:44 ` ✓ Xe.CI.Full: success for tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6 (rev3) Patchwork
2025-03-30 13:02 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-30 13:24 ` ✓ Xe.CI.Full: success for tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6 (rev4) Patchwork
2025-03-30 13:57 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-06 18:15 ` [PATCH i-g-t v4] tests/intel/kms_pm_dc: Remove PKGC10 dependency to validate DC6 Mohammed Thasleem
2025-04-07 14:04   ` Imre Deak
2025-04-06 19:02 ` ✓ i915.CI.BAT: success for tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6 (rev5) Patchwork
2025-04-06 19:09 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-06 20:59 ` ✗ Xe.CI.Full: failure for tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6 (rev3) Patchwork
2025-04-06 21:02 ` ✗ i915.CI.Full: failure for tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6 (rev5) Patchwork
2025-04-06 21:09 ` ✗ Xe.CI.Full: failure for tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6 (rev4) Patchwork
2025-04-07 23:18 ` ✗ Xe.CI.Full: failure for tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6 (rev5) Patchwork
2025-04-08 21:45 ` [PATCH i-g-t v5] tests/intel/kms_pm_dc: Remove PKGC10 dependency to validate DC6 Mohammed Thasleem
2025-04-10 10:35   ` Imre Deak
2025-04-08 23:29 ` ✓ i915.CI.BAT: success for tests/intel/kms_pm_dc: Remove PKC10 dependecy to validate DC6 (rev6) Patchwork
2025-04-08 23:33 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-09  0:51 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-09  1:20 ` ✗ Xe.CI.Full: " Patchwork
2025-04-11 12:11 ` ✓ i915.CI.Full: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox