Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, kunal1.joshi@intel.com,
	sameer.lattannavar@intel.com, pranay.samala@intel.com,
	Leo Li <sunpeng.li@amd.com>, Jani Nikula <jani.nikula@intel.com>,
	Uma Shankar <uma.shankar@intel.com>,
	Ramanaidu Naladala <ramanaidu.naladala@intel.com>
Subject: [PATCH i-g-t v3 0/5] Refactor DRM Debug Severity Handling for
Date: Tue,  1 Apr 2025 14:50:10 +0530	[thread overview]
Message-ID: <20250401092015.818465-1-pranay.samala@intel.com> (raw)

This update refactors the debug mask handling in the test framework for
improved readability and addresses logical inconsistencies. Users can now
pass a bitmask option during execution, enabling dynamic updates to the
debug mask. If no bitmask is provided, the default value is set to 0x4.

Additionally, the exit handler has been modified to restore the original
debug mask after the test completes, ensuring consistency. These changes
enhance the flexibility and robustness of the DRM debug logic, making it
easier to control the debug mask throughout the test.

v2:
- Implementated to allow flexible bitmask usage during execution. (Jani)
- Update the commit message (Jani)
- Using mask to update instead of a single category (Jani)
- To handle nested updates, exit_handler is set before the update
  process (Jani)

v3:
- Refactored for readability and address logical comment.

Cc: Leo Li <sunpeng.li@amd.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Ramanaidu Naladala <ramanaidu.naladala@intel.com>
Cc: Sameer Lattannavar <sameer.lattannavar@intel.com>

Fixes: 56b91193b825 ("lib/igt_sysfs: Implement dynamic adjustment of debug log level")
Fixes: a2ab0ec12ef4 ("tests/kms_atomic_transition: Reducing debug loglevel dynamically")
Fixes: 4baeb7397d71 ("tests/intel/kms_dp_linktrain_fallback: Reduce debug loglevel dynamically")
Fixes: 7a8a3744466f ("tests/kms_cursor_legacy: Reduce debug loglevel dynamically")

Pranay Samala (5):
  lib/igt_sysfs: Usage of Original debug mask to read/reset
  lib/igt_sysfs: Rename debug level APIs/variables to debug mask
  lib/igt_sysfs: Update new debug mask requested by user
  tests/kms: Add parse_bitmask support for user
  lib/igt_sysfs: Move igt_exit_handler into test

 lib/igt_sysfs.c                         | 64 +++++++++++++------------
 lib/igt_sysfs.h                         |  7 +--
 tests/intel/kms_dp_linktrain_fallback.c | 38 +++++++++++----
 tests/kms_atomic_transition.c           | 25 +++++-----
 tests/kms_cursor_legacy.c               | 38 +++++++++++----
 5 files changed, 108 insertions(+), 64 deletions(-)

-- 
2.34.1


             reply	other threads:[~2025-04-01  9:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01  9:20 Pranay Samala [this message]
2025-04-01  9:20 ` [PATCH i-g-t v3 1/5] lib/igt_sysfs: Usage of Original debug mask to read/reset Pranay Samala
2025-04-23 11:49   ` [i-g-t,v3,1/5] " Joshi, Kunal1
2025-04-01  9:20 ` [PATCH i-g-t v3 2/5] lib/igt_sysfs: Rename debug level APIs/variables to debug mask Pranay Samala
2025-04-23 11:56   ` [i-g-t,v3,2/5] " Joshi, Kunal1
2025-04-01  9:20 ` [PATCH i-g-t v3 3/5] lib/igt_sysfs: Update new debug mask requested by user Pranay Samala
2025-04-01  9:20 ` [PATCH i-g-t v3 4/5] tests/kms: Add parse_bitmask support for user Pranay Samala
2025-04-03 15:18   ` Jani Nikula
2025-04-23 12:23   ` [i-g-t,v3,4/5] " Joshi, Kunal1
2025-04-01  9:20 ` [PATCH i-g-t v3 5/5] lib/igt_sysfs: Move igt_exit_handler into test Pranay Samala
2025-04-01 10:04 ` [PATCH i-g-t v3 0/5] Refactor DRM Debug Severity Handling for Samala, Pranay
2025-04-01 12:24 ` ✗ i915.CI.BAT: failure for " Patchwork
2025-04-01 12:30 ` ✓ Xe.CI.BAT: success " Patchwork
2025-04-01 14:39 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-06 22:24 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250401092015.818465-1-pranay.samala@intel.com \
    --to=pranay.samala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=karthik.b.s@intel.com \
    --cc=kunal1.joshi@intel.com \
    --cc=ramanaidu.naladala@intel.com \
    --cc=sameer.lattannavar@intel.com \
    --cc=sunpeng.li@amd.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox